Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands

2018-08-02 Thread Bart Van Assche
On Thu, 2018-08-02 at 11:05 +, Avri Altman wrote: > -Original Message- > > From: Bart Van Assche > > Sent: Wednesday, August 01, 2018 6:28 PM > > [ ... ] > > > + spin_unlock_irqrestore(host->host_lock, flags); > > > + > > > + /* wait until the task management command is completed */ >

RE: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands

2018-08-02 Thread Avri Altman
nayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ; > subha...@codeaurora.org > Subject: Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands > > On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote: > > +/** > > + * ufshcd_exec_raw_upiu_cmd -

RE: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands

2018-08-02 Thread Avri Altman
nayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ; > subha...@codeaurora.org > Subject: Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands > > On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote: > > + wait_event(hba->tm_tag_wq, ufshcd_get_t

Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands

2018-08-01 Thread Bart Van Assche
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote: > +/** > + * ufshcd_exec_raw_upiu_cmd - API function for sending raw upiu commands > + * @hba: per-adapter instance > + * @req_upiu:upiu request - 8 dwards > + * @rsp_upiu:upiu reply - 8 dwards > + * @msgcode: message code,

Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands

2018-08-01 Thread Bart Van Assche
On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote: > + wait_event(hba->tm_tag_wq, ufshcd_get_tm_free_slot(hba, _slot)); The above is the weirdest API I have seen so far for tag allocation. Why does ufshcd_get_tm_free_slot() does a linear search through a bitmap instead of using the sbitmap