On Wed, Nov 5, 2014 at 8:56 AM, David Gálvez dgalve...@gmail.com wrote:
Do you know about the Falcon's disturbance in the SDMA clock signal
hardware problem?
Most Falcons, specially those used in music studios, have a hardware
patch to fix this, it's normally called SCSI patch.
Some more
On 11/04/2014 04:01 PM, Christoph Hellwig wrote:
On Tue, Nov 04, 2014 at 08:21:13AM +0100, Hannes Reinecke wrote:
Why did you use a wrapper for an already existing function?
Please fold the logic into alua_check_sense().
That's what the first version did. See the response from Rob to it
on
On 11/5/2014 6:57 AM, Elliott, Robert (Server Storage) wrote:
-Original Message-
From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il]
Sent: Tuesday, November 04, 2014 6:15 AM
To: Bart Van Assche; Elliott, Robert (Server Storage); Christoph Hellwig
Cc: Jens Axboe; Sagi Grimberg;
Hi all,
this patchset updates the ATA stack to correctly detect
host-managed ZAC devices.
Hannes Reinecke (3):
libsas: use ata_dev_classify()
libata: Implement ATA_DEV_ZAC
libata-scsi: Update SATL for ZAC drives
drivers/ata/libata-core.c | 20 +++
Add new ATA device type for ZAC devices.
Acked-by: Christoph Hellwig h...@lst.de
Acked-by: Tejun Heo t...@kernel.org
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/ata/libata-core.c | 20 ++--
drivers/ata/libata-eh.c| 7 +--
drivers/ata/libata-scsi.c
ZAC (zoned-access command) drives translate into ZBC (Zoned block
command) device type for SCSI. So implement the correct mappings
into libata-scsi and update the SCSI command set versions.
Acked-by: Christoph Hellwig h...@lst.de
Acked-by: Tejun Heo t...@kernel.org
Signed-off-by: Hannes Reinecke
On 11/04/14 15:14, Christoph Hellwig wrote:
I've applied patches 1-3 to the core-for-3.19 branch. Various srp
patches, including the first one fail to apply for me. Can you
regenerate them against the drivers-for-3.19 branch? Thanks!
Hello Christoph,
That's strange. I have compared the
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
Pull the common code from the two callers into the function,
and renamed it to scsi_ioctl_reset.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
The calling conventions for this function where bad as it could return
-ENODEV both for a device not currently online and a not recognized ioctl.
Add a new scsi_ioctl_block_when_processing_errors function that wraps
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
No need to verify the passthrough ioctls, the real handler will
take care of that. Also make sure not to block for resets on
O_NONBLOCK fds.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/st.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 7d2e036..e46e02b2 100644
---
On 10/30/2014 10:27 AM, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c
index 712f159..c4f7b56 100644
---
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph The calling conventions for this function where bad as it
Christoph could return -ENODEV both for a device not currently online
Christoph and a not recognized ioctl.
s/where/were/
Christoph Add a new
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph No need to verify the passthrough ioctls, the real handler
Christoph will take care of that. Also make sure not to block for
Christoph resets on O_NONBLOCK fds.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin
Christoph == Christoph Hellwig h...@lst.de writes:
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
Christoph == Christoph Hellwig h...@lst.de writes:
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph - return -ENODEV;
Christoph + return -EAGAIN;
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
On Wed, Nov 05, 2014 at 01:08:19PM +0100, Hannes Reinecke wrote:
Hi all,
this patchset updates the ATA stack to correctly detect
host-managed ZAC devices.
And more importantly exports /dev/sg nodes from them so they can be
actually be accessed.
I'm fine with taking the whole series through
On 11/05/2014 04:03 PM, Christoph Hellwig wrote:
On Wed, Nov 05, 2014 at 01:08:19PM +0100, Hannes Reinecke wrote:
Hi all,
this patchset updates the ATA stack to correctly detect
host-managed ZAC devices.
And more importantly exports /dev/sg nodes from them so they can be
actually be
Replying to two messages at once:
Date: Tue, 4 Nov 2014 11:14:39 -0500 (EST)
From: Alan Stern st...@rowland.harvard.edu
cc: Dale R. Worley wor...@alum.mit.edu, linux-scsi@vger.kernel.org,
linux-...@vger.kernel.org
On Tue, 4 Nov 2014, James Bottomley wrote:
On Mon, 2014-11-03 at
On Tue, 2014-11-04 at 11:14 -0500, Alan Stern wrote:
On Tue, 4 Nov 2014, James Bottomley wrote:
On Mon, 2014-11-03 at 16:06 -0500, Dale R. Worley wrote:
Was there any resolution as to how large disk drives would be handled
if their interface did not support the capacity request that
On Wed, Nov 05, 2014 at 01:08:19PM +0100, Hannes Reinecke wrote:
Hi all,
this patchset updates the ATA stack to correctly detect
host-managed ZAC devices.
Hannes Reinecke (3):
libsas: use ata_dev_classify()
libata: Implement ATA_DEV_ZAC
libata-scsi: Update SATL for ZAC drives
On Wed, 5 Nov 2014, James Bottomley wrote:
On Tue, 2014-11-04 at 11:14 -0500, Alan Stern wrote:
On Tue, 4 Nov 2014, James Bottomley wrote:
On Mon, 2014-11-03 at 16:06 -0500, Dale R. Worley wrote:
Was there any resolution as to how large disk drives would be handled
if their
On 11/05/2014 06:34 PM, Alan Stern wrote:
It's simpler than that: The drive is attached directly to the computer
(i.e., via SATA rather than USB) when the partition table is created.
With no USB-SATA bridge chip to mess things up, there's no problem
determining the correct capacity.
On Wed, Nov 05, 2014 at 01:37:14PM +0100, Bart Van Assche wrote:
That's strange. I have compared the patches that are already in your tree
with the patches I had posted myself with a diff tool. These patches look
identical to what I had posted except for one CC tag that has been left out.
If I
On Wed, Nov 05, 2014 at 05:07:48PM +0100, James Bottomley wrote:
OK, but I still don't understand how windows gets the partition table on
there in the first place ... that must surely be some sort of guess the
disk size hack.
99% of the time the partition table was provided by the drive
I've pushed an updated branch with the review comments addressed to
git://git.infradead.org/users/hch/scsi.git tcq-rework
Thansk for all the reviews, and looking forward to the missing ones!
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
On Wed, Nov 05, 2014 at 11:34:11AM -0500, Alan Stern wrote:
Sorry, meant to. In principle I'm OK with this as the lever for the
hack (largely because it means we don't need to do anything) but will
the distributions support it?
While I can't speak for the distributions, it's reasonable
From: Hariprasad Shenai haripra...@chelsio.com
Date: Tue, 4 Nov 2014 08:20:54 +0530
It's not really the hardware which generates these hardware constant
symbolic
macros/register defines of course, it's scripts developed by the hardware
team.
Various patches have ended up changing the
There were missing curly braces so we always return the first
additional2[] string.
Fixes: 7046d2fa6dbd ('scsi: use sdev as argument for sense code printing')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
index
Looks ok.
Acked-by: Chad Dupuis chad.dup...@qlogic.com
On Tue, 4 Nov 2014, Dan Carpenter wrote:
The bnx2fc_if_create() function returns NULL on failure, it never
returns an error pointer.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jeff Moyer jmo...@redhat.com
---
From: Alan Stern st...@rowland.harvard.edu
I posted a patch to allow the user to override the reported capacity:
http://marc.info/?l=linux-scsim=140993840113445w=2
I see the patch, and I feel confident I could install it if I needed
to. What command do I execute to write to the
This is a note to let you know that I have just added a patch titled
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND
to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree
which can be found at:
David, Geert,
my Falcon has some variant of this clock patch installed - it may not
be precisely the one described but reasonably close. It also has one
of the old 030 accelerator tricks (clock doubling of the 030 if the
CPU does not do bus cycles - named Skunk) fitted; the clock patch was
On Thu, 6 Nov 2014, Michael Schmitz wrote:
Leaves the current instability - I did some work on the CT60 accelerator
(reflashed the firmware so I can use the CTPCI board). This might have
caused the system to become more unstable. Needs more investigation.
I gather from the emails we've
On Tue, Nov 04, 2014 at 08:10:59AM +0100, Hannes Reinecke wrote:
gcc complained about an uninitialized warning.
Looks fine to me, although it very much is gcc overreacting.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Tue, Nov 04, 2014 at 09:06:41AM +0100, Hannes Reinecke wrote:
The request tag provides a concise identification of a SCSI
command, so we should be printing that out for scmd_printk().
Suggested-by: Christoph Hellwig h...@lst.de
Signed-off-by: Hannes Reinecke h...@suse.de
Reviewed-by:
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/05/2014 09:38 PM, Dan Carpenter wrote:
There were missing curly braces so we always return the first
additional2[] string.
Fixes: 7046d2fa6dbd ('scsi: use sdev as argument for sense code printing')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
On Tue, Nov 04, 2014 at 09:06:43AM +0100, Hannes Reinecke wrote:
libata already uses an internal buffer, so we should be using
__scsi_format_command() here.
Looks good,
Reviewed-by: Christoph Hellwig h...@lst.de
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body
On Tue, Nov 04, 2014 at 09:06:46AM +0100, Hannes Reinecke wrote:
SPC-3 defines SERVICE ACTION IN(12) and SERVICE ACTION IN(16).
So rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to be
consistent with SPC and to allow for better distinction.
Looks fine, I'd really like to take this at the
On Tue, Nov 04, 2014 at 09:06:47AM +0100, Hannes Reinecke wrote:
SPC-3 defines SERVICE ACTION IN(12), SERVICE_ACTION OUT(12),
SERVICE ACTION OUT(16), and SERVICE ACTION BIDIRECTIONAL.
And READ MEDIA SERIAL NUMBER has long since been deprecated.
So update callers to refer to the new cdb name.
+static inline const char *scsi_sense_key_string(unsigned char key)
+{ return NULL; }
+static inline const char *scsi_extd_sense_format(unsigned char asc,
+ unsigned char ascq,
+ const char **fmt)
+{ *fmt = NULL;
On Tue, Nov 04, 2014 at 09:06:49AM +0100, Hannes Reinecke wrote:
One statement was missing from the conversion to dev_printk().
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/scsi.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
+#define scmd_format_header(b, l, d, t) \
+ sdev_format_header(b, l, (d) ? (d)-disk_name : NULL, t)
I'd rather have a
static inline const char *scmd_name(struct scsi_cmnd *scmd)
{
return scmd-request-rq_disk ?
scmd-request-rq_disk-disk_name : NULL;
}
helper and use
On 11/06/2014 08:20 AM, Christoph Hellwig wrote:
On Tue, Nov 04, 2014 at 09:06:49AM +0100, Hannes Reinecke wrote:
One statement was missing from the conversion to dev_printk().
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/scsi.c | 10 ++
1 file changed, 6
On 11/06/2014 08:33 AM, Christoph Hellwig wrote:
+#define scmd_format_header(b, l, d, t) \
+sdev_format_header(b, l, (d) ? (d)-disk_name : NULL, t)
I'd rather have a
static inline const char *scmd_name(struct scsi_cmnd *scmd)
{
return scmd-request-rq_disk ?
scsi_lib.c is where the rest of the I/O submission path lives, so move
scsi_dispatch_cmd there and mark it static.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Bart Van Assche bvanass...@acm.org
---
drivers/scsi/scsi.c | 81
Now that we are using the split completion model for the legacy request
path as well we can use scsi_mq_free_sgtables unconditionally.
Rename it to scsi_free_sgtables, use it for the legacy path and remove
scsi_release_(bidi_)buffers.
Signed-off-by: Christoph Hellwig h...@lst.de
---
There is no reason for ULDs to pass in a flag on how to allocate the S/G
lists. While we don't need GFP_ATOMIC for the blk-mq case because we
don't hold locks, that decision can be made way down the chain without
having to pass a pointless gfp_mask argument.
Signed-off-by: Christoph Hellwig
There's only one caller left, so inline it and reduce the blk-mq vs !blk-mq
diff a litte bit.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Bart Van Assche bvanass...@acm.org
---
drivers/scsi/scsi_lib.c | 18 --
drivers/scsi/scsi_priv.h | 1 -
2 files changed, 4
scsi_reset_provider already manually runs all queues for the given host,
so it doesn't need the scsi_run_queues call from it, and it doesn't need
a reference on the device because it's synchronous.
So let's just call scsi_put_command directly and avoid the device reference
dance to simplify the
This series cleans up a couple of lose ends I noticed during the scsi-mq
work, but which weren't important enough to address during the last cycle.
These are also available at:
git://git.infradead.org/users/hch/scsi.git scsi-io-path-cleanups
Changes since V1:
- rebased to core-for-3.19
-
Move a bit code out of scsi_io_completion and into scsi_requeue_command
in preparation for further refactoring.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Bart Van Assche bvanass...@acm.org
---
drivers/scsi/scsi_lib.c | 86 ++---
1 file
55 matches
Mail list logo
