RE: [PATCH] megaraid-sas: request irqs later

>-Original Message- >From: Martin K. Petersen [mailto:martin.peter...@oracle.com] >Sent: Tuesday, November 15, 2016 5:18 AM >To: Tomas Henzl >Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com; >kashyap.de...@broadcom.com >Subject: Re: [PATCH] megaraid-sas: request irqs later >

Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation

On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote: [...] > Hello Johannes, > > I think the above code will miscalculate seconds_since_last_reset if > 'jiffies' wraps around after an lport has been created and before > seconds_since_last_reset is computed. Shouldn't

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote: > Hi Johannes, > > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > > > > On Thu, Oct

[PATCH v3] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

Some UFS host controllers may clear a transfer request slot by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0. That's opposite to what UFS spec describes. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 28 ++--

[PATCH v3] ufs: introduce UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR quirk

If UFS driver resets interrupt aggregation timer and counter when there are some pended tasks, an IO competion interrupt of any corresponing task may be issued. That would casue a command timeout. One thing you should mind to use interrupt aggreation with this quirk is that the host controller

[PATCH v3] ufs: introduce UFSHCD_QUIRK_BROKEN_HCE quirk

Some UFS host controllers might not be able to reset UIC by setting HCE to 1. Those controllers should invoke 'DME reset' and 'DME enable' in order instead. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 44 +++-

RE: [PATCH v2] ufs: add a variety of definitions decribed in UFS spec

> On 2016-11-15 03:24, Kiwoong Kim wrote: > > These things are defined to be used by some UFS Host controllers. > > And a new file for some declarations of mphy standard is added > > > > V2 > > - modify the commit message > > - add a new macro for UECDL > > - add two definitions about UECDL > > -

[PATCH v3] ufs: add a variety of definitions decribed in UFS spec

These things are defined to be used by some UFS Host controllers. And a new file for some declarations of mphy standard is added Signed-off-by: Kiwoong Kim --- V3: add new macros of all bits of UECDL --- drivers/scsi/ufs/mphy.h | 38

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

Hi Johannes, On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: Hm, still behaves for me like

Back to Synopsys

Hi all, I am back to Synopsys, so please don't apply the patches I sent a few weeks ago with the goal of changing the UFS drivers author e-mail. I will be available to help in anything you need. Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation

On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote: > On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote: > > I think the above code will miscalculate seconds_since_last_reset > > if  > > 'jiffies' wraps around after an lport has been created and before  > >

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote: > Hi Johannes, > > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote: > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > > > > On Thu, Oct

RE: [PATCH] hpsa: correct logical resets

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, November 14, 2016 5:44 PM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; Bader Ali-saleh; h...@infradead.org; Scott Teel; Viswas G; > Justin

Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1

Hello, Rameshwar. On Fri, Nov 11, 2016 at 01:36:28PM +0530, Rameshwar Sahu wrote: > Hi Tejun, > > On Wed, Nov 9, 2016 at 10:15 PM, Tejun Heo wrote: > > Hello, > > > > On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote: > >> > @@ -821,8 +823,6 @@ static int

Re: [PATCH] libfc: fix seconds_since_last_reset miscalculation

On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote: > On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote: > > On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote: > > > I think the above code will miscalculate seconds_since_last_reset > > > if  > > > 'jiffies'

[Bug 187221] HPSA resetting logical / reset logical

https://bugzilla.kernel.org/show_bug.cgi?id=187221 --- Comment #1 from Patrick Schaaf --- Some more info on my problematic machine / further diagnosing is in https://bugzilla.kernel.org/show_bug.cgi?id=187231 Summary: at least with the P440ar controllers, such 10-30 second

[Bug 187231] kernel panic during hpsa MSI plus tg3 MSI

https://bugzilla.kernel.org/show_bug.cgi?id=187231 Patrick Schaaf changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] aacraid: switch to pci_alloc_irq_vectors

On 11/15/2016 08:33 PM, Raghava Aditya Renukunta wrote: > Hi Hannes, > Thank you for the patch > >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Monday, November 7, 2016 11:12 PM >> To: Martin K. Petersen >> Cc: Christoph Hellwig; James Bottomley;

Re: [PATCH v2] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

On 2016-11-15 02:52, Kiwoong Kim wrote: Some UFS host controllers may clear a transfer request slot by setting an associated bit in UTRLCLR/UTMRLCLR to 1, not 0. That's opposite to what UFS spec describes. v2: modify the commit message, remove unrelated changes As Martin mentioned in other

[PATCH 1/2] nvme: untangle 0 and BLK_MQ_RQ_QUEUE_OK

From: Omar Sandoval Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Signed-off-by: Omar Sandoval --- drivers/nvme/host/core.c | 4 ++-- drivers/nvme/host/pci.c| 8 drivers/nvme/host/rdma.c

Re: [PATCH v2] ufs: introduce UFSHCD_QUIRK_BROKEN_HCE quirk

On 2016-11-15 02:55, Kiwoong Kim wrote: Some UFS host controllers might not be able to reset UIC by setting HCE to 1. Those controllers should invoke 'DME reset' and 'DME enable' in order instead. V2 As Martin mentioned in other email, please separate this version history from commit text

[PATCH V2] hpsa: correct logical resets

- driver was not calling done in some cases which causes the volume to be offlined. - avoid doing rescan during a reset. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace ---

Re: [PATCH 1/2] nvme: untangle 0 and BLK_MQ_RQ_QUEUE_OK

On 11/15/2016 12:11 PM, Omar Sandoval wrote: From: Omar Sandoval Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Thanks Omar, applied both for 4.10. -- Jens Axboe -- To unsubscribe from this list: send the line

RE: [PATCH] aacraid: switch to pci_alloc_irq_vectors

Hi Hannes, Thank you for the patch > -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Monday, November 7, 2016 11:12 PM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes > Reinecke; Hannes Reinecke; dl-esc-Aacraid

Re: [PATCH v2] ufs: introduce UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR quirk

On 2016-11-15 02:57, Kiwoong Kim wrote: If UFS driver resets interrupt aggregation timer and counter when there are some pended tasks, an IO competion interrupt of any corresponing task may be issued. That would casue a command timeout. One thing you should mind to use interrupt aggreation with

Re: [PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

On 2016-11-15 04:25, Zang Leigang wrote: We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler fails. So I think UFSHCD_STATE_ERROR means host not works any more. Set it before schedule eh_work is not correct. Signed-off-by: Zang Leigang diff --git

[PATCH 2/2] scsi_lib: untangle 0 and BLK_MQ_RQ_QUEUE_OK

From: Omar Sandoval Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having specific values. No functional change. Signed-off-by: Omar Sandoval --- drivers/scsi/scsi_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2] ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk

On 2016-11-15 02:49, Kiwoong Kim wrote: Some UFS host controllers may think granularitys of PRDT length and offset as bytes, not double words. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 28 +--- drivers/scsi/ufs/ufshcd.h | 6

Re: [PATCH v2] ufs: add a variety of definitions decribed in UFS spec

On 2016-11-15 03:24, Kiwoong Kim wrote: These things are defined to be used by some UFS Host controllers. And a new file for some declarations of mphy standard is added V2 - modify the commit message - add a new macro for UECDL - add two definitions about UECDL - change the names of two macros

Re: [PATCH 1/2] nvme: untangle 0 and BLK_MQ_RQ_QUEUE_OK

On Tue, Nov 15, 2016 at 11:11:58AM -0800, Omar Sandoval wrote: > From: Omar Sandoval > > Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having > specific values. No functional change. > > Signed-off-by: Omar Sandoval Yeah, we've been depending on the

Re: [PATCH 2/2] blk-mq: Avoid memory reclaim when remapping queues

On 11/14/2016 11:24 AM, Gabriel Krisman Bertazi wrote: --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1597,7 +1597,7 @@ static struct blk_mq_tags *blk_mq_init_rq_map(struct blk_mq_tag_set *set, INIT_LIST_HEAD(>page_list); tags->rqs = kzalloc_node(set->queue_depth * sizeof(struct

[PATCH 00/14] cxlflash: Fixes, enhancements, cleanup and staging

The first four patches in this patch series include fixes for command room violation and lun table management. The remaining patches remove the reliance upon an internally maintained private command pool in favor of private commands being allocated alongside the SCSI commands. Several cleanup

[PATCH 13/14] cxlflash: Migrate IOARRIN specific routines to function pointers

From: "Matthew R. Ochs" As staging for supporting hardware with a different queuing mechanism, move the send_cmd() and context_reset() routines to function pointers that are configured when the AFU is initialized. In addition, rename the existing routines to better

[PATCH 14/14] cxlflash: Migrate scsi command pointer to AFU command

From: "Matthew R. Ochs" Currently, when sending a SCSI command, the pointer is stored in a reserved field of the AFU command descriptor for retrieval once the SCSI command has completed. In order to support new descriptor formats that make use of the reserved field,

[PATCH 10/14] cxlflash: Remove AFU command lock

From: "Matthew R. Ochs" The original design of the cxlflash driver required AFU commands to convey state information across multiple threads. The IOASA "host use" byte was used to track if a command was done, errored, or timed out. A per-command spin lock was used to

[PATCH 11/14] cxlflash: Cleanup send_tmf()

From: "Matthew R. Ochs" The send_tmf() routine includes some copy/paste cruft that can be removed as well as the setting of an AFU command-specific while holding the tmf_slock. While not a bug, it is out of place and should be shifted down alongside the other command

[PATCH 12/14] cxlflash: Cleanup queuecommand()

From: "Matthew R. Ochs" The queuecommand routine is disorganized where it populates the private command and also contains some logic/statements that are not needed given that cxlflash devices do not (and likely never will) support scatter-gather. Restructure the code

[PATCH 09/14] cxlflash: Wait for active AFU commands to timeout upon tear down

From: "Matthew R. Ochs" With the removal of the static private command pool, the ability to 'complete' outstanding commands was lost. While not an issue for the commands originating outside the driver, internal AFU commands are synchronous and therefore have a timeout

[PATCH 07/14] cxlflash: Use cmd_size for private commands

From: "Matthew R. Ochs" Instead of using a private pool of AFU commands, use cmd_size to prime the private pool of SCSI commands such that they are allocated with a size large enough to contain an aligned AFU command. Use scsi_cmd_priv() to derive the aligned/zeroed

[PATCH 06/14] cxlflash: Allocate memory instead of using command pool for AFU sync

From: "Matthew R. Ochs" As staging for the removal of the AFU command pool, remove the reliance upon the pool for the internal AFU sync command. Instead of obtaining an AFU command from the pool, dynamically allocate memory with the appropriate alignment requirements.

[PATCH 08/14] cxlflash: Remove private command pool

From: "Matthew R. Ochs" Clean up and remove the remaining private command pool infrastructure that is no longer required. Signed-off-by: Matthew R. Ochs --- drivers/scsi/cxlflash/common.h | 7 - drivers/scsi/cxlflash/main.c | 68

[PATCH 01/14] cxlflash: Set sg_tablesize to 1 instead of SG_NONE

The following Oops is encountered when blk_mq is enabled with the cxlflash driver: [ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5] [ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0 [ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0 [ 2960.817314] Call Trace: [ 2960.817320]

[PATCH 05/14] cxlflash: Remove unused buffer from AFU command

From: "Matthew R. Ochs" The cxlflash driver originally required a per-command 4K buffer that hosted data passed to the AFU. When the routines that initiate AFU and internal SCSI commands were refactored to use scsi_execute(), the need for this buffer became obsolete.

[PATCH 04/14] cxlflash: Avoid command room violation

During test, a command room violation interrupt is occasionally seen for the master context when the CXL flash devices are stressed. After studying the code, there could be gaps in the way command room value is being cached in cxlflash. When the cached command room is zero the thread attempting

[PATCH 02/14] cxlflash: Fix crash in cxlflash_restore_luntable()

During test, the following crash was observed: [34538.981505] Faulting instruction address: 0xd7c9c870 cpu 0x9: Vector: 300 (Data Access) at [c007f1e8f590] pc: d7c9c870: cxlflash_restore_luntable+0x70/0x1d0 [cxlflash] lr: d7c9c84c:

[PATCH 03/14] cxlflash: Improve context_reset() logic

Currently, the context reset routine waits for command room to be available before sending the reset request. Per review of the SISLite specification and clarifications from the CXL Flash AFU designers, this wait is unnecessary. The reset request can be sent anytime regardless of command room, so

[PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler fails. So I think UFSHCD_STATE_ERROR means host not works any more. Set it before schedule eh_work is not correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c

[RFC PATCH] scsi:fc: avoid a permanent stop of the scsi device's request queue

A scan work can run simultaneously with fc_remote_port_delete(). If a scsi device is added to the ->__devices list in the scan work, it can be touched and will be blocked in scsi_target_block(), and QUEUE_FLAG_STOPPED will be setted to the scsi device's request queue. But unfortunately, this flag

Re: [PATCH 02/11] hisi_sas: alloc queue id of slot according to device id

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Currently slots are allocated from queues in a round-robin fashion. > This causes a problem for internal commands in device mode. For this > mode, we should ensure that the

Re: [PATCH 04/11] hisi_sas: fix port form bug in hisi_sas_port_notify_formed()

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > When we form a wideport, we should use hardware PHY port_id instead > of sas_phy->id. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry

Re: [PATCH 10/11] hisi_sas: use atomic64_t for hisi_sas_device.running_req

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > Sometimes the value of hisi_sas_device.running_req > would go negative unless we have the check for > running_req >= 0 before trying to decrement. > > This is because using running_req is not thread-safe. > > As such, the

Re: [PATCH 07/11] hisi_sas: delete repeated configuration in free_device_v2_hw()

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Delete repeated configuration items for hisi_sas_device() when > we free a device. These items are now only set in > hisi_sas_dev_gone(). > > Signed-off-by: Xiang Chen

[PATCH v2] ufs: add a variety of definitions decribed in UFS spec

These things are defined to be used by some UFS Host controllers. And a new file for some declarations of mphy standard is added V2 - modify the commit message - add a new macro for UECDL - add two definitions about UECDL - change the names of two macros (s/IS_PWR_MODE_HS/IS_HS_PWR_MODE,

[PATCH v2] ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk

Some UFS host controllers may think granularitys of PRDT length and offset as bytes, not double words. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 28 +--- drivers/scsi/ufs/ufshcd.h | 6 ++ 2 files changed, 27 insertions(+), 7

[PATCH v2] ufs: introduce UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR quirk

If UFS driver resets interrupt aggregation timer and counter when there are some pended tasks, an IO competion interrupt of any corresponing task may be issued. That would casue a command timeout. One thing you should mind to use interrupt aggreation with this quirk is that the host controller

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote: > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote: > > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > > > Hm, still behaves for me like I reported for v2: > > >

Re: [PATCH 08/11] hisi_sas: modify some values in get_ata_protocol()

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Modify and add some SATA commands according to SATA protocol. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry

Re: [PATCH 03/11] hisi_sas: only process broadcast change in phy_bcast_v2_hw()

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > There are many BROADCAST primitives generated by the host. > We are only interested in BROADCAST (CHANGE) primitives currently, > so only process this. > > Signed-off-by:

Re: [PATCH 01/11] hisi_sas: add v2 hw support for ECC and AXI bus fatal error

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > For ECC 1bit error, logic can recover it, so we only print > a warning. > For ECC multi-bit and AXI bus fatal error, we panic. Is it possible to recover via resetting phy

Re: [PATCH 11/11] hisi_sas: add PHY set linkrate support for v1 and v2 hw

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Add the function to set PHY min and max linkrate through > sysfs interface. > > Signed-off-by: Xiang Chen > Signed-off-by: John Garry

Re: [PATCH] scsi: ufs: remove unnecessary UFSHCD_STATE_ERROR set

Ok, got it. I will resend a new patch. On Tue, Nov 15, 2016 at 11:00:12AM -0800, Subhash Jadavani wrote: > On 2016-11-15 04:25, Zang Leigang wrote: > >We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler > >fails. So I think UFSHCD_STATE_ERROR means host not works any more. > >Set it

Re: [PATCH 06/11] hisi_sas: modify return value of hisi_sas_query_task()

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > sas_scsi_find_task() only deals with return value > TMF_RESP_FUNC_FAILED/TMF_RESP_FUNC_SUCC/TMF_RESP_FUNC_COMPLETE of > query task. So for LLDD errors just return

Re: [PATCH 09/11] hisi_sas: check SATA FIS when directly attaching SATA device

On Mon, Nov 7, 2016 at 8:48 PM, John Garry wrote: > From: Xiang Chen > > Check ERR bit of status to decide whether there is something wrong with > initial register-D2H FIS. If error exists, PHY reset the channel to > restart OOB. > >

RE: [PATCH v2] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

>> > Some UFS host controllers may clear a transfer request slot by setting >> > an associated bit in UTRLCLR/UTMRLCLR to 1, not 0. >> > That's opposite to what UFS spec describes. >> > >> > v2: modify the commit message, remove unrelated changes >> >> As Martin mentioned in other email, please

[PATCH] scsi: ufs: introduce a new ufshcd_statea UFSHCD_STATE_EH_SCHEDULED

Add a new ufshcd_state, indicats that an err handler may get to run immediately. Use UFSHCD_STATE_ERROR here looks not literaly correct. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 05c7456..59d4130 100644 ---

[PATCH 1/1] [fnic, snic] Updating maintainers list for Cisco FNI and SNIC drivers

Signed-off-by: Satish Kharat Signed-off-by: Sesidhar Baddela --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b3a7774..11fdf45 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@