Re: [PATCH 09/39] megaraid_sas: NVME Interface detection and prop settings

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > New functionality > Adding detection logic for NVME device attached behind Ventura controller. > Driver set HostPageSize in IOC_INIT frame to inform about page size for NVME > devices. > Firmware reports NVME page size to the driver. > PD INFO DCMD

Re: [PATCH 10/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property from FW using New DCMD > interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap

Re: [PATCH 23/39] megaraid_sas: set pd_after_lb from MR_BuildRaidContext and initialize pDevHandle to MR_DEVHANDLE_INVALID

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Issue is limited for Syncro firmware where pd_after_lb is not set but is > accidentally used. > Not a functional issue, but results in low performance due to improper load > balancing between two LUNs. > > Signed-off-by: Kashyap Desai

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > No functional change. Code clean up. Removing error code which is not > valid scenario. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- >

Re: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never require to convert fpio to > ldio because of frame unavailability. > Grab extra frame of raid 1 write fast path before it creates first frame as > Fast Path. >

Re: [PATCH 02/39] megaraid_sas: cpu select rework.

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > No functional change. Code refactor. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 175 >

Re: [PATCH 07/39] megaraid_sas: Use DID_REQUEUE

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Moving to use DID_REQUEUE return type for reliable unconditional retries. > Driver wants unconditional re-queue, so replace DID_RESET with DID_REQUEUE > Discussed below - > https://www.spinics.net/lists/linux-scsi/msg102848.html > > Signed-off-by:

Re: [PATCH 06/39] megaraid_sas: RAID map is accessed for SYS PDs when use_seqnum_jbod_fp is not set

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 25 ++--- > 1 file changed, 14 insertions(+),

RE: [PATCH 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 3:54 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 26/39] megaraid_sas: max_fw_cmds are decremented twice, remove duplicate

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fix to account for the reply_q_sz not exceeding > the maximum commands that the firmware can support, > instance->max_fw_cmds is already decremented in > megasas_fusion_update_can_queue(). > Remove the extra decrement logic in code. > >

Re: [PATCH 28/39] megaraid_sas: Remove unused pd_index from megasas_build_ld_nonrw_fusion

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff

Re: [PATCH 27/39] megaraid_sas: megasas_return_cmd does not memset IO frame to zero

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Memset the IO frame to zero after release. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h | 1 + >

[bug report] qla2xxx: Add framework for async fabric discovery

2017-02-06 Thread Dan Carpenter
Hello Quinn Tran, The patch b79414ee4988: "qla2xxx: Add framework for async fabric discovery" from Jan 19, 2017, leads to the following static checker warning: drivers/scsi/qla2xxx/qla_init.c:3910 qla2x00_alloc_fcport() warn: use 'flags' here instead of GFP_XXX?

Re: [PATCH 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura. > No need to pass extra flag. > Only IOC INIT required 64 bit Descriptor write. > > Signed-off-by: Shivasharan S

Re: [PATCH 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > No functional change. Code refactor. > megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura. > No need to pass extra flag. > Only IOC INIT required 64 bit Descriptor write. > > Signed-off-by: Shivasharan S

Re: [PATCH 18/39] megaraid_sas: MR_TargetIdToLdGet u8 to u16 and avoid invalid raid-map access

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > If MR_TargetIdToLdGet return >= 0xFF, it is invalid entry. > Consider that entry as invalid and do not access raid map for further > operation. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 19/39] megaraid_sas: Big endian RDPQ mode fix

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fix if RDPQ mode enabled MR FW is deployed on big endian host machine, > driver does not setup reply address correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

2017-02-06 Thread ojab
On 2017/02/06 12:02, Sreekanth Reddy wrote: Hi Ojab, Can I get output of 'lspci -vvv -s' for LSI SAS2 card? On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as

Re: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-06 Thread Tomas Henzl
On 6.2.2017 14:27, Kashyap Desai wrote: >>> /** >>> + * megasas_complete_r1_command - >>> + * completes R1 FP write commands which has valid peer smid >>> + * @instance: Adapter soft state >>> + * @cmd_fusion:MPT command frame >>> + * >>> + */ >>> +static

Re: [PATCH 01/39] Revert "scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth"

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > This reverts > commit "3e5eadb1a881" ("scsi: megaraid_sas: Enable or Disable Fast path based > on the PCI Threshold Bandwidth") > > This patch was aimed to increase performance of R1 Write operation for large > IO size. > Since this method used

Re: [PATCH 17/39] megaraid_sas: In validate raid map, raid capability is not converted to cpu format for all lds

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > On a host, if an ld is deleted there is a hole in the ld array returned > by the FW. But in MR_ValidateMapInfo we are not accounting for holes in > the ld array and traverse only upto index num_lds. > This patch takes care of converting the capability

Re: [PATCH 16/39] megaraid_sas: reduce size of fusion_context and use vmalloc if kmalloc fails

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Currently fusion context has fixed array load_balance_info. Use dynamic > allocation. > In few places, driver do not want physically contigious memory. > Attempt to use vmalloc if physical contiguous memory is not available. > > Signed-off-by:

Re: [PATCH 01/39] Revert "scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth"

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > This reverts > commit "3e5eadb1a881" ("scsi: megaraid_sas: Enable or Disable Fast path based > on the PCI Threshold Bandwidth") > > This patch was aimed to increase performance of R1 Write operation for large > IO size. > Since this method used timer

Re: [PATCH 07/39] megaraid_sas: Use DID_REQUEUE

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Moving to use DID_REQUEUE return type for reliable unconditional retries. > Driver wants unconditional re-queue, so replace DID_RESET with DID_REQUEUE > Discussed below - > https://www.spinics.net/lists/linux-scsi/msg102848.html > > Signed-off-by:

RE: [PATCH 11/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Shivasharan S [mailto:shivasharan.srikanteshw...@broadcom.com] > Sent: Monday, February 06, 2017 3:30 PM > To: linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 05/39] megaraid_sas: Refactor MEGASAS_IS_LOGICAL macro using sdev

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas.h| 4 ++-- > drivers/scsi/megaraid/megaraid_sas_base.c | 20

RE: [PATCH 04/39] megaraid_sas: 32 bit descriptor fire cmd optimization

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 3:54 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 38/39] megaraid_sas: Change RAID_1_10_RMW_CMDS to RAID_1_PEER_CMDS and set value to 2

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > For RAID1 FastPath writes, driver needs to allocate extra commands > internally to accommodate for the extra peer command being sent. > Currently driver is allocating 2 extra commands for each but only > one extra command is necessary. > Set

Re: [PATCH 39/39] megaraid_sas: driver version upgrade

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > Remove function megasas_fpio_to_ldio as we never require to convert fpio to > ldio because of frame unavailability. > Grab extra frame of raid 1 write fast path before it creates first frame as > Fast Path. >

RE: [PATCH 01/39] Revert "scsi: megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth"

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Shivasharan S [mailto:shivasharan.srikanteshw...@broadcom.com] > Sent: Monday, February 06, 2017 3:30 PM > To: linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

RE: [PATCH 11/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Shivasharan S [mailto:shivasharan.srikanteshw...@broadcom.com] > Sent: Monday, February 06, 2017 3:30 PM > To: linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 11/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread kbuild test robot
Hi Shivasharan, [auto build test WARNING on scsi/for-next] [cannot apply to v4.10-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Shivasharan-S/megaraid_sas-Updates-for-scsi-next/20170206

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fixing issue of not setting residual bytes correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 10

Re: [PATCH 12/39] megaraid_sas: raid 1 write performance for large io

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Avoid Host side PCI bandwidth bottleneck and hint FW to do Write buffering > using > RaidFlag MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT. > Once IO is landed in FW with MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT, > it will do single DMA from host and

Re: [PATCH 14/39] megaraid_sas: enhance debug logs in OCR context

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Add additional logging from driver in OCR context. > Add debug logs for partial completion of IOs is iodone context. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 21/39] megaraid_sas: avoid unaligned access in ioctl path

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fix kernel warning for accessing unaligned memory access in driver. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- >

Re: [PATCH 20/39] megaraid_sas: big endian support changes

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fix endiannes fixes for Ventura specific. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas_fp.c | 15 ++-- >

Re: [PATCH 22/39] megaraid_sas: latest controller OCR capability from FW before sending shutdown DCMD

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Fetch the latest controller OCR capability from FW before > sending MR_DCMD_CTRL_SHUTDOWN > When application sends a shutdown DCMD (MR_DCMD_CTRL_SHUTDOWN), > driver will fetch latest controller information from firmware. > This is to ensure that

Re: [PATCH 35/39] megaraid_sas: Increase internal command pool

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Fix - increase internal command pool to 8. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h| 2 +- >

Re: [PATCH 36/39] megaraid_sas: Cleanup VD_EXT_DEBUG and SPAN_DEBUG related debug prints

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas.h| 2 - > drivers/scsi/megaraid/megaraid_sas_base.c | 15 -- >

Re: [PATCH 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > FIX - Do not use random delay to synchronize with IRQ. Use kernel API. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- >

Re: [PATCH 37/39] megaraid_sas: Indentation and smatch warning fixes

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Fix indentation issues and smatch warning reported by Dan Carpenter > for previous series as discussed below. > http://www.spinics.net/lists/linux-scsi/msg103635.html > http://www.spinics.net/lists/linux-scsi/msg103603.html > > Reported-by: Dan

RE: [PATCH 06/39] megaraid_sas: RAID map is accessed for SYS PDs when use_seqnum_jbod_fp is not set

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:11 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

RE: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:14 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 05/39] megaraid_sas: Refactor MEGASAS_IS_LOGICAL macro using sdev

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 11/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property > from FW using New DCMD interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 33/39] megaraid_sas: call flush_scheduled_work during controller shutdown/detach

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 32/39] megaraid_sas: Bail out the driver load if ld_list_query fails

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Error handling: Bail out the driver load if > key FW cmds (LD_LIST) are not return successful. > Clean up error handling in megasas_init_fw. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

2017-02-06 Thread Sreekanth Reddy
Hi Ojab, Can I get output of 'lspci -vvv -s' for LSI SAS2 card? On my Supermicro system, I have enabled ASPM in system BIOS but still in lspci output I see this ASPM was disabled for my SAS2 HBA card which has Phase19 firmware (i.e. 19.00.00.00) as shown below, # lspci -vvv -s 83:00.0 83:00.0

Re: [PATCH 02/39] megaraid_sas: cpu select rework.

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code refactor. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

RE: [PATCH 03/39] megaraid_sas: raid 1 fast path code optimize

2017-02-06 Thread Kashyap Desai
> > > > /** > > + * megasas_complete_r1_command - > > + * completes R1 FP write commands which has valid peer smid > > + * @instance: Adapter soft state > > + * @cmd_fusion:MPT command frame > > + * > > + */ > > +static inline void > >

RE: [PATCH 09/39] megaraid_sas: NVME Interface detection and prop settings

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Monday, February 06, 2017 4:17 PM > To: Shivasharan S; linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

RE: [PATCH 10/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Shivasharan S [mailto:shivasharan.srikanteshw...@broadcom.com] > Sent: Monday, February 06, 2017 3:30 PM > To: linux-scsi@vger.kernel.org > Cc: martin.peter...@oracle.com; the...@redhat.com; > j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com; >

Re: [PATCH 15/39] megaraid_sas: add print in device removal path

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 10:59 AM, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 19 +++ > 1 file changed, 11 insertions(+), 8

Re: [PATCH 30/39] megaraid_sas: During OCR, if get_ctrl_info fails do not continue with OCR

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Error handling: If controller reset is not able to > recover, kill HBA and quit immediately. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- >

Re: [PATCH 31/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > Code refactoring to build_mpt_mfi_pass_thru to return void. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c |

Re: [PATCH 29/39] megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool

2017-02-06 Thread Hannes Reinecke
On 02/06/2017 11:00 AM, Shivasharan S wrote: > FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for > better tracking and other functionalities if the device > is task management capable. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

2017-02-06 Thread Dan Williams
On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote: > On 02/06/2017 05:14 PM, James Bottomley wrote: >> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: >>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: Dan, can you please quote your

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

2017-02-06 Thread Jens Axboe
On 02/06/2017 05:14 PM, James Bottomley wrote: > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: >> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: >>> Dan, >>> >>> can you please quote your emails? I can't find any content >>> inbetween all these quotes. >> >>

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

2017-02-06 Thread James Bottomley
On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote: > > Dan, > > > > can you please quote your emails? I can't find any content > > inbetween all these quotes. > > Sorry, I'm using gmail, but I'll switch to attaching

[Bug 194321] New: drivers/scsi/mpt3sas/mpt3sas_base.c mpt3sas_base_put_smid_fast_path structure descriptor.Default.DescriptorTypeDependent is not used in fast path

2017-02-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194321 Bug ID: 194321 Summary: drivers/scsi/mpt3sas/mpt3sas_base.c mpt3sas_base_put_smid_fast_path structure descriptor.Default.DescriptorTypeDependent is not used in

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-02-06 Thread Martin K. Petersen
> "Bart" == Bart Van Assche writes: Hi Bart, Bart> Since there is now a resolution for patch 2: have you already Bart> decided when to submit these patches upstream? I queued it in scsi-fixes last week: commit 2780f3c8f0233de90b6b47a23fc422b7780c5436 Author:

[Bug 194341] New: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures

2017-02-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=194341 Bug ID: 194341 Summary: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures Product: SCSI Drivers Version: 2.5 Kernel Version: 4.10

Re: [PATCH] fnic: switch to pci_alloc_irq_vectors

2017-02-06 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Not a full cleanup for the IRQ code, for that we'd need to Christoph> know if the max number of the various CQ types is going to Christoph> stay 1 forever. Satish: Please test and review! -- Martin K. Petersen Oracle

Re: [PATCH] snic: switch to pci_irq_alloc_vectors

2017-02-06 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Narsimhulu, Please test and review! https://patchwork.kernel.org/patch/9549801/ -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V4 00/24] aacraid: Patchset for Smart Family Support

2017-02-06 Thread Martin K. Petersen
> "Raghava" == Raghava Aditya Renukunta > writes: Raghava> This patchset adds support to the HBA1000 and SMARTIOC2000 Raghava> family of cards. The driver version is now updated to 50740 Applied to 4.11/scsi-queue. -- Martin K. Petersen

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread James Bottomley
On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: > Hi Sathya, > > On Mon, Feb 06, 2017 at 09:21:44AM -0700, Sathya Prakash Veerichetty > wrote: > > Willy, > > I think this patch had a problem and later modified to a different > > blocking mechanism. Could you please pull in the latest

Re: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread Willy Tarreau
Hi James, On Mon, Feb 06, 2017 at 10:38:48PM -0800, James Bottomley wrote: > On Mon, 2017-02-06 at 23:26 +0100, Willy Tarreau wrote: (...) > > We don't have the referenced commit above in 3.10 so we should be > > safe. Additionally I checked that neither 4.4 nor 3.12 have them > > either, so

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

2017-02-06 Thread Martin K. Petersen
> "Shivasharan" == Shivasharan S > writes: Shivasharan> Fixing issue of not setting residual bytes correctly. @@ -1464,6 +1465,15 @@ map_cmd_status(struct fusion_context *fusion, SCSI_SENSE_BUFFERSIZE);

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Martin K. Petersen
> "Shivasharan" == Shivasharan Srikanteshwara > writes: Shivasharan, Shivasharan> Are you OK if I re-send only above impacted patch or like Shivasharan> to see complete series with v2 tag and updated patch Shivasharan> numbers? Please send a

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Martin K. Petersen
> "Martin" == Martin K Petersen writes: Martin> Also, please remove all the "This patch depends on ..." stuff Martin> from the patch descriptions. The dependencies are inherent in Martin> the ordering of the patches and we don't want that in the commit Martin>

Re: [PATCH] pm8001: switch to pci_irq_alloc_vectors

2017-02-06 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: sort out the ->eh_timed_out mess

2017-02-06 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> We originally only supported the methods in the Christoph> transport_template, which led to problems with drivers Christoph> needing it and having to fake up a template. Then we added Christoph> it to the host to avoid that

Re: [PATCH 12/39] megaraid_sas: raid 1 write performance for large io

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Avoid Host side PCI bandwidth bottleneck and hint FW to do Write buffering > using > RaidFlag MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT. > Once IO is landed in FW with MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT, > it will do single DMA from host and buffer the

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Fixing issue of not setting residual bytes correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 15/39] megaraid_sas: add print in device removal path

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 16/39] megaraid_sas: reduce size of fusion_context and use vmalloc if kmalloc fails

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Currently fusion context has fixed array load_balance_info. Use dynamic > allocation. > In few places, driver do not want physically contigious memory. > Attempt to use vmalloc if physical contiguous memory is not available. > > Signed-off-by: Shivasharan

Re: [PATCH 23/39] megaraid_sas: set pd_after_lb from MR_BuildRaidContext and initialize pDevHandle to MR_DEVHANDLE_INVALID

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Issue is limited for Syncro firmware where pd_after_lb is not set but is > accidentally used. > Not a functional issue, but results in low performance due to improper load > balancing between two LUNs. > > Signed-off-by: Kashyap Desai

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-06 Thread Hannes Reinecke
On 02/03/2017 08:17 PM, Dupuis, Chad wrote: > From: "Dupuis, Chad" > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > 41000 > Series Converged Network Adapters by QLogic. This patch consists of following > changes: > > - MAINTAINERS

Re: [PATCH 32/39] megaraid_sas: Bail out the driver load if ld_list_query fails

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Error handling: Bail out the driver load if > key FW cmds (LD_LIST) are not return successful. > Clean up error handling in megasas_init_fw. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 22/39] megaraid_sas: latest controller OCR capability from FW before sending shutdown DCMD

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Fetch the latest controller OCR capability from FW before > sending MR_DCMD_CTRL_SHUTDOWN > When application sends a shutdown DCMD (MR_DCMD_CTRL_SHUTDOWN), > driver will fetch latest controller information from firmware. > This is to ensure that driver

Re: [PATCH 28/39] megaraid_sas: Remove unused pd_index from megasas_build_ld_nonrw_fusion

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 29/39] megaraid_sas: Do not set fp_possible if TM capable for non-RW syspdIO, change fp_possible to bool

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for > better tracking and other functionalities if the device > is task management capable. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 19/39] megaraid_sas: Big endian RDPQ mode fix

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Fix if RDPQ mode enabled MR FW is deployed on big endian host machine, > driver does not setup reply address correctly. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 27/39] megaraid_sas: megasas_return_cmd does not memset IO frame to zero

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Memset the IO frame to zero after release. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > No functional change. Code clean up. Removing error code which is not > valid scenario. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai I'm not sure if the part which

Re: [PATCH 11/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property > from FW using New DCMD interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 17/39] megaraid_sas: In validate raid map, raid capability is not converted to cpu format for all lds

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > On a host, if an ld is deleted there is a hole in the ld array returned > by the FW. But in MR_ValidateMapInfo we are not accounting for holes in > the ld array and traverse only upto index num_lds. > This patch takes care of converting the capability

Re: [PATCH 31/39] megaraid_sas: Change build_mpt_mfi_pass_thru to return void

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > Code refactoring to build_mpt_mfi_pass_thru to return void. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 20/39] megaraid_sas: big endian support changes

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Fix endiannes fixes for Ventura specific. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 24/39] megaraid_sas: Change max_cmd from u32 to u16 in all functions

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Since maximum supported FW commands are all defined as u16, change > all local variables referring to max_cmd from u32 to u16. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 25/39] megaraid_sas: update can_queue only if the new value is less

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Minor Optimization: No need to update HBA can_queue value > if the current max FW commands is equal to earlier value. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S

Re: [PATCH 34/39] megaraid_sas: Use synchronize_irq to wait for IRQs to complete

2017-02-06 Thread Tomas Henzl
On 6.2.2017 11:00, Shivasharan S wrote: > FIX - Do not use random delay to synchronize with IRQ. Use kernel API. > > Signed-off-by: Kashyap Desai > Signed-off-by: Shivasharan S > --- Reviewed-by: Tomas Henzl

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2017-02-06 Thread Sagi Grimberg
Hey Chris and Guilherme, I'm indeed not responsive under this email address. Thanks for the testing, looks like you have the magic target to reproduce this. I think this verifies what Mike's idea of what was going wrong, and we're way overdue to get this fixed upstream. Thanks to IBM for

Re: [PATCH V3 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-06 Thread Chad Dupuis
On Mon, 6 Feb 2017, 3:56pm -, Hannes Reinecke wrote: > On 02/03/2017 08:17 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > > 41000 > > Series Converged Network Adapters by QLogic.

Re: [bug report] qla2xxx: Add framework for async fabric discovery

2017-02-06 Thread Tran, Quinn
Dan, Will take a look and submit patch to remove warning. Thanks. Regards, Quinn Tran -Original Message- From: Dan Carpenter Date: Monday, February 6, 2017 at 3:37 AM To: "Tran, Quinn" Cc: "linux-scsi@vger.kernel.org"

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2017-02-06 Thread Guilherme G. Piccoli
On 06/02/2017 15:27, Chris Leech wrote: > - Original Message - >> On 09/11/2016 03:21, Chris Leech wrote: >>> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote: Sure! Count on us to test any patches. I guess the first step is to reproduce on upstream

Re: [PATCH 10/39] megaraid_sas: NVME interface target prop added

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > This patch depends on patch 0008. > This patch fetch true values of NVME property from FW using New DCMD > interface MR_DCMD_DEV_GET_TARGET_PROP > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

Re: [PATCH 14/39] megaraid_sas: enhance debug logs in OCR context

2017-02-06 Thread Tomas Henzl
On 6.2.2017 10:59, Shivasharan S wrote: > Add additional logging from driver in OCR context. > Add debug logs for partial completion of IOs is iodone context. > > Signed-off-by: Shivasharan S > Signed-off-by: Kashyap Desai

  1   2   >