Re: [PATCH] qla1280.c /proc/scsi/qla1280/x reads garbage

2005-02-06 Thread Takayoshi Kochi
Hi, From: Christoph Hellwig <[EMAIL PROTECTED]> Subject: Re: [PATCH] qla1280.c /proc/scsi/qla1280/x reads garbage Date: Fri, 4 Feb 2005 11:27:30 + > > In 2.6.11-rc3, reading /proc/scsi/qla1280/0 sometimes spits garbage. > > This is because in qla1280_proc_info() the returned pointer to > > th

[2.6 patch] SCSI ultrastor.c: make a variable static

2005-02-06 Thread Adrian Bunk
This patch makes a needlessly global variable static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 15 Nov 2004 --- linux-2.6.10-rc1-mm5-full/drivers/scsi/ultrastor.c.old 2004-11-14 01:31:07.0 +0100 +++ linux-2.6.10-rc1-mm5-full/drivers/scsi/

[2.6 patch] SCSI sym53c416.c: make a function static

2005-02-06 Thread Adrian Bunk
This patch makes a needlessly global function static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 15 Nov 2004 --- linux-2.6.10-rc1-mm5-full/drivers/scsi/sym53c416.c.old 2004-11-14 01:30:23.0 +0100 +++ linux-2.6.10-rc1-mm5-full/drivers/scsi/

[PATCH] dc395x fix memory mapping (was Re: dc395x: can't write to tape)

2005-02-06 Thread Guennadi Liakhovetski
Hi again Two weeks since I posted this patch - ping... Regards Guennadi On Sun, 23 Jan 2005, Guennadi Liakhovetski wrote: > On Sun, 9 Jan 2005, Jamie Lenehan wrote: > > > On Sun, Jan 09, 2005 at 12:42:26PM +0100, Guennadi Liakhovetski wrote: > > [...] > > > I could try to improve the highmem s

Re: [PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Matthew Wilcox
On Sun, Feb 06, 2005 at 08:41:23PM +0100, Andi Kleen wrote: > This patch fixes one of Christroph's fixme comments in the SCSI midlayer. If we're going to start fixing problems that Christoph noted, this one seems obvious to me: The static device_request_lock doesn't protect anything; remove it.

Re: [PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Andi Kleen
[...] Willy pointed out a bogus hunk in the original patch that should not have been there. Retransmit with that removed. Also mark scsi_cmnd_serial inline. This patch fixes one of Christroph's fixme comments in the SCSI midlayer. The selection of the serial number and pid for commands was don

[PATCH] Fix selection of command serial numbers and pids

2005-02-06 Thread Andi Kleen
This patch fixes one of Christroph's fixme comments in the SCSI midlayer. The selection of the serial number and pid for commands was done by a global variable and not SMP safe. The race was not very serious because it was only used for error handling, but it's still better to fix it. I audited

Re: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 12:28:17PM -0500, [EMAIL PROTECTED] wrote: > Since the Emulex driver tracks things by target (actually FC remote port) > rather than luns, having the ability to have driver data space in the > lun didn't help much. Yes, the driver data space could be in the > transport-speci

RE: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-06 Thread James . Smart
No - there was no discussion of adding scsi targets to linux (per your definition or otherwise). Since the Emulex driver tracks things by target (actually FC remote port) rather than luns, having the ability to have driver data space in the lun didn't help much. Yes, the driver data space could be

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-06 Thread Christoph Hellwig
On Thu, Feb 03, 2005 at 11:05:32AM +0100, Arjan van de Ven wrote: > * needs to use list.h lists not open coded ones the only list uses I saw in a quick scan were for internal queueing which should go away. (see the tmscsim driver in 2.6 on what to return when the queue is full) > * uses wrong lo

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-06 Thread Christoph Hellwig
On Thu, Feb 03, 2005 at 12:33:37PM +0800, erich wrote: > Hi,Andrew Morton > > Thanks for your doing. > ARECA Linux RAID driver need to support old linux kerenel version. > There are a lot of NAS RAID STORAGE SYSTEM development worker still use it > at old linux kernel. > Maybe I need to released

Re: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-06 Thread Vladislav Bolkhovitin
Please, forgive me my ignorance, it looks like something was happened "behind the scene" (linux-scsi list), and I missed it. Is support for SCSI targets started to be added in Linux? I mean "SCSI targets" as the ability to export local devices on a SCSI bus. If so, please consider proposed SCSI