[RFC] Common header file for FC definitions

2008-01-08 Thread Christof Schmitt
zfcp has a couple of definitions to describe the FC protocol. Grepping through the complete source tree shows that e.g. the lpfc module makes similar private definitions. It think that it would make sense to introduce a global header file for FC related definitions that each FC driver can use.

Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3

2008-01-08 Thread Evgeniy Dushistov
On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote: This is a bit of a rash of bug fixes. The qla1280 is actually a bug fix (in spite of the title---it's actually correcting an existing problem with the qla1280 implementation of accessors that broke the current driver).

Re: [RFC] Common header file for FC definitions

2008-01-08 Thread Christoph Hellwig
On Tue, Jan 08, 2008 at 09:09:36AM +0100, Christof Schmitt wrote: zfcp has a couple of definitions to describe the FC protocol. Grepping through the complete source tree shows that e.g. the lpfc module makes similar private definitions. It think that it would make sense to introduce a global

Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread Hannes Reinecke
Hi all, I have here a buggy firewire bridge (Prolific PL3507) which requires that each 'INQUIRY' command is followed by a 'READ CAPACITY' command. Otherwise any read will return invalid data (the payload is preceded by 36 empty bytes). How to fix this? Sure one could add a hack to sbp2.c to

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Dienstag, 8. Januar 2008 04:56:03 schrieb Alan Stern: You'll have to add this method whenever a new subsystem is affected by power management. Sorry, I don't understand your point.  If you mean that we'll have to add autosuspend and autoresume code to every driver that wants to support

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern:  /** + * autoresume - perform dynamic (runtime) host resume + [EMAIL PROTECTED]: host to resume + * + * Resume (return to an operational power level) the specified host. + * Return 0 if the resume was successful, otherwise a

Re: [RFC] Common header file for FC definitions

2008-01-08 Thread Seokmann Ju
Christof Schmitt wrote: zfcp has a couple of definitions to describe the FC protocol. Grepping through the complete source tree shows that e.g. the lpfc module makes similar private definitions. It think that it would make sense to introduce a global header file for FC related definitions that

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread Matthew Wilcox
On Tue, Jan 08, 2008 at 02:43:34PM +0100, Hannes Reinecke wrote: Hi all, I have here a buggy firewire bridge (Prolific PL3507) which requires that each 'INQUIRY' command is followed by a 'READ CAPACITY' command. Otherwise any read will return invalid data (the payload is preceded by 36

Re: [GIT PATCH] SCSI bug fixes for 2.6.24-rc3

2008-01-08 Thread FUJITA Tomonori
CC'ed Jes, On Tue, 8 Jan 2008 14:15:53 +0300 Evgeniy Dushistov [EMAIL PROTECTED] wrote: On Sun, Nov 25, 2007 at 01:24:25PM +0200, James Bottomley wrote: This is a bit of a rash of bug fixes. The qla1280 is actually a bug fix (in spite of the title---it's actually correcting an existing

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Dienstag, 8. Januar 2008 16:06:53 schrieb Alan Stern: Eventually parts of the autosuspend mechanism will go there.  But first I thought we should have a proof-of-concept version working for at least two different subsystems (such as SCSI and USB), so that we can understand what should go

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Alan Stern
On Tue, 8 Jan 2008, Oliver Neukum wrote: Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern:  /** + * autoresume - perform dynamic (runtime) host resume + [EMAIL PROTECTED]: host to resume + * + * Resume (return to an operational power level) the specified host. + * 

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Dienstag, 8. Januar 2008 16:12:52 schrieb Alan Stern: On Tue, 8 Jan 2008, Oliver Neukum wrote: Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern:  /** + * autoresume - perform dynamic (runtime) host resume + [EMAIL PROTECTED]: host to resume + * + * Resume

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Alan Stern
On Tue, 8 Jan 2008, Oliver Neukum wrote: Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: This patch applies to 2.6.24-rc6.  Comments and suggestions are welcome. What about the SG_IO ioctl() ? It seems to me that you must not autosuspend a device after that ioctl() has been used

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: This patch applies to 2.6.24-rc6.  Comments and suggestions are welcome. What about the SG_IO ioctl() ? It seems to me that you must not autosuspend a device after that ioctl() has been used until the file handle is closed.

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Alan Stern
On Tue, 8 Jan 2008, Oliver Neukum wrote: Am Dienstag, 8. Januar 2008 04:56:03 schrieb Alan Stern: You'll have to add this method whenever a new subsystem is affected by power management. Sorry, I don't understand your point.  If you mean that we'll have to add autosuspend and

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Oliver Neukum
Am Dienstag, 8. Januar 2008 16:16:43 schrieb Alan Stern: What about the SG_IO ioctl() ? It seems to me that you must not autosuspend a device after that ioctl() has been used until the file handle is closed. That's an open problem.  The patch does block autosuspends as long as an sg file

Re: [PATCH] sym8xx_2: kill compilation warning

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 07:40 +0100, Krzysztof Helt wrote: On Mon, 07 Jan 2008 16:39:35 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote: From: Krzysztof Helt [EMAIL PROTECTED] This patch fixes call to

Re: [RFC] Common header file for FC definitions

2008-01-08 Thread Christof Schmitt
On Tue, Jan 08, 2008 at 10:46:51AM -0500, James Smart wrote: Christoph Hellwig wrote: On Tue, Jan 08, 2008 at 09:09:36AM +0100, Christof Schmitt wrote: zfcp has a couple of definitions to describe the FC protocol. Grepping through the complete source tree shows that e.g. the lpfc module makes

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread Stefan Richter
Matthew Wilcox wrote: On Tue, Jan 08, 2008 at 02:43:34PM +0100, Hannes Reinecke wrote: I have here a buggy firewire bridge (Prolific PL3507) which requires that each 'INQUIRY' command is followed by a 'READ CAPACITY' command. Otherwise any read will return invalid data (the payload is preceded

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Stefan Richter
Alan Stern wrote: On Tue, 8 Jan 2008, Oliver Neukum wrote: Am Montag, 7. Januar 2008 20:42:23 schrieb Alan Stern: /** + * autoresume - perform dynamic (runtime) host resume [...] This seems to be a bit misleading. It seems to me that you must cancel any outstanding request to

looking for help with mpt fusion driver log: FAULT code = 1804h

2008-01-08 Thread Chris Friesen
Hi all, We're seeing the following on startup: Fusion MPT base driver 3.02.55 Copyright (c) 1999-2005 LSI Logic Corporation Fusion MPT SAS Host driver 3.02.55 mptbase: Initiating ioc0 bringup mptbase: ioc0: WARNING - IOC is in FAULT state!!! FAULT code = 1804h mptbase: ioc0: ERROR -

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 18:56 +0100, Stefan Richter wrote: Matthew Wilcox wrote: On Tue, Jan 08, 2008 at 02:43:34PM +0100, Hannes Reinecke wrote: I have here a buggy firewire bridge (Prolific PL3507) which requires that each 'INQUIRY' command is followed by a 'READ CAPACITY' command.

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread Matthew Wilcox
On Tue, Jan 08, 2008 at 06:56:11PM +0100, Stefan Richter wrote: It's hald or something like that. Can't we get hald to look at the cached results of the inquiry command, handily available through sysfs? Matthew Wilcox wrote: I have a hard time thinking this needs to be handled generically

Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Alan Stern
On Tue, 8 Jan 2008, Stefan Richter wrote: How about something more like this: * Resume (return to an operational power level) the specified host, * and prevent autosuspends from other software layers until the * template autosuspend method has been called again. * Return 0 if

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread Stefan Richter
Matthew Wilcox wrote: According to SPC4r05a, READ CAPACITY(10) (opcode 25) is Mandatory for D, W and O. READ CAPACITY (opcode 25) is Optional for R. READ CARD CAPACITY (also opcode 25) is Mandatory for K. [...] According to this table (D.2 for anyone following along at home), RBC devices

[PATCH 1/1] aacraid: add aacraid.cache parameter to driver to control FUA and SYNCHRONIZE_CACHE policy

2008-01-08 Thread Salyzyn, Mark
aacraid.cache parameter, Disable Queue Flush commands: bit 0 - Disable FUA in WRITE SCSI commands bit 1 - Disable SYNCHRONIZE_CACHE SCSI command bit 2 - Disable only if Battery not protecting adapter supplied Cache e.g.: aacraid.cache=7 will disable the FUA and

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread maximilian attems
On Tue, Jan 08, 2008 at 12:10:47PM -0600, James Bottomley wrote: Not to hijack the thread, but this is getting to be a broken record. I was dealing only a few days ago with a camera presenting as a mass storage device that was then crashing and going offline. I looked at the dmesg trace

[PATCH 1/1] aacraid: add call to flush_kernel_dcache_page for architectures that require it.

2008-01-08 Thread Salyzyn, Mark
Some architectures require a call to flush_kernel_dcache_page for processor spoofed DMA operations. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments (inline gets damaged, use attachment).

[PATCH 1/1] aacraid: add sysfs report of RAID level

2008-01-08 Thread Salyzyn, Mark
Report the RAID level string for the SCSI device representing the array. Report is in /sys/class/scsi_device/#:#:#:#/device/level. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments.

[PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Salyzyn, Mark
Big endian systems issues discovered in the aacraid driver. Somewhat reverses a patch from November 7th of last year that removed swap operations because they formerly were being assigned to an u8 array when they should have been assigned to an le32 array. This patch is largely inert for any

[PATCH 1/1] aacraid: variable redefinition hides earlier warning

2008-01-08 Thread Salyzyn, Mark
The parameter 'info' is reused, renamed the second to sinfo to represent supplemental adapter info, to suppress compile warning message. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments

Size of SCSI READ_10 commands

2008-01-08 Thread Ethan Burns
Hello, I am working on a project with the University of New Hampshire iSCSI initiator and target modules. I am seeing an issue with the SCSI commands that are being given to the initiator side. We register the initiator as a SCSI device with max_sectors=1024 in the host template. When I

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread David Zeuthen
On Tue, 2008-01-08 at 15:10 -0500, David Zeuthen wrote: Perhaps if you can point to what SCSI commands hald are sending it would be easier to debug. Any other ideas? Also, if you can identify the name of the process image doing this it would be helpful. I know both libipoddevice and libgpod

[PATCH 1/1] aacraid: multiple definition of automatic variable warning.

2008-01-08 Thread Salyzyn, Mark
The 'entry' automatic variable was defined at the top and within a block that uses it, removed the definition from the block that uses it. Some cosmetic changes were made while in the same file. This patch should be inert. This attached patch is against current scsi-misc-2.6.

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Grant Grundler
On Jan 8, 2008 12:48 PM, Salyzyn, Mark [EMAIL PROTECTED] wrote: Big endian systems issues discovered in the aacraid driver. ... --- a/drivers/scsi/aacraid/comminit.c 2008-01-08 15:32:28.329810853 -0500 +++ b/drivers/scsi/aacraid/comminit.c 2008-01-08 15:37:35.633163607 -0500 @@ -301,10

[PATCH 1/1] aacraid: OS panic after Adapter panic (hardening).

2008-01-08 Thread Salyzyn, Mark
In experiments in the lab we managed to trigger an Adapter firmware panic (BlinkLED) coincidentally while several pass-through ioctl command from the management software were outstanding on a bug only present on a class of RAID Adapters that require a hardware reset rather than a commanded

RE: [PATCH 1/1] aacraid: multiple definition of automatic variable warning.

2008-01-08 Thread Salyzyn, Mark
Missed the patch attachment 8-} Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark Sent: Tuesday, January 08, 2008 3:58 PM To: 'linux-scsi@vger.kernel.org' Subject: [PATCH 1/1] aacraid: multiple definition of

RE: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Salyzyn, Mark
I've always assumed that byte swapping of constants would be optimized where a variable would not :-) I have confirmed in assembler output of the compiler that constant merely become byte reversed constants optimized or no in at least one architectural case. I have *not* confirmed that a

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Matthew Wilcox
On Tue, Jan 08, 2008 at 01:17:15PM -0800, Grant Grundler wrote: Why apply le32_to_cpu() to the constant instead of the variable? On systems were le32_to_cpu() is doing something, can gcc or preprocessor optimize the constant? I've always assumed it could not but that might be wrong. $ grep

Re: [linux-pm] Re: [RFC] Implementation of SCSI dynamic power management

2008-01-08 Thread Pavel Machek
When all the devices under a host are suspended, the LLD is informed (via a new autosuspend method in the host template) so that it can That is most certainly a mistake. Why? Is there a good reason to not modify to extend suspend() to take an extra argument for the reason it

[PATCH 1/1] aacraid: improve queue balancing

2008-01-08 Thread Salyzyn, Mark
The adapter queue is divided up equally to all the arrays to prevent command starvation to any individual array. On the other hand, physical targets are only granted a queue depth of one each. The code prior to this patch used to deal with the incremental discovery of targets, but the driver

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-08 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Sat, 05 Jan 2008 14:01 +0900: From: Deepak Colluru [EMAIL PROTECTED] Subject: [PATCH] bsg : Add support for io vectors in bsg Date: Fri, 4 Jan 2008 21:47:34 +0530 (IST) From: Deepak Colluru [EMAIL PROTECTED] Add support for io vectors in bsg.

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Greg KH
On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: On Jan 8, 2008 1:20 AM, Greg KH [EMAIL PROTECTED] wrote: On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: It's already in the driver core to the most part. It remains to be seen what is less complicated in the

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-08 Thread FUJITA Tomonori
On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote on Sat, 05 Jan 2008 14:01 +0900: From: Deepak Colluru [EMAIL PROTECTED] Subject: [PATCH] bsg : Add support for io vectors in bsg Date: Fri, 4 Jan 2008 21:47:34 +0530 (IST) From: Deepak

Number of devices that SCSI can support

2008-01-08 Thread Vinay Venkataraghavan
Hello everybody, Is there a limit on the number of devices that SCSI supports. In other words, I have a QLogic HBA card, and I am connecting to a SAN which has 64 targets. I also have one local SCSI disk. So the total number of targets that I need to see is 65. So now what happens is that

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Dave Young
On Jan 9, 2008 6:48 AM, Greg KH [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: On Jan 8, 2008 1:20 AM, Greg KH [EMAIL PROTECTED] wrote: On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: It's already in the driver core to the most part.

Re: Number of devices that SCSI can support

2008-01-08 Thread Matthew Wilcox
On Tue, Jan 08, 2008 at 04:55:46PM -0800, Vinay Venkataraghavan wrote: Is there a limit on the number of devices that SCSI supports. In other words, I have a QLogic HBA card, and I am connecting to a SAN which has 64 targets. I've personally had over five hundred LUNs. You shouldn't be

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-08 Thread Tejun Heo
James Bottomley wrote: ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a dma_alignment variable which ensures both the beginning and

Re: [PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Grant Grundler
On Jan 8, 2008 1:37 PM, Salyzyn, Mark [EMAIL PROTECTED] wrote: I've always assumed that byte swapping of constants would be optimized where a variable would not :-) definitely...I understood that. It just seemed odd usage. I have confirmed in assembler output of the compiler that constant

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-08 Thread James Bottomley
On Wed, 2008-01-09 at 11:10 +0900, Tejun Heo wrote: James Bottomley wrote: ATA requires that all DMA transfers begin and end on word boundaries. Because of this, a large amount of machinery grew up in ide to adjust scatterlists on this basis. However, as of 2.5, the block layer has a

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-08 Thread Tejun Heo
James Bottomley wrote: Also, DMA alignment at block layer isn't enough for ATA. ATA needs drain buffers for ATAPI commands with variable length response. :-( OK, where is this in the libata code? The dma_pad size is only 4 bytes, so this drain, I assume is only a word long? Given the

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Dave Young
On Wed, Jan 09, 2008 at 09:32:48AM +0800, Dave Young wrote: On Jan 9, 2008 6:48 AM, Greg KH [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: On Jan 8, 2008 1:20 AM, Greg KH [EMAIL PROTECTED] wrote: On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Dave Young
On Jan 9, 2008 2:13 PM, Dave Young [EMAIL PROTECTED] wrote: On Wed, Jan 09, 2008 at 09:32:48AM +0800, Dave Young wrote: On Jan 9, 2008 6:48 AM, Greg KH [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: On Jan 8, 2008 1:20 AM, Greg KH [EMAIL PROTECTED]

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Dave Young
On Jan 9, 2008 2:37 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 9, 2008 2:13 PM, Dave Young [EMAIL PROTECTED] wrote: On Wed, Jan 09, 2008 at 09:32:48AM +0800, Dave Young wrote: On Jan 9, 2008 6:48 AM, Greg KH [EMAIL PROTECTED] wrote: On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave

AHCI finds disks; no /dev/sd inodes bound?

2008-01-08 Thread Jon Watte
I ran out of PATA ports, and figured I'd use the un-used SATA ports on the motherboard of the current machine (Intel G33/ICH9 based) to expand storage that has run out again (like storage usually does). I shut down the machine, put in the disks, booted up, made sure the BIOS said enhanced/AHCI