Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-09-06 Thread Jiri Kosina
On Wed, 28 Aug 2013, Bjorn Helgaas wrote: [+cc another email addr for Adam from git logs] Thanks. Adam, would you happen to have any possible explanation / background? Commit d5dea7d95 (PCI: msi: Disable msi interrupts when we initialize a pci device) makes MSIs be forcibly disabled at

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Sergei Shtylyov
Hello. On 06-09-2013 4:44, Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. Don't give the same name to both patches. In this case, you could prefix the patch name with e.g. sd: . Signed-off-by: Todd Brandt

Re: [PATCH v2] scsi: sr: use block layer runtime PM

2013-09-06 Thread Alan Stern
On Fri, 6 Sep 2013, Aaron Lu wrote: Migrate SCSI Optical Disk Drive(ODD) driver sr to make use of block layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is simplified as all SCSI devices that implement runtime PM are now request based. Note that due to ODD will be

Re: [PATCH v2] scsi: sr: use block layer runtime PM

2013-09-06 Thread James Bottomley
On Fri, 2013-09-06 at 10:01 +0800, Aaron Lu wrote: Migrate SCSI Optical Disk Drive(ODD) I'm not very keen on this description because it's not quite accurate. sr stands for SCSI ROM. You could say optical SCSI ROM perhaps, but Magneto Optical disks are handled by sd not sr. driver sr to make

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread James Bottomley
On Thu, 2013-09-05 at 17:44 -0700, Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. This is a horrible patch description, it won't tell the next reader anything about what is going on and why. Give the patches two separate

[PATCH 4/18] lpfc 8.3.42: Fixed mailbox memory leak.

2013-09-06 Thread James Smart
Fixed mailbox memory leak. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c |1 + 1 file changed, 1 insertion(+) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2013-09-04 13:18:04.0

[PATCH 0/18] lpfc 8.3.42: Update lpfc to revision 8.3.42

2013-09-06 Thread James Smart
This patch set updates the lpfc driver to revision 8.3.42 The patches for 8.3.42 contain: - Fixed using unsafe linked list macro for walking and deleting linked list - Fixed not able to log informational messages at early stage of driver init time - Fix ramdom errors using first burst - Fixed

[PATCH 14/18] lpfc 8.3.42: Fixed failure to allocate SCSI buffer on PPC64 platform for SLI4 devices

2013-09-06 Thread James Smart
Fixed failure to allocate SCSI buffer on PPC64 platform for SLI4 devices Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 7/18] lpfc 8.3.42: Fixed race condition between BSG I/O dispatch and timeout handling

2013-09-06 Thread James Smart
Fixed race condition between BSG I/O dispatch and timeout handling Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c | 86 + lpfc_sli.h |3 +- 2 files changed, 72 insertions(+), 17 deletions(-) diff -upNr

[PATCH 16/18] lpfc 8.3.42: Fixed inconsistent spin lock usage.

2013-09-06 Thread James Smart
Fixed inconsistent spin lock usage. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c |8 lpfc_scsi.c | 26 -- 2 files changed, 16 insertions(+), 18 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c

[PATCH 12/18] lpfc 8.3.42: Avoided making pci bar ioremap call during dual-chute WQ/RQ pci bar selection

2013-09-06 Thread James Smart
Avoided making pci bar ioremap call during dual-chute WQ/RQ pci bar selection Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 34 -- lpfc_sli.c | 16 2 files changed, 12 insertions(+), 38 deletions(-) diff -upNr

[PATCH 9/18] lpfc 8.3.42: Fixed logging format of setting driver sysfs attributes hard to interpret

2013-09-06 Thread James Smart
Fixed logging format of setting driver sysfs attributes hard to interpret Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c ---

[PATCH 10/18] lpfc 8.3.42: Fix crash on driver load due to cpu affinity logic

2013-09-06 Thread James Smart
Fix crash on driver load due to cpu affinity logic Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c |5 - lpfc_init.c | 28 +++- 2 files changed, 27 insertions(+), 6 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 3/18] lpfc 8.3.42: Fix ramdom errors using first burst

2013-09-06 Thread James Smart
Fix ramdom errors using first burst Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 11/18] lpfc 8.3.42: Fixed driver iocbq structure's iocb_flag field running out of space

2013-09-06 Thread James Smart
Fixed driver iocbq structure's iocb_flag field running out of space Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c | 14 +++--- lpfc_sli.h |5 ++--- 2 files changed, 9 insertions(+), 10 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c

[PATCH 13/18] lpfc 8.3.42: Fix WARN_ON when driver unloads

2013-09-06 Thread James Smart
Fix WARN_ON when driver unloads Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c 2013-09-06

[PATCH 2/18] lpfc 8.3.42: Fixed not able to log informational messages at early stage of driver init time

2013-09-06 Thread James Smart
Fixed not able to log informational messages at early stage of driver init time Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c

[PATCH 1/18] lpfc 8.3.42: Fixed using unsafe linked list macro for walking and deleting linked list

2013-09-06 Thread James Smart
Fixed using unsafe linked list macro for walking and deleting linked list Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |4 ++-- lpfc_sli.c |5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c

[PATCH 17/18] lpfc 8.3.42: Fixed issue of task management commands having a fixed timeout

2013-09-06 Thread James Smart
Fixed issue of task management commands having a fixed timeout Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |1 + lpfc_attr.c |8 lpfc_scsi.c |2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 5/18] lpfc 8.3.42: Back out data count,(residual fcfi_parm) fix for bad target.

2013-09-06 Thread James Smart
Back out data count,(residual fcfi_parm) fix for bad target. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 8/18] lpfc 8.3.42: Fixed back to back RSCNs discovery failure.

2013-09-06 Thread James Smart
Fixed back to back RSCNs discovery failure. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hbadisc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c ---

[PATCH 18/18] lpfc 8.3.42: Update lpfc version to driver version 8.3.42

2013-09-06 Thread James Smart
Update lpfc version to driver version 8.3.42 Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h

Re: [PATCH v2] scsi: sr: use block layer runtime PM

2013-09-06 Thread Alan Stern
On Fri, 6 Sep 2013, James Bottomley wrote: layer runtime PM. Accordingly, the SCSI bus layer runtime PM callback is simplified as all SCSI devices that implement runtime PM are now request based. OK, let's now try for a descriptive changelog. All SCSI devices (including sr) are request

[PATCH] SCSI: Fix potential out-of-bounds access in drivers/scsi/sd.c

2013-09-06 Thread Alan Stern
This patch fixes an out-of-bounds error in sd_read_cache_type(), found by Google's AddressSanitizer tool. When the loop ends, we know that offset lies beyond the end of the data in the buffer, so no Caching mode page was found. In theory it may be present, but the buffer size is limited to 512

[PATCH 6/18] lpfc 8.3.42: Fixed function mode field defined too small for not recognizing dual-chute mode

2013-09-06 Thread James Smart
Fixed function mode field defined too small for not recognizing dual-chute mode Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli4.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h ---

Re: [PATCH] SCSI: Fix potential out-of-bounds access in drivers/scsi/sd.c

2013-09-06 Thread Paolo Bonzini
Il 06/09/2013 17:49, Alan Stern ha scritto: This patch fixes an out-of-bounds error in sd_read_cache_type(), found by Google's AddressSanitizer tool. When the loop ends, we know that offset lies beyond the end of the data in the buffer, so no Caching mode page was found. In theory it may be

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, September 05, 2013 05:44:25 PM Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. Please update the patch description to say what the patch does (and why). Signed-off-by: Todd Brandt todd.e.bra...@intel.com

Re: [PATCH 04/12] [SCSI] qla2xxx: Use standard PCIe Capability Link register field names

2013-09-06 Thread Bjorn Helgaas
Sorry, I said I was going to push this through my PCI tree, but I forgot all about it. I put it (finally) in my pci/misc branch, and will merge it during the v3.13 merge window. On Fri, Jan 4, 2013 at 12:31 PM, Bjorn Helgaas bhelg...@google.com wrote: I haven't heard anything, so I'm going to

Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread James Bottomley
On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote: Code to reset fc_host statistics. echo 1 /sys/class/fc_host/hostX/statistics/reset_statistics clears fc_host stats, the code also issues command to fnic firmware to clear vnic stats. Signed-off-by: Narsimhulu Musini nmus...@cisco.com

Re: [PATCH v2 1/6] scsi/bfa: use pcie_set/get_readrq to simplify code

2013-09-06 Thread Jon Mason
On Thu, Sep 5, 2013 at 12:55 AM, Yijing Wang wangyij...@huawei.com wrote: v1-v2: use pcie_get/set_readrq to simplify code a lot suggestd by Bjorn. Use pcie_get_readrq()/pcie_set_readrq() to simplify code. Very similar to a patch I sent out in 2011

Re: [PATCH 1/6] SCSI: esas2r: smatch - Use biwise rather than logical AND for checking if any bit set

2013-09-06 Thread James Bottomley
On Thu, 2013-08-29 at 15:55 -0400, Bradley Grove wrote: Signed-off-by: Bradley Grove bgr...@attotech.com This additional SCSI: in the subject is unnecessary and just causes me extra work to remove it. There should be a Reported-by: before the signoff indicating whoever you got the report from

Re: [PATCH 1/2] megaraid_sas: Add High Availability clustering support using shared Logical Disks

2013-09-06 Thread James Bottomley
On Sat, 2013-08-31 at 16:54 -0700, adam radford wrote: --- scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c 2013-08-31 16:17:56.909172648 -0700 +++ scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c 2013-08-31 16:24:51.861078589 -0700 @@ -77,9 +77,12 @@

Re: [PATCH 17/18] lpfc 8.3.42: Fixed issue of task management commands having a fixed timeout

2013-09-06 Thread Jeremy Linton
On 9/6/2013 11:22 AM, James Smart wrote: Fixed issue of task management commands having a fixed timeout I'm surprised about this change, since it appears a number of issues in the send_taskmgmt() still exist that keep it from handling task management failures correctly. It also

Re: [PATCH] ibmvscsi: Fix little endian issues

2013-09-06 Thread James Bottomley
On Tue, 2013-09-03 at 10:04 +1000, Anton Blanchard wrote: The hypervisor is big endian, so little endian kernel builds need to byteswap. Signed-off-by: Anton Blanchard an...@samba.org You have two serious checkpatch errors in this: ERROR: trailing whitespace #57: FILE:

Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread Hiral Patel (hiralpat)
Hi James, Yes for this patch Narsimhulu Musini is the author of this patch. Thanks, Hiral On 9/6/13 10:35 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote: Code to reset fc_host statistics. echo 1

[RESEND PATCH v5 0/2] block,scsi: fixup blk_get_request dead queue scenarios

2013-09-06 Thread Joe Lawrence
Hi Jens, James, This is a resend of a patchset to 1) protect blk_get_request __GFP_WAIT callers from dead queues and then 2) convert blk_get_request to return ERR_PTR to distinguish between dead queues and low-memory scenarios. [1] A similar bug report appeared on LKML in June [2], (although I

[RESEND PATCH v5 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2013-09-06 Thread Joe Lawrence
The blk_get_request function may fail in low-memory conditions or during device removal (even if __GFP_WAIT is set). To distinguish between these errors, modify the blk_get_request call stack to return the appropriate ERR_PTR. Verify that all callers check the return status and consider IS_ERR

[RESEND PATCH v5 1/2] block,scsi: verify return pointer from blk_get_request

2013-09-06 Thread Joe Lawrence
The blk-core dead queue checks introduce an error scenario to blk_get_request that returns NULL if the request queue has been shutdown. This affects the behavior for __GFP_WAIT callers, who should verify the return value before dereferencing. Signed-off-by: Joe Lawrence joe.lawre...@stratus.com

Re: [PATCH v2 1/6] scsi/bfa: use pcie_set/get_readrq to simplify code

2013-09-06 Thread Bjorn Helgaas
On Thu, Sep 05, 2013 at 03:55:25PM +0800, Yijing Wang wrote: v1-v2: use pcie_get/set_readrq to simplify code a lot suggestd by Bjorn. Use pcie_get_readrq()/pcie_set_readrq() to simplify code. Signed-off-by: Yijing Wang wangyij...@huawei.com Cc: Jiang Liu jiang@huawei.com Cc: Anil

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Todd E Brandt
I'll resubmit with a better description. As for the return value, if you look at the mailing list history you'll see that I already tried that approach (and was actually advised to do it this way): http://marc.info/?l=linux-scsim=136881989601276w=2 On Fri, Sep 06, 2013 at 07:03:26PM +0200,

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Todd E Brandt
I'll fix those, thanks for the feedback. On Fri, Sep 06, 2013 at 04:37:00PM +0400, Sergei Shtylyov wrote: Hello. On 06-09-2013 4:44, Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. Don't give the same name to both

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread Todd E Brandt
Sorry for the missing description, I've submitted it several times so I just assumed that the previous entries in the thread were enough. I'll resubmit with a full description. As for replacing sd_resume altogether, the reason I didn't is because there are three callbacks which use sd_resume.

Re: [PATCH 1/2] megaraid_sas: Add High Availability clustering support using shared Logical Disks

2013-09-06 Thread adam radford
On 9/6/13, James Bottomley james.bottom...@hansenpartnership.com wrote: Checkpatch doesn't like this. It thinks (correctly) that these should all be in megaraid_sas.h so we can't get the prototype different from the actual function without some type of warning. Can you move them, please?

Re: [PATCH/RESEND 1/2] Hard disk S3 resume time optimization

2013-09-06 Thread Todd E Brandt
On Fri, Sep 06, 2013 at 06:54:48PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday, September 05, 2013 05:38:53 PM Todd E Brandt wrote: This is the final draft of the non-blocking hard disk resume patch. I've included some performance results to demonstrate the real benefits of

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-09-06 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 28 Aug 2013, Bjorn Helgaas wrote: [+cc another email addr for Adam from git logs] Thanks. Adam, would you happen to have any possible explanation / background? Commit d5dea7d95 (PCI: msi: Disable msi interrupts

Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread James Bottomley
On Fri, 2013-09-06 at 20:51 +, Hiral Patel (hiralpat) wrote: Hi James, Yes for this patch Narsimhulu Musini is the author of this patch. Thanks, Hiral On 9/6/13 10:35 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel

Re: [PATCH 4/6] scsi: ufs: add unipro attribute IDs

2013-09-06 Thread James Bottomley
On Sat, 2013-08-31 at 21:40 +0530, Santosh Y wrote: From: Seungwon Jeon tgih@samsung.com 'drivers/scsi/ufs/unipro.h' is added. Attributes in the layers of the UNIPRO stack can be read and written via the DME. A dangling unused header file is a bit of a strange commit. I merged it into