Re: [PATCH V2] [scsi] enclosure: remove duplicate device before add new

2013-09-24 Thread Joe Jin
Hi James, Can you please help to review the patch and comment it? Thanks, Joe On 09/20/13 08:16, Joe Jin wrote: When do disk pull/insert test we encountered below: WARNING: at fs/sysfs/dir.c:455 sysfs_add_one+0xbc/0xe0() Hardware name: SUN FIRE X4370 M2 SERVER sysfs: cannot create

Re: [PATCH v3 3/6] uas: make work list per-device

2013-09-24 Thread Christoph Hellwig
On Wed, Sep 18, 2013 at 09:33:04AM +0200, Gerd Hoffmann wrote: While being at it rename the list head from list to work, preparing for the addition of a second list. Why do you even the list? The list was already there when I took over maintainance ... What would a ordered

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Paolo Bonzini
Il 21/09/2013 00:03, Martin K. Petersen ha scritto: The major headache here of course is that WRITE SAME is inherently destructive. We can't just fire off one during discovery and see if it works. For WRITE you can issue a command with a transfer length of 0 to see if things work. But

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Jack Wang
On 09/21/2013 07:24 AM, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, September 20, 2013 1:32 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

RE: Drivers: scsi: FLUSH timeout

2013-09-24 Thread KY Srinivasan
-Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Tuesday, September 24, 2013 5:08 AM To: KY Srinivasan Cc: Greg KH; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux-

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Bernd Schubert
On 09/24/2013 02:35 PM, KY Srinivasan wrote: -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Tuesday, September 24, 2013 5:08 AM To: KY Srinivasan Cc: Greg KH; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread James Bottomley
On Tue, 2013-09-24 at 11:37 +0200, Paolo Bonzini wrote: Il 21/09/2013 00:03, Martin K. Petersen ha scritto: The major headache here of course is that WRITE SAME is inherently destructive. We can't just fire off one during discovery and see if it works. For WRITE you can issue a command

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Martin K. Petersen
Mike == Mike Snitzer snit...@redhat.com writes: Mike So are there drives like this?: Mike 1) don't support RSOC Mike 2) do support WRITE SAME Mike 3) do populate VPD page with either WRITE SAME w/ discard bit set Mikeor UNMAP? Yes. But again, the fundamental issue here is not the drives.

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Mike Snitzer
On Tue, Sep 24 2013 at 9:49am -0400, Martin K. Petersen martin.peter...@oracle.com wrote: Mike == Mike Snitzer snit...@redhat.com writes: Mike So are there drives like this?: Mike 1) don't support RSOC Mike 2) do support WRITE SAME Mike 3) do populate VPD page with either WRITE SAME w/

Re: Drivers: scsi: FLUSH timeout

2013-09-24 Thread Mike Christie
On 09/24/2013 07:35 AM, KY Srinivasan wrote: -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Tuesday, September 24, 2013 5:08 AM To: KY Srinivasan Cc: Greg KH; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

Errors then crash Megaraid_sas v06.506.00.00-rc1

2013-09-24 Thread Errol Neal
Hi. I'm running Ubuntu 13.04 Raring on a Power Edge R515 with Dell H700 controller. I'm using kernel 3.10.12 Its a test platform and I'm driving quite a bit of i/o through it. Under load at times, the megaraid_sas driver will spit out the following error: Sep 24 11:16:17 ubuntu1 kernel:

Megaraid SAS HA using shared disks

2013-09-24 Thread Errol Neal
Curious. There were some commits made recently that make it possible using LSI's raid controllers. I checked out the LSI website and it sees that the Syncro product line has been updated to include support for Linux. Can anyone comment on if these patches enable the feature stand-alone with ANY

Re: [dm-devel] SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Mikulas Patocka
On Fri, 20 Sep 2013, Mike Snitzer wrote: On Thu, Sep 19 2013 at 12:13pm -0400, Mike Snitzer snit...@redhat.com wrote: Workaround the SCSI layer's problematic WRITE SAME heuristics by disabling WRITE SAME in the DM multipath device's queue_limits if an underlying device disabled it.

Re: [dm-devel] SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Jeremy Linton
On 9/24/2013 12:39 AM, Hannes Reinecke wrote: My drives support 'report opcodes', and report that write same is supported: ... 93 16Write same(16) ... but no support for page 'b0'. And yes, these are real SAS drives. So the question is, how many devices get the

Re: notify userspace of offline - running transitions

2013-09-24 Thread Ewan Milne
http://marc.info/?l=linux-scsim=133901769900806w=2 Can we reconsider applying patch 4 in Mike's set? The problem still exists, and there was never another solution proposed as far as I can see. (I posted a question about this a while back...) It is a big issue for people who happen to get a

Re: [dm-devel] SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Douglas Gilbert
On 13-09-24 03:12 PM, Jeremy Linton wrote: On 9/24/2013 12:39 AM, Hannes Reinecke wrote: My drives support 'report opcodes', and report that write same is supported: ... 93 16Write same(16) ... but no support for page 'b0'. And yes, these are real SAS drives. So

Re: [PATCH] sd: error handling during flushing caches

2013-09-24 Thread Alan Stern
On Mon, 16 Sep 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de It makes no sense to flush the cache of a device without medium. Errors during suspend must be handled according to their causes. Errors due to missing media or unplugged devices must be ignored. Errors due to

[PATCH RESEND] sd: disk offlined prematurely from media access timeout

2013-09-24 Thread David Jeffery
There is an error with the medium access timeout feature of the sd driver. The sdkp-medium_access_timed_out value is set to zero in sd_done() in the wrong place. It is set to zero only if a command returns sense data. If an I/O command times out, error handling succeeds, and the I/O commands

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-09-24 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 4:47 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina jkos...@suse.cz wrote: Commit d5dea7d95 (PCI: msi: Disable msi interrupts when we initialize a pci device) makes MSIs be forcibly disabled at boot time. It turns

[PATCH-v2] tcm_fc: Convert to per-cpu command map pre-allocation of ft_cmd

2013-09-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@daterainc.com This patch converts tcm_fc to use transport_init_session_tags() pre-allocation logic for struct ft_cmd descriptors using per-cpu session tag pooling in order to effectively avoid memory allocation + release for each received I/O. It adds

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-09-24 Thread Ric Wheeler
On 08/29/2013 09:06 AM, Hannes Reinecke wrote: Hi James, On 08/07/2013 08:43 AM, Ren Mingxin wrote: Hi, James: On 07/11/2013 04:35 AM, Ewan Milne wrote: Looks good. We have been testing this extensively. Acked-by: Ewan D. Milneemi...@redhat.com Do you think this patchset can be applied?

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread Mike Snitzer
On Tue, Sep 24 2013 at 4:44pm -0400, Martin K. Petersen martin.peter...@oracle.com wrote: The other headache is what happens if a stacking driver gets -EIO or -EREMOTEIO on a WRITE SAME request. That's what Mike was trying to fix with his patch. Maybe it would make sense for us to use -EINVAL

Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

2013-09-24 Thread Hannes Reinecke
On 09/24/2013 10:51 PM, Ric Wheeler wrote: On 08/29/2013 09:06 AM, Hannes Reinecke wrote: Hi James, On 08/07/2013 08:43 AM, Ren Mingxin wrote: Hi, James: On 07/11/2013 04:35 AM, Ewan Milne wrote: Looks good. We have been testing this extensively. Acked-by: Ewan D. Milneemi...@redhat.com