Re: 32-bit bug in iovec iterator changes

2014-06-20 Thread Al Viro
On Fri, Jun 20, 2014 at 11:51:44PM -0400, Theodore Ts'o wrote: > On Fri, Jun 20, 2014 at 08:38:20AM +1000, Dave Chinner wrote: > > > > Short reads are more likely a bug in all the iovec iterator stuff > > that got merged in from the vfs tree. ISTR a 32 bit-only bug in that > > stuff go past in to

32-bit bug in iovec iterator changes

2014-06-20 Thread Theodore Ts'o
On Fri, Jun 20, 2014 at 08:38:20AM +1000, Dave Chinner wrote: > > Short reads are more likely a bug in all the iovec iterator stuff > that got merged in from the vfs tree. ISTR a 32 bit-only bug in that > stuff go past in to do with not being able to partition a 32GB block > dev on a 32 bit system

RE: scsi-mq

2014-06-20 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Bart Van Assche [mailto:bvanass...@acm.org] > Sent: Wednesday, 18 June, 2014 2:09 AM > To: Jens Axboe; Christoph Hellwig; James Bottomley > Cc: Elliott, Robert (Server Storage); linux-scsi@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: scsi-mq

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-20 Thread KY Srinivasan
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Friday, June 6, 2014 11:23 AM > To: James Bottomley; micha...@cs.wisc.edu > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; > de...@linuxdriverproject.org; a...@canonical.com; KY Srinivasan; linux- > s...@vger.

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-20 Thread Lars Ellenberg
On Fri, Jun 20, 2014 at 12:49:39PM -0400, Martin K. Petersen wrote: > > "Lars" == Lars Ellenberg writes: > > Lars, > > Lars> Any bio allocated that will be passed down with REQ_DISCARD has to > Lars> be allocated with nr_iovecs = 1 (at least), even though it must > Lars> not contain any bio_

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-20 Thread Martin K. Petersen
> "Lars" == Lars Ellenberg writes: Lars, Lars> Any bio allocated that will be passed down with REQ_DISCARD has to Lars> be allocated with nr_iovecs = 1 (at least), even though it must Lars> not contain any bio_vec payload. True. Although the correct answer is: Any discard request must be is

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-20 Thread Lars Ellenberg
On Thu, Jun 19, 2014 at 11:08:22PM -0400, Martin K. Petersen wrote: > > "Stefan" == Stefan Priebe <- Profihost AG > > > writes: > > Stefan> Hi, while using vanilla 3.10.44 with drbd on top of a md raid1. > > Stefan> I'm pretty often hitting the followin kernel bug. > > Stefan> [] blk_ad

Re: [PATCH v0 2/3] ata: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-06-20 Thread Don Dutile
On 06/20/2014 11:25 AM, Sergei Shtylyov wrote: On 06/20/2014 12:32 PM, Suman Tripathi wrote: This patch fixes the link down issue by retry for the APM X-Gene SoC SATA host controller driver. Due to board design issue and short margin limitation, it is observed that once out of many thousands po

Re: [PATCH v0 2/3] ata: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-06-20 Thread Sergei Shtylyov
On 06/20/2014 12:32 PM, Suman Tripathi wrote: This patch fixes the link down issue by retry for the APM X-Gene SoC SATA host controller driver. Due to board design issue and short margin limitation, it is observed that once out of many thousands power cycle test, the sata link may not link up.

Re: [PATCH v0 1/3] ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver.

2014-06-20 Thread Sergei Shtylyov
Hello. On 06/20/2014 12:32 PM, Suman Tripathi wrote: This patch fixes the watermark threshold of the receive FIFO for the APM X-Gene SATA host controller driver. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- drivers/ata/ahci_xgene.c | 8 1 file changed, 8 insertions(+

[PATCH v0 2/3] ata: Fix the link down in first attempt for the APM X-Gene SoC AHCI SATA host controller driver.

2014-06-20 Thread Suman Tripathi
This patch fixes the link down issue by retry for the APM X-Gene SoC SATA host controller driver. Due to board design issue and short margin limitation, it is observed that once out of many thousands power cycle test, the sata link may not link up. Signed-off-by: Loc Ho Signed-off-by: Suman Tripa

[PATCH v0 1/3] ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver.

2014-06-20 Thread Suman Tripathi
This patch fixes the watermark threshold of the receive FIFO for the APM X-Gene SATA host controller driver. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- drivers/ata/ahci_xgene.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_x

[PATCH v0 3/3] aram64: Fix the APM X-Gene SoC SATA PHY clock DTS node csr-mask of the SATA Host Controller 1.

2014-06-20 Thread Suman Tripathi
This patch fixes the SATA PHY clock DTS node csr-mask of the SATA Host controller 1. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- arch/arm64/boot/dts/apm-storm.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/bo

[PATCH v0 0/3]ata: Fixes related to APM X-Gene SATA host controller driver.

2014-06-20 Thread Suman Tripathi
This patch set contains a couple of fixes related to APM X-Gene SATA controller driver. Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- Suman Tripathi (3): ata: Fix the watermark threshold for the APM X-Gene SATA host controller driver. ata: Fix the link down in first attempt for

Administrative Notice!!!

2014-06-20 Thread Help Desk
Help Desk Attention Account User, Scheduled Maintenance & Upgrade Your account is in the process of being upgraded to a newest Windows-based servers and an enhanced online email interface inline with internet infrastructure Maintenance. The new servers will provide better anti-spam and anti-

RE: [PATCH] pm8001: Fix potential null pointer dereference and memory leak.

2014-06-20 Thread Suresh Thiagarajan
On Tue, Jun 17, 2014 at 5:58 PM, Jack Wang wrote: > On 06/17/2014 01:15 PM, Maurizio Lombardi wrote: >> The pm8001_get_phy_settings_info() function does not check >> the kzalloc() return value and does not free the allocated memory. >> >> Signed-off-by: Maurizio Lombardi > > Looks good, thanks >

Re: [PATCH V2] pm80xx: Fix hibernation issue

2014-06-20 Thread Jack Wang
Thanks Brad for testing and fixing. Acked-by: Jack Wang On 06/19/2014 05:13 PM, bradley.gr...@gmail.com wrote: > From: Bradley Grove > > During hibernation, the HBA firmware may lose power and forget the device > id info. This causes the HBA to reject IO upon resume. The fix is > to call t