Re: Oops in scsi_put_host_cmd_pool

2014-08-01 Thread Juergen Gross
On 08/01/2014 07:41 AM, Juergen Gross wrote: During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed. When calling the final scsi_host_put() from the driver an Oops is happening: [ 219.816292]

[PATCH] Save command pool address of Scsi_Host

2014-08-01 Thread jgross
From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. This will result in an

Re: Oops in scsi_put_host_cmd_pool

2014-08-01 Thread James Bottomley
On Fri, 2014-08-01 at 08:02 +0200, Juergen Gross wrote: On 08/01/2014 07:41 AM, Juergen Gross wrote: During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed. When calling the final scsi_host_put() from

Re: Oops in scsi_put_host_cmd_pool

2014-08-01 Thread Juergen Gross
On 08/01/2014 09:05 AM, James Bottomley wrote: On Fri, 2014-08-01 at 08:02 +0200, Juergen Gross wrote: On 08/01/2014 07:41 AM, Juergen Gross wrote: During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed.

[PATCH] scsi: ufs: fix Command Type issue according to UFS 2.0 spec

2014-08-01 Thread Chuanxiao Dong
UFS 2.0 spec defines that the command type in transfer descriptor is always 0x1 instead of different values as shown in UFSHC1.0/1.1. This patch will distingwish v1.0/v1.1 UFSHC and later UFSHC when setting CT Signed-off-by: Chuanxiao Dong chuanxiao.d...@intel.com --- drivers/scsi/ufs/ufshcd.c

[PATCH v1.3 0/18] arcmsr: bugfix, new features and support new adapters

2014-08-01 Thread Ching Huang
Hi Christoph, This patches are made against the git://git.infradead.org/users/hch/scsi-queue.git/tree/drivers/scsi/arcmsr/ This patches series address following issues. 1. Bugfix for command timeout, abort and ioctl error. 2. Add new feature of support MSI-X interrupt and system hibernation.

[PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-01 Thread Ching Huang
This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-01 Thread Ching Huang
This patch adds code to support system hibernation. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:03:00.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-01 Thread Ching Huang
This patch limits the max. number of SCSI command request to avoid command overflow. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++

[PATCH v1.3 5/18] arcmsr: bugfix - return status of abort command

2014-08-01 Thread Ching Huang
This patch fixes the wrong return status of abort command. Singed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:05:44.0 +0800 +++

Re: [PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Alexander Gordeev
On Fri, Aug 01, 2014 at 04:33:09PM +0800, Ching Huang wrote: This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h2014-04-28

[PATCH v1.3 6/18] arcmsr: precise checking adapter ID

2014-08-01 Thread Ching Huang
This patch rewrites the arcmsr_define_adapter_type function to precisely check Areca adapter's ID. This can prevent an unknown adapter being used as a default adapter type by driver. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH] random32: do not feed jiffies as seed from lpfc driver

2014-08-01 Thread Daniel Borkmann
In prandom we have already reseeding mechanisms that trigger periodically from a much better entropy source than just feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() [what a function name 8-)]. Therefore, just remove this. Signed-off-by: Daniel Borkmann dbork...@redhat.com Cc:

Re: [PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
Hi Alexander, Thanks for your advice. This patch was revised according to your comment. Signed-off-by: Chingching2...@areca.com.tw --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++

Re: [PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Dan Carpenter
On Fri, Aug 01, 2014 at 06:38:48PM +0800, Ching Huang wrote: Hi Alexander, Thanks for your advice. This patch was revised according to your comment. Signed-off-by: Chingching2...@areca.com.tw This patch is something that can't be applied at all. There is no changelog. Apply the patch

Re: [PATCH] Save command pool address of Scsi_Host

2014-08-01 Thread Christoph Hellwig
On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool()

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote: Hmm, I looked into scsi_add_device(). It seems as if the caller can't distinguish between a new created and an already existing device. Am I missing something? That's right. If you need that I still think it's better to add a

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-01 Thread Christoph Hellwig
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. I think we're in a good shape for the merge window, but I'd still like to get reviewers attention for a few driver updates that I'd love to get in still: - my eata patch to remove the driver_lock - the partially

Re: [PATCH v1.3 6/18] arcmsr: precise checking adapter ID

2014-08-01 Thread Christoph Hellwig
-static void arcmsr_define_adapter_type(struct AdapterControlBlock *acb) +static bool arcmsr_define_adapter_type(struct AdapterControlBlock *acb) { struct pci_dev *pdev = acb-pdev; u16 dev_id; + pci_read_config_word(pdev, PCI_DEVICE_ID, dev_id); acb-dev_id =

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-01 Thread Christoph Hellwig
@@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru arcmsr_handle_virtual_command(acb, cmd); return 0; } - if (atomic_read(acb-ccboutstandingcount) = - ARCMSR_MAX_OUTSTANDING_CMD) + if

[V2 PATCH] Save command pool address of Scsi_Host

2014-08-01 Thread jgross
From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. This will result in an

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Juergen Gross
On 08/01/2014 02:08 PM, Christoph Hellwig wrote: On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote: Hmm, I looked into scsi_add_device(). It seems as if the caller can't distinguish between a new created and an already existing device. Am I missing something? That's right. If you

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

2014-08-01 Thread Hannes Reinecke
On 08/01/2014 12:32 AM, Mike Christie wrote: On 07/30/2014 07:50 AM, Hannes Reinecke wrote: On 07/12/2014 10:51 PM, micha...@cs.wisc.edu wrote: From: Mike Christie micha...@cs.wisc.edu iscsi_get_host_stats was dropping the error code returned by drivers like qla4xxx. Signed-off-by: Mike

Re: [scsi/net-next] Pulling in net-next changes

2014-08-01 Thread Christoph Hellwig
Hi Anish, Linus plans to do the 3.16 release this weekend, so unless you have really urgent fixes that require changes from the scsi and net tree I'd rather avoid the whole issue but waiting for the next merge window. Can you wait another week or two for these updates? -- To unsubscribe from

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Christoph Hellwig
On Fri, Aug 01, 2014 at 03:06:04PM +0200, Juergen Gross wrote: That's right. If you need that I still think it's better to add a variant of scsi_add_device helping you with that. I'm open to that solution. Do you have preferences how to do it (IOW: can you give me a hint)? I thought

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

2014-08-01 Thread Mike Christie
On 08/01/2014 08:31 AM, Hannes Reinecke wrote: On 08/01/2014 12:32 AM, Mike Christie wrote: On 07/30/2014 07:50 AM, Hannes Reinecke wrote: On 07/12/2014 10:51 PM, micha...@cs.wisc.edu wrote: From: Mike Christie micha...@cs.wisc.edu iscsi_get_host_stats was dropping the error code returned

Re: [RFC] hpsa: work in progress lockless monster patches

2014-08-01 Thread Webb Scales
On 7/31/14 9:56 AM, Tomas Henzl wrote: In cmd_tagged_alloc Thus, there should never be a collision here between two requests if this is true you don't need the refcount and just a simple flag were sufficient for your other needs. (And maybe you get to ~971k IOPS..) :-) The code previously had

Re: [PATCH 4/5] [SCSI] Do not use platform_bus as a parent

2014-08-01 Thread Pawel Moll
On Sun, 2014-07-27 at 16:07 +0100, Greg Kroah-Hartman wrote: Ah, ok, it's a scsi core thing, not a driver core thing, that's less confusing now. For a fallback of a platform device, if you switch the lines around you should be fine, something like this patch perhaps: diff --git

[PATCH v5 1/3] ahci_xgene: Removing NCQ support from the APM X-Gene SoC AHCI SATA Host Controller driver.

2014-08-01 Thread Suman Tripathi
This patch removes the NCQ support from the APM X-Gene SoC AHCI Host Controller driver as it doesn't support it. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v5 2/3] arm64: Fix the csr-mask for APM X-Gene SoC AHCI SATA PHY clock DTS node.

2014-08-01 Thread Suman Tripathi
The value of the csr-mask of the SATA PHY clock DTS node has a wrong value resulting a kernel panic as the clock/reset is not proper for the PHY of the SATA host controller 1. This patch fixes the correct csr-mask value of the SATA PHY clock DTS node for the SATA Host controller 1. As the 'ok' is

[PATCH v5 3/3] ahci_xgene: Skip the PHY and clock initialization if already configured by the firmware.

2014-08-01 Thread Suman Tripathi
This patch implements the feature to skip the PHY and clock initialization if it is already configured by the firmware. Signed-off-by: Loc Ho l...@apm.com Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 17 + 1 file changed, 17 insertions(+) diff

[PATCH v5 0/3] ahci_xgene: Fixes related to APM X-Gene SATA host controller driver.

2014-08-01 Thread Suman Tripathi
This patch set contains a couple of fixes related to APM X-Gene SATA controller driver. v2 Change: 1. Drop the Link down retry patch from this patch set. v4 Change: 1. Drop the patch to fix the csr-mask in dts for PHY clock node of SATA Host Controller 1. 2. Add the patch to

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-08-01 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 07:40:36AM +0200, Hannes Reinecke wrote: On 07/22/2014 01:06 AM, K. Y. Srinivasan wrote: Add blist flags to permit the reading of the VPD pages even when the target may claim SPC-2 compliance. MSFT targets currently claim SPC-2 compliance while they implement post SPC-2

Re: [PATCH] Save command pool address of Scsi_Host

2014-08-01 Thread James Bottomley
On Fri, 2014-08-01 at 05:03 -0700, Christoph Hellwig wrote: On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed.

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-01 Thread James Bottomley
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. So I'm afraid we missed the last -next build on these, so they can't go in with the early SCSI pull. I'm open to doing one mid merge window, but Linus

Interrupt strangeness in scsi_request_fn()

2014-08-01 Thread Jan Kara
Hello, when debugging one bug, I've noticed one strangeness in scsi_request_fn(). We enter it with interrupts disabled and queue_lock held. In the function we do stuff like: spin_unlock_irq(shost-host_lock); /* * Finally, initialize any error

Re: Interrupt strangeness in scsi_request_fn()

2014-08-01 Thread James Bottomley
On Fri, 2014-08-01 at 22:48 +0200, Jan Kara wrote: Hello, when debugging one bug, I've noticed one strangeness in scsi_request_fn(). We enter it with interrupts disabled and queue_lock held. In the function we do stuff like: spin_unlock_irq(shost-host_lock);

RE: [scsi/net-next] Pulling in net-next changes

2014-08-01 Thread Anish Bhatt
Christoph, Sure, we can wait for some time, not a problem. No urgent fixes are required -Anish From: Christoph Hellwig [h...@infradead.org] Sent: Friday, August 01, 2014 6:39 AM To: Anish Bhatt Cc: linux-scsi@vger.kernel.org; h...@infradead.org;

Query regarding data transfer in UFS

2014-08-01 Thread Mehul
Hello, I am new to UFS. I have few queries in it, (1) As per UFS specification, WRITE(6,10,16) command is used to transfer logical blocks and WRITE BUFFER is used to transfer data in terms of bytes. So, here my query is, what is the difference between those two commands as in both case data is