Re: [PATCH v3 1/5] target: ensure se_cmd-t_prot_sg is allocated when required

2015-04-26 Thread Sagi Grimberg
On 4/25/2015 5:33 PM, Akinobu Mita wrote: Even if the device backend is initialized with protection info is enabled, some requests don't have the protection info attached for WRITE SAME command issued by block device helpers, WRITE command with WRPROTECT=0 by SG_IO ioctl, etc. So when TCM

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread Ondrej Zary
On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: Ancient, and pretty much obsolete by now. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/advansys.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread Christoph Hellwig
On Sun, Apr 26, 2015 at 04:57:01PM +0200, Ondrej Zary wrote: This patch breaks my setup: modprobe advansys hangs. It works when all other patches are applied except this one. Oh damn, looks like the code does have issues in this case. So let's just drop this change for now. Jusr curious: do

Re: [PATCH v3 3/5] target: handle odd SG mapping for data transfer memory

2015-04-26 Thread Sagi Grimberg
On 4/25/2015 5:33 PM, Akinobu Mita wrote: sbc_dif_generate() and sbc_dif_verify() currently assume that each SG element for data transfer memory doesn't straddle the block size boundary. However, when using SG_IO ioctl, we can choose the data transfer memory which doesn't satisfy that alignment

Re: [PATCH v3 4/5] target: Fix sbc_dif_generate() and sbc_dif_verify() for WRITE SAME

2015-04-26 Thread Sagi Grimberg
On 4/25/2015 5:33 PM, Akinobu Mita wrote: For WRITE SAME, data transfer memory only contains a single block but protection information is required for all blocks that are written by the command. This makes sbc_dif_generate() and sbc_dif_verify() work for WRITE_SAME. This feels a bit like an

Re: [PATCH v3 5/5] target/file: enable WRITE SAME when protection info is enabled

2015-04-26 Thread Sagi Grimberg
On 4/25/2015 5:33 PM, Akinobu Mita wrote: Now we can generate correct PI for WRITE SAME command, so it is unnecessary to disallow WRITE SAME when protection info is enabled. Signed-off-by: Akinobu Mita akinobu.m...@gmail.com Cc: Nicholas Bellinger n...@linux-iscsi.org Cc: Sagi Grimberg

Re: [PATCH] lpfc: fix model description

2015-04-26 Thread Sebastian Herbszt
Bart Van Assche wrote: On 04/22/15 23:16, Sebastian Herbszt wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c ---

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread Ondrej Zary
On Sunday 26 April 2015 18:55:41 Christoph Hellwig wrote: On Sun, Apr 26, 2015 at 04:57:01PM +0200, Ondrej Zary wrote: This patch breaks my setup: modprobe advansys hangs. It works when all other patches are applied except this one. Oh damn, looks like the code does have issues in this

Re: [PATCH 19/23] advansys: Remove cmd_per_lun setting

2015-04-26 Thread James Bottomley
On Sun, 2015-04-26 at 16:57 +0200, Ondrej Zary wrote: On Friday 24 April 2015 13:18:38 Hannes Reinecke wrote: Ancient, and pretty much obsolete by now. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/advansys.c | 18 -- 1 file changed, 18 deletions(-)

[PATCH RFC 1/2] cxlflash: Base support for IBM CXL Flash Adapter

2015-04-26 Thread Matthew R. Ochs
SCSI device driver to support filesystem access on the IBM CXL Flash adapter. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- Documentation/powerpc/cxlflash.txt | 275 + drivers/scsi/Kconfig |1 +

[PATCH RFC 0/2] IBM CXL Flash Adapter

2015-04-26 Thread Matthew R. Ochs
This patch set adds support for the IBM CXL flash (cxlflash) adapter. The device is presented to the system as a SCSI adapter and may be accessed and used via the normal filesystem paths. Also included is support for a special mode that allows direct access from userspace. The IBM Power processor

[PATCH RFC 2/2] cxlflash: Support for superpipe I/O API

2015-04-26 Thread Matthew R. Ochs
Allow userspace applications to obtain CXL resources and exploit the superpipe functionality of the IBM CXL Flash adapter. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- drivers/scsi/cxlflash/Makefile |2 +-