Re: [PATCH 05/11] hpsa: add sysfs entry path_info to show box and bay information

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: From: Joe Handzik joseph.t.hand...@hp.com host no, bus, target, lun, scsi_device_type for hba mode add: box and bay information report if the path is active/inactive Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel

RE: [PATCH V4 10/10] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-22 Thread Rajinikanth Pandurangan
Ok. will follow-up with new patch. We probably lower it to 4 instead of 8 :). Thanks, -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Wednesday, July 22, 2015 8:10 AM To: Rajinikanth Pandurangan; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc:

Re: [PATCH 01/11] hpsa: Correct double unlock of mutex

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: Reported-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas ---

Re: [PATCH 10/11] hpsa: fix issues with multilun devices

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:13, Don Brace wrote: From: shane.seymour shane.seym...@hp.com A regression was introduced into the hpsa driver a while back so non-zero LUNs of multi-LUN devices may no longer be presented via a SAS based Smart Array. I have not done a bisection to discover the change that

Re: [PATCH 09/11] hpsa: add in new offline mode

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:13, Don Brace wrote: From: Scott Benesh scott.ben...@pmcs.com prevent adding volumes that are not available. Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Reviewed-by: Justin Lindley justin.lind...@pmcs.com Signed-off-by:

Re: [PATCH] lpfc: Use instead of for boolean expression

2015-07-22 Thread James Smart
Reviewed-by: James Smart james.sm...@avagotech.com Thanks -- james On 7/22/2015 4:53 AM, Sebastian Herbszt wrote: Use logical instead of bitwise AND. Signed-off-by: Sebastian Herbszt herb...@gmx.de --- diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c ---

Re: [PATCH 07/11] hpsa: add in new controllers

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10

Re: [PATCH 06/11] hpsa: cleanup update scsi devices

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: showing that tables have been updated unnecessarily. Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas ---

Re: [PATCH 02/11] hpsa: correct decode sense data

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: Reported-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas ---

Re: [PATCH 03/11] hpsa: correct static checker warnings on driver init cleanup

2015-07-22 Thread Tomas Henzl
On 18.7.2015 18:12, Don Brace wrote: Reported-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Kevin Barnett kevin.barn...@pmcs.com Reviewed-by: Scott Teel scott.t...@pmcs.com Signed-off-by: Don Brace don.br...@pmcs.com Reviewed-by: Tomas Henzl the...@redhat.com Tomas ---

[PATCH V5 06/11] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Reset irq affinity hints before releasing IRQ Removed duplicate code of IRQ acquire/release Changes from V2: None Reviewed by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com, Johannes Thumshirn

[PATCH V5 04/11] [SCSI] aacraid: Enable 64-bit write to controller register

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: If writeq() not supported, then do atomic two 32bit write Changes from V2: None Reviewed by: Tomas Henzl the...@redhat.com, Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com, Johannes Thumshirn

[PATCH V5 09/11] [SCSI] aacraid: Update driver version

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Signed-off-by: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 2 +- drivers/scsi/aacraid/linit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH V5 05/11] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: If 'IsFastPath' bit is set, then response path assumes no error and skips error check. Changes from V2: None Reviewed By: Tomas Henzl the...@redhat.com, Mahesh Rajashekhara

[PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: As pci_enable_msix() deprecated, replaced with pci_enable_msix_range() V4 Reviewed/commented by: Tomas Henzl the...@redhat.com Changes from V4: Changed to 1 as minimum msix range in

[PATCH V5 07/11] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: Driver blocks ioctls once it received shutdown/suspend request during suspend/hybernation. This patch unblocks ioctls on resume path. Changes from V2: None Reviewed by: Mahesh Rajashekhara

[Bug 101011] Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 taz-...@latribu.com changed: What|Removed |Added CC||taz-...@latribu.com --- Comment #5

[PATCH V5 03/11] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: This change always sets MSI interrupt mode for series-6 controller. Note: For series 6 family, MSIx is not supported. Changes from V2: Only Subject description change. Reviewed by: Tomas Henzl

[PATCH V5 02/11] [SCSI] aacraid: Add Power Management support

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: * .suspend() and .resume() routines implemented in the driver * aac_release_resources() initiates firmware shutdown * aac_acquire_resources re-initializes the host interface Changes from V2:

[PATCH V5 00/11] [SCSI] aacraid: Patchset for aacraid driver version 41010

2015-07-22 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V5: Splited patch 10 from V4 into 2 Added one more patch to request minimum 2 MSIx. V4: Updated code with

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-22 Thread Dan Williams
On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote: Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas

[PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-22 Thread Spencer Baugh
From: Roland Dreier rol...@purestorage.com It's not necessarily a fatal error if a command with a data-out phase has a data length that differs from the transport data length (e.g. PERSISTENT RESERVE OUT might have a parameter list length in the CDB that's smaller than the FC_DL field), so allow

[PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Spencer Baugh
From: Roland Dreier rol...@purestorage.com In a performance profile, taking a mutex in iscsit_increment_maxcmdsn() shows up very high. However taking a mutex around sess-max_cmd_sn += 1 seems pretty silly: we're not serializing against other contexts in any useful way. I did a quick audit and

[PATCH] qla2xxx: remove unused rval

2015-07-22 Thread Spencer Baugh
From: Joern Engel jo...@logfs.org We don't touch the return value of qla2x00_loop_resync in qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning. Signed-off-by: Joern Engel jo...@logfs.org Signed-off-by: Spencer Baugh sba...@catern.com --- drivers/scsi/qla2xxx/qla_os.c | 3

[PATCH] target: improve unsupported opcode message

2015-07-22 Thread Spencer Baugh
From: Joern Engel jo...@purestorage.com Make the warning about unsupported SCSI opcode more useful: - Add in the initiator name so we know who's sending it. - Print the warning even for opcodes that spc_parse_cdb() knows about but that we don't handle. Signed-off-by: Joern Engel

RE: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Spencer Baugh Sent: Wednesday, July 22, 2015 5:08 PM Subject: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment ... diff --git