Re: [RFC] scsi: generate uevent for SCSI sense code

2017-05-12 Thread Song Liu
> On May 3, 2017, at 5:50 PM, Song Liu wrote: > > This patch adds capability for SCSI layer to generate uevent for SCSI > sense code. The feature is gated by CONFIG_SCSI_SENSE_UEVENT. > > We can configure which sense keys generate uevent for each device > through sysfs

Re: [PATCH v2 2/4] scsi_dh_alua: Do not retry for unmapped device

2017-05-12 Thread Bart Van Assche
On Fri, 2017-05-12 at 15:15 +0200, Martin Wilck wrote: > From: Hannes Reinecke > > If a device becomes unmapped on the target we should be returning > SCSI_DH_DEV_OFFLINED. Reviewed-by: Bart Van Assche

Re: [PATCH v2 1/4] scsi_dh_alua: Do not modify the interval value for retries

2017-05-12 Thread Bart Van Assche
On Fri, 2017-05-12 at 15:15 +0200, Martin Wilck wrote: > From: Hannes Reinecke > > We shouldn't set the interval value to 0 in alua_rtpg_work(), as the struct > is accessed from different devices and hence we might end up scheduling > too early. > > With this change, pg->interval

Re: [PATCH v2 3/4] scsi_dh_alua: do not call BUG_ON when updating port group

2017-05-12 Thread Bart Van Assche
On Fri, 2017-05-12 at 15:15 +0200, Martin Wilck wrote: > alua_rtpg() can race with alua_bus_detach(). The assertion that > alua_dh_data *h->sdev must be non-NULL is not guaranteed because > alua_bus_detach sets this field to NULL before removing the entry > from the port group's dh_list. > > This

Re: [PATCH v2 4/4] scsi_dh_alua: take sdev reference in alua_bus_attach

2017-05-12 Thread Bart Van Assche
On Fri, 2017-05-12 at 15:15 +0200, Martin Wilck wrote: > Modification of the access_state field in struct scsi_device > in alua_rtpg() may race with alua_bus_detach(). Avoid > the scsi_device struct to be freed while it's being processed > in the alua code by taking a reference. Hello Martin,

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-12 Thread Chad Dupuis
On Tue, 9 May 2017, 11:18am, James Bottomley wrote: > On Tue, 2017-05-09 at 10:17 -0400, Chad Dupuis wrote: > > On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > > > > > > > Sebastian, > > > > > > > Martin, do you see any chance to get this merged? Chad replied to > > the > > > >

[PATCH 34/36] scsi: fix some kernel-doc markups

2017-05-12 Thread Mauro Carvalho Chehab
Sphinx is very pedantic with regards to ident/spacing. Fix some kernel-doc markups in order to solve those errors/warnings: ./drivers/scsi/scsicam.c:121: WARNING: Inline emphasis start-string without end-string. ./drivers/scsi/scsicam.c:121: WARNING: Inline emphasis start-string without

[PATCH v2 3/4] scsi_dh_alua: do not call BUG_ON when updating port group

2017-05-12 Thread Martin Wilck
alua_rtpg() can race with alua_bus_detach(). The assertion that alua_dh_data *h->sdev must be non-NULL is not guaranteed because alua_bus_detach sets this field to NULL before removing the entry from the port group's dh_list. This happens when a device is about to be removed, so don't BUG out but

[PATCH v2 4/4] scsi_dh_alua: take sdev reference in alua_bus_attach

2017-05-12 Thread Martin Wilck
Modification of the access_state field in struct scsi_device in alua_rtpg() may race with alua_bus_detach(). Avoid the scsi_device struct to be freed while it's being processed in the alua code by taking a reference. Signed-off-by: Martin Wilck ---

[PATCH v2 1/4] scsi_dh_alua: Do not modify the interval value for retries

2017-05-12 Thread Martin Wilck
From: Hannes Reinecke We shouldn't set the interval value to 0 in alua_rtpg_work(), as the struct is accessed from different devices and hence we might end up scheduling too early. With this change, pg->interval is now effectively constant, thus we might as well replace it with a

[PATCH v2 0/4] failover fixes for scsi_dh_alua

2017-05-12 Thread Martin Wilck
Here are 4 fixes we came up with at SUSE to fix problems we encountered in multipath failover tests. Feedback welcome. Best regards, Martin Changes wrt v1: - Use a constant value for the retry interval in patch 1/4 - Style fix in patch 2/4 - Safer coding in patch 3/4 as suggested by Bart -

[PATCH v2 2/4] scsi_dh_alua: Do not retry for unmapped device

2017-05-12 Thread Martin Wilck
From: Hannes Reinecke If a device becomes unmapped on the target we should be returning SCSI_DH_DEV_OFFLINED. Signed-off-by: Hannes Reinecke Reviewed-by: Martin Wilck --- drivers/scsi/device_handler/scsi_dh_alua.c | 9 ++--- 1 file changed, 6

Re: [PATCH] scsi: libfc: fix incorrect variable assingment

2017-05-12 Thread Ewan D. Milne
On Thu, 2017-05-11 at 17:24 -0500, Gustavo A. R. Silva wrote: > Previous assignment was causing the use of the uninitialized variable > _explan_ inside fc_seq_ls_rjt() function, which in this particular > case is being called by fc_seq_els_rsp_send(). > > Addresses-Coverity-ID: 1398125 >

APPLY FOR YOUR URGENT LOAN AT 2%

2017-05-12 Thread Thomas Credit Firm
* Do you need an urgent loan? We offer all kinds of loan * Very fast and urgent transfer to your bank account. * Payment begins (6) months after you get the money in your bank account * Low interest rates 2% * Payment of long-term (1-30 years) duration For more information and loan application

[PATCH] scsi: ufs: Clean up some rpm/spm level SysFS nodes upon remove

2017-05-12 Thread Michal Potomski
From: Michał Potomski When reloading module these two attributes aren't cleaned up properly and they persist causing warnings when trying to load module again. Additionally they are not recreated properly due to that. Signed-off-by: Michał Potomski