[PATCH v2 14/20] lpfc: Fix relative offset error on large nvmet target ios

From: Dick Kennedy if the nvmet_fc transport breaks an io into multiple sequences, the driver will improperly set the relative offset on the 2nd through N sequences. Correct by properly formatting the hw cmd so the relative offset is picked up from the hw cmd.

[PATCH v2 17/20] lpfc: remove console log clutter

Change hw queue binding messages to info - not error. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c

[PATCH v2 12/20] lpfc: Limit amount of work processed in IRQ

From: Dick Kennedy Various oops being seen on being in the ISR too long and cpu lockups, when under heavy load. The amount of work being posted off of completion queues kept the ISR running almost all the time Correct the issue by limiting the amount of work per

[PATCH v2 16/20] lpfc: Fix bad sgl reposting after 2nd adapter reset

From: Dick Kennedy Fix bad sgl reposting after 2nd adapter reset port issue was fixed, the hbacmd reset would take more than 8 minutes to complete. There were conflicting NVME SGL posting/reposting responsibilities between lpfc_online()/lpfc_sli4_hba_setup() and

[PATCH v2 13/20] lpfc: Fix MRQ > 1 context list handling

From: Dick Kennedy Various oops including cpu LOCKUPs were seen. For asynchronously received ius where the driver must assign exchange resources, the resources were on a single get (free) list and put list (finished, waiting to be put on get list). As all cpus are

[PATCH v2 09/20] lpfc: Fix crash in lpfc nvmet when fc port is reset

From: Dick Kennedy in adapter reset tests, an oops was seen with a NULL pointer in lpfc_free_rq_buffer+0x20/0x60 The driver is failing to properly repost the nvmet sgl list when recovering from the reset. Thus the driver eventually trys to walk an errant buffer list.

[PATCH v2 10/20] lpfc: Fix NVME PRLI handling during RSCN

From: Dick Kennedy A race condition was found whereby the initiator would receive the RSCN for a new NVME device before it had a chance to register its FC4 support with the fabric. Thus, when queried by the initiator, it would see that the target supported FC-NVME.

[PATCH v2 15/20] lpfc: Fix nvme target failure after 2nd adapter reset

From: Dick Kennedy Fix nvme target failure after 2nd adapter reset The nonrecovery occurred because the lpfc nvme initiator function did not reestablish its localport creation with the nvme host transport in lpfc_oneline. Because of that, an NVME rport binding could

[PATCH v2 11/20] lpfc: Correct issues with FAWWN and FDISCs

From: Dick Kennedy When using fabric-assigned WWNs, the switch doesn't like copy of the FLOGI payload, which includes valid VVL bits, to be used as the FDISC paylaod. Rather than wait for corrected switch firmware, ensure the VVL bits are marked invalid on FDISCs.

[PATCH v2 18/20] lpfc: Add Buffer to Buffer credit recovery support

Add Buffer to buffer credit recovery support to the driver. This is a negotiated feature with the peer that allows for both sides to detect dropped RRDY's and FC Frames and recover credit. Signed-off-by: Dick Kennedy Signed-off-by: James Smart

[PATCH v2 19/20] scsi: lpfc: fix "integer constant too large" error on 32bit archs

From: Maurizio Lombardi cc1: warnings being treated as errors drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn': drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for 'long' type Signed-off-by: Maurizio Lombardi

[PATCH v2 20/20] lpfc: lpfc version bump 11.4.0.3

From: Dick Kennedy Update driver version to 11.4.0.3 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 07/20] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology

From: Dick Kennedy After link bounce in a NVME Pt2Pt config, the driver managed to map the same nport twice, resulting in multiple device nodes for the same namespace. In Pt2Pt, the driver must send PRLI's for both (scsi) FCP and NVME rather than using fabric aids.

[PATCH v2 05/20] lpfc: convert info messages to standard messages

From: Dick Kennedy Transitioned some informational discovery messages to now always be displayed when log_verbose is set. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_ct.c | 4

[PATCH v2 06/20] lpfc: Correct return error codes to align with nvme_fc transport

From: Dick Kennedy Modify driver return error codes to align with host nvme transport. Driver isn't returning Exxx error codes to properly reflect out of resource or connectivity conditions (-EBUSY), yet there were hard error conditions returning -EBUSY. Fix to

[PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces.

From: Dick Kennedy After lip, the driver sometimes would have two rports for the same device, allowing the namespaces to be duplicated by nvme. In lpfc_plogi_confirm_nport() the driver was not swapping the nrport maintained by the ndlp's undergoing address swapping.

[PATCH v2 02/20] lpfc: Fix loop mode target discovery

From: Dick Kennedy The driver does not discover targets when in loop mode. The NLP type is correctly getting set when a fabric connection is detected but, not for loop. The unknown NLP type means that the driver does not issue a PRLI when in loop topology. Thus target

[PATCH v2 03/20] lpfc: Fix rediscovery on switch blade pull

From: Dick Kennedy When the switch blade is pulled out then plugged back in, the driver does not issue a PLOGI to the target When the switch blade is pulled out, it does not reset the link. The driver ends up issuing a LOGO to the target, and finally sees devloss.

[PATCH v2 01/20] lpfc: Fix plogi collision that causes illegal state transition

From: Dick Kennedy Message "0271 Illegal State Transition: node" seen in logs, all luns are unuseable for that target. A window exists in the rcv_plogi path where if the state is plogi issue but the driver has not issued a plogi, then two reglogins will be sent for

[PATCH v2 04/20] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment

From: Dick Kennedy lpfc oops when it discovers a NVME target but is configured for SCSI only operation. Oops is in lpfc_nvme_register_port+0x33/0x300. The localport is not valid so it should not have been referenced. Added validity check for localport Signed-off-by:

[PATCH v2 00/20] lpfc updates for 11.4.0.3

This patch set provides a number of bug fixes and one additions. The additions are BB credit support. The patches were cut against the Martin's 4.13/scsi-fixes tree. There are no outside dependencies. V2: removed redundant Expresslane patch removed if type 6 support. Will add later.

Re: [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled

On 8/3/2017 3:43 AM, Nikola Pajkovsky wrote: James Smart writes: From: Dick Kennedy Null pointer dereference in lpfc_sli4_fof_intr_handler The driver does not set up cq->assoc_qp for sli4_hba->oas_cq Initialize cq->assoc_qp before accessing

[PATCH v2 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

At queue creation, the transport allocates a local job struct (struct nvmet_fc_fcp_iod) for each possible element of the queue. When a new CMD is received from the wire, a jobs struct is allocated from the queue and then used for the duration of the command. The job struct contains buffer space

[PATCH v2 2/2] lpfc: support nvmet_fc defer_rcv callback

Currently, calls to nvmet_fc_rcv_fcp_req() always copied the FC-NVME cmd iu to a temporary buffer before returning, allowing the driver to immediately repost the buffer to the hardware. To address timing conditions on queue element structures vs async command reception, the nvmet_fc transport

[PATCH v2 0/2] nvmet_fc: work around overalloc of queue elements

At queue creation, the transport allocates a local job struct (struct nvmet_fc_fcp_iod) for each possible element of the queue. When a new CMD is received from the wire, a jobs struct is allocated from the queue and then used for the duration of the command. The job struct contains buffer space

Re: Undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24

On 2017-08-04, at 6:12 PM, Helge Deller wrote: > On the parisc platform I noticed the UBSAN warning below. > Maybe nr_divisor isn't correctly initialized ? > Helge > > [ 18.555455] sym0: <896> rev 0x7 at pci :00:0f.0 irq 68 > [ 18.625415] >

.Your Payment..

Top of the day to you and I once tried to notify you as my earlier letter was returned undelivered and I deemed it necessary and urgent to contact you again via your e-mail address and to notify you finally about your outstanding compensation payment. After the last annual calculation of your

Undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24

On the parisc platform I noticed the UBSAN warning below. Maybe nr_divisor isn't correctly initialized ? Helge [ 18.555455] sym0: <896> rev 0x7 at pci :00:0f.0 irq 68 [ 18.625415] [ 18.726489] UBSAN:

Increased memory usage with scsi-mq

https://bugzilla.redhat.com/show_bug.cgi?id=1478201 We have a libguestfs test which adds 256 virtio-scsi disks to a qemu virtual machine. The VM has 500 MB of RAM, 1 vCPU and no swap. This test has been failing for a little while. It runs out of memory during SCSI enumeration in early boot.

Re: [PATCH] hpsa: disable volume status check for older controller

> You should be able to suppress the "can't get device id' messages with: Yes, these messages are gone and it still works. -- Meelis Roos (mr...@linux.ee)

Re: [PATCH 0/2] generate uevent for SCSI sense code

Hi all, Could you please share your feedback on this version of the change? Thanks in advance, Song >> On 7/21/17, 3:58 PM, "Song Liu" wrote: This change is to follow up our discussion on event log for media management during LSF/MM 2017. Changes

Re: [PATCH] hpsa: disable volume status check for older controller

On 08/04/2017 06:36 PM, Hannes Reinecke wrote: > On 08/04/2017 06:26 PM, Meelis Roos wrote: >>> Older Controller might not support volume status, so disable >>> it if 'hpsa_allow_any' is present. >> >> It makes my DL380G4 boot with hpsa.hpsa_allow_any=1 and it seems to >> work. Howevere, there

Re: [PATCH] scsi_devinfo: fixup string compare

On Fri, 2017-08-04 at 18:28 +0200, Hannes Reinecke wrote: > Well, maybe; however, the current logic fails to match the entry > > {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2}, > > against the 'real' name, which is "HITACHI" "OPEN-V". > And for some reason we have far more customer using

Re: [PATCH] hpsa: disable volume status check for older controller

On 08/04/2017 06:26 PM, Meelis Roos wrote: >> Older Controller might not support volume status, so disable >> it if 'hpsa_allow_any' is present. > > It makes my DL380G4 boot with hpsa.hpsa_allow_any=1 and it seems to > work. Howevere, there are multiole verbose dmesg entries about failing >

Re: [PATCH] scsi_devinfo: fixup string compare

On 08/04/2017 05:32 PM, Bart Van Assche wrote: > On Fri, 2017-08-04 at 11:40 +0200, Hannes Reinecke wrote: >> When checking the model and vendor string we need to use the >> minimum value of either string, otherwise we'll miss out on >> wildcard matches. >> Without this patch certain Hitachi

Re: [PATCH] hpsa: disable volume status check for older controller

> Older Controller might not support volume status, so disable > it if 'hpsa_allow_any' is present. It makes my DL380G4 boot with hpsa.hpsa_allow_any=1 and it seems to work. Howevere, there are multiole verbose dmesg entries about failing things: 0.267224] HP HPSA Driver (v 3.4.18-0) [

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

On Fri, 2017-08-04 at 08:37 +0200, Hannes Reinecke wrote: > ALUA is only relevant for disk-like devices, so we shouldn't > be printing out warning messages for other device types. Reviewed-by: Bart Van Assche

Re: [PATCH 1/2] block: Zoned block device single-threaded submission

On Fri, 2017-08-04 at 16:52 +0900, Damien Le Moal wrote: > From: Hannes Reinecke > > The scsi_request_fn() dispatch function internally unlocks the request > queue before submitting a request to the underlying LLD. This can > potentially lead to write request reordering if the

Re: [PATCH 2/2] sd_zbc: Write unlock zones from sd_uninit_cmnd()

On Fri, 2017-08-04 at 16:52 +0900, Damien Le Moal wrote: > Releasing the write lock of a zone when the write commnand that > acquired the lock completes can cause deadlocks with scsi-mq due to > potential queue reordering if the lock owning request is requeued and > not executed. > > Since

Re: [PATCH] aacraid: Fix out of bounds in aac_get_name_resp

On Fri, 2017-08-04 at 03:51 -0700, Raghava Aditya Renukunta wrote: > diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c > index 707ee2f5954d..a875175d58d1 100644 > --- a/drivers/scsi/aacraid/aachba.c > +++ b/drivers/scsi/aacraid/aachba.c > @@ -549,7 +549,9 @@ static void

Re: [PATCH] scsi_devinfo: fixup string compare

On Fri, 2017-08-04 at 11:40 +0200, Hannes Reinecke wrote: > When checking the model and vendor string we need to use the > minimum value of either string, otherwise we'll miss out on > wildcard matches. > Without this patch certain Hitachi arrays will not be presenting > VPD pages correctly. > >

Re: Gift-

Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Annand Mayrhofer. --- This email has been checked

Re: [RFC 4/9] zfcp: decouple FSF request setup of TMF from scsi_cmnd

Just for the records: There's another bug below. On 07/25/2017 04:14 PM, Steffen Maier wrote: The scsi_device argument of zfcp_fc_fcp_tm() can now be NULL. In zfcp_fsf_fcp_task_mgmt() resolve the still old argument scsi_cmnd into scsi_device very early and only depend on scsi_device and

Koch

Ishmeal Camara, presently working under the central bank of Togo, i have financier offer for both of us 2.5 M USD deal.

[PATCH] scsi_devinfo: fixup string compare

When checking the model and vendor string we need to use the minimum value of either string, otherwise we'll miss out on wildcard matches. Without this patch certain Hitachi arrays will not be presenting VPD pages correctly. Fixes: 5e7ff2c ("SCSI: fix new bug in scsi_dev_info_list string

Re: [PATCH v2 4/5] aic7xxx: regenerate firmware files

On 08/04/2017 01:28 AM, Michał Mirosław wrote: > Regenerate firmware files to make cleaner base for following fix. > This removes some unused definitions and reorders some #defines, but > the code remains the same. > > Signed-off-by: Michał Mirosław > --- >

Re: [PATCH v2 2/5] aic7xxx: fix firmware build deps

On 08/04/2017 01:28 AM, Michał Mirosław wrote: > We need to override Kbuild rules for copying shipped files, otherwise > aic7xxx_reg.h and aic7xxx_reg_print.c will be ovewritten by old versions. > > Fixes: 516b7db593f3a541e2e98867575c3c697f41a247 > Signed-off-by: Michał Mirosław

Re: [PATCH v2 3/5] aic7xxx: remove rules for shipped files

On 08/04/2017 01:28 AM, Michał Mirosław wrote: > There are Kbuild rules for that already. > > Signed-off-by: Michał Mirosław > --- > drivers/scsi/aic7xxx/Makefile | 4 > 1 file changed, 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes

Re: [PATCH v2 1/5] aic7xxx: remove empty function

On 08/04/2017 01:28 AM, Michał Mirosław wrote: > > ahc_platform_dump_card_state() does nothing. Remove it. > > Signed-off-by: Michał Mirosław > --- > drivers/scsi/aic7xxx/aic7xxx_core.c | 1 - > drivers/scsi/aic7xxx/aic7xxx_osm.c | 5 - >

[PATCH] scsi: osst: silence underflow warning in osst_verify_frame()

The code looks like this: i = ntohl(aux->filemark_cnt); if (STp->header_cache != NULL && i < OS_FM_TAB_MAX && (i > STp->filemark_cnt || STp->first_frame_position - 1 != ntohl(STp->header_cache->dat_fm_tab.fm_tab_ent[i]))) { If i is negative then it's less than

Re: [PATCH] scsi-mq: Always unprepare before requeuing a request

On 8/4/17 06:40, Bart Van Assche wrote: > One of the two scsi-mq functions that requeue a request unprepares > a request before requeueing (scsi_io_completion()) but the other > function not (__scsi_queue_insert()). Make sure that a request is > unprepared before requeuing it. > > Fixes: commit

[PATCH 0/2 V2] Zoned block device support fixes

This small series addresses a couple of problems with zoned block devices detected with 4.13-rc. The first patch ensures that a well behaved host managed zoned block device user (an application doing direct disk accesses, f2fs or dm-zoned) will not see unaligned write errors due to reordering of

[PATCH 1/2] block: Zoned block device single-threaded submission

From: Hannes Reinecke The scsi_request_fn() dispatch function internally unlocks the request queue before submitting a request to the underlying LLD. This can potentially lead to write request reordering if the context executing scsi_request_fn() is preempted before the request is

[PATCH 2/2] sd_zbc: Write unlock zones from sd_uninit_cmnd()

Releasing the write lock of a zone when the write commnand that acquired the lock completes can cause deadlocks with scsi-mq due to potential queue reordering if the lock owning request is requeued and not executed. Since sd_uninit_cmnd() is always called when a request is requeued, call

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

[PATCH 1/5] dt-bindings: phy: Add PHY_TYPE_UFS definition

Add definition for UFS phy type. Signed-off-by: Vivek Gautam --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6c901930eb3e..d16e8755f6a9 100644 ---

[PATCH 2/5] phy: Add UFS PHY modes

UFS phy has two modes for each High speed generation. These modes are identified by two rates of operations - Rate A, and Rate B. Add these UFS phy modes to phy framework. Signed-off-by: Vivek Gautam --- include/linux/phy/phy.h | 2 ++ 1 file changed, 2

[PATCH 3/5] phy: qcom-ufs: Add support to set phy mode

Adding support to set desired UFS phy mode that can be set from the host controller. Signed-off-by: Vivek Gautam --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.c | 14 ++

[PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam --- drivers/scsi/ufs/ufs-qcom.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 --

[PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

Refactoring the qcom-ufs phy and host controller code to move further towards the generic phy usage. Right now the qcom-ufs exports a bunch of APIs that are used by the host controller to initialize the phy. With this patch series, we populate the phy_init() which was a no-op earlier. The host

[PATCH] scsi_dh_alua: suppress errors from unsupported devices

ALUA is only relevant for disk-like devices, so we shouldn't be printing out warning messages for other device types. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 ++ drivers/scsi/scsi_dh.c | 5 +++--