Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Kishon Vijay Abraham I
Vivek, On Tuesday 08 August 2017 09:20 PM, Vivek Gautam wrote: > Hi Koshon, > > On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: >>> Refactoring the qcom-ufs phy and host controller code to move >>> further towards the generic

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Damien Le Moal
On 8/9/17 13:15, Bart Van Assche wrote: > On Wed, 2017-08-09 at 13:07 +0900, Damien Le Moal wrote: >> >> On 8/9/17 12:57, Bart Van Assche wrote: >>> On Wed, 2017-08-09 at 11:47 +0900, Damien Le Moal wrote: On 8/9/17 11:19, Damien Le Moal wrote: > On 8/9/17 00:07, Bart Van Assche wrote:

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Bart Van Assche
On Wed, 2017-08-09 at 13:07 +0900, Damien Le Moal wrote: > > On 8/9/17 12:57, Bart Van Assche wrote: > > On Wed, 2017-08-09 at 11:47 +0900, Damien Le Moal wrote: > > > On 8/9/17 11:19, Damien Le Moal wrote: > > > > On 8/9/17 00:07, Bart Van Assche wrote: > > > > > On Tue, 2017-08-08 at 13:17

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Damien Le Moal
On 8/9/17 12:57, Bart Van Assche wrote: > On Wed, 2017-08-09 at 11:47 +0900, Damien Le Moal wrote: >> On 8/9/17 11:19, Damien Le Moal wrote: >>> On 8/9/17 00:07, Bart Van Assche wrote: On Tue, 2017-08-08 at 13:17 +0900, Damien Le Moal wrote: > acquired the lock completes can cause

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Bart Van Assche
On Wed, 2017-08-09 at 11:47 +0900, Damien Le Moal wrote: > On 8/9/17 11:19, Damien Le Moal wrote: > > On 8/9/17 00:07, Bart Van Assche wrote: > > > On Tue, 2017-08-08 at 13:17 +0900, Damien Le Moal wrote: > > > > acquired the lock completes can cause deadlocks with scsi-mq due to > > > > potential

[PATCH V2] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Damien Le Moal
Releasing a zone write lock only when the write commnand that acquired the lock completes can cause deadlocks due to potential command reordering if the lock owning request is requeued and not executed. This problem exists only with the scsi-mq path as, unlike the legacy path, requests are moved

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Damien Le Moal
Bart, On 8/9/17 11:19, Damien Le Moal wrote: > Bart, > > On 8/9/17 00:07, Bart Van Assche wrote: >> On Tue, 2017-08-08 at 13:17 +0900, Damien Le Moal wrote: >>> Releasing the write lock of a zone when the write commnand that >> >>

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Laurence Oberman
On Tue, 2017-08-08 at 20:11 -0400, Laurence Oberman wrote: > > On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: > > > > Hi Guys, > > > >  > > > > Laurence and I see a system lockup issue when running > > concurrent > > > > big buffered write(4M bytes) to IB SRP on v4.13-rc3. > > > >  > > > > 1

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Damien Le Moal
Bart, On 8/9/17 00:07, Bart Van Assche wrote: > On Tue, 2017-08-08 at 13:17 +0900, Damien Le Moal wrote: >> Releasing the write lock of a zone when the write commnand that > > command?

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Laurence Oberman
On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: > Hi Guys, > > Laurence and I see a system lockup issue when running concurrent > big buffered write(4M bytes) to IB SRP on v4.13-rc3. > > 1 how to reproduce > > 1) setup IB_SRR & multi path > > #./start_opensm.sh > #./start_srp.sh 

Re: [v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Bart Van Assche
On Tue, 2017-08-08 at 22:17 +0800, Ming Lei wrote: > Laurence and I see a system lockup issue when running concurrent > big buffered write(4M bytes) to IB SRP on v4.13-rc3. > [ ... ] > #cat hammer_write.sh > #!/bin/bash > while true; do > dd if=/dev/zero

Re: [PATCH v3 01/13] mpt3sas: Update MPI Header

2017-08-08 Thread J Freyensee
Looks like your header has a white space error: Applying: mpt3sas: Update MPI Header .git/rebase-apply/patch:1452: new blank line at EOF. + Also, FYI, this project has a lot of sparse errors that look like existed before your patchset. As your patchset touches a few of the files that have

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
On 08/08/2017 06:11 PM, Bart Van Assche wrote: > On Tue, 2017-08-08 at 12:06 -0400, Alan Stern wrote: >> On Tue, 8 Aug 2017, Hannes Reinecke wrote: >>> On 08/08/2017 05:25 PM, Alan Stern wrote: On Tue, 8 Aug 2017, Hannes Reinecke wrote: > When checking the model and vendor string we

Re: [PATCH v3 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

2017-08-08 Thread Martin K. Petersen
Suganath, > + /* > + ** Below code detects gaps/holes in IO data buffers. > + ** What does holes/gaps mean? > + ** Any SGE except first one in a SGL starts at non NVME page size > + ** aligned address OR Any SGE except last one in a SGL ends at > + ** non NVME page

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Bart Van Assche
On Tue, 2017-08-08 at 12:06 -0400, Alan Stern wrote: > On Tue, 8 Aug 2017, Hannes Reinecke wrote: > > On 08/08/2017 05:25 PM, Alan Stern wrote: > > > On Tue, 8 Aug 2017, Hannes Reinecke wrote: > > > > > > > When checking the model and vendor string we need to use the > > > > minimum value of

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
On 08/08/2017 06:06 PM, Alan Stern wrote: > On Tue, 8 Aug 2017, Hannes Reinecke wrote: > >> On 08/08/2017 05:25 PM, Alan Stern wrote: >>> On Tue, 8 Aug 2017, Hannes Reinecke wrote: >>> When checking the model and vendor string we need to use the minimum value of either string, otherwise

Re: [PATCH 00/22] zfcp fixes and cleanups

2017-08-08 Thread Martin K. Petersen
Benjamin, >> If you are OK with everything going into 4.14, then let me know. In >> that case you don't have to shuffle the patches around. > I think it is OK for us, if this goes into 4.14 as one series. So if > it is OK with you, just apply the complete series for that. OK. Applied to

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Alan Stern
On Tue, 8 Aug 2017, Hannes Reinecke wrote: > On 08/08/2017 05:25 PM, Alan Stern wrote: > > On Tue, 8 Aug 2017, Hannes Reinecke wrote: > > > >> When checking the model and vendor string we need to use the > >> minimum value of either string, otherwise we'll miss out on > >> wildcard matches. > >>

Re: [PATCH] megaraid_sas: move command counter to correct place

2017-08-08 Thread Martin K. Petersen
James, > Martin: this means my fixes branch got rebased; can you rebase your > fixes branch on top of mine before we all get a beating from Stephen > Rothwell because of a mismerge in linux-next due to the tree > differences? Done. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Vivek Gautam
Hi Koshon, On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: Hi, On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: Refactoring the qcom-ufs phy and host controller code to move further towards the generic phy usage. Right now the qcom-ufs exports a bunch of APIs that are used by the

Re: [PATCH] megaraid_sas: move command counter to correct place

2017-08-08 Thread James Bottomley
On Tue, 2017-08-08 at 13:07 +0530, Sumit Saxena wrote: > > > > -Original Message- > > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > > Sent: Monday, August 07, 2017 11:07 PM > > To: Tomas Henzl > > Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com; > >

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
On 08/08/2017 05:25 PM, Alan Stern wrote: > On Tue, 8 Aug 2017, Hannes Reinecke wrote: > >> When checking the model and vendor string we need to use the >> minimum value of either string, otherwise we'll miss out on >> wildcard matches. >> And we should avoid matching anything with zero size as

[GIT PULL] SCSI fixes for 4.13-rc4

2017-08-08 Thread James Bottomley
Two small fixes, one re-fix of a previous fix and five patches sorting out hotplug in the bnx2X class of drivers.  The latter is rather involved, but necessary because these drivers have started dropping lockdep recursion warnings on the hotplug lock because of its conversion to a percpu rwsem.

Re: [PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Alan Stern
On Tue, 8 Aug 2017, Hannes Reinecke wrote: > When checking the model and vendor string we need to use the > minimum value of either string, otherwise we'll miss out on > wildcard matches. > And we should avoid matching anything with zero size as this > match will be incorrect. > Without this

Re: scsi: qla2xxx: use dma_mapping_error to check map errors

2017-08-08 Thread Madhani, Himanshu
> On Aug 8, 2017, at 6:55 AM, Pan Bian wrote: > > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its > return value is checked against NULL, which could result in failures. > >

Re: scsi: hisi_sas: replace kfree with scsi_host_put

2017-08-08 Thread PanBian
On Tue, Aug 08, 2017 at 03:56:22PM +0100, John Garry wrote: > On 08/08/2017 12:37, Pan Bian wrote: > >Return value of scsi_host_alloc() should be released with > >scsi_host_put() rather than kfree(). > > > >Signed-off-by: Pan Bian > > We also have a kfree(shost) in newly

Re: [PATCH] sd_zbc: Write unlock zone from sd_uninit_cmnd()

2017-08-08 Thread Bart Van Assche
On Tue, 2017-08-08 at 13:17 +0900, Damien Le Moal wrote: > Releasing the write lock of a zone when the write commnand that command? > acquired the lock completes can cause deadlocks

Re: scsi: hisi_sas: replace kfree with scsi_host_put

2017-08-08 Thread John Garry
On 08/08/2017 12:37, Pan Bian wrote: Return value of scsi_host_alloc() should be released with scsi_host_put() rather than kfree(). Signed-off-by: Pan Bian We also have a kfree(shost) in newly added pci-based v3 driver which would need replacing for consistency. But,

Re: scsi: mvsas: replace kfree with scsi_host_put

2017-08-08 Thread Jinpu Wang
On Tue, Aug 8, 2017 at 2:02 PM, Pan Bian wrote: > The return value of scsi_host_alloc() should be released by > scsi_host_put(). However, in function mvs_pci_init(), kfree() > is used. This patch replaces kfree() with scsi_host_put() to avoid > possible memory leaks. > >

[PATCH 3/4] scsi_debug: allow to specify inquiry vendor and model

2017-08-08 Thread Hannes Reinecke
For testing purposes we need to be able to pass in the inquiry vendor and model. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_debug.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/scsi_debug.c

[PATCH 2/4] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
When checking the model and vendor string we need to use the minimum value of either string, otherwise we'll miss out on wildcard matches. And we should avoid matching anything with zero size as this match will be incorrect. Without this patch certain Hitachi arrays will not be presenting VPD

[PATCH 4/4] scsi: Export blacklist flags to sysfs

2017-08-08 Thread Hannes Reinecke
Each scsi device is scanned according to the found blacklist flags, but this information is never presented to sysfs. This makes it quite hard to figure out if blacklisting worked as expected. With this patch we're exporting an additional attribute 'blacklist' containing the blacklist flags for

[PATCH 0/4] Fixup blacklist handling

2017-08-08 Thread Hannes Reinecke
Hi all, the SCSI blacklist handling seems to be rather tricky issue; everytime a fix is included it tends to break other devices. This patchset attempt to simplify the devlist handling yet again, but this time implementing the framework for regression testing, too. So with this patchset we can

[PATCH 1/4] scsi: whitespace fixes in scsi_devinfo.c

2017-08-08 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_devinfo.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 28fea83..776c701 100644 ---

Re: [PATCH] scsi_devinfo: fixup string compare

2017-08-08 Thread Hannes Reinecke
On 08/04/2017 06:38 PM, Bart Van Assche wrote: > On Fri, 2017-08-04 at 18:28 +0200, Hannes Reinecke wrote: >> Well, maybe; however, the current logic fails to match the entry >> >> {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2}, >> >> against the 'real' name, which is "HITACHI" "OPEN-V". >> And

[v4.13-rc BUG] system lockup when running big buffered write(4M) to IB SRP via mpath

2017-08-08 Thread Ming Lei
Hi Guys, Laurence and I see a system lockup issue when running concurrent big buffered write(4M bytes) to IB SRP on v4.13-rc3. 1 how to reproduce 1) setup IB_SRR & multi path #./start_opensm.sh #./start_srp.sh # cat start_opensm.sh #!/bin/bash rmmod

RE: [PATCH v2] scsi: megaraid_sas: fix allocate instance->pd_info twice

2017-08-08 Thread Sumit Saxena
>-Original Message- >From: weiping zhang [mailto:zhangweip...@didichuxing.com] >Sent: Tuesday, August 08, 2017 10:46 AM >To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; >shivasharan.srikanteshw...@broadcom.com >Cc: megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org

scsi: qla2xxx: use dma_mapping_error to check map errors

2017-08-08 Thread Pan Bian
The return value of dma_map_single() should be checked by dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its return value is checked against NULL, which could result in failures. Signed-off-by: Pan Bian --- drivers/scsi/qla2xxx/qla_mbx.c | 2 +- 1

Re: scsi: pm8001: fix double free in pm8001_pci_probe

2017-08-08 Thread Jinpu Wang
On Tue, Aug 8, 2017 at 1:40 PM, Pan Bian wrote: > In function pm8001_pci_probe(), on errors that the control flow jumps to > label err_out_ha_free, function pm8001_free() is called. In pm8001_free(), > scsi_host_put() is called to release shost, which keeps the return value >

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Kishon Vijay Abraham I
Hi, On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: > Refactoring the qcom-ufs phy and host controller code to move > further towards the generic phy usage. Right now the qcom-ufs exports > a bunch of APIs that are used by the host controller to initialize > the phy. > With this patch

scsi: mvsas: replace kfree with scsi_host_put

2017-08-08 Thread Pan Bian
The return value of scsi_host_alloc() should be released by scsi_host_put(). However, in function mvs_pci_init(), kfree() is used. This patch replaces kfree() with scsi_host_put() to avoid possible memory leaks. Signed-off-by: Pan Bian --- drivers/scsi/mvsas/mv_init.c | 4

scsi: pm8001: fix double free in pm8001_pci_probe

2017-08-08 Thread Pan Bian
In function pm8001_pci_probe(), on errors that the control flow jumps to label err_out_ha_free, function pm8001_free() is called. In pm8001_free(), scsi_host_put() is called to release shost, which keeps the return value of scsi_host_alloc(). After pm8001_free() returns, kfree() is called to free

scsi: hisi_sas: replace kfree with scsi_host_put

2017-08-08 Thread Pan Bian
Return value of scsi_host_alloc() should be released with scsi_host_put() rather than kfree(). Signed-off-by: Pan Bian --- drivers/scsi/hisi_sas/hisi_sas_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c

aac_convert_sgraw2() masks -ENOMEM

2017-08-08 Thread Nikola Pajkovsky
Hey, today, I have run smatch and it reports, that aac_convert_sgraw2() returns -1 instead of -ENOMEM on kmalloc(). This is easy to fix, but nobody tests what aac_convert_sgraw2() returns in aac_build_sgraw2() Since commit 0b4334473d48 ("[SCSI] aacraid: SCSI dma mapping failure case handling"),

Re: [PATCH 00/22] zfcp fixes and cleanups

2017-08-08 Thread Benjamin Block
On Mon, Aug 07, 2017 at 01:19:11PM -0400, Martin K. Petersen wrote: > > here is a series of (important) fixes and some additional cleanups for > > the zfcp driver. Our fixes are marked for stable accordingly. > > > > Patches 01 - 04 are cleanups and external patches (also cleanups) that we > >

[PATCH v3 02/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

2017-08-08 Thread Suganath Prabu S
1) Added support for probing pcie device and adding NVMe drives to SML and driver's internal list pcie_device_list. 2) Added support for determing NVMe as boot device. 3) Added nvme device support for call back functions scan_finished target_alloc,slave_alloc,target destroy and slave destroy.

[PATCH v3 03/13] mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

2017-08-08 Thread Suganath Prabu S
* Added support for translating the SGLs associated with incoming commands either to IEE SGL or NVMe PRPs for NVMe devices. * The hardware translation of IEEE SGL to NVMe PRPs has limitation and if a command cannot be translated by hardware then it will go to firmware and the firmware needs to

[PATCH v3 01/13] mpt3sas: Update MPI Header

2017-08-08 Thread Suganath Prabu S
Update MPI Files for NVMe support Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpi/mpi2.h | 43 +++- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 564 --

[PATCH v3 04/13] mpt3sas: Added support for nvme encapsulated request message.

2017-08-08 Thread Suganath Prabu S
* Mpt3sas driver uses the NVMe Encapsulated Request message to send an NVMe command to an NVMe device attached to the IOC. * Normal I/O commands like reads and writes are passed to the controller as SCSI commands and the controller has the ability to translate the commands to NVMe equivalent. *

[PATCH v3 07/13] mpt3sas: Handle NVMe PCIe device related events generated from firmware.

2017-08-08 Thread Suganath Prabu S
* The controller firmware sends separate events for NVMe devices and PCIe switches similar to existing SAS events. * NVMe device detection, addition and removal are reported by the firmware through PCIe Topology Change list events. * The PCIe device state change events are sent when the firmware

[PATCH v3 05/13] mpt3sas: API 's to support NVMe drive addition to SML

2017-08-08 Thread Suganath Prabu S
Below Functions are added in various paths to support NVMe drive addition. _scsih_pcie_add_device _scsih_pcie_device_add _scsih_pcie_device_init_add _scsih_check_pcie_access_status _scsih_pcie_check_device mpt3sas_get_pdev_by_handle mpt3sas_config_get_pcie_device_pg0

[PATCH v3 06/13] mpt3sas: API's to remove nvme drive from sml

2017-08-08 Thread Suganath Prabu S
Below API's are included in nvme drive remove path. _scsih_pcie_device_remove_by_handle _scsih_pcie_device_remove_from_sml Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke

[PATCH v3 08/13] mpt3sas: Set NVMe device queue depth as 128

2017-08-08 Thread Suganath Prabu S
Sets nvme device queue depth, name and displays device capabilities Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h |2 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 47

[PATCH v3 09/13] mpt3sas: scan and add nvme device after controller reset

2017-08-08 Thread Suganath Prabu S
After Controller reset, Scan and add nvme device back to the topology. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 194 +- 1 files

[PATCH v3 10/13] mpt3as: Add-Task-management-debug-info-for-NVMe-drives.

2017-08-08 Thread Suganath Prabu S
Added debug information for NVMe/PCIe drives in target rest path. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 83

[PATCH v3 13/13] mpt3sas: Update mpt3sas driver version.

2017-08-08 Thread Suganath Prabu S
Updated mpt3sas driver version to 15.101.00.00 Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.h |4 ++-- 1 files changed, 2

[PATCH v3 11/13] mpt3sas: NVMe drive support for BTDHMAPPING ioctl command and log info

2017-08-08 Thread Suganath Prabu S
* Added debug prints for pcie devices in ioctl debug path. Which will be helpful for debugging. * Added PCIe device support for ioctl BTDHMAPPING ioctl. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Reviewed-by:

[PATCH v3 12/13] mpt3sas: Fix nvme drives checking for tlr.

2017-08-08 Thread Suganath Prabu S
Check for NVMe drives before enabling or checking tlr. Signed-off-by: Chaitra P B Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22

[PATCH v3 00/13] mpt3sas driver NVMe support:

2017-08-08 Thread Suganath Prabu S
Ventura Series controller are Tri-mode. The controller and firmware are capable of supporting NVMe devices and PCIe switches to be connected with the controller. This patch set adds driver level support for NVMe devices and PCIe switches. mpt3sas v3 patset: Posting version v3. This accommodates

[PATCHv2] scsi_dh_alua: suppress errors from unsupported devices

2017-08-08 Thread Hannes Reinecke
ALUA is only relevant for disk-like devices, so we shouldn't be printing out warning messages for other device types. Signed-off-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Reviewed-by: Bart Van Assche ---

[PATCH 1/6] hpsa: consolidate status variables

2017-08-08 Thread Hannes Reinecke
Consolidate several boolean variable into one field. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 1c49741..bd16f38 100644 ---

[PATCH RESEND 0/6] hpsa: support legacy boards

2017-08-08 Thread Hannes Reinecke
(Resend to include linux-scsi) Hi all, this patch adds support for legacy boards, ie for boards previously supported by cciss only. With this patchset the hpsa driver should work with all Smart Array boards if the 'hpsa_allow_any' module option is set, rendering the cciss driver obsolete.

[PATCH 5/6] hpsa: do not print errors for unsupported report luns format

2017-08-08 Thread Hannes Reinecke
Older/Unsupported controllers might not support the 'extended' report luns format, but as they are unsupported we don't need to print out an error here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 21 - 1 file changed, 12 insertions(+), 9

[PATCH 3/6] hpsa: disable volume status check for older controller

2017-08-08 Thread Hannes Reinecke
Older Controller might not support volume status, so assume the volume is online here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 7ca6078..4ebf5d4 100644

[PATCH 2/6] hpsa: add support for legacy boards

2017-08-08 Thread Hannes Reinecke
Add support for legacy boards, ensuring to enable the driver for those boards only when 'hpsa_allow_any' is set. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 54 ++--- drivers/scsi/hpsa.h | 45

[PATCH 4/6] hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page

2017-08-08 Thread Hannes Reinecke
Older controller do not support the LV_DEVICE_ID VPD page, so we shouldn't print out an error message here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 6/6] hpsa: handle unsupported devices more gracefully

2017-08-08 Thread Hannes Reinecke
From: Jeff Mahoney Add a warning message if an unsupported device is found and the hpsa_allow_any parameter is not set. Also make the hpsa_allow_any parameter writeable once the hpsa driver is loaded. Signed-off-by: Jeff Mahoney --- drivers/scsi/hpsa.c | 43

RE: [PATCH] megaraid_sas: move command counter to correct place

2017-08-08 Thread Sumit Saxena
>-Original Message- >From: Martin K. Petersen [mailto:martin.peter...@oracle.com] >Sent: Monday, August 07, 2017 11:07 PM >To: Tomas Henzl >Cc: linux-scsi@vger.kernel.org; sumit.sax...@broadcom.com; >kashyap.de...@broadcom.com >Subject: Re: [PATCH] megaraid_sas: move command counter to

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

2017-08-08 Thread Keith Busch
On Tue, Aug 08, 2017 at 12:33:40PM +0530, Sreekanth Reddy wrote: > On Tue, Aug 8, 2017 at 9:34 AM, Keith Busch wrote: > > > > It looks like they can make existing nvme tooling work with little > > effort if they have the driver implement NVME_IOCTL_ADMIN_COMMAND, and > >

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

2017-08-08 Thread Sreekanth Reddy
On Tue, Aug 8, 2017 at 9:34 AM, Keith Busch wrote: > On Mon, Aug 07, 2017 at 08:45:25AM -0700, James Bottomley wrote: >> On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: >> > >> > We have to attempt this use case and see how it behaves. I have not >> > tried this, so

Re: [PATCH 00/29] constify scsi pci_device_id.

2017-08-08 Thread Johannes Thumshirn
On Mon, Aug 07, 2017 at 01:28:18PM -0400, Martin K . Petersen wrote: > However, having a bazillion identical commit messages is also really > annoying. So for automated changes like this, I'd rather just have a > single patch. Thought so ;-) -- Johannes Thumshirn