Re: [PATCH 27/30] blk_end_request: changing scsi (take 4)

2007-12-12 Thread James Bottomley
On Tue, 2007-12-11 at 17:52 -0500, Kiyoshi Ueda wrote: This patch converts scsi mid-layer to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, scsi_end_request(), is changed. This looks fine, as far as it

Re: broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)

2007-12-12 Thread James Bottomley
On Wed, 2007-12-12 at 11:16 -0800, Andrew Morton wrote: On Wed, 12 Dec 2007 14:43:42 +0100 Anders Henke [EMAIL PROTECTED] wrote: Am 12.12.2007 schrieb Miquel van Smoorenburg: On Wed, 2007-12-12 at 03:38 -0800, Andrew Morton wrote: On Wed, 12 Dec 2007 11:58:41 +0100 Anders Henke [EMAIL

Re: [PATCH] dpt_i2o: don't set DMA_64BIT_MASK [was: Re: [stable] broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)]

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 11:11 +0100, Miquel van Smoorenburg wrote: According to Greg KH: So, what should be added to 2.6.23-stable then? And, can I get a real changelog entry for it? This is suitable for both 2.6.23.x and 2.6.24-rc5 : linux-2.6-dpt_i2o-no-dma64.patch Actually, this

Re: [PATCH] scsi device recovery

2007-12-13 Thread James Bottomley
2007 16:59:36 James Bottomley wrote: On Wed, 2007-12-12 at 15:36 +0100, Bernd Schubert wrote: On Wednesday 12 December 2007 14:39:27 Matthew Wilcox wrote: On Wed, Dec 12, 2007 at 01:54:14PM +0100, Bernd Schubert wrote: below is a patch introducing device recovery, trying to prevent i/o

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 11:42 -0700, Matthew Wilcox wrote: On Thu, Dec 13, 2007 at 01:37:59PM -0500, Mark Lord wrote: The problem is, the block layer *never* sends an SG entry larger than 8192 bytes, and even that size is exceptionally rare. Nearly all I/O segments are 4096 bytes, so

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-13 Thread James Bottomley
On Thu, 2007-12-13 at 14:02 -0800, Andrew Morton wrote: On Thu, 13 Dec 2007 21:09:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: OK, it's a vm issue, cc linux-mm and probable culprit. I have tens of thousand backward pages after a boot - IOW, bvec-bv_page is the page before

Re: [patch 22/30] sg: nopage

2007-12-15 Thread James Bottomley
On Thu, 2007-12-13 at 16:14 -0800, [EMAIL PROTECTED] wrote: From: Nick Piggin [EMAIL PROTECTED] Convert SG from nopage to fault. Doug, could you look this over and test it, please? Thanks, James - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-12-15 Thread James Bottomley
On Tue, 2007-09-18 at 17:04 +0200, Boaz Harrosh wrote: On Wed, Sep 12 2007 at 10:42 +0300, Russell King [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: - if (SCpnt-request_bufflen != len) + if (scsi_bufflen(SCpnt) != len) { +

Re: INITIO scsi driver fails to work properly

2007-12-17 Thread James Bottomley
On Mon, 2007-12-17 at 14:36 +, Alan Cox wrote: On Mon, 17 Dec 2007 16:40:53 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote: On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote: initio doesn't seem to have a maintainer... Are you able to identify any earlier kernel

Re: 2.6.24-rc5: tape drive not responding

2007-12-17 Thread James Bottomley
On Mon, 2007-12-17 at 13:43 -0800, Andrew Morton wrote: On Mon, 17 Dec 2007 16:02:02 -0500 John Stoffel [EMAIL PROTECTED] wrote: Just to confirm, the propsed patch to st.c fixes the issue with 2.6.24-rc5 as well at 2.6.24-rc5-mm1 with access to my DLT tape drives. err, what patch

[GIT PATCH] SCSI bug fixes for 2.6.24-rc5

2007-12-19 Thread James Bottomley
at include/linux/scatterlist.h:59! James Bottomley (1): dpt_i2o: driver is only 32 bit so don't set 64 bit DMA mask Tony Battersby (2): sym53c8xx: fix irq X: nobody cared regression sym53c8xx: fix free_irq() regression The diffstat: dpt_i2o.c |3 +-- initio.c

Re: INITIO scsi driver fails to work properly

2007-12-19 Thread James Bottomley
On Wed, 2007-12-19 at 06:29 -0700, Matthew Wilcox wrote: On Wed, Dec 19, 2007 at 10:48:27AM +0200, Filippos Papadopoulos wrote: Would it be better to open a bug report at bugzilla? No, it wouldn't. Bugzilla is a place where bug reports go to be ignored. Witness 9370 where despite my best

Re: INITIO scsi driver fails to work properly

2007-12-20 Thread James Bottomley
On Thu, 2007-12-20 at 01:32 -0800, Natalie Protasevich wrote: On Dec 19, 2007 9:05 AM, Matthew Wilcox [EMAIL PROTECTED] wrote: On Wed, Dec 19, 2007 at 10:50:40AM -0600, James Bottomley wrote: So, to get the best of both worlds, file a bugzilla and note the bugid. Then email a complete

Re: smp_utils 0.93 beta, adds sgv4 interface

2007-12-21 Thread James Bottomley
On Fri, 2007-12-21 at 10:10 -0500, Douglas Gilbert wrote: James Bottomley wrote: On Wed, 2007-12-19 at 23:46 -0500, Douglas Gilbert wrote: smp_utils is a package of command line utilities for invoking SMP functions to monitor and manage SAS expanders. SMP is the Serial Attached SCSI (SAS

Re: INITIO scsi driver fails to work properly

2007-12-21 Thread James Bottomley
On Fri, 2007-12-21 at 14:30 -0500, Chuck Ebbert wrote: On 12/19/2007 03:48 AM, Filippos Papadopoulos wrote: On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote: I have found one problem. Please try patch [2] below and report. If it still fails try to enable debugging by setting

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread James Bottomley
On Wed, 2007-12-26 at 17:36 +0900, Tejun Heo wrote: (PS, I haven't followed the sg chaining discussion. Why is sg chaining an optional feature? Performance overhead on low end machines?) The idea of SG chaining is to allow drivers that wish to take advantage of it to increase their transfer

[PATCH] libsas: add host SMP processing

2007-12-28 Thread James Bottomley
This patch allows the sas host device to accept SMP commands. This brings the libsas attached hosts on to a par with the firmware based ones like mptsas. James diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig index c01a40d..18f33cd 100644 --- a/drivers/scsi/libsas/Kconfig

Re: [PATCH] libsas: add host SMP processing

2007-12-29 Thread James Bottomley
On Sat, 2007-12-29 at 14:24 +0900, FUJITA Tomonori wrote: From: James Bottomley [EMAIL PROTECTED] --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -1896,11 +1896,9 @@ int sas_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy

Re: [PATCH] libsas: add host SMP processing

2007-12-29 Thread James Bottomley
On Sun, 2007-12-30 at 01:06 +0900, FUJITA Tomonori wrote: On Sat, 29 Dec 2007 09:44:32 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Sat, 2007-12-29 at 14:24 +0900, FUJITA Tomonori wrote: From: James Bottomley [EMAIL PROTECTED] --- a/drivers/scsi/libsas/sas_expander.c +++ b

Re: [PATCH] libsas: don't treat underrun as an error on SMP tasks

2007-12-30 Thread James Bottomley
On Sun, 2007-12-30 at 19:34 +0900, FUJITA Tomonori wrote: On Sat, 29 Dec 2007 11:49:53 -0600 James Bottomley [EMAIL PROTECTED] wrote: All SMP tasks sent through bsg generate messages like: sas: smp_execute_task: task to dev 500605b01450 response: 0x0 status 0x81 Three times

[PATCH] libsas: don't use made up error codes

2007-12-30 Thread James Bottomley
This is bad for two reasons: 1. If they're returned to outside applications, no-one knows what they mean. 2. Eventually they'll clash with the ever expanding standard error codes. The problem error code in question is ETASK. I've replaced this by ECOMM (communications

Re: [PATCH] libsas: don't use made up error codes

2007-12-31 Thread James Bottomley
On Mon, 2007-12-31 at 13:25 -0800, Darrick J. Wong wrote: On Sun, Dec 30, 2007 at 12:37:31PM -0600, James Bottomley wrote: This is bad for two reasons: 1. If they're returned to outside applications, no-one knows what they mean. 2. Eventually they'll clash

[PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2007-12-31 Thread James Bottomley
coming in from user space. However, since all kernel allocations are automatically aligned on a minimum of 32 byte boundaries, it is safe to adjust them in this manner as well. Signed-off-by: James Bottomley [EMAIL PROTECTED] --- This also fixes a current panic in libsas with SATAPI devices. I

Re: [PATCH 2/2] relax scsi dma alignment

2008-01-01 Thread James Bottomley
On Tue, 2008-01-01 at 11:08 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Mon, 31 Dec 2007 16:43 -0600: This patch relaxes the default SCSI DMA alignment from 512 bytes to 4 bytes. I remember from previous discussions that usb and firewire have sector size alignment requirements,

Re: [Bugme-new] [Bug 9674] New: Oops during rmmod'ing modeuls sdhci, sr_mod, ricoh_mmc, mmc_core

2008-01-01 Thread James Bottomley
On Tue, 2008-01-01 at 18:10 -0800, Andrew Morton wrote: On Tue, 1 Jan 2008 14:55:45 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9674 Summary: Oops during rmmod'ing modeuls sdhci, sr_mod, ricoh_mmc, mmc_core Guys,

Re: [Bugme-new] [Bug 9674] New: Oops during rmmod'ing modeuls sdhci, sr_mod, ricoh_mmc, mmc_core

2008-01-02 Thread James Bottomley
On Wed, 2008-01-02 at 13:21 +0100, Rafael J. Wysocki wrote: On Wednesday, 2 of January 2008, James Bottomley wrote: On Tue, 2008-01-01 at 18:10 -0800, Andrew Morton wrote: On Tue, 1 Jan 2008 14:55:45 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id

Re: [Bugme-new] [Bug 9674] New: Oops during rmmod'ing modeuls sdhci, sr_mod, ricoh_mmc, mmc_core

2008-01-02 Thread James Bottomley
sr_mod is removed, it looks like the request queue prep_rq_fn is still pointing to the now nonexistent sr_prep_fn. This may have been due to a commit that went in early 2.6.24: commit 7f9a6bc4e9d59e7fcf03ed23f60cd81ca5d80b65 Author: James Bottomley [EMAIL PROTECTED] Date: Sat

[PATCH] scsi_sysfs: restore prep_fn when ULD is removed

2008-01-02 Thread James Bottomley
A recent bug report: http://bugzilla.kernel.org/show_bug.cgi?id=9674 Was caused because the ULDs now set their own prep functions, but don't necessarily reset the prep function back to the SCSI default when they are removed. This leads to panics if commands are sent to the device after the

Re: [PATCH] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 16:58 +0900, FUJITA Tomonori wrote: On Mon, 31 Dec 2007 15:56:08 -0600 James Bottomley [EMAIL PROTECTED] wrote: @@ -1080,24 +1073,15 @@ extern void ata_port_pbar_desc(struct ata_port *ap, int bar, ssize_t offset, static inline struct scatterlist

Re: advansys broken (at least) on ARM and MIPS

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 08:43 +0100, Martin Michlmayr wrote: Commit 9d511a4b29de6764931343d03e493f2e04df0271 removed the depends on BROKEN || X86_32 line from advansys' Kconfig entry. I'm not sure that was such a great idea - the module doesn't compile at least on ARM and MIPS: ARM: CC

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: As recommended by Christoph Hellwig. There is no use of Fixing these drivers, since there is a much simpler and modern esp infrastructure with David Miller's esp_scsi - Remove all driver files dependent on NCR53C9x.c

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread James Bottomley
On Thu, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote: On Thu, 3 Jan 2008, James Bottomley wrote: On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: As recommended by Christoph Hellwig. There is no use of Fixing these drivers, since there is a much simpler and modern esp

[GIT PATCH] another SCSI critical bug fix for 2.6.24-rc6

2008-01-04 Thread James Bottomley
transport, and removing them will cause corruption and an oops when their creator tries to remove them. Signed-off-by: David Dillow [EMAIL PROTECTED] Acked-by: FUJITA Tomonori [EMAIL PROTECTED] Signed-off-by: James Bottomley [EMAIL PROTECTED] --- drivers/scsi/scsi_transport_srp.c |3 ++- 1 files

Re: [PATCH] tgt: Use scsi_init_io instead of scsi_alloc_sgtable

2008-01-04 Thread James Bottomley
On Thu, 2007-12-13 at 13:44 +0200, Boaz Harrosh wrote: - If we export scsi_init_io()/scsi_release_buffers() instead of scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is much more insulated from scsi_lib changes. As a bonus it will also gain bidi capability when it comes.

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-05 Thread James Bottomley
On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: This patch series is the start of my attempt to simplify and make explicit the chained scatterlist logic. It's not complete: my SATA box boots and seems happy, but all the other users of SCSI need to be updated and checked. But I've

[PATCH] add missing transport configure points for target and host

2008-01-05 Thread James Bottomley
While trying to convert the SPI transport class to attribute groups, I discovered that we don't actually have any transport configure points for either the target or the host. This patch adds these missing transport class triggers. The host one is simply done after the add, the target one tries

[PATCH] scsi_transport_spi: convert to attribute groups

2008-01-05 Thread James Bottomley
This conversion makes full use of the is_visible() callback on attribute groups. Now, each device appears only with its capability flags in the transport class directory. Previously each device appeared with the capability of the host, so this is a functionality improvement. Converting to

[PATCH] sr: update to follow tray status correctly

2008-01-05 Thread James Bottomley
It's been a while with no status on this one, so I corrected the patch based on my original input. The attached is what I think is the best way of doing this (I've replaced the home grown test_unit_ready routine with the SCSI one and updated some of the sense check conditions). It seems to work

Re: An MCA ESP driver

2008-01-05 Thread James Bottomley
On Wed, 2007-08-15 at 14:55 -0700, David Miller wrote: From: Matthew Wilcox [EMAIL PROTECTED] Date: Wed, 15 Aug 2007 11:26:00 -0600 On Tue, Aug 07, 2007 at 12:26:04AM -0700, David Miller wrote: - struct sbus_dma *dma; + union { + struct sbus_dma

Re: [PATCH] tgt: Use scsi_init_io instead of scsi_alloc_sgtable

2008-01-06 Thread James Bottomley
On Sun, 2008-01-06 at 19:08 +0200, Boaz Harrosh wrote: On Sat, Jan 05 2008 at 1:02 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-12-13 at 13:44 +0200, Boaz Harrosh wrote: - If we export scsi_init_io()/scsi_release_buffers() instead of scsi_{alloc,free}_sgtable() from

Re: [PATCH][SCSI] megaraid: Convert from scsi.h to scsi.h (and friends)

2008-01-06 Thread James Bottomley
On Sun, 2008-01-06 at 20:03 +0100, Richard Knutsson wrote: Convert glue-include scsi.h to scsi.h (and friends). (binary sizes) allyesconfig: before: 260132 after: 260048 allmodconfig: before: 261740 after: 261656 Signed-off-by: Richard Knutsson [EMAIL

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:38 +1100, Rusty Russell wrote: On Sunday 06 January 2008 02:31:12 James Bottomley wrote: On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: This patch series is the start of my attempt to simplify and make explicit the chained scatterlist logic. It's

Re: Multipath failover handling (Was: Re: 2.6.24-rc3-mm1)

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 15:05 +0100, Hannes Reinecke wrote: James Bottomley wrote: On Fri, 2007-12-14 at 10:00 +0100, Hannes Reinecke wrote: James Bottomley wrote: On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote: OK, thanks. I'll assume that James and Hannes have this in hand

Re: [PATCH] sym8xx_2: Fixes call to wait_for_completion_timeout() with NULL argument

2008-01-07 Thread James Bottomley
On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote: From: Krzysztof Helt [EMAIL PROTECTED] This patch fixes call to wait_for_completion_timeout() with NULL argument. That doesn't seem to be at all what your patch is doing. I can't see any case in the old code where

Re: [PATCH] sym8xx_2: kill compilation warning

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 07:40 +0100, Krzysztof Helt wrote: On Mon, 07 Jan 2008 16:39:35 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-01-07 at 22:56 +0100, Krzysztof Helt wrote: From: Krzysztof Helt [EMAIL PROTECTED] This patch fixes call

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread James Bottomley
On Tue, 2008-01-08 at 18:56 +0100, Stefan Richter wrote: Matthew Wilcox wrote: On Tue, Jan 08, 2008 at 02:43:34PM +0100, Hannes Reinecke wrote: I have here a buggy firewire bridge (Prolific PL3507) which requires that each 'INQUIRY' command is followed by a 'READ CAPACITY' command.

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-19 Thread James Bottomley
On Tue, 2012-09-18 at 15:10 -0700, Roland Dreier wrote: From: Roland Dreier rol...@purestorage.com The qla2xxx firmware actually expects the task management response code in a CTIO IOCB with SCSI status mode 1 to be in little-endian byte order, ie the response code should be the first byte

Re: [PATCH v7 0/6] ZPODD patches

2012-09-19 Thread James Bottomley
On Wed, 2012-09-19 at 16:03 +0800, Aaron Lu wrote: Hi James, May I know if this patchset will enter v3.7? Sigh, well, I was hoping to persuade the PM people to sort this out first. The first observation is that all this looks to be too specific. ZPO may be ACPI specific, but the property it

Re: [PATCH v7 0/6] ZPODD patches

2012-09-19 Thread James Bottomley
On Wed, 2012-09-19 at 14:50 +0200, Rafael J. Wysocki wrote: On Wednesday, September 19, 2012, James Bottomley wrote: On Wed, 2012-09-19 at 16:03 +0800, Aaron Lu wrote: Hi James, May I know if this patchset will enter v3.7? Sigh, well, I was hoping to persuade the PM people

Re: [PATCH] qla2xxx: Correct loop_id_map allocation-size and usage.

2012-09-20 Thread James Bottomley
On Thu, 2012-09-20 at 03:39 -0400, Saurav Kashyap wrote: From: Andrew Vasquez andrew.vasq...@qlogic.com Original code incorrectly assigned LOOPID_MAP_SIZE to be the allocation size in bytes rather than total bit size. Additionally corrected code to check for bit-allocation failure in

Re: Discard merging / Write same support v5

2012-09-20 Thread James Bottomley
On Thu, 2012-09-20 at 14:33 +0200, Jens Axboe wrote: On 09/18/2012 06:19 PM, Martin K. Petersen wrote: I've been beating on this patch kit for the last few weeks with a bunch of different devices. I have also tested extensively with Shaohua Li's MD RAID0 discard support. The only

Re: [PATCH] qla2xxx: Fix endianness of task management response code

2012-09-21 Thread James Bottomley
On Wed, 2012-09-19 at 07:09 -0700, Roland Dreier wrote: On Wed, Sep 19, 2012 at 12:59 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: Is this also true on Big Endian Hardware? Because the fix you have assumes that the TIO IOCB with SCSI status mode 1 should be CPU endian

Re: [PATCH v3] scsi_lib: rate-limit the error message from failing commands

2012-09-22 Thread James Bottomley
On Fri, 2012-09-21 at 15:15 -0400, Mike Snitzer wrote: On Thu, Aug 30, 2012 at 7:25 PM, Jens Axboe ax...@kernel.dk wrote: On 2012-08-30 14:06, Yi Zou wrote: [ Jens/James, This is a rather old rate limt patch but never gets picked up in upstream, so I am resending it here as v3,

[GIT PULL] SCSI fixes for 3.6-rc6

2012-09-23 Thread James Bottomley
This is a set of four essential fixes: two oops related (bnx2i, virtio-scsi), one data corruption related (hpsa) and one failure to boot due to interrupt routing issues (mpt2ss). The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short

Re: [Bug 47781] ata2: exception Emask 0x10 SAct 0x0 SErr 0x4050002 action 0xe frozen

2012-09-23 Thread James Bottomley
On Sun, 2012-09-23 at 21:07 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=47781 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-23 Thread James Bottomley
On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: Just noticed that after commit 919f797, it is possible that scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking for drv returned from the above function. Maybe it is not possible at run time, but from the code itself,

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 15:03 +0800, Li Zhong wrote: On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: Just noticed that after commit 919f797, it is possible that scsi_cmd_to_driver() returns NULL. This patch adds the NULL checking

Re: [PATCHv2] st: remove st_mutex

2012-09-24 Thread James Bottomley
On Mon, 2012-09-10 at 15:36 -0700, Lee Duncan wrote: From: Hannes Reinecke h...@suse.com The st_mutex was created when the BKL was removed, and prevents simultaneous st_open calls. It is better to protect just the necessary data. Signed-off-by: Hannes Reinecke h...@suse.com Reviewed-by:

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-24 Thread James Bottomley
On Mon, 2012-09-24 at 17:25 +0800, Li Zhong wrote: On Mon, 2012-09-24 at 11:35 +0400, James Bottomley wrote: On Mon, 2012-09-24 at 15:03 +0800, Li Zhong wrote: On Mon, 2012-09-24 at 09:44 +0400, James Bottomley wrote: On Mon, 2012-09-24 at 13:30 +0800, Li Zhong wrote: Just noticed

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-25 Thread James Bottomley
On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote: On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed

Re: [PATCH v7 0/6] ZPODD patches

2012-09-25 Thread James Bottomley
On Tue, 2012-09-25 at 16:18 +0800, Aaron Lu wrote: A example patch would be something like the following, I didn't seperate these ACPI calls in sr.c as this is just a concept proof, if this is the right thing to do, I will separate them into another file sr-acpi.c and make empty stubs for them

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-26 Thread James Bottomley
On Wed, 2012-09-26 at 22:02 -0400, Martin K. Petersen wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: James Plus, I think it fixes a bug where you get different behaviours James from REQ_TYPE_BLOCK_PC commands when a driver is and isn't James attached (I've

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-26 Thread James Bottomley
On Wed, 2012-09-26 at 22:20 -0400, Martin K. Petersen wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: James On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, 5 insertions(+), 1

Re: [PATCH scsi] Short the path length of scsi_cmd_to_driver()

2012-09-28 Thread James Bottomley
On Thu, 2012-09-27 at 13:43 -0400, Martin K. Petersen wrote: Li == Li Zhong zh...@linux.vnet.ibm.com writes: @@ -845,8 +844,11 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd, scsi_eh_restore_cmnd(scmd, ses); -if (sdrv sdrv-eh_action) -

Re: [PATCH scsi] Add NULL checking of return value from scsi_cmd_to_driver()

2012-09-28 Thread James Bottomley
On Thu, 2012-09-27 at 13:41 -0400, Martin K. Petersen wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: I'm fine with having the eh action be triggered for FS requests only, if that's what you're asking? James Sort of ... I was thinking do it for all non

Re: [PATCH 0/2] virtio-scsi fixes for 3.6

2012-10-02 Thread James Bottomley
On Mon, 2012-10-01 at 15:11 +0200, Paolo Bonzini wrote: Il 26/07/2012 15:28, Paolo Bonzini ha scritto: James, patch 1 fixes scanning of LUNs whose number is greater than 255. QEMU passes a max_lun of 16383 (because it uses SAM numbering) but in Linux it must become 32768 (because LUNs

Re: [Bug 48241] New: oops when setting up LVM

2012-10-03 Thread James Bottomley
On Wed, 2012-10-03 at 15:04 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=48241 Summary: oops when setting up LVM Product: IO/Storage Version: 2.5 Kernel Version: 3.6.0-next-20121003 Platform:

Re: standards revisions

2012-10-07 Thread James Bottomley
On Sat, 2012-10-06 at 23:11 -0700, Nicholas A. Bellinger wrote: On Sat, 2012-10-06 at 21:49 -0400, Christoph Hellwig wrote: Currenly all non-pscsi bakcneds report their standards version as SPC 2 via -get_device_rev. No, the proper on-the-wire bits to signal SPC-3 compliance are already

Re: [PATCH, resend] Fix race between starved list processing and device removal

2012-10-07 Thread James Bottomley
On Mon, 2012-09-24 at 15:14 +0200, Bart Van Assche wrote: Avoid that the sdev reference count can drop to zero before the queue is run by scsi_run_queue(). Also avoid that the sdev reference count can drop to zero in the same function by invoking __blk_run_queue(). [...] if

Re: Request for improved commit tracking between fcoe and scsi trees

2012-10-07 Thread James Bottomley
On Wed, 2012-10-03 at 15:23 -0400, Neil Horman wrote: James, Robert- I've been doing lots of backports of FCoE code to the RHEL tree these last few months, and I've noticed something fairly irritating, and I was wondering if you two could help me out with it (in fact you two are the only

Re: Request for improved commit tracking between fcoe and scsi trees

2012-10-07 Thread James Bottomley
On Thu, 2012-10-04 at 20:25 +, Love, Robert W wrote: On 10/3/2012 12:23 PM, Neil Horman wrote: James, Robert- I've been doing lots of backports of FCoE code to the RHEL tree these last few months, and I've noticed something fairly irritating, and I was wondering if you two could

Re: [RESEND][PATCH 0/20][SCSI] mpt3sas: Driver submission v01.100.00.00

2012-10-07 Thread James Bottomley
On Sat, 2012-09-29 at 19:48 +0530, sreekanth.re...@lsi.com wrote: This is new scsi lld device driver from LSI supporting the SAS 3.0 standard. Here is list of new 12gb host controllers: LSI SAS3004 LSI SAS3008 LSI SAS3108 Signed-off-by: Sreekanth Reddy sreekanth.re...@lsi.com

Re: standards revisions

2012-10-08 Thread James Bottomley
On Sun, 2012-10-07 at 11:11 -0700, Nicholas A. Bellinger wrote: On Sun, 2012-10-07 at 09:16 +0100, James Bottomley wrote: On Sat, 2012-10-06 at 23:11 -0700, Nicholas A. Bellinger wrote: On Sat, 2012-10-06 at 21:49 -0400, Christoph Hellwig wrote: Currenly all non-pscsi bakcneds report

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-10-08 Thread James Bottomley
On Mon, 2012-10-08 at 17:27 +0800, Aaron Lu wrote: On Sun, Sep 30, 2012 at 03:43:27PM -0400, Alan Stern wrote: On Sun, 30 Sep 2012, Jeff Garzik wrote: The simple fact of only ZPODD devices out there are ATA is not the decision-maker for where the code should live. It is more a

Re: [V5 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-10-08 Thread James Bottomley
On Mon, 2012-10-08 at 15:37 +0530, Naresh Kumar Inna wrote: Please let me know if you are expecting any more changes to this driver to resume its review. I have addressed all review comments as of the last series of patches (below). No, I don't think so, but please understand that the review

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-09 Thread James Bottomley
On Wed, 2012-10-03 at 20:39 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw --- diff -uprN -X linux-vanilla/Documentation/dontdiff

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-10-09 Thread James Bottomley
On Tue, 2012-10-09 at 21:23 +0800, NickCheng wrote: From: Nick Cheng nick.ch...@areca.com.tw Replace the nameing, hba, hbb and hbc, with hbaA, hbaB abd hbaC respectively Signed-off-by: Nick Cheng nick.ch...@areca.com.tw This is still malformed in exactly the same way diff -uprN -X

Re: [PATCH v7 2/6] scsi: sr: support runtime pm

2012-10-09 Thread James Bottomley
On Tue, 2012-10-09 at 15:20 +0800, Aaron Lu wrote: On 10/08/2012 06:21 PM, James Bottomley wrote: On Mon, 2012-10-08 at 17:27 +0800, Aaron Lu wrote: On Sun, Sep 30, 2012 at 03:43:27PM -0400, Alan Stern wrote: On Sun, 30 Sep 2012, Jeff Garzik wrote: The simple fact of only ZPODD devices

Re: [PATCH] sd: Reshuffle init_sd to avoid crash

2012-10-10 Thread James Bottomley
On Wed, 2012-10-10 at 10:36 +0200, Hannes Reinecke wrote: scsi_register_driver will register a prep_fn() function, which in turn migh need to use the sd_cdp_pool for DIF. Which hasn't been initialised at this point, leading to a crash. So reshuffle the init_sd() and exit_sd() paths to have

Re: [PATCH] sd: Reshuffle init_sd to avoid crash

2012-10-10 Thread James Bottomley
On Wed, 2012-10-10 at 12:01 +0200, Hannes Reinecke wrote: On 10/10/2012 11:55 AM, James Bottomley wrote: On Wed, 2012-10-10 at 10:36 +0200, Hannes Reinecke wrote: scsi_register_driver will register a prep_fn() function, which in turn migh need to use the sd_cdp_pool for DIF. Which hasn't

Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

2012-10-11 Thread James Bottomley
On Thu, 2012-10-11 at 10:15 +0100, James Hogan wrote: The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when used in struct osd_cdb_head, but it isn't marked as packed. Some architectures will round the struct size up which triggers BUILD_BUG_ON compile errors in

Re: Drivers: scsi

2012-10-24 Thread James Bottomley
On Wed, 2012-10-24 at 09:25 -0700, K. Y. Srinivasan wrote: When the low level driver returns SCSI_MLQUEUE_DEVICE_BUSY, how is the command retried; I suspect the retry is done after some delay. Delay depends mainly on I/O pressure and the unplug timer in the block layer. Is this delay

Re: [PATCH] aic7xxx_old: silence GCC warnings

2012-10-29 Thread James Bottomley
On Mon, 2012-10-29 at 11:36 +0100, Paul Bolle wrote: On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote: Building the aic7xxx_old driver triggers these GCC warnings: drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in enumerated type 'ahc_chip' [-Wswitch]

Re: [PATCH v8 02/11] ata: zpodd: Add CONFIG_SATA_ZPODD

2012-10-29 Thread James Bottomley
On Mon, 2012-10-29 at 17:01 +0800, Aaron Lu wrote: Added a new config CONFIG_SATA_ZPODD, which is ued to support SATA based zero power ODD. It depends on ACPI, and selects BLK_DEV_SR as the implementation of ZPODD depends on SCSI sr driver. 2 new files are added, which will be used to host

Re: [PATCH v8 10/11] scsi: sr: support (un)block events

2012-10-29 Thread James Bottomley
On Mon, 2012-10-29 at 17:01 +0800, Aaron Lu wrote: 2 interfaces are added to block/unblock events for the disk sr manages. This is used by SATA ZPODD, when ODD is runtime powered off, the events poll is no longer needed so better be blocked. And once powered on, events poll will be unblocked.

Re: [PATCH v8 10/11] scsi: sr: support (un)block events

2012-10-29 Thread James Bottomley
On Mon, 2012-10-29 at 18:22 -0400, Alan Stern wrote: On Mon, 29 Oct 2012, James Bottomley wrote: On Mon, 2012-10-29 at 17:01 +0800, Aaron Lu wrote: 2 interfaces are added to block/unblock events for the disk sr manages. This is used by SATA ZPODD, when ODD is runtime powered off

Re: Drivers: scsi

2012-11-04 Thread James Bottomley
On Sat, 2012-11-03 at 09:40 -0700, K. Y. Srinivasan wrote: Do we currently support dynamic re-sizing of LUNs. Hyper-V can notify capacity change via sense data and I was wondering if this is handled in the generic scsi code. Depends what you mean by dynamic. Experience shows that most users

Re: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-06 Thread James Bottomley
On Mon, 2012-11-05 at 14:53 -0500, Xi Wang wrote: Invoking bit(n) with n = 64 is undefined behavior, since bit(n) does a 64-bit shift. This patch adds a check on the shifting amount. Why is this necessary? As I read the reg set assignment code, it finds a free bit in the 64 bit register and

Re: [PATCH] target: Update copyright ownership to 2012

2012-11-11 Thread James Bottomley
On Fri, 2012-11-09 at 23:00 +, Nicholas A. Bellinger wrote: diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index 4c8eea2..035c606 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c @@ -3,8 +3,9 @@ * * This file

Re: scsi target, likely GPL violation

2012-11-11 Thread James Bottomley
On Wed, 2012-11-07 at 08:50 -0800, Andy Grover wrote: Nick, Your company appears to be shipping kernel features in RTS OS that are not made available under the GPL, specifically support for the EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim full Vmware vSphere 5 VAAI

Re: scsi target, likely GPL violation

2012-11-11 Thread James Bottomley
On Sun, 2012-11-11 at 10:15 -0500, Bradley M. Kuhn wrote: James wrote: [I'd like to see] a genuine public apology for the libel... Because any further discussion of unsubstantiated allegations of this nature exposes us all to jeopardy of legal sanction. Hey that's a complete

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Fri, 2012-11-09 at 16:33 +, Elliott, Robert (Server Storage) wrote: I recommend broadening this patch. T10 is discussing making READ (10), WRITE (10), etc. obsolete in SBC-4 in favor of their 16-byte CDB counterparts. The algorithm should be: 1. During discovery, determine if

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@ -251,6 +251,11 @@ static int slave_configure(struct

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Mon, 2012-11-12 at 15:31 +0100, Paolo Bonzini wrote: Il 12/11/2012 12:33, James Bottomley ha scritto: On Fri, 2012-11-09 at 11:08 -0500, Jason J. Herne wrote: diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 13b8bcd..6ff785e 100644 --- a/drivers/usb

Re: [PATCH] USB enclosures seem to require read(16) with 2TB drives

2012-11-12 Thread James Bottomley
On Mon, 2012-11-12 at 10:01 -0500, Jason J. Herne wrote: Any reason not to do this always on 2TB drives, which basically means changing this: - } else if (block 0x) { + } else if (sdkp-capacity 0x) { and nothing else? This was the intent of my patch,

Re: [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue

2012-11-13 Thread James Bottomley
On Wed, 2012-10-24 at 01:45 -0500, Mike Christie wrote: On 10/19/2012 06:15 PM, John Soni Jose wrote: @@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost) BS_%d : Getting Port Speed Failed\n); return -EBUSY; -}

Re: [PATCH 0/7] qla4xxx: Updates for scsi misc branch

2012-11-13 Thread James Bottomley
On Wed, 2012-10-10 at 11:08 -0500, Michael Christie wrote: On Oct 10, 2012, at 6:24 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas.

Re: [PATCH 1/1] aacraid: SCSI dma mapping failure case handling

2012-11-13 Thread James Bottomley
On Tue, 2012-10-16 at 23:34 +0200, Tomas Henzl wrote: On 10/16/2012 10:59 PM, Mahesh Rajashekhara wrote: This patch handles SCSI dma mapping failure case. Reporting error code to the upper layer instead of BUG_ON(). This patch is created against current upstream kernel.

Re: [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset.

2012-11-13 Thread James Bottomley
On Sat, 2012-10-20 at 04:41 +0530, John Soni Jose wrote: From: Minh Tran minhduc.t...@emulex.com Fixed soft_reset problem which driver modified all 32bit before a write on second pass. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: Jayamohan Kallickal

Re: [PATCH 1/5] arcmsr: Re-name the HBA Type

2012-11-13 Thread James Bottomley
On Fri, 2012-10-12 at 17:05 +0800, NickCheng wrote: -#define ARCMSR_HBCMU_OUTBOUND_DOORBELL_ISR_MASK0x0004 /* When clear, the General Outbound Doorbell interrupt routes to the host.*/ The patch is still linebroken here. It is a massively long line (like about 200 characters). I

<    2   3   4   5   6   7   8   9   10   11   >