On Wed, 2014-01-08 at 12:16 +, Saxena, Sumit wrote:
-Original Message-
From: Wei Yongjun [mailto:weiyj...@gmail.com]
Sent: Friday, December 20, 2013 8:38 AM
To: DL-MegaRAID Linux; jbottom...@parallels.com; simon.pu...@gmail.com;
jkos...@suse.cz
Cc:
On Tue, 2014-02-18 at 13:55 -0600, Stephen M. Cameron wrote:
From: Scott Teel scott.t...@hp.com
Signed-off-by: Scott Teel scott.t...@hp.com
Acked-by: Stephen M. Cameron scame...@beardog.cce.hp.com
Just a note: when you send a patch to me, that should be signed-off-by.
It's because you're
On Wed, 2014-01-08 at 12:28 +, Saxena, Sumit wrote:
-Original Message-
From: Jasper Spaans [mailto:spa...@fox-it.com]
Sent: Friday, October 25, 2013 5:53 PM
To: DL-MegaRAID Linux
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] megaraid_sas: make the log message about rescanning
Hi everyone
We're about three weeks out from LSF/MM, so the PC is putting together
the agenda here:
https://docs.google.com/spreadsheet/pub?key=0ArurRVMVCSnkdHU2Zk1KbFhmeVZFVmFMQ19nakJYaFEgid=0
The current list of attendees is:
This is a set of six fixes. Two are instant crash/null deref types
(storvsc and isci reset fixes). The two qla2xxx are initialisation
problems that cause MSI-X failures and card misdetection, the isci
erroneous macro is actually illegal C that's causing a miscompile with
certain gcc versions and
On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote:
On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
In the long game, though this whole debate is moot: setups with hard
wired start times adhere to them regardless of what the system does, so
On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote:
On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley
james.bottom...@hansenpartnership.com wrote:
On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote:
On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley
james.bottom
On Mon, 2014-03-17 at 12:52 -0400, Josh Boyer wrote:
Hi All,
We've had a few reports[1][2] now on the vmw_pvscsi driver throwing
DMA-API mapping errors when the DMA_API_DEBUG option is enabled. I've
included one from a recent 3.14-rc6 kernel below. Looking at
vmw_pvscsi.c, I can see
On Tue, 2014-03-18 at 07:52 +0100, Hannes Reinecke wrote:
On 03/17/2014 11:11 PM, Jeremy Linton wrote:
On 3/15/2014 3:51 AM, Hannes Reinecke wrote:
Add a flag 'vpd_invalid' to the SCSI device to indicate that
the VPD data needs to be refreshed. This is required if
either a manual rescan
On Wed, 2014-03-19 at 07:21 +, Desai, Kashyap wrote:
-Original Message-
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
Sent: Thursday, March 13, 2014 4:00 PM
To: Saxena, Sumit
Cc: Wei Yongjun; DL-MegaRAID Linux; simon.pu...@gmail.com;
jkos...@suse.cz
On Wed, 2014-03-12 at 16:08 -0500, wenxi...@vmlinux.vnet.ibm.com wrote:
From: Alexander Gordeev agord...@redhat.com
There is no need to call pci_disable_msi() or pci_disable_msix()
in case the call to pci_enable_msi() or pci_enable_msix() failed.
Signed-off-by: Alexander Gordeev
On Wed, 2014-03-19 at 15:26 -0500, Brian King wrote:
On 03/19/2014 02:55 PM, James Bottomley wrote:
On Wed, 2014-03-12 at 16:08 -0500, wenxi...@vmlinux.vnet.ibm.com wrote:
From: Alexander Gordeev agord...@redhat.com
There is no need to call pci_disable_msi() or pci_disable_msix
On Wed, 2014-03-19 at 16:31 -0400, Alan Stern wrote:
On Wed, 19 Mar 2014, Andreas Reis wrote:
I've uploaded a dmesg with the new debugging patch to bugzilla:
https://bugzilla.kernel.org/attachment.cgi?id=130041
Thanks. I have now managed to reproduce many of the features of this
On Tue, 2014-03-11 at 13:51 -0700, Arvind Kumar wrote:
Fixed an issue with log message's prefix. Should have been vmw_pvscsi, was
pvscsi.
Resending. Please consider this one. Thanks!
This change allows pvscsi driver to coalesce I/O requests
before issuing them. The number of I/O's
On Fri, 2014-03-14 at 16:37 -0400, Martin K. Petersen wrote:
Sreekanth == Reddy, Sreekanth sreekanth.re...@lsi.com writes:
Sreekanth A new mpt2sas driver module parameter 'disable_eedp' is added
Sreekanth to Disable EEDP support. By default DIF support is enabled in
Sreekanth the driver and
to
sysfs
:: TO: Hannes Reinecke h...@suse.de
:: CC: James Bottomley jbottom...@parallels.com
Actually, it's not just this that's a problem. Since the _len variables
are unsigned chars, they're bogus in more ways than having errors put
into them because the lengths of the pages can go
On Thu, 2014-03-20 at 08:19 +0100, Hannes Reinecke wrote:
The VPD page length parameter is not only used for the length,
but also to hold any error code. So it needs to be moved to an
integer.
And we should be resetting the default VPD page length after
each iteration so that we do not
On Sat, 2014-03-15 at 09:51 +0100, Hannes Reinecke wrote:
Add a flag 'vpd_invalid' to the SCSI device to indicate that
the VPD data needs to be refreshed. This is required if either
a manual rescan is triggered or if the sense code INQUIRY DATA
HAS CHANGED has been received.
Signed-off-by:
On Thu, 2014-03-20 at 11:36 -0400, Alan Stern wrote:
On Wed, 19 Mar 2014, James Bottomley wrote:
Basically, usb-storage deadlocks when the SCSI error handler invokes
the eh_device_reset_handler callback while a command is running. The
command has timed out and will never complete
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
OK, so I think we have three things to do
1. Investigate SCSI and fix it's abort state problem that's causing
it not to send the abort second time around
2. Fix usb
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
OK, so I think we have three things to do
1. Investigate SCSI and fix it's abort state problem that's causing
it not to send the abort second time around
2. Fix usb
On Thu, 2014-03-20 at 15:48 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
OK, so I think we have three things to do
1. Investigate SCSI and fix it's
On Thu, 2014-03-20 at 15:59 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
OK, so I think we have three things to do
1. Investigate SCSI and fix it's abort state problem that's causing
it not to send the abort second time around
2. Fix usb
On Fri, 2014-03-21 at 12:32 -0700, Linus Torvalds wrote:
On Fri, Mar 21, 2014 at 11:34 AM, Oleg Nesterov o...@redhat.com wrote:
Yes, it seems that it actually needs 30 secs. It spends most of the time
(30.13286 seconds) in [..]
So how about taking a completely different approach:
-
On Sat, 2014-03-22 at 20:25 +0100, Oleg Nesterov wrote:
On 03/22, Tetsuo Handa wrote:
Oleg Nesterov wrote:
Tetsuo, what do you think?
I don't like blocking SIGKILL while doing operations that depend on memory
allocation by other processes. If the OOM killer is triggered and it chose
On Sat, 2014-03-22 at 11:13 -0700, Laura Abbott wrote:
Rather than have architectures #define ARCH_HAS_SG_CHAIN in an architecture
specific scatterlist.h, make it a proper Kconfig option and use that
instead. At same time, remove the header files are are now mostly
useless and just include
On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote:
On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
Perhaps now might be the time to ask which are the remaining
architectures that cannot do SG chaining and then we can fix them and
pull the whole thing out
On Sat, 2014-03-22 at 22:52 +, Russell King - ARM Linux wrote:
On Sat, Mar 22, 2014 at 03:37:40PM -0700, James Bottomley wrote:
On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote:
On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
Perhaps now might
On Sun, 2014-03-23 at 09:04 +0100, Thomas Gleixner wrote:
On Sun, 23 Mar 2014, Tetsuo Handa wrote:
Thomas Gleixner wrote:
But then systemd/udev mutters:
You migh be able to work around the timeout with udev rules and
OPTIONS+=event_timeout=120, but that code was maybe
On Sun, 2014-03-23 at 15:28 +0100, Thomas Gleixner wrote:
On Sun, 23 Mar 2014, James Bottomley wrote:
On Sun, 2014-03-23 at 09:04 +0100, Thomas Gleixner wrote:
On Sun, 23 Mar 2014, Tetsuo Handa wrote:
Thomas Gleixner wrote:
But then systemd/udev mutters:
You migh
On Thu, 2014-03-27 at 13:19 +0300, Sergey Senozhatsky wrote:
Hello,
[1.971778] [ cut here ]
[1.971960] WARNING: CPU: 1 PID: 6 at mm/page_alloc.c:2497
__alloc_pages_nodemask+0x1b9/0x693()
[1.972246] Modules linked in: sd_mod ahci
[1.972604] CPU: 1
On Tue, 2014-03-25 at 16:36 +0100, Paolo Bonzini wrote:
Il 25/03/2014 16:31, Christoph Hellwig ha scritto:
Paolo,
do you have a virtio_scsi tree to picks this up in? We now have all
the infrastructure for it in James' tree.
I don't, I usually just give my Acked-by and James picks it
. Fix this by properly zeroing the scmd-status before
the command is resubmitted.
Signed-off-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: James Bottomley jbottom...@parallels.com
---
drivers/scsi/scsi_error.c | 1 +
drivers/scsi/scsi_lib.c | 1 +
2 files changed, 2 insertions(+)
diff
The abort state is being stored persistently across commands, meaning if the
command times out a second time, the error handler thinks an abort is still
pending. Fix this by properly resetting the abort flag after the abort is
finished.
Signed-off-by: James Bottomley jbottom...@parallels.com
This is a set of three patches we agreed to a while ago to eliminate a
USB deadlock. I did rewrite the first patch, if it could be reviewed
and tested.
Thanks,
James
---
Alan Stern (1):
[SCSI] Fix command result state propagation
James Bottomley (2):
[SCSI] Fix abort state memory problem
this by
testing to see if we actually got a CHECK_CONDITION return and skip asking for
sense if we don't.
Tested-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: James Bottomley jbottom...@parallels.com
---
drivers/scsi/scsi_error.c | 9 +
1 file changed, 9 insertions(+)
diff --git
On Thu, 2014-03-20 at 15:49 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
On Thu, 2014-03-20 at 12:34 -0400, Alan Stern wrote:
On Thu, 20 Mar 2014, James Bottomley wrote:
OK, so I think we have three things to do
1. Investigate SCSI and fix it's
[lets split the thread]
On Mon, 2014-03-31 at 16:37 +0200, Hannes Reinecke wrote:
On 03/31/2014 03:33 PM, Alan Stern wrote:
On Mon, 31 Mar 2014, Hannes Reinecke wrote:
On 03/28/2014 08:29 PM, Alan Stern wrote:
On Fri, 28 Mar 2014, James Bottomley wrote:
Maybe scmd_eh_abort_handler
()
megaraid_sas_fusion: Return correct error value in
megasas_get_ld_map_info()
megaraid_sas_fusion: correctly pass queue info pointer
bfa: set correct command return code
hpsa: fixup MSI-X registration
scsi_error: disable eh_deadline if no host_reset_handler is set
James Bottomley (2
On Sun, 2014-03-30 at 15:30 +0200, Mathias Krause wrote:
The format strings for various printk()s make use of a temporary
variable that is declared 'static'. This is probably not intended,
so fix those.
Actually, it was intended. It was to work around an assignment to const
gcc bug: some
On Tue, 2014-04-08 at 09:39 +, bugzilla-dae...@bugzilla.kernel.org
wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=73621
Alan a...@lxorguk.ukuu.org.uk changed:
What|Removed |Added
[+linux-scsi]
On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote:
On Wed, 2014-04-09 at 10:39 +0800, Baoquan He wrote:
Hi,
The kernel is 3.14.0+ which is pulled just now.
Cc'ing more people.
While the hpsa driver appears to be involved in some way, I'm sure if
this is a
On Wed, 2014-04-09 at 16:08 -0700, James Bottomley wrote:
[+linux-scsi]
On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote:
On Wed, 2014-04-09 at 10:39 +0800, Baoquan He wrote:
Hi,
The kernel is 3.14.0+ which is pulled just now.
Cc'ing more people.
While the hpsa
On Wed, 2014-04-09 at 16:40 -0700, Davidlohr Bueso wrote:
On Wed, 2014-04-09 at 16:10 -0700, James Bottomley wrote:
On Wed, 2014-04-09 at 16:08 -0700, James Bottomley wrote:
[+linux-scsi]
On Wed, 2014-04-09 at 15:49 -0700, Davidlohr Bueso wrote:
On Wed, 2014-04-09 at 10:39 +0800
On Thu, 2014-04-10 at 19:52 +0200, Hannes Reinecke wrote:
On 04/10/2014 05:31 PM, Alan Stern wrote:
On Thu, 10 Apr 2014, Hannes Reinecke wrote:
On 04/10/2014 12:58 PM, Andreas Reis wrote:
That patch appears to work in preventing the crashes, judged on one
repeated appearance of the bug.
On Thu, 2014-04-10 at 18:24 -0700, Dan Williams wrote:
Hi Linus,
James might still be in the process of sending this your way. However,
given the proximity to -rc1, my reasoning for sending this directly is:
1/ It provides a tangible speed up for a non-esoteric use case (laptop
resume):
Your subject line is very tame. It should be the one line summary of
why we apply the patch, so it should read something like
hpsa: fix NULL deref in performant mode
On Thu, 2014-04-10 at 17:17 -0500, scame...@beardog.cce.hp.com wrote:
Without this, you'll see a null pointer dereference in
On Wed, 2014-02-19 at 01:06 +, Ben Hutchings wrote:
Matt Taggart reported that mvsas didn't bind to the Marvell
SAS controller on a Supermicro AOC-SAS2LP-MV8 board.
lspci reports it as:
01:00.0 RAID bus controller [0104]: Marvell Technology Group Ltd. Device
[1b4b:9485] (rev 03)
On Thu, 2014-04-17 at 11:07 +0800, xiangliang yu wrote:
hi,
The patch is support SATA PM device and can find all devices that is
attached to PM.
By PM you mean Port Multipilier not Power Management ... we can be
easily confused by the acronym, so I'd spell it out.
It also looks like the
deadlock caused by SCSI error handling
James Bottomley (2):
More USB deadlock fixes
Fix spurious request sense in error handling
scame...@beardog.cce.hp.com (1):
hpsa: fix NULL dereference in hpsa_put_ctlr_into_performant_mode()
And the diffstat:
drivers/scsi/hpsa.c | 8
On Fri, 2014-04-25 at 13:09 +0200, Christoph Hellwig wrote:
Hi Linus, hi James,
these are two simple use after free fixes that fix a regression introduced
by me in the first scsi update for 3.15-rc1.
I've sent them to the scsi list 10 days ago and haven't seen any reply to
them, and I'd
On Wed, 2014-03-19 at 23:35 +1100, Finn Thain wrote:
This patch series addresses several issues with NCR5380 drivers:
1. The complex network of #include directives.
2. Three inconsistent implementations of the core driver all attempting
to share the same macro definitions in NCR5380.h.
On Mon, 2014-04-28 at 11:03 +0200, Christoph Hellwig wrote:
On Fri, Apr 25, 2014 at 08:00:48AM -0700, James Bottomley wrote:
You should have received my git tree emails that they were already in
SCSI fixes ... didn't you? I certainly got a copy.
I've not seen a single reply to the patches
On Mon, 2014-04-28 at 18:16 -0700, Xiangliang Yu wrote:
Hi, Jan
I think below change may be better:
{ PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 },
Ben Hutchings already submitted a patch for this twice, which I cc'd you
on:
http://marc.info/?t=13927720393
will you ack it?
On Tue, 2014-04-29 at 15:15 +1200, Michael Schmitz wrote:
Finn,
On Tue, Apr 29, 2014 at 2:22 PM, Finn Thain fth...@telegraphics.com.au
wrote:
On Sat, 26 Apr 2014, James Bottomley wrote:
OK, so this is a pretty big change to an unmaintained driver. I'll take
it if you're willing
On Wed, 2014-04-30 at 17:40 +0800, ching wrote:
From: Chingching2...@areca.com.tw
Rewrite interrupt service routine relate function to fix command
timeout on controller very heavy loading.
OK, so I think you've confused us a bit. This looks to be an update of
your previous v1.4 patch set,
This is two patches both fixing bugs in drivers (virtio-scsi and
mpt2sas) causing an oops in certain circumstances.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Fam Zheng (1):
virtio-scsi: Skip setting
On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote:
On Wed, May 07, 2014 at 05:00:20AM -0400, vikas.chaudh...@qlogic.com wrote:
From: Vikas Chaudhary vikas.chaudh...@qlogic.com
Broadcom iscsi offload firmware uses a non standard ibft sign of BIFT.
Why? If it uses the
On Sat, 2014-05-10 at 22:38 +0800, loody wrote:
hi all:
I have a USB hard disk and when I play specific file.
it will show below message
( I purpose enable usb/storage/transport.c debug message about urb debug)
what makes me confused are
1. Does Unhandled sense code mean the SCSI Request
On Sun, 2014-05-11 at 00:43 +0800, loody wrote:
hi James:
2014-05-10 23:10 GMT+08:00 James Bottomley
james.bottom...@hansenpartnership.com:
On Sat, 2014-05-10 at 22:38 +0800, loody wrote:
hi all:
I have a USB hard disk and when I play specific file.
it will show below message
( I
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft a...@canonical.com
Suggested-by: James Bottomley james.bottom...@hansenpartnership.com
That is my patch, isn't it, just with a slightly modified comment:
http://marc.info/?l=linux-scsim=137908428211951
Andy promised
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft a...@canonical.com
BugLink: http://bugs.launchpad.net/bugs/1234417
This is a pretty low quality bug report; where's the analysis that
should be in your patch?
The problem is, is it not, that when you turn on trim we
On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote:
On 2014-05-16 18:14, James Bottomley wrote:
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft a...@canonical.com
Suggested-by: James Bottomley james.bottom...@hansenpartnership.com
That is my patch, isn't
On Fri, 2014-05-16 at 19:18 +0100, Ian Abbott wrote:
On 2014-05-16 18:58, James Bottomley wrote:
On Fri, 2014-05-16 at 18:39 +0100, Ian Abbott wrote:
On 2014-05-16 18:14, James Bottomley wrote:
On Fri, 2014-05-16 at 16:39 +0100, Ian Abbott wrote:
From: Andy Whitcroft a...@canonical.com
On Fri, 2014-05-16 at 15:38 +0200, Hannes Reinecke wrote:
On 05/15/2014 07:26 AM, Christoph Hellwig wrote:
Hi James,
we're past -rc5 and no SCSI patches have been collected for 3.16 yet,
despite a lot of patches including a lot of reviewed ones pending on the
list.
I'd really love
On Fri, 2014-05-16 at 15:01 -0700, James Bottomley wrote:
On Fri, 2014-05-16 at 15:38 +0200, Hannes Reinecke wrote:
On 05/15/2014 07:26 AM, Christoph Hellwig wrote:
Hi James,
we're past -rc5 and no SCSI patches have been collected for 3.16 yet,
despite a lot of patches including
a sense code (and some devices get
* confused by sense requests out of the blue)
*/
continue;
However, that last bit is a recent introduction:
commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e
Author: James Bottomley jbottom
On Thu, 2014-02-27 at 13:17 +0900, Yoshihiro YUNOMAE wrote:
+/* Maximum size of a local buffer for structured printk */
+#define SCSI_LOG_LINE_MAX 512
+
+/* Local buffer for structured printk */
+struct scsi_log_line {
+ int offset;
+ char buf[SCSI_LOG_LINE_MAX];
+};
This piece
On Wed, 2014-05-21 at 09:46 +1000, Stephen Rothwell wrote:
Hi Christoph,
On Mon, 19 May 2014 22:39:28 -0700 Christoph Hellwig h...@infradead.org
wrote:
On Tue, May 20, 2014 at 10:03:43AM +1000, Stephen Rothwell wrote:
Is this a request for inclusion of those branches into linux-next
On Thu, 2014-05-22 at 10:49 +, KY Srinivasan wrote:
-Original Message-
From: Andy Whitcroft [mailto:a...@canonical.com]
Sent: Wednesday, May 21, 2014 7:25 AM
To: Ian Abbott
Cc: linux-scsi@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan;
Haiyang Zhang; James
On Sat, 2014-05-24 at 12:35 +0200, Hannes Reinecke wrote:
[...]
I'm all for it. Removing never-really-implemented feature on obsolete
hardware is always a good idea.
Acked-by: Hannes Reinecke h...@suse.de
Wait, no, that's not a good idea. We leave obsolete drivers to bitrot.
Particularly
This is a single fix for a bug exposed by a sysfs change in 3.13 which
now causes libsas to trigger a warn on in device removal.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Joe Lawrence (1):
On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote:
On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote:
Wait, no, that's not a good idea. We leave obsolete drivers to bitrot.
Particularly we try not to touch them unless we have to because there
might be a few people still using them
On Mon, 2014-05-26 at 17:23 +0200, Paolo Bonzini wrote:
Il 26/05/2014 17:14, Bart Van Assche ha scritto:
scsi_put_command() is either invoked before a command is queued or
after a command has completed. scsi_cmnd.abort_work is scheduled
after a command has timed out and before it is
On Tue, 2014-05-27 at 10:06 +0200, Bart Van Assche wrote:
On 05/26/14 17:23, Paolo Bonzini wrote:
Il 26/05/2014 17:14, Bart Van Assche ha scritto:
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 88d46fe..c972eab 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
On Tue, 2014-05-27 at 09:49 +0200, Bart Van Assche wrote:
On 05/26/14 17:27, James Bottomley wrote:
On Mon, 2014-05-26 at 17:15 +0200, Bart Van Assche wrote:
Make it possible to test the REQ_ATOM_COMPLETE bit from outside the
block layer core.
I don't see the value of patches 2,3
On Tue, 2014-05-27 at 10:36 +0200, Bart Van Assche wrote:
On 05/27/14 10:09, James Bottomley wrote:
On Tue, 2014-05-27 at 10:06 +0200, Bart Van Assche wrote:
As you probably know scsi_put_command() can get called from softirq
context. A BUG_ON() in that context might make it unnecessary
On Tue, 2014-05-27 at 11:00 +0200, Bart Van Assche wrote:
On 05/27/14 10:23, James Bottomley wrote:
On Tue, 2014-05-27 at 09:49 +0200, Bart Van Assche wrote:
When reading the source code in scsi_error.c it's easy to overlook that
scmd_eh_abort_handler(), scsi_abort_command
On Tue, 2014-05-27 at 12:47 +0200, Paolo Bonzini wrote:
Il 27/05/2014 12:21, James Bottomley ha scritto:
I could also see us one day extending the TMF capability to abort any
running command, which would make even an assertion of block timed out
or completed invalid.
Actually
On Tue, 2014-05-27 at 13:52 +0200, Paolo Bonzini wrote:
Il 27/05/2014 13:26, James Bottomley ha scritto:
You could use a different mechanism than a softirq to tell the abort
were successful, for example by overriding scsi_done. But with respect
to the block layer, the mechanics of avoiding
On Tue, 2014-05-27 at 19:39 +0800, Vaughan Cao wrote:
This is a fix for commit:
39c60a0948cc06139e2fbfe084f83cb7e7deae3b sd: fix array cache flushing bug
causing performance problems
We must notify the block layer via q-flush_flags after temporary change the
cache_type to write through.
On Wed, 2014-05-28 at 03:56 -0700, Christoph Hellwig wrote:
James, can you take a look at this series? I would be great to get it
merged for 3.16!
Remind me how we're planning to fix the conversion bug in
scsilun_to_int, it doesn't seem to be in the patch series anymore... I
remember there
On Wed, 2014-05-28 at 16:15 -0400, Joe Lawrence wrote:
On Mon, 26 May 2014 17:12:27 +0200
Bart Van Assche bvanass...@acm.org wrote:
Every now and then someone asks how it is avoided that the SCSI error
handler and the SCSI completion handler are invoked concurrently for
the same SCSI
On Thu, 2007-04-05 at 15:36 -0700, David Miller wrote:
From: Andrew Burgess [EMAIL PROTECTED]
Date: Thu, 5 Apr 2007 15:13:27 -0700
David, do you see any other problems with scsi_send_eh_cmnd?
I've switched back to 2.6.18 which seems to not oops
and am happy to try patches.
Does
On Thu, 2007-04-05 at 17:15 -0700, David Miller wrote:
This won't work I believe.
There are cases that use smaller sense buffers than the minimum
specified by the SCSI layer.
One example is that do_sr_ioctl() stuff when the cgc passed
in has a sense buffer. That will only be as large as
On Thu, 2007-04-05 at 19:21 -0700, Andrew Burgess wrote:
2.6.20.4 with your patch dies in the memcpy (as does 21-gitN)
2.6.20.4 without your patch dies in the subsequent __free_page
with a null pointer ref at 000...008
James should I try your posted patch? On which kernel?
Well, mine will
On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote:
Yes. The 3w-.c driver changed between 2.6.18 and 2.6.20 but
nothing jumps out to my untrained eyes. Here's the diff:
Also, I should mention that the working kernel is a fedora
rpm (2.6.18-1.2798.fc6) so I don't know what patches are
Sorry, was waiting for a reply on this one ... didn't realise it hadn't
cc'd linux-scsi ...
James
On Tue, 2007-03-27 at 17:25 +0100, Hugh Dickins wrote:
I'm not using an initrd, most of my kernel is builtin,
just a few modules for occasional filesystems.
CONFIG_MODULES=y
CONFIG_SCSI=y
On Fri, 2007-04-06 at 08:51 -0700, Andrew Burgess wrote:
James Bottomley wrote:
It's actually a long standing bug in the 3w- driver. Apparently it
assumes request sense is always the use_sg == 0 case. This is what it
does on a request sense:
static int tw_scsiop_request_sense
On Fri, 2007-04-06 at 12:32 -0400, Douglas Gilbert wrote:
That last line should be:
request_buffer[7] = 10; /* minimum size per SPC: 18 bytes */
Er, yes, I'm afraid when I see n-7 I always think n is the lenght, not n
is the last byte ...
James
-
To unsubscribe from this list:
On Fri, 2007-04-06 at 11:32 -0700, David Miller wrote:
From: James Bottomley [EMAIL PROTECTED]
Date: Fri, 06 Apr 2007 10:27:57 -0500
On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote:
Yes. The 3w-.c driver changed between 2.6.18 and 2.6.20 but
nothing jumps out to my
instead and check the error result; free region if
setup fails. Should be functionally identical to the original except for
fixing the potential race.
Signed-off-by: Zachary Amsden [EMAIL PROTECTED]
Cc: James Bottomley [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/scsi
On Thu, 2007-04-12 at 16:27 -0500, Mike Miller (OS Dev) wrote:
This kconfig patch makes cciss dependent on scsi for the new SG_IO ioctl we
just
added. If cciss is built into the kernel it makes sures that scsi is also
statically
linked. If scsi is a module then cciss will also be built as a
Mon Sep 17 00:00:00 2001
From: James Bottomley [EMAIL PROTECTED]
Date: Fri, 6 Apr 2007 11:14:56 -0500
Subject: [SCSI] 3w-: fix oops caused by incorrect REQUEST_SENSE handling
3w- emulates a REQUEST_SENSE response by simply returning nothing.
Unfortunately, it's assuming
On Tue, 2007-04-17 at 11:20 -0400, Jeff Garzik wrote:
then, unless there are dependencies in libata-dev, how about Tejun
pushes patches 3-4 through scsi-misc as well?
Sure ... as long as there are no dependencies.
James
-
To unsubscribe from this list: send the line unsubscribe linux-scsi
On Tue, 2007-04-17 at 10:45 -0400, Jeff Garzik wrote:
ACK patches 3-4 for upstream. I'm dropping them, and requesting resend
when patches 1-2 are applied (which I also ACK). Or, alternately, I
could apply all four patches with the other subsystem owner's assent, or
the other subsystem
On Wed, 2007-04-18 at 02:09 +0900, Tejun Heo wrote:
James, are you going to rebase scsi-misc-2.6 before sending to Linus
when 2.6.22-rc1 window opens? If not, Jeff can pull it into libata-dev
and patch 3 and 4 can go in there. The difference in libata between
scsi-misc-2.6 and libata-dev is
On Wed, 2007-04-18 at 10:21 +0200, Johann Lombardi wrote:
We have observed noticeable performance improvement by using large single
command data transfers (up to 4MB) with some storage subsystems such as DDN's.
The patch below adds a new config option (CONFIG_SCSI_LARGE_SG) which allows
to
On Thu, 2007-04-19 at 09:25 -0400, Josef Bacik wrote:
Looking through everything I came to the conclusion that we don't really need
the scsi_sysfs_add_devices in scsi_finish_async_scan, which gets run everytime
we do a do_scan_async. In doing the scanning, if we come upon anything we
will
On Thu, 2007-04-19 at 15:09 +, Miller, Mike (OS Dev) wrote:
Nak. You still haven't told where you saw these warnings. What compiler
are you using? I do not see these in my 32-bit environment.
I think it's seen with CONFIG_LBD=n on 32 bits
In that configuration, sector_t is a u32 (it's u64
1001 - 1100 of 2722 matches
Mail list logo
