Re: [PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-08-26 Thread James Bottomley
On Mon, 2013-08-26 at 08:41 +0530, Sujit Reddy Thumma wrote: On 8/23/2013 11:47 PM, James Bottomley wrote: On Tue, 2013-07-30 at 00:35 +0530, Santosh Y wrote: From: Sujit Reddy Thumma sthu...@codeaurora.org As part of device initialization sequence, sending NOP OUT UPIU and waiting

Re: [PATCH v4 00/10] SCSI: esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver

2013-08-26 Thread James Bottomley
On Fri, 2013-08-23 at 10:35 -0400, Bradley Grove wrote: This is a new driver for ATTO Technology's ExpressSAS series of hardware RAID adapters. It supports the following adapters: - ExpressSAS R60F - ExpressSAS R680 - ExpressSAS R608 - ExpressSAS R644 OK, I put this in

Re: [PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-26 Thread James Bottomley
On Mon, 2013-08-26 at 12:14 +0800, 黃清隆 wrote: From: Ching ching2...@areca.com.tw Support Areca new SATA Raid adapter ARC1214/1224/1264/1284. Modify maximum outstanding command number, notify command complete with auto request sense Signed-off-by: Ching ching2...@areca.com.tw Checkpatch

Re: [PATCH 3/3] arcmsr: Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface

2013-08-26 Thread James Bottomley
On Mon, 2013-08-26 at 12:28 +0800, 黃清隆 wrote: From: Ching ching2...@areca.com.tw Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface. Signed-off-by: Ching ching2...@areca.com.tw --- This one has a set of nasty checkpatch errors: WARNING: please, no spaces at the start of

Re: [TRIVIAL PATCH 0/2] Fix warnings in kernel build

2013-08-26 Thread James Bottomley
On Mon, 2013-08-26 at 13:06 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com The patch to add uevents for certain Unit Attention codes had a couple of problems which were found by a kbuild test robot. Sorry about that, I will be more careful next time. I already did both of

Re: [PATCH 00/29] Update driver to 8.06.00.08-k

2013-08-27 Thread James Bottomley
On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: Hi James, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Patch 26/29 is missing. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

Re: [PATCH v5 1/4] [SCSI] sg: use rwsem to solve race during exclusive open

2013-08-27 Thread James Bottomley
On Mon, 2013-07-22 at 12:40 +0800, Vaughan Cao wrote: A race condition may happen if two threads are both trying to open the same sg with O_EXCL simultaneously. It's possible that they both find fsds list is empty and get_exclude(sdp) returns 0, then they both call set_exclude() and break out

Re: [PATCH 02/29] qla2xxx: Add support for ISP8044.

2013-08-28 Thread James Bottomley
On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: From: Atul Deshmukh atul.deshm...@qlogic.com You seem to have stopped running your stuff through checkpatch: WARNING: please, no spaces at the start of a line #317: FILE: drivers/scsi/qla2xxx/qla_gbl.h:479: +uint8_t *, uint32_t,

Re: [PATCH v6 1/4] sg: use rwsem to solve race during exclusive open

2013-08-28 Thread James Bottomley
On Wed, 2013-08-28 at 18:07 +0800, Vaughan Cao wrote: @@ -331,17 +330,20 @@ sg_open(struct inode *inode, struct file *filp) } if ((sfp = sg_add_sfp(sdp, dev))) filp-private_data = sfp; - else { + /* retval is already provably zero at this

re: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-28 Thread James Bottomley
Dan Carpenter dan.carpen...@oracle.com wrote: Hello 黃清隆, The patch 17628f3a062b: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 from Aug 26, 2013, leads to the following Smatch warning: drivers/scsi/arcmsr/arcmsr_hba.c:3580 arcmsr_hbaD_get_config() warn:

Re: [RFC/PATCH 2/2] scsi: ufs: requests completion handling

2013-08-29 Thread James Bottomley
On Thu, 2013-08-29 at 11:54 +0300, Raviv Shvili wrote: The patch solves the request completion report order. At the current implementation, when multiple requests end at the same interrupt call, the requests reported as completed according to a bitmap scan from the lowest tags to the highest,

Re: [PATCH 1/1 v1.1] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 (Resend renew)

2013-08-29 Thread James Bottomley
On Thu, 2013-08-29 at 12:55 +0800, 黃清隆 wrote: Update the patch code. From: Chingching2...@areca.com.tw Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284. Modify maximum outstanding command number. Notify command complete with auto request sense. Fix bug of updating adapter

Re: [RFC/PATCH 2/2] scsi: ufs: requests completion handling

2013-08-29 Thread James Bottomley
On Thu, 2013-08-29 at 20:37 +0300, Yaniv Gardi wrote: Hi James, See reply inline Thanks, Yaniv -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of James Bottomley Sent: Thursday, August 29, 2013 12:28 PM To: Raviv

[GIT PULL] SCSI fixes for 3.11-rc7

2013-08-31 Thread James Bottomley
This is a bug fix for the pm80xx driver. It turns out that when the new hardware support was added in 3.10 the IO command size was kept at the old hard coded value. This means that the driver attaches to some new cards and then simply hangs the system. The patch is available here:

[GIT PULL] First round of SCSI updates for the 3.11+ merge window

2013-09-03 Thread James Bottomley
This patch set is a set of driver updates (ufs, zfcp, lpfc, mpt2/3sas, qla4xxx, qla2xxx [adding support for ISP8044 + other things]) we also have a new driver: esas2r which has a number of static checker problems, but which I expect to resolve over the -rc course of 3.12 under the new driver

Re: ATTO 6G SAS/SATA HBA Driver

2013-09-03 Thread James Bottomley
On Tue, 2013-09-03 at 13:11 -0400, Bradley Grove wrote: James, Now that we are finishing up development for our esas2r driver, we are planning to start work on a kernel driver for our PM8001 based 6G SAS/SATA HBA product. We have some questions about the best way to proceed. While we

Re: [PATCH v2] scsi: sr: use block layer runtime PM

2013-09-06 Thread James Bottomley
On Fri, 2013-09-06 at 10:01 +0800, Aaron Lu wrote: Migrate SCSI Optical Disk Drive(ODD) I'm not very keen on this description because it's not quite accurate. sr stands for SCSI ROM. You could say optical SCSI ROM perhaps, but Magneto Optical disks are handled by sd not sr. driver sr to make

Re: [PATCH/RESEND 2/2] Hard disk S3 resume time optimization

2013-09-06 Thread James Bottomley
On Thu, 2013-09-05 at 17:44 -0700, Todd E Brandt wrote: Part 2 of the hard disk resume optimization patch, this one applies to the scsi subsystem. This is a horrible patch description, it won't tell the next reader anything about what is going on and why. Give the patches two separate

Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread James Bottomley
On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel wrote: Code to reset fc_host statistics. echo 1 /sys/class/fc_host/hostX/statistics/reset_statistics clears fc_host stats, the code also issues command to fnic firmware to clear vnic stats. Signed-off-by: Narsimhulu Musini nmus...@cisco.com

Re: [PATCH 1/6] SCSI: esas2r: smatch - Use biwise rather than logical AND for checking if any bit set

2013-09-06 Thread James Bottomley
On Thu, 2013-08-29 at 15:55 -0400, Bradley Grove wrote: Signed-off-by: Bradley Grove bgr...@attotech.com This additional SCSI: in the subject is unnecessary and just causes me extra work to remove it. There should be a Reported-by: before the signoff indicating whoever you got the report from

Re: [PATCH 1/2] megaraid_sas: Add High Availability clustering support using shared Logical Disks

2013-09-06 Thread James Bottomley
On Sat, 2013-08-31 at 16:54 -0700, adam radford wrote: --- scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c 2013-08-31 16:17:56.909172648 -0700 +++ scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c 2013-08-31 16:24:51.861078589 -0700 @@ -77,9 +77,12 @@

Re: [PATCH] ibmvscsi: Fix little endian issues

2013-09-06 Thread James Bottomley
On Tue, 2013-09-03 at 10:04 +1000, Anton Blanchard wrote: The hypervisor is big endian, so little endian kernel builds need to byteswap. Signed-off-by: Anton Blanchard an...@samba.org You have two serious checkpatch errors in this: ERROR: trailing whitespace #57: FILE:

Re: [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated

2013-09-06 Thread James Bottomley
On Fri, 2013-09-06 at 20:51 +, Hiral Patel (hiralpat) wrote: Hi James, Yes for this patch Narsimhulu Musini is the author of this patch. Thanks, Hiral On 9/6/13 10:35 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2013-08-29 at 10:57 -0700, Hiral Patel

Re: [PATCH 4/6] scsi: ufs: add unipro attribute IDs

2013-09-06 Thread James Bottomley
On Sat, 2013-08-31 at 21:40 +0530, Santosh Y wrote: From: Seungwon Jeon tgih@samsung.com 'drivers/scsi/ufs/unipro.h' is added. Attributes in the layers of the UNIPRO stack can be read and written via the DME. A dangling unused header file is a bit of a strange commit. I merged it into

Re: [BusLogic] DMA-API: device driver failed to check map error

2013-09-10 Thread James Bottomley
Add missing cc of linux-scsi On Tue, 2013-09-10 at 15:03 +0900, Tetsuo Handa wrote: Hello. I got below warning on current linux.git . -- [2.612237] scsi: * BusLogic SCSI Driver Version 2.1.16 of 18 July 2002 * [2.613067] scsi: Copyright 1995-1998 by Leonard N.

Re: [PATCH] [scsi] enclosure: remove all possible sysfs entries before add device

2013-09-10 Thread James Bottomley
if will adding device's symlink existed or no. The description doesn't look helpful. The problem, presumably in a remove/re-add test that the add event gets processed before the remove event, which is why the link is still there? Cc: James Bottomley james.bottom...@hansenpartnership.com Signed-off-by: Joe

Re: [PATCH] [scsi] enclosure: remove all possible sysfs entries before add device

2013-09-10 Thread James Bottomley
On Tue, 2013-09-10 at 09:50 +0800, Joe Jin wrote: On 09/09/13 21:41, Christoph Hellwig wrote: Modules linked in: oracleacfs(P)(U) oracleadvm(P)(U) oracleoks(P)(U) Please reproduce without this weird crap loaded. These modules is filesystem and will not impact enclosure. That's not

Re: [PATCH][SCSI] megaraid_sas: addded support for big endian architecture

2013-09-10 Thread James Bottomley
On Fri, 2013-09-06 at 15:50 +0530, sumit.sax...@lsi.com wrote: This patch will add big endian architecture support to megaraid_sas driver. The support added is for LSI MegaRAID all generation controllers- (3Gb/s, 6Gb/s and 12 Gb/s controllers). This patch will be applied on top of recently

Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's

2013-09-10 Thread James Bottomley
On Wed, 2013-09-04 at 15:05 -0500, Mike Miller wrote: Patch 1 of 4 From: Mike Miller mike.mil...@hp.com Just for future reference, doing it this way means I have to edit the patch. The way git am works when applying patches is that if the first body line is a keyword it recognises (like

Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's

2013-09-10 Thread James Bottomley
On Tue, 2013-09-10 at 22:17 +, Miller, Mike (OS Dev) wrote: -Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Tuesday, September 10, 2013 5:02 PM To: Miller, Mike (OS Dev) Cc: Andrew Morton; LKML; LKML-scsi Subject: Re: [PATCH 1/4

Re: [PATCH 2/9] fnic: host reset returns nonzero value(errno) on success

2013-09-11 Thread James Bottomley
On Mon, 2013-09-09 at 13:31 -0700, Hiral Patel wrote: From: Narsimhulu Musini nmus...@cisco.com Fixed appropriate error codes that returns -1 on failure, and 0 on success This is about as undescriptive as they come. What you mean is that fnic_reset() is used directly by the fc transport

Re: [PATCH 8/9] fnic: Fnic Statistics Collection

2013-09-11 Thread James Bottomley
On Mon, 2013-09-09 at 13:31 -0700, Hiral Patel wrote: This feature gathers active and cumulative per fnic stats for io, abort, terminate, reset, vlan discovery path and it also includes various important stats for debugging issues. It also provided debugfs and ioctl interface for user to

Re: [PATCH 0/4] Hyper-V TRIM support

2013-09-13 Thread James Bottomley
On Fri, 2013-09-13 at 13:58 +0100, Andy Whitcroft wrote: tl;dr -- enable TRIM support for Hyper-V emulated disks. The Hyper-V hypervisor can support TRIM for its devices, advertising this via the appropriate VPD pages. However the emulated disks only claim to be SPC-2 devices. According to

Re: [patch 1/5] drivers/scsi/a100u2w.c: convert to module_pci_driver

2013-09-13 Thread James Bottomley
On Fri, 2013-09-13 at 14:52 -0700, a...@linux-foundation.org wrote: From: Libo Chen clbchenlibo.c...@huawei.com Subject: drivers/scsi/a100u2w.c: convert to module_pci_driver Use module_pci_driver instead of init/exit, make code clean. To be honest, I don't really agree that any of these

[GIT PULL] Final round of SCSI updates for the 3.11+ merge window

2013-09-15 Thread James Bottomley
This patch set is a set of driver updates (megaraid_sas, fnic, lpfc, ufs, hpsa) we also have a couple of bug fixes (sd out of bounds and ibmvfc error handling) and the first round of esas2r checker fixes and finally the much anticipated big endian additions for megaraid_sas. The patch is

Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver

2013-09-17 Thread James Bottomley
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After

Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver

2013-09-17 Thread James Bottomley
On Tue, 2013-09-17 at 16:29 +0200, Hannes Reinecke wrote: On 09/17/2013 04:13 AM, Doug Ledford wrote: Yes, this driver is well past ready to be removed. Acked-by: Doug Ledford dledf...@redhat.com Sent from my ASUS Pad Paul Gortmaker paul.gortma...@windriver.com wrote: After

Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()

2013-09-23 Thread James Bottomley
On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote: Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound), the driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-24 Thread James Bottomley
On Tue, 2013-09-24 at 11:37 +0200, Paolo Bonzini wrote: Il 21/09/2013 00:03, Martin K. Petersen ha scritto: The major headache here of course is that WRITE SAME is inherently destructive. We can't just fire off one during discovery and see if it works. For WRITE you can issue a command

Re: SCSI core patches for kernel 3.12

2013-10-02 Thread James Bottomley
And I thought the world was ending when Linus started top posting ... On Wed, 2013-10-02 at 00:40 -0700, Christoph Hellwig wrote: James, and comments on this? You mean apart from the fact that it's a long series which seems to self confess to providing not much value and therefore not rating

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread James Bottomley
On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: -Original Message- From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] On Behalf Of Geert Uytterhoeven Sent: Wednesday, September 25, 2013 1:40 AM To: KY Srinivasan Cc: Mike Christie; Jack Wang; Greg

Re: Drivers: scsi: FLUSH timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 15:02 +, KY Srinivasan wrote: -Original Message- From: Eric Seppanen [mailto:e...@purestorage.com] Sent: Thursday, October 03, 2013 1:49 PM To: Nicholas A. Bellinger Cc: KY Srinivasan; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

Re: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 12:38 -0700, K. Y. Srinivasan wrote: Rather than having a separate constant for specifying the timeout on FLUSH operations, use the basic I/O timeout value that is already configurable on a per target basis to derive the FLUSH timeout. Looking at the current definitions

Re: [PATCH 1/1] Drivers: scsi: Derive the FLUSH_TIMEOUT from the basic I/O timeout

2013-10-04 Thread James Bottomley
On Fri, 2013-10-04 at 22:01 +, KY Srinivasan wrote: -Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Friday, October 04, 2013 2:42 PM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de

Re: [PATCH] eisa: standardize on eisa_register_driver like similar bus registrations

2013-10-07 Thread James Bottomley
On Mon, 2013-10-07 at 16:02 -0400, David Miller wrote: From: Matthew Whitehead tedheads...@gmail.com Date: Sat, 5 Oct 2013 22:35:58 -0400 The other buses (isa, pci, pnp, parport, usb, tty, etc) all use the convention of ${BUSNAME}_register_driver. Rewrite the little remaining code that

Re: [Bug 62811] New: Don't Modify the scsi subcmd as LUN value when using VENDOR cmd

2013-10-10 Thread James Bottomley
On Thu, 2013-10-10 at 17:22 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=62811 Bug ID: 62811 Summary: Don't Modify the scsi subcmd as LUN value when using VENDOR cmd Product: SCSI Drivers

Re: Is there any plan to support 64bit lun in mainline?

2013-10-14 Thread James Bottomley
repository. However, there are two other patchsets pending (EH Deadline and asynchronous command aborts), both of which have been tested thoroughly _and_ have acked-by from various other parties. None of these patchset had received any feedback from James Bottomley, let alone any indication

Re: Is there any plan to support 64bit lun in mainline?

2013-10-15 Thread James Bottomley
Ok may be brief: on top of cliff with fleeting mobile signal. Hannes Reinecke h...@suse.de wrote: On 10/14/2013 08:30 PM, James Bottomley wrote: On Mon, 2013-10-14 at 12:32 +0200, Hannes Reinecke wrote: [ .. ] However, there are two other patchsets pending (EH Deadline and asynchronous

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-16 Thread James Bottomley
On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: This patchs adds an 'eh_deadline' sysfs attribute to the scsi host which limits the overall runtime of the SCSI EH. The 'eh_deadline' value is stored in the now obsolete field 'resetting'. When a command is failed the start time of the

Re: [PATCH 1/3] scsi: Fix erratic device offline during EH

2013-10-16 Thread James Bottomley
On Mon, 2013-09-02 at 13:58 +0200, Hannes Reinecke wrote: Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8 (Handle disk devices which can not process medium access commands) was introduced to offline any device which cannot process medium access commands. However, commit

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-16 Thread James Bottomley
On Tue, 2013-10-08 at 09:45 -0400, Douglas Gilbert wrote: On 13-10-08 02:44 AM, vaughan wrote: Hi Madper, CC to Douglas to get comments. I use the rw_semaphore o_sem to protect excl open, introduced in commit 15b06f9a02406e5460001db6d5af5c738cd3d4e7 since v3.12-rc1. Is it forbidden to

Re: [PATCH][SCSI] megaraid_sas: Fix synchronization problem between sysPD IO path and AEN path

2013-10-16 Thread James Bottomley
On Wed, 2013-10-16 at 17:04 +0530, sumit.sax...@lsi.com wrote: There is syncronization problem between sysPD IO path and AEN path. Driver maintains instance-pd_list[] array, which will get updated(by calling function megasas_get_pd_list[]), whenever any of below events occurs-

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-16 Thread James Bottomley
On Tue, 2013-10-15 at 19:40 -0700, Praveen Murali wrote: Yes, I checked that today and was meaning to ask you about it. :) Ideally, I need someone from Marvell to ack it ... can you prod them? Thanks, James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-23 Thread James Bottomley
On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: On 13-10-22 04:56 PM, Simon Kirby wrote: Hello! While trying to figure out why the request queue to sda (ext4) was clogging up on one of our btrfs backup boxes, I noticed a megarc process in D state, so enabled locking debugging,

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 11:25 +0200, Hannes Reinecke wrote: On 10/16/2013 09:22 PM, James Bottomley wrote: On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: This patchs adds an 'eh_deadline' sysfs attribute to the scsi host which limits the overall runtime of the SCSI EH

Re: [GIT PULL] SCSI fixes for 3.12-rc6

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 13:07 +0100, Linus Torvalds wrote: On Wed, Oct 23, 2013 at 12:27 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes No it's not. Already up-to-date

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 05:11 -0700, Josh Boyer wrote: On Wed, Oct 23, 2013 at 12:44 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: On 13-10-22 04:56 PM, Simon Kirby wrote: Hello! While trying to figure out

Re: [GIT PULL] SCSI fixes for 3.12-rc6

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 13:42 +0100, Linus Torvalds wrote: You need to think about *WHY* we had a new driver exception. And realize that it probably will never actually be relevant for any SCSI driver (not counting things like USB storage etc). OK, point taken, here's the new pull request

Re: self assignment bug in aix94xx

2013-10-24 Thread James Bottomley
On Thu, 2013-10-24 at 04:55 -0400, Dave Jones wrote: 2908d778(James Bottomley2006-08-29 09:22:51 -0500 515) scb-ssp_task.retry_count = scb-ssp_task.retry_count; Is this supposed to maybe be.. scb-ssp_task.retry_count = task-ssp_task.retry_count; ? Oh

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-25 Thread James Bottomley
On Thu, 2013-10-24 at 17:37 -0700, Simon Kirby wrote: On Wed, Oct 23, 2013 at 10:10:47AM -0400, Douglas Gilbert wrote: On 13-10-23 03:44 AM, James Bottomley wrote: On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: On 13-10-22 04:56 PM, Simon Kirby wrote: Hello! While trying

[GIT PULL] SCSI fixes for 3.12-rc7

2013-10-28 Thread James Bottomley
] sg_open+0x3a0/0x4d0 The fix is large, so at this late stage we'd like to revert the functionality and start again in the next merge window. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: James Bottomley (4): Revert sg

Re: arcmsr driver update

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 16:14 +0100, Markus Blank-Burian wrote: Dear all, two month ago, there was a patch submitted by the company areca regarding their in-kernel driver: [PATCH v1.2 1/1] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 The patch never made it to the list

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 22:10 +0300, Dan Carpenter wrote: If fibsize is zero then it leads to a ZERO_SIZE_PTR dereference when we dereference user_srbcmd. Due to a missing capable() check in the compat ioctls then this error can be triggered without CAP_SYS_RAWIO. I have fixed that in a

Re: [PATCH] [SCSI] hpsa: fix return value check in start_controller_lockup_detector()

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 11:09 -0500, scame...@beardog.cce.hp.com wrote: On Tue, Oct 29, 2013 at 02:43:56PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function kthread_run() returns ERR_PTR() and never returns NULL. The NULL test in the

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 14:36 +0100, Hannes Reinecke wrote: On 10/31/2013 04:49 PM, Christoph Hellwig wrote: Looks reasonable to me, but a few minor nitpicks: + spin_lock_irqsave(sdev-host-host_lock, flags); + if (scsi_host_eh_past_deadline(sdev-host)) { I don't have the

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 15:46 +0100, Hannes Reinecke wrote: On 11/04/2013 03:25 PM, James Bottomley wrote: On Mon, 2013-11-04 at 14:36 +0100, Hannes Reinecke wrote: On 10/31/2013 04:49 PM, Christoph Hellwig wrote: Looks reasonable to me, but a few minor nitpicks

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 16:43 +0100, Hannes Reinecke wrote: On 11/04/2013 03:50 PM, James Bottomley wrote: On Mon, 2013-11-04 at 15:46 +0100, Hannes Reinecke wrote: On 11/04/2013 03:25 PM, James Bottomley wrote: On Mon, 2013-11-04 at 14:36 +0100, Hannes Reinecke wrote: On 10/31/2013 04:49

Re: [PATCH 2/5] scsi: improved eh timeout handler

2013-11-09 Thread James Bottomley
On Thu, 2013-11-07 at 07:45 +0100, Hannes Reinecke wrote: On 11/06/2013 06:23 PM, Mike Christie wrote: On 11/05/2013 10:48 PM, Hannes Reinecke wrote: On 11/05/2013 08:19 PM, Mike Christie wrote: On 11/04/2013 11:05 PM, Hannes Reinecke wrote: + +scmd-eh_eflags |=

[GIT PULL] First round of SCSI updates for the 3.11+ merge window

2013-11-09 Thread James Bottomley
advansys: Remove 'last_reset' references dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset dpt_i2o: Remove DPTI_STATE_IOCTL Hiral Patel (2): fnic: Incremented driver version fnic: Fnic Statistics Collection Jack Wang (1): export device_busy for sdev James Bottomley (1

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread James Bottomley
On Tue, 2013-11-12 at 17:10 -0800, David Decotigny wrote: This patch avoids to use an object after it was potentially reclaimed by scsi_device_put(). The analysis is wrong, I'm afraid. __scsi_remove_device() does the final put for devices that are being destroyed. If the device isn't in the

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread James Bottomley
On Tue, 2013-11-12 at 18:09 -0800, David Decotigny wrote: I was considering the following scenario wherein the if (scsi_device_created(sdev)) test at the end would test garbage at best (or unmapped data): Well, no, the counting isn't right: if (!(sdev =

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-13 Thread James Bottomley
On Wed, 2013-11-13 at 18:50 -0800, David Decotigny wrote: Hello, Thank you for looking into this. I could reproduce the oops on some Dell Poweredge R720 with the following config flags, otherwise the problem goes un-noticed: CONFIG_DEBUG_PAGEALLOC=y CONFIG_DEBUG_SLAB=y [4.924033]

Re: [Bug 64171] Block SCSI Generic Driver does not keep data

2013-11-15 Thread James Bottomley
On Sat, 2013-11-02 at 17:09 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=64171 --- Comment #2 from d gilbert dgilb...@interlog.com --- On 13-11-01 03:49 PM, bugzilla-dae...@bugzilla.kernel.org wrote:

Re: [PATCH 1/1] enclosure: fix WARN_ON in dual path device removing

2013-11-15 Thread James Bottomley
On Fri, 2013-11-15 at 10:46 -0600, wenxi...@linux.vnet.ibm.com wrote: The issue is happened in dual controller configuration. We got the sysfs warnings when rmmod the ipr module. enclosure_unregister() in drivers/msic/enclosure.c, call device_unregister() for each componment deivce,

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-16 Thread James Bottomley
On Thu, 2013-11-07 at 16:16 -0500, Phillip Susi wrote: On 11/7/2013 1:21 PM, Douglas Gilbert wrote: On 13-11-06 08:57 PM, Phillip Susi wrote: Don't bother forcing disks to spin up on resume, as they will do so automatically when accessed, and forcing them to spin up slows down the resume.

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

2013-11-16 Thread James Bottomley
On Mon, 2013-11-11 at 09:58 +0100, Jack Wang wrote: Hi James, About this gpio feature, do you think it's OK to implement with IOCTL Definitely not via another strange ioctl or we can use exist bsg interface in libsas and add another function call? My default thought is that it should go

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-16 Thread James Bottomley
On Sat, 2013-11-16 at 22:50 -0500, Phillip Susi wrote: On 11/16/2013 01:20 PM, James Bottomley wrote: No disk does, neither SCSI nor ATA. The error handler is not automatically activated for a not ready/initializing command required because of multi-path. We override the default

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. You pointlessly renamed a variable, which makes the diff hard to read. Please don't do

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 11:15 -0500, Phillip Susi wrote: On 11/17/2013 01:43 AM, James Bottomley wrote: OK, so three people have now told you that's not how the code works. Why don't you just read it? because there's not really much point us reading your patches until you do. I have

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 15:51

Re: Question on SCSI target scan

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 00:52 -0700, Ramesh Chikkanayakanahally wrote: Thanks for the response. If using RSCN sounds like a reasonable approach in this scenario (protocol limitations), then as per the original question - would it be acceptable to add an interface in scsi_transport_fc layer,

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: 2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09

Re: [PATCH] scsi: Add missing sysfs attribute to scsi_device structure

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 12:59 -0500, Ewan Milne wrote: On Mon, 2013-11-18 at 09:45 -0800, James Bottomley wrote: On Mon, 2013-11-18 at 12:10 -0500, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com This change adds a missing sysfs attribute to scsi_device which is set when

Re: [LWN] Linux 3.13-rc1 is out

2013-11-23 Thread James Bottomley
On Sat, 2013-11-23 at 11:52 -0500, Douglas Gilbert wrote: With a three week window we see this: ChangeLog: ... James Bottomley (1): first round of SCSI updates ... That begs the question: was there nothing suitable for a second round? As you probably picked up from

Re: [mptscsih] Watchdog detected hard LOCKUP on cpu 0

2013-11-25 Thread James Bottomley
On Mon, 2013-11-25 at 02:48 -0500, George Spelvin wrote: I first reported this in mid-October, but I've been AFK for a month and haven't done anything about it in that time. Basically, sustained linear reads from 6 (7200 RPM 2 TB) disks on a BR10i controller causes a hard lockup. Anyway, I

Re: swiotlb buffer is full with 3.13-rc1+ but not 3.4.

2013-11-30 Thread James Bottomley
On Sat, 2013-11-30 at 13:56 -0500, Konrad Rzeszutek Wilk wrote: My theory is that the SWIOTLB is not full - it is just that the request is for a compound page that is more than 512kB. Please note that SWIOTLB highest chunk of buffer it can deal with is 512kb. And that is of course the

Re: [PATCH v2] sg: relax 16 byte cdb restriction

2013-11-30 Thread James Bottomley
On Wed, 2013-10-30 at 18:25 -0400, Douglas Gilbert wrote: This is essentially the same patch sent 6 weeks ago: http://marc.info/?l=linux-scsim=137943733409512w=2 re-based on '[PATCH v2] sg: O_EXCL and other lock handling'. ChangeLog: - remove the 16 byte CDB (SCSI command) length

Re: [PATCH 03/11] hpsa: add 5 second delay after doorbell reset

2013-12-01 Thread James Bottomley
On Fri, 2013-11-08 at 09:31 -0600, scame...@beardog.cce.hp.com wrote: On Fri, Nov 08, 2013 at 04:02:20PM +0100, Tomas Henzl wrote: On 11/08/2013 03:44 PM, scame...@beardog.cce.hp.com wrote: On Fri, Nov 08, 2013 at 02:51:37PM +0100, Tomas Henzl wrote: On 11/07/2013 05:45 PM, Stephen M.

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix SCSILIB_ to macro SP

2013-12-01 Thread James Bottomley
On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote: On 12/02/2013 12:17 AM, Bart Van Assche wrote: On 11/27/13 03:29, Chen Gang wrote: the macro SP is too common to make conflict with some architectures, so recommend to add prefix for it. The related warning (with allmodconfig for

Re: [PATCH 03/11] hpsa: add 5 second delay after doorbell reset

2013-12-02 Thread James Bottomley
On Mon, 2013-12-02 at 11:15 -0600, Mike Miller wrote: On Sat, Nov 30, 2013 at 04:42:02PM -0800, James Bottomley wrote: On Fri, 2013-11-08 at 09:31 -0600, scame...@beardog.cce.hp.com wrote: On Fri, Nov 08, 2013 at 04:02:20PM +0100, Tomas Henzl wrote: On 11/08/2013 03:44 PM, scame

Re: [PATCH 01/11] hpsa: use workqueue instead of kernel thread for lockup detection

2013-12-02 Thread James Bottomley
On Thu, 2013-11-07 at 10:45 -0600, Stephen M. Cameron wrote: From: Stephen M. Cameron scame...@beardog.cce.hp.com Much simpler and avoids races starting/stopping the thread. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Actually, perhaps you do need to resubmit the series:

Re: [PATCH V2 4/4] pm80xx: Tasklets synchronization fix.

2013-12-02 Thread James Bottomley
On Wed, 2013-11-13 at 05:36 -0800, Anand wrote: From 9dda7700201be93d4d2b83c2733be3d582859bc7 Mon Sep 17 00:00:00 2001 From: Nikith Ganigarakoppal nikith.ganigarakop...@pmcs.com Date: Mon, 11 Nov 2013 15:28:14 +0530 Subject: [PATCH V2 4/4] pm80xx: Tasklets synchronization fix. When multiple

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-02 Thread James Bottomley
On Mon, 2013-12-02 at 16:12 -0600, Alireza Haghdoost wrote: Hi, We are working on a very high I/O throughput application and facing with a challenge to send the I/O request to a SAN drive in-order. I would appreciate if you can help us with an explanation about this unexpected behavior

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 13:26 +0100, Bart Van Assche wrote: On 12/03/13 00:38, James Bottomley wrote: Well this would be because we don't guarantee order at any granularity below barriers. We won't reorder across barriers but below them we can reorder the commands and, of course, we use

Re: [PATCH 7/8] bfa: Fix crash when symb name set for offline vport

2013-12-03 Thread James Bottomley
On Tue, 2013-11-19 at 23:05 -0800, vmo...@brocade.com wrote: From: Vijaya Mohan Guvva vmo...@brocade.com This patch fixes a crash when tried setting symbolic name for an offline vport through sysfs. Crash is due to uninitialized pointer lport-ns, which gets initialized only on linkup (port

Re: [PATCH 7/8] bfa: Fix crash when symb name set for offline vport

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 07:38 -0700, Vijaya Mohan Guvva wrote: On Tue, 2013-11-19 at 23:05 -0800, vmo...@brocade.com wrote: From: Vijaya Mohan Guvva vmo...@brocade.com This patch fixes a crash when tried setting symbolic name for an offline vport through sysfs. Crash is due to

Re: swiotlb buffer is full with 3.13-rc1+ but not 3.4.

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 12:33 -0500, Konrad Rzeszutek Wilk wrote: On Sat, Nov 30, 2013 at 03:48:44PM -0500, James Bottomley wrote: On Sat, 2013-11-30 at 13:56 -0500, Konrad Rzeszutek Wilk wrote: My theory is that the SWIOTLB is not full - it is just that the request is for a compound page

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 11:46 -0600, Alireza Haghdoost wrote: On Tue, Dec 3, 2013 at 7:25 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: Well, no, we could have used Ordered instead of Simple tags ... that would preserve submission order according to spec. This wouldn't

Re: [PATCH 01/11] hpsa: use workqueue instead of kernel thread for lockup detection

2013-12-04 Thread James Bottomley
On Wed, 2013-12-04 at 10:31 -0600, scame...@beardog.cce.hp.com wrote: On Mon, Dec 02, 2013 at 10:00:02AM -0800, James Bottomley wrote: On Thu, 2013-11-07 at 10:45 -0600, Stephen M. Cameron wrote: From: Stephen M. Cameron scame...@beardog.cce.hp.com Much simpler and avoids races

[GIT PULL] SCSI fixes for 3.13-rc2

2013-12-06 Thread James Bottomley
and then firmware has been choking on the commands). The rest are various crash, hang or warn driver fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dan Williams (1): libsas: fix usage of ata_tf_to_fis James

<    4   5   6   7   8   9   10   11   12   13   >