Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com writes:
Add MSI-x interrupt mode support.
Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com
---
drivers/scsi/aacraid/aacraid.h | 80 -
drivers/scsi/aacraid/comminit.c | 95 +-
Fix compilation errors on forgotten #include linux/dmapool.h and warnings when
CONFIG_PCI is not set.
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/scsi/advansys.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
)) {
--
2.1.4
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G
On Fri, Jun 12, 2015 at 08:31:38AM +0200, Hannes Reinecke wrote:
On 05/22/2015 11:15 AM, Johannes Thumshirn wrote:
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap
returns without doing an iounmap() of mvi-regs_ex.
Found by the cocinelle tool.
Signed-off
-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
people debugging it) knew it will be already initialized and b) you don't need
is already initialized check any more.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH
, even better.
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg
list_head delayed_tr_list;
struct list_head delayed_tr_volume_list;
u8 temp_sensors_count;
--
2.0.2
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de
(sas_device_pg0.Slot);
+ _scsih_mark_responding_sas_device(ioc, sas_device_pg0);
}
out:
--
2.0.2
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list
];
Minor nit of different indent here, don't know if it is worth re-sending?
Other than that:
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH
On Fri, Jun 19, 2015 at 02:51:00PM +0530, Sreekanth Reddy wrote:
On Fri, Jun 19, 2015 at 2:44 PM, Johannes Thumshirn jthumsh...@suse.de
wrote:
On Thu, Jun 18, 2015 at 03:27:26PM +0530, Sreekanth Reddy wrote:
Hi,
Any other review comments on this patch. please let us known if any
of writeq?
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumsh
://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard
*/
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH
(0x0004)
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
On Mon, Jun 15, 2015 at 04:41:56PM +0530, Sreekanth Reddy wrote:
On Mon, Jun 15, 2015 at 3:16 PM, Johannes Thumshirn jthumsh...@suse.de
wrote:
On Fri, Jun 12, 2015 at 03:12:22PM +0530, Sreekanth Reddy wrote:
Added the following Dell branding to the mpt3sas driver.
VendorID DeviceID
-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
On Mon, Jun 15, 2015 at 03:56:56PM +0530, Sreekanth Reddy wrote:
On Fri, Jun 12, 2015 at 6:10 PM, Johannes Thumshirn jthumsh...@suse.de
wrote:
On Fri, Jun 12, 2015 at 05:48:56PM +0530, Sreekanth Reddy wrote:
On Fri, Jun 12, 2015 at 4:58 PM, Johannes Thumshirn jthumsh...@suse.de
wrote
: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de
to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This might be something you might consider re-organizing for your code-base
merge as well, as it leads to a lot of code duplication the more OEMs you have.
--
Johannes Thumshirn
this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh
= DID_SOFT_ERROR 16;
break;
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn
;
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumsh...@suse.de
;
}
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Fri, Jun 12, 2015 at 05:48:56PM +0530, Sreekanth Reddy wrote:
On Fri, Jun 12, 2015 at 4:58 PM, Johannes Thumshirn jthumsh...@suse.de
wrote:
On Fri, Jun 12, 2015 at 03:12:16PM +0530, Sreekanth Reddy wrote:
Removed the redundancy code while freeing the controller resources.
Signed-off
the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de
to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH
;
}
scmd-result = DID_SOFT_ERROR 16;
break;
--
2.0.2
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
, scsi_result);
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
please format the patch according to
Documentation/SubmittingPatches and re-send.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F
info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911
majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F
#endif
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
+851,8 @@ bfad_im_module_exit(void)
if (bfad_im_scsi_vport_transport_template)
fc_release_transport(bfad_im_scsi_vport_transport_template);
+
+ idr_destroy(bfad_im_port_index);
}
void
--
1.9.1
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes
On Thu, May 28, 2015 at 09:49:08AM +, Narsimhulu Musini (nmusini) wrote:
Hi Boaz,
Sure, I will incorporate the comments and suggestions in next patch
submittal.
Thanks
Narsimhulu
As you're going to re-submit anyway, I have found several occurences of:
[Insert appropriate license
Seymour, Shane M shane.seym...@hp.com writes:
Two SLES11 SP3 servers encountered similar crashes simultaneously
following some kind of SAN/tape target issue:
Thanks,
Reviewed-by: Johannes Thumshirn jthumsh...@suse.com
--
Johannes Thumshirn Storage
the io lock */
- if (CMD_FLAGS(sc) FNIC_IO_INITIALIZED)
+ if (io_lock_acquired)
spin_unlock_irqrestore(io_lock, flags);
Can't you just use
if (spin_is_locked(io_lock))
spin_unlock_irqrestore(io_lock, flags);
atomic_dec(fnic-in_flight);
Johannes
--
Johannes
;
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap
returns without doing an iounmap() of mvi-regs_ex.
Found by the cocinelle tool.
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/scsi/mvsas/mv_init.c | 5 -
1 file changed, 4 insertions(+), 1 deletion
In case pci_resource_start() or pci_resource_len() reutrn 0, mvsas_ioremap
returns without doing an iounmap() of mvi-regs_ex.
Found by the cocinelle tool.
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/mvsas/mv_init.c | 5 -
1
with error %d\n, r);
+ return SCSI_MLQUEUE_HOST_BUSY;
+ }
+
int_to_scsilun(sc-device-lun, fc_lun);
/* Enqueue the descriptor in the Copy WQ */
Looks good from my side.
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
2020 2020
010 4551 554d 4420 4456 522d 4d4f 2020 2020
020 2e32 2e33
024
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/scsi/scsi_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
vmscsi_win8_extension),
+ },
+ {
+ VMSTOR_PROTO_VERSION_WIN6,
+ PRE_WIN8_STORVSC_SENSE_BUFFER_SIZE,
+ sizeof(struct vmscsi_win8_extension),
+ }
+};
+
Thanks,
Johannes
--
Johannes Thumshirn Storage
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911
);
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
In bfa_fcs_lport_get_rport_max_speed() check if port is non NULL before
dereferencing it's child port-fcs-bfa to trl_enabled.
NB: I'm not entirely sure if port can even be NULL, so the check for NULL might
be useless as well.
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/scsi
. This is the use after free. Following the use after free mp
gets kfree()d again which is a double free.
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
---
drivers/scsi/lpfc/lpfc_mbox.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers
Jack Wang xjtu...@gmail.com writes:
2015-08-17 15:04 GMT+02:00 Johannes Thumshirn jthumsh...@suse.de:
In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
Apparently I've hit enter to fast. This shouldn't be XXX but
psataPayload-status. I'll be sending a v2 :-(.
ts-stat
In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
ts-stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
fallthrough to the default handler of the switch statement overriding ts-stat
to SAS_DEV_NO_RESPONSE.
Signed-off-by: Johannes Thumshirn jthumsh
In case psataPayload-status has a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
ts-stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
fallthrough to the default handler of the switch statement overriding ts-stat
to SAS_DEV_NO_RESPONSE.
Signed-off-by: Johannes Thumshirn
Sebastian Herbszt herb...@gmx.de writes:
Johannes Thumshirn wrote:
If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
continues normally and mp gets kfree()d.
If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
error label where
;
}
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
);
sgl-va = virtual_address;
Given the above is swapped:
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
;
+ }
}
megasas_return_cmd(instance, cmd);
For the curly braces part:
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
While you're up to it, care to check drivers/scsi/bfa as well? There was
a patch somewhen in the past but it seems it wasn't applied. But if
found this bugzilla entry
https
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911
-lsL0P1VTbdAQ9zpAXLjCCl4LS3bUhIe=
--
Nagarajkumar Narayanan
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J
*virtual_address,
{
WARN_ON(!virtual_address);
WARN_ON(!physical_address);
- WARN_ON(!length 0);
+ WARN_ON(length == 0);
WARN_ON(!sgl);
sgl-va = virtual_address;
Looks good.
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn
KY Srinivasan k...@microsoft.com writes:
-Original Message-
From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
Sent: Thursday, August 13, 2015 7:34 AM
To: KY Srinivasan k...@microsoft.com; Keith Mange
keith.ma...@microsoft.com
Cc: gre...@linuxfoundation.org; linux-ker
2020 2020
010 4551 554d 4420 4456 522d 4d4f 2020 2020
020 2e32 2e33
024
Signed-off-by: Johannes Thumshirn jthumsh...@suse.de
Reviewed-by: Hannes Reinecke h...@suse.de
---
Chanes to v1:
* Correct typo userlang - userland in commit message.
drivers/scsi/scsi_sysfs.c | 24
)) {
pci_unmap_single(fnic-pdev, pa, skb-len, PCI_DMA_TODEVICE);
@@ -1071,6 +1091,12 @@ static int fnic_send_frame(struct fnic *fnic, struct
fc_frame *fp)
pa = pci_map_single(fnic-pdev, eth_hdr, tot_len, PCI_DMA_TODEVICE);
[..]
Otherwise:
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes
);
Reviewed-by: Johannes Thumshirn jthumsh...@suse.de
--
Johannes Thumshirn Storage
jthumsh...@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284
On Wed, 2015-10-21 at 17:26 +0300, Dāvis Mosāns wrote:
> 2015-10-21 16:47 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de>:
> > On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote:
> > > 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de
> > >
oid __exit wd719x_exit(void)
> -{
> - pci_unregister_driver(_pci_driver);
> -}
> -
> -module_init(wd719x_init);
> -module_exit(wd719x_exit);
> +module_pci_driver(wd719x_pci_driver);
>
> MODULE_DESCRIPTION("Western Digital WD7193/7197/7296 SCSI driver");
>
ic void wd719x_pci_remove(struct pci_dev
> *pdev)
> scsi_host_put(sh);
> }
>
> -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = {
> +static const struct pci_device_id wd719x_pci_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) },
> {}
> };
On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote:
> When dropping a lock while iterating a list we must restart the
> search
> as other threads could have manipulated the list under us. Without
> this
> we can get stuck in an endless loop.
>
> Reported-by: Johann
megasas_probe_one(struct pci_dev
> *pdev,
>
> >evt_detail_h);
>
> if (!instance->evt_detail) {
> - dev_printk(KERN_DEBUG, >dev, "Failed to
> allocate memory for "
> +
debug("megasas: failed to open device node\n");
> return rval;
> }
>
> @@ -6752,7 +6752,7 @@ static int __init megasas_init(void)
> rval = pci_register_driver(_pci_driver);
>
> if (rval) {
> - printk(KERN_DEBUG "megasas: PCI hotplug registration
> failed \n");
> + pr_debug("megasas: PCI hotplug registration failed
> \n");
> goto err_pcidrv;
> }
>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
frame pool and assign one frame to each cmd
> */
> if (megasas_create_frame_pool(instance)) {
> - dev_dbg(>pdev->dev, "Error creating frame
> DMA pool\n");
> + dev_err(>pdev->dev, "Error creating frame
> DM
On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote:
> When dropping a lock while iterating a list we must restart the
> search
> as other threads could have manipulated the list under us. Without
> this
> we can get stuck in an endless loop.
>
> Reported-by: Johann
On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote:
> 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn <jthumsh...@suse.de>:
> > On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote:
> > > 2015-08-21 7:29 GMT+03:00 Dāvis Mosāns <davis...@gmail.com>:
>
if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
> goto out;
>
> errout:
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> the body of a message to ma
2020 2020
010 4551 554d 4420 4456 522d 4d4f 2020 2020
020 2e32 2e33
024
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Hannes Reinecke <h...@suse.de>
---
1st sent on Aug. 14 2015
1st resend on Oct. 30 2015
drivers/scsi/scsi_sysfs.c | 24 +++
conds, which returns a 64-bit seconds value.
Thanks for the conversion. Can you please check if other (scsi) drivers
have the same y2038 issues? A quick "git grep do_gettimeofday
drivers/scsi/ | wc -l" reveals 30 occurrences (of cause not all are
problematic).
Other than that
Reviewed-
Hi Bart,
On Tue, 2015-10-27 at 13:14 -0700, Bart Van Assche wrote:
> On 10/26/2015 01:35 AM, Johannes Thumshirn wrote:
> > I haven't heard anything from the original reporter of the lockup
> > but
> > my test's went all O.K., so
> >
> > Tested-by: Johan
2020 2020
010 4551 554d 4420 4456 522d 4d4f 2020 2020
020 2e32 2e33
024
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Hannes Reinecke <h...@suse.de>
---
drivers/scsi/scsi_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --g
Hi Tim,
tim.gard...@canonical.com writes:
> From: Tim Gardner
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied
> to the left hand side of comparison
.
> This patch uses ktime_get_real_seconds() instead since it provides a
> 64-bit seconds value, which is 2038 safe.
>
> Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/scsi/mvumi.c | 10 +
gt; The patch uses ktime_get_real_seconds() which returns a 64-bit
> seconds value.
>
> Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_mr.c | 5 ++---
> 1 file changed,
On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote:
> On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote:
> > Removing a SCSI target via scsi_remove_target() suspected to be
> > racy. When a
> > sibling get's removed from the list it can occassionly ha
On Wed, 2015-10-14 at 16:22 -0400, Ewan Milne wrote:
> On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote:
> > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote:
> > > Removing a SCSI target via scsi_remove_target() suspected to be
> > > racy. When a
Zitat von James Bottomley <james.bottom...@hansenpartnership.com>:
On Wed, 2015-10-14 at 16:39 +0200, Johannes Thumshirn wrote:
On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote:
> On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote:
> > Removing a
Zitat von Christoph Hellwig <h...@infradead.org>:
On Wed, Oct 14, 2015 at 04:39:07PM +0200, Johannes Thumshirn wrote:
removal. This is what my initial proposal did as well. Christoph wanted
me to decouple the whole process from the host_lock though and this is
what this patches do as we
On Wed, 2015-10-07 at 05:39 +, Junichi Nomura wrote:
> This is a set of scripts for kernel-side dm-multipath testing.
> Current
> set of scripts are stress testing of extreme situation and its
> coverage
> is limited. But recently found dm-mpath regressions should be
> detectable
> with this.
On Wed, 2015-10-14 at 11:18 -0700, Christoph Hellwig wrote:
> On Wed, Oct 14, 2015 at 08:45:56AM -0700, James Bottomley wrote:
> > OK, so I really need you to separate the problems. Fixing the bug
[..]
>
> Johannes, can you test the patch below?
I've tested your patch and it doesn't show the
SAS_ADDR(dev->sas_addr));
>
> - rc = SAS_PHY_DOWN;
> - return rc;
> + rc = SAS_PHY_DOWN;
> + return rc;
> }
> tei.port = dev->port->lldd_port;
> if (tei.port && !t
*sht, int privsize)
>
> fail_kthread:
> kthread_stop(shost->ehandler);
> + fail_index_remove:
> + ida_simple_remove(_index_ida, shost->host_no);
> fail_kfree:
> kfree(shost);
> return NULL;
> @@ -588,6 +593,7 @@ int scsi_init_hosts(void)
>
Introduce target_lock and device_lock to untangle the __devices and __targets
lists from the host_lock.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/53c700.c | 3 +++
drivers/scsi/hosts.c | 2 ++
drivers/scsi/scsi.c | 8
driver
Rework the list handling in scsi_target_remove(). The new version introduces a
reap list for targets. Targets that shall be removed are placed on the reap
list and can then be reaped later on.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/scsi_sysfs.
Rework the list handling in __scsi_target_remove(). The new version introduces
a reap list for devices. Devices that shall be removed are placed on the reap
list and can then be removed later on.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
---
drivers/scsi/scsi_sysfs.
dprobe $module;
mount $mountpoint;
done
This is a follow up of the patch proposed here:
http://marc.info/?l=linux-scsi=144377409311774=2
incorporating Christoph's comment
Johannes Thumshirn (3):
SCSI: Introduce device_lock and target_lock in Scsi_Host
SCSI: Rework list ha
ot_idx)
> > {
> > + if (!slot)
> > + return;
> > if (!slot->task)
> > return;
> > if (!sas_protocol_ata(task->task_proto))
> > --
> > 2.5.0
> >
>
> Can this get
, defines_module_exit.exit;
@@
exit(void)
{
...
idr_destroy(idr);
...
}
@ missing_module_idr_destroy depends on declares_idr defines_module_exit
!on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
+idr_destroy(idr);
}
/SmPL
Signed-off-by: Johannes Thumshirn
;
@@
exit(void)
{
...
idr_destroy(idr);
...
}
@ missing_module_idr_destroy depends on declares_idr defines_module_exit
!on_exit_calls_destroy @
identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
+idr_destroy(idr);
}
/SmPL
Signed-off-by: Johannes Thumshirn jthumsh
1 - 100 of 1470 matches
Mail list logo