Re: [PATCH 02/14] cxlflash: Fix crash in cxlflash_restore_luntable()

LUN information structure is updated to > reflect the LUN is no longer in the LUN table once all references to > the LUN are gone. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from

Re: [PATCH 01/14] cxlflash: Set sg_tablesize to 1 instead of SG_NONE

issue, sg_tablesize for cxlflash can simply be set > to 1, a value which satisfies the constraints in cxlflash and the > lack of support of SG_NONE in SCSI blk_mq. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vn

Re: [PATCH 04/14] cxlflash: Avoid command room violation

Hi Uma, I do see a potential hang issue with this patch. See my comments below. -matt > On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote: > > During test, a command room violation interrupt is occasionally seen > for the master context when the CXL flash devices

Re: [PATCH v2 04/14] cxlflash: Avoid command room violation

o account the > current thread consuming a hardware command. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] cxlflash: Cancel scheduled workers before stopping AFU

is > cancelled after interrupts have been disabled and prior to the mapping > being freed. > > Fixes: b45cdbaf9f7f ("cxlflash: Resolve oops in wait_port_offline") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good. Acked-by: Matthew R. Ochs <mr

Re: [PATCH 10/17] cxlflash: Fence EEH during probe

> On Apr 13, 2017, at 1:27 AM, Andrew Donnellan <andrew.donnel...@au1.ibm.com> > wrote: > > On 13/04/17 05:14, Uma Krishnan wrote: >> From: "Matthew R. Ochs" <mro...@linux.vnet.ibm.com> >> >> An EEH during probe can lead to a crash as the reco

Re: [PATCH 15/17] cxlflash: Support multiple hardware queues

initially implemented as a static array > embedded in the AFU. This will be transitioned to a dynamic allocation in a > later series to improve the memory footprint of the driver. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'

ristophe.jail...@wanadoo.fr> Yep, that's a bug. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxlflash: return -EFAULT if copy_from_user() fails

debug") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Good catch Dan! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

[PATCH 0/3] cxlflash: Minor fix and EH refactoring

This small series fixes a recently injected double free and also includes two patches to refactor the host and reset handlers to ease the burden of making this driver compatible with an updated SCSI EH framework. This series is intended for 4.13 and is bisectable. Matthew R. Ochs (3): cxlflash

[PATCH 3/3] cxlflash: Update debug prints in reset handlers

and associated CDB. This is not necessary as the SCSI command is simply the messenger in these scenarios. Refactor the debug prints in the host and reset handlers to only present information that is applicable given the function scope. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.

[PATCH 2/3] cxlflash: Update send_tmf() parameters

. As a nice side effect, this will ease the burden of converting caller routines to be based solely off of a SCSI device reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 27 +-- 1 file changed, 13 insertions(

[PATCH 1/3] cxlflash: Avoid double free of character device

ement interface") Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 7a787b6..455564f 100644 --- a/drivers/scsi/cxlflash/main.c ++

Re: [PATCH 33/47] cxlflash: use dedicated reset command in send_tmf()

Hi Hannes, We actually just reworked these paths in a series that was pulled in on Monday. While testing, I came across a bug in that series and was planning on sending out a fix for it. I'll include some patches that will ease the burden of incorporating your EH updates for cxlflash. Many

Re: [PATCH 01/17] cxlflash: Combine the send queue locks

mplification and to support serialization with enqueue > operations, move to only a single lock that is used for enqueueing > regardless of the queueing model. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 02/17] cxlflash: Update cxlflash_afu_sync() to return errno

rly indicate the failure cause to the > caller. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 04/17] cxlflash: Schedule asynchronous reset of the host

o recoverable actions. > > To avoid this situation, context reset failures will be escalated to a host > reset operation. This will be done asynchronously to allow the acting > thread to return to the user with a failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vne

Re: [PATCH 03/17] cxlflash: Reset hardware queue context via specified register

ue > reference instead of a single command to better reflect that the entire > queue associated with the context is impacted by the reset. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 09/17] cxlflash: Create character device to provide host management interface

gt; manage the adapter. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 06/17] cxlflash: Track pending scsi commands in each hardware queue

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 07/17] cxlflash: Flush pending commands in cleanup path

-layer and indicating that the command > can be retried. > > Once the card has been quiesced, the hardware send queue lock is acquired > to prevent any data movement while the pending commands are processed. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 05/17] cxlflash: Handle AFU sync failures

> > Update documentation to reflect behavior in the event of an AFU sync > failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 08/17] cxlflash: Add scsi command abort handler

support to process command timeouts > and abort requests. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxlflash: Select IRQ_POLL

sh: Implement IRQ polling for RRQ > processing") > Signed-off-by: Guenter Roeck <li...@roeck-us.net> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/7] cxlflash: Yield to active send threads

ter can > also be used for the active send threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/7] cxlflash: Limit the debug logs in the IO path

to debug issues that involve command > tracking, the abundance of data can overwrite other useful data in the > log. The best option available is to limit the messages that should > serve most of the common use cases. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com

Re: [PATCH 5/7] cxlflash: Add include guards to backend.h

On Fri, May 11, 2018 at 02:05:51PM -0500, Uma Krishnan wrote: > The new header file, backend.h, that was recently added is missing > the include guards. This commit adds the guards. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 7/7] cxlflash: Isolate external module dependencies

f > to avoid compilation errors. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 3/7] cxlflash: Acquire semaphore before invoking ioctl services

leading > to the hang. > > To support the current design point of holding the semaphore on the > ioctl() paths, the release fop should acquire it before invoking any > ioctl services. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 6/7] cxlflash: Abstract hardware dependent assignments

> Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/6] scsi: cxlflash: Drop unused sense buffers

On Tue, May 22, 2018 at 11:15:08AM -0700, Kees Cook wrote: > This removes the unused sense buffer in read_cap16() and write_same16(). > > Signed-off-by: Kees Cook <keesc...@chromium.org> Looks good. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/6] cxlflash: Reset command ioasc

a hang or IO failure. > > To fix the issue, clear the ioasc before queuing any command. > > Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command > data") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 5/6] cxlflash: Adapter context init can return error

On Wed, Jan 03, 2018 at 04:55:04PM -0600, Uma Krishnan wrote: > Adapter context creation can return either NULL or an error pointer. > Updating the check condition to reflect this. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/6] cxlflash: Reset command ioasc

On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote: > On 04/01/18 09:54, Uma Krishnan wrote: > >In the event of a command failure, cxlflash returns the failure to the > >upper layers to process. After processing the error, when the command is > >queued again, the private command

Re: [PATCH 2/6] cxlflash: Update cxl-specific arguments to generic cookie

On Wed, Jan 03, 2018 at 04:54:25PM -0600, Uma Krishnan wrote: > Convert cxl-specific pointers to generic cookies to facilitate future > enhancements. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

On Tue, Feb 20, 2018 at 07:56:35PM +1100, Michael Ellerman wrote: > Vaibhav Jain writes: > > > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by > > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash > > module gets hung with

Re: [PATCH] scsi: cxlflash: fix assignment of the backend operations

Thanks for catching this Cedric! Acked-by: Matthew R. Ochs

Re: [PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

evice state and yield to any active reset or probing threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

ing command list > before freeing the buffer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 41/41] cxlflash: Handle spurious interrupts

lem, a boolean will indicate if the hardware queue is > ready to process interrupts or not. This can be evaluated in the interrupt > handler before proessing an interrupt. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 00/38] cxlflash: OpenCXL transport support

and agree that the OpenCXL terminology should be consistent throughout the kernel. So...contingent upon a V2 with OpenCXL references being replaced by OCXL: Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > > Matthew R. Ochs (1): > cxlflash: Avoid clobbering context co

<    1   2   3   4   5