The attached patch built against scsi-misc-2.6 moves the
target iSCSI attributes to a new structure representing
a iSCSI session. The reason for doing this is to
create a interface that allows the Sourceforge iSCSI driver
to create and setup a session through sysfs (no more
IOCTL at all in our
James,
It appears there is a missing class_device_del.
The comments for transport_remove_device indicate
that transport_remove_classdev should call it
(which the attached patch does), but the comment in
attribute_container_remove_device:
If you want a
* two phase release: remove from visibility
+static void
+fc_rport_terminate(struct fc_rport *rport)
+{
+ struct Scsi_Host *shost = rport_to_shost(rport);
+ struct device *dev = rport-dev;
+ unsigned long flags;
+
+ if (rport-starget) {
+ scsi_forget_target(rport-starget);
+
The attach patch converts scsi_debug to use the virtual scsi bus.
It was built against scsi-rc-fixes-2.6.
The interface has changed a little. Here is an
example of adding and removing a single host:
cd /sys/bus/scsi_host/drivers/scsi_debug
[EMAIL PROTECTED] scsi_debug]# ls
add_host dev_size_mb
The attached patch copies the code from the fc transport
class which allows a LLD to block and unblock a device.
The block/unblock code is used by the iscsi-sfnet
driver in replacement of a internal timer doing the
same thing.
I understand that the target code is under construction
and our group
Andrew Vasquez wrote:
On Wed, 23 Feb 2005, Mike Christie wrote:
The attached patch copies the code from the fc transport
class which allows a LLD to block and unblock a device.
The block/unblock code is used by the iscsi-sfnet
driver in replacement of a internal timer doing the
same thing.
I
Mike Christie wrote:
Andrew Vasquez wrote:
On Wed, 23 Feb 2005, Mike Christie wrote:
Andrew Vasquez wrote:
Speaking of which, are there any major objections to the patches
proposed here:
Add scsi_target_[un]block() and scsi_target_remove() generics
http://marc.theaimsgroup.com/?l=linux-scsim
Matthew Zito wrote:
Hi,
The iscsi_sfnet module I compiled against my 2.6.10-xen0 tree loads
fine, but when the iscsid process goes to discover the luns, it sees the
luns but dumps error strings similar to the following:
Attached scsi disk sdb at scsi0, channel 0, id 0,
Alex Aizman wrote:
This is to announce Open-iSCSI project: High-Performance iSCSI Initiator for
Linux.
MOTIVATION
==
Our initial motivations for the project were: (1) implement the right
user/kernel split, and (2) design iSCSI data path for performance. Recently
we added (3): get accepted
Jens Axboe wrote:
On Wed, Mar 16 2005, Christoph Hellwig wrote:
On Wed, Mar 16, 2005 at 05:53:39PM +0100, Jens Axboe wrote:
The list doesn't really need dma mapping at that point, the problem here
is that the driver needs to punt to pio mode because of foo. So calling
pci/dma_map_* is pointless,
According to this article http://lwn.net/Articles/125930/, When
cancel_delayed_work() returns zero, it means that the delayed
work request was fired off before the call; it might, in fact,
be running on another CPU when the cancel attempt is made.
If it is successful, it returns a nonzero value.
Is FC_SCSI_SCAN_DELAY used by a FC driver that is
not yet in mainline? This patch just deletes it
if not since no one else is.
Signed-off-by: Mike Chrisite [EMAIL PROTECTED]
--- scsi-misc-2.6.orig/include/scsi/scsi_transport_fc.h 2005-03-25 21:35:06.0 -0800
+++
The attached patch adds session block and unblock functions
similar to the rport block and unblock code.
The patch was built against scsi misc (but also pathces
against scsi rc fixes) and this patch
http://marc.theaimsgroup.com/?l=linux-scsim=81778109783w=2
which adds a scsi_flush_work
This is just a resend with Andries Brouwer ccd to make sure
I did not mess up any of the disk geometry stuff up.
On 32 bit archs with LBD set, setsize can cast a capacity so
that we result in heads==0 (capacity is sector_t which would
be a 64 bit value with LBD but it gets cast to a unsigned
?
Patch was made against James scsi-block-2.6 tree.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
diff --git a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c
--- a/drivers/block/ll_rw_blk.c
+++ b/drivers/block/ll_rw_blk.c
@@ -2193,31 +2193,6 @@ int blk_rq_map_user_iov(request_queue_t
Dmitry Yusupov wrote:
On Sat, 2005-07-30 at 15:23 -0500, James Bottomley wrote:
On Sat, 2005-07-30 at 12:53 -0700, David S. Miller wrote:
From: James Bottomley [EMAIL PROTECTED]
Date: Sat, 30 Jul 2005 12:32:42 -0500
FIB has taken your netlink number, so I changed it to 32
MAX_LINKS is 32,
Jens Axboe wrote:
On Fri, Jul 29 2005, Mike Christie wrote:
Hey Jens and James,
The inlined patch moves the bounce buffer handling to blk_execute_rq_nowait
so the scsi, sg io and cdrom code does not have to handle it. To accomplish
this I moved the bio_uncopy_user to a bi_end_io function
Guennadi Liakhovetski wrote:
On Sun, 7 Aug 2005, Mike Christie wrote:
Guennadi Liakhovetski wrote:
Now, it would be best, I think, if somebody could review the patches to
dc395x and tmscsim. In case the 2 functions are correct, they could be
included in a central file (scsi_lib?) for all
On 03/15/2013 08:41 AM, Bart Van Assche wrote:
On 03/15/13 14:28, Bryn M. Reeves wrote:
On 03/15/2013 12:46 PM, Bart Van Assche wrote:
The SCSI EH keeps trying until all outstanding request have been
finished. Does lpfc_host_reset_handler() invoke scsi_done() for
It does not really matter at
On 03/15/2013 02:13 PM, Bart Van Assche wrote:
On 03/15/13 19:51, Mike Christie wrote:
On 03/15/2013 08:41 AM, Bart Van Assche wrote:
How about using the value of scsi_cmnd.jiffies_at_alloc to finish only
those SCSI commands in the host reset handler that exceeded a certain
processing time
On 03/11/2013 11:39 PM, jayamoh...@gmail.com wrote:
From: Jayamohan.Kallickal jayamohan.kallic...@emulex.com
Free CXN specific resource held by driver when login redirection
or connection retry happens. Login redirection was failing
because WRB/SGL were not allocated from the CID on which
I agree with Steffan's concerns below. Please fix or explain.
On 03/13/2013 05:29 AM, Steffen Maier wrote:
On 03/12/2013 05:39 AM, jayamoh...@gmail.com wrote:
From: Jayamohan.Kallickal jayamohan.kallic...@emulex.com
This patch fixes the display of proper FW Version from the driver.
Vikas Chaudhary (3):
qla4xxx: Added missing check for ISP83XX in CHAP related functions
qla4xxx: Assign correct CHAP table address to FLT
qla4xxx: Update driver version to 5.03.00-k6
Looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from
On 03/22/2013 06:41 AM, vikas.chaudh...@qlogic.com wrote:
From: Vikas Chaudhary vikas.chaudh...@qlogic.com
James,
Following patches allows iscsiadm to manage iSCSI target information
stored on adapter flash on per host basis and and perform various
operations like add, delete, login,
Patches 1 - 3 look ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
On 03/25/2013 07:08 AM, vikas.chaudh...@qlogic.com wrote:
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com
Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com
Signed-off-by: Vikas
changed, 38 insertions(+), 43 deletions(-)
iscsi parts are ok. I also ran some quick tests on them.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 03/28/2013 02:32 PM, Jeff Moyer wrote:
Hi,
If blk_get_requet fails here, it means that the queue is dead. It seems
better to return a DEV_OFFLINED error code than the misleading
TEMP_UNAVAIL. Comments?
Signed-off-by: Jeff Moyer jmo...@redhat.com
diff --git
On 04/02/2013 07:09 PM, Mikulas Patocka wrote:
Hi
This fixes a possible race in scsi_dh_emc. It is untested because I don't
have the hardware. It could happen when we reload a multipath device and
path failure happens at the same time.
I think this patch is ok. I do not have the hw to
qla4xxx: Restrict logout from boot target session using session id
qla4xxx: Use correct value for max flash node entries
Vikas Chaudhary (2):
qla4xxx: Added print statements to display AENs
qla4xxx: Update driver version to 5.03.00-k8
Looks ok to me.
Reviewed-by: Mike
-by: Mike Christie micha...@cs.wisc.edu
Signed-off-by: Mike Christie micha...@cs.wisc.edu
Sorry about the incorrect signed of chain James. When I sent/made the
patches I added both a reviewed-by and signed-off to this one by accident.
Masatake made the patch. I am just resending to the list
On 4/5/13 10:38 PM, Jayamohan Kallickal wrote:
During reboot/shutdown cycle, the active sessions were not updated.
In iSCSI Boot case, the boot session was alive and this fix informs
that the machine is going down, so no more ops happens on that session.
Signed-off-by: John Soni Jose
On 04/05/2013 10:38 PM, Jayamohan Kallickal wrote:
- Fix the session cleanup when reboot or shutdown happens
All patches but that one looked ok. Since Jay dropped it for now, then
the patchset looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from
-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This fixes a bug where the iscsi class/driver did not do a put_device
when a sess/conn device was found. This also simplifies the interface
by not having to pass in some arguments that were duplicated and did
not need to be exported.
Signed-off-by: Mike Christie micha...@cs.wisc.edu
diff --git a/drivers
Come on man, same comments as last patches like this :) Could you use
the same names that we currently use for existing params?
Check for the inorder ones and the ones where we use en instead of
enabled for the postfix. Also check the others.
Also what is up with isns. If we support passing the
On 05/28/2013 03:49 AM, Mike Christie wrote:
Come on man, same comments as last patches like this :) Could you use
the same names that we currently use for existing params?
Check for the inorder ones and the ones where we use en instead of
enabled for the postfix. Also check the others
On 05/09/2013 05:02 AM, vikas.chaudh...@qlogic.com wrote:
+ ISCSI_PARAM_DEF_TASKMGMT_TMO,
We currently have:
ISCSI_PARAM_ABORT_TMO,
ISCSI_PARAM_LU_RESET_TMO,
ISCSI_PARAM_HOST_RESET_TMO,
Does your card just have the one timeout for all types of tmfs?
I think the
On 05/28/2013 06:55 AM, Vikas Chaudhary wrote:
-Original Message-
From: Mike Christie micha...@cs.wisc.edu
Date: Tuesday 28 May 2013 2:27 PM
To: Vikas vikas.chaudh...@qlogic.com
Cc: jbottom...@parallels.com jbottom...@parallels.com, scsi
linux-scsi@vger.kernel.org, Lalit
On 05/28/2013 06:36 AM, Vikas Chaudhary wrote:
-Original Message-
From: Mike Christie micha...@cs.wisc.edu
Date: Tuesday 28 May 2013 2:19 PM
To: Vikas vikas.chaudh...@qlogic.com
Cc: jbottom...@parallels.com jbottom...@parallels.com, scsi
linux-scsi@vger.kernel.org, Lalit
.
Three new session sysfs params are defined:
boot_root - holds the name of the /sys/firmware/ibft or iscsi_rootN
boot_nic - holds the ethernetN name
boot_target - holds the targetN name
Signed-off-by: Eddie Wai eddie@broadcom.com
Ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
-by: Bart Van Assche bvanass...@acm.org
Acked-by: Tejun Heo t...@kernel.org
Acked-by: Hannes Reinecke h...@suse.de
Cc: Mike Christie micha...@cs.wisc.edu
Cc: James Bottomley jbottom...@parallels.com
Seems ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send
On 6/12/13 7:55 AM, Bart Van Assche wrote:
A SCSI LLD may start cleaning up host resources as soon as
scsi_remove_host() returns. These host resources may be needed by
the LLD in an implementation of one of the eh_* functions. So if
one of the eh_* functions is in progress when
such that the get_device() call
added in scsi_run_queue() is guaranteed to succeed.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Reported-and-tested-by: Chanho Min chanho@lge.com
Reference: http://lkml.org/lkml/2012/8/2/96
Acked-by: Tejun Heo t...@kernel.org
Reviewed-by: Mike Christie micha
On 06/24/2013 02:19 PM, James Bottomley wrote:
On Wed, 2013-06-12 at 14:55 +0200, Bart Van Assche wrote:
A SCSI LLD may start cleaning up host resources as soon as
scsi_remove_host() returns. These host resources may be needed by
the LLD in an implementation of one of the eh_* functions. So if
On 06/24/2013 05:27 PM, James Bottomley wrote:
However, what's the reasoning behind wanting to do this? In theory all
necessary resources for the eh thread should only be freed in the
release callback. That means they aren't freed until all error recovery
completes.
I think it makes it
Chaudhary (1):
qla4xxx: Update driver version to 5.03.00-k10
Looks ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in this set.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
On 07/01/2013 04:54 AM, vikas.chaudh...@qlogic.com wrote:
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com
Exporting new iSCSI Session and Connection parameters to sysfs
Signed-off-by: Adheer Chandravanshi
On 07/08/2013 06:33 AM, adheer.chandravan...@qlogic.com wrote:
static ssize_t
@@ -181,8 +179,8 @@ qla4xxx_iscsi_version_show(struct device *dev, struct
device_attribute *attr,
char *buf)
{
struct scsi_qla_host *ha = to_qla_host(class_to_shost(dev));
-
On 07/18/2013 12:51 PM, Nicholas A. Bellinger wrote:
On Wed, 2013-07-17 at 18:19 +0200, Alexander Gordeev wrote:
On Tue, Jul 16, 2013 at 02:38:03PM -0700, Nicholas A. Bellinger wrote:
[7.927818] scsi_execute(): Calling blk_mq_free_request
[7.927826] scsi 0:0:0:0: Direct-Access ATA
.
qla4xxx: Export more firmware info in sysfs
qla4xxx: Update driver version to 5.03.00-k11
Ignore my comment on that one patch. Patches look ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
On 07/17/2013 11:44 AM, Mike Christie wrote:
On 07/08/2013 06:33 AM, adheer.chandravan...@qlogic.com wrote:
static ssize_t
@@ -181,8 +179,8 @@ qla4xxx_iscsi_version_show(struct device *dev, struct
device_attribute *attr,
char *buf)
{
struct scsi_qla_host *ha
On 07/18/2013 06:23 PM, Nicholas A. Bellinger wrote:
Just saw this while trying out iscsi with the scsi-mq stuff :)
Took at stab at this a while back, but ended getting distracted on other
items. Do you have an initial conversion running yet..?
Not running well :) Have a patch but I am
-by: Mike Christie micha...@cs.wisc.edu
diff --git a/block/blk-flush.c b/block/blk-flush.c
index c56c37d..3e4cc9c 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -231,7 +231,7 @@ static void flush_end_io(struct request *flush_rq, int
error)
unsigned long flags = 0;
if (q
on? It helps in reviewing them.
Adheer Chandravanshi (2):
libiscsi: Add a missing break statement
libiscsi: Add missing prints for session and connection sysfs attrs
Patches look ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line
processing error. The logout timeout will
kick in so we do not hang, but the patch makes it harder to debug those
type of problems. I think the annoyance that this error message causes
is higher than those concerns though since that happens so rarely now.
So patch is ok with me.
Reviewed-by: Mike
:
return -ENOSYS;
}
Patch looks ok.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/01/2014 11:19 AM, Sagi Grimberg wrote:
+/*
+ * data integrity helpers
+ */
+static inline unsigned
+iscsi_prot_len(unsigned data_len, unsigned sector_size)
+{
+ switch (sector_size) {
+ case 512:
+ return (data_len 9) * 8;
+ case 1024:
+
On 06/01/2014 11:19 AM, Sagi Grimberg wrote:
/**
+ * iscsi_adjust_dl - Adjust SCSI data length to include PI
+ * @sc: scsi command.
+ * @data_length: command data length.
+ *
+ * Adjust the data length to account for how much data
+ * is actually on the wire.
+ *
+ * returns the adjusted
On 06/04/2014 12:15 PM, KY Srinivasan wrote:
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Wednesday, June 4, 2014 10:02 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org;
On 6/5/14, 9:53 PM, KY Srinivasan wrote:
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Thursday, June 5, 2014 6:33 PM
To: KY Srinivasan
Cc: James Bottomley; linux-ker...@vger.kernel.org; a...@canonical.com;
de...@linuxdriverproject.org; h...@infradead.org
);
memset(buf, 0, host_stats_size);
err = transport-get_host_stats(shost, buf, host_stats_size);
Looks ok to me.
Acked-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
Looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
comments.
Signed-off-by: Douglas Gilbert dgilb...@interlog.com
Looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
public interface about the cmd_len field being
limited to 16 bytes.
- remove some dead code caused by this change
- cleanup comment block at the top of sg.h, fix urls
Signed-off-by: Douglas Gilbert dgilb...@interlog.com
Looks ok to me.
Reviewed-by: Mike Christie micha
On 06/11/2014 04:09 AM, Sagi Grimberg wrote:
In case protection information exists on the wire
scsi transports should include it in the transfer
byte count (even if protection information does not
exist in the host memory space). This helper will
compute the total transfer length from the
On 06/23/2014 03:59 PM, Christoph Hellwig wrote:
This patch causes a regression when using the iscsi initiator over
TCP for me. When mounting a newly created ext4 filesystem I get the
following BUG:
[ 31.611803] BUG: unable to handle kernel NULL pointer dereference at
000c
On 06/11/2014 04:09 AM, Sagi Grimberg wrote:
In case protection information exists on the wire
scsi transports should include it in the transfer
byte count (even if protection information does not
exist in the host memory space). This helper will
compute the total transfer length from the
of the patch below with a
proper description and signoff.
It would be nice to just have one function to call and it just do the
right thing for the drivers. I am fine with Sagi's libiscsi patch for
now though:
Acked-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send
On 06/24/2014 11:31 AM, Martin K. Petersen wrote:
Mike == Michael Christie micha...@cs.wisc.edu writes:
Mike Do we need to check for the data direction. Something like
Mike if (scmd-sc_data_direction == DMA_TO_DEVICE)
Mike xfer_len = scsi_out(scmnd)-length;
Mike else
Mike
On 06/24/2014 12:00 PM, Mike Christie wrote:
On 06/24/2014 11:30 AM, Christoph Hellwig wrote:
On Tue, Jun 24, 2014 at 07:27:46PM +0300, Sagi Grimberg wrote:
This condition only matters in the bidi case, which is not relevant for the
PI case.
I suggested to condition that in libiscsi (posted
On 06/24/2014 12:08 PM, Mike Christie wrote:
On 06/24/2014 12:00 PM, Mike Christie wrote:
On 06/24/2014 11:30 AM, Christoph Hellwig wrote:
On Tue, Jun 24, 2014 at 07:27:46PM +0300, Sagi Grimberg wrote:
This condition only matters in the bidi case, which is not
relevant for the PI case. I
)) {
Looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of the array. This patch fixes bnx2i and be2iscsi's setting of the
custom stats. They both just have the one, eh_abort_cnt, so that should
be in the first entry of the custom array and custom_length should then
be one.
Signed-off-by: Mike Christie micha...@cs.wisc.edu
Acked-by: Eddie Wai eddie
task as they are not always true and
somewhat redundant anyway.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Reviewed-by: Mike Christie micha...@cs.wisc.edu
Acked-by: Mike Christie micha...@cs.wisc.edu
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
Signed-off-by: Greg Kroah
On 07/03/2014 12:11 PM, Christoph Hellwig wrote:
On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote:
From: Stephen M. Cameron scame...@beardog.cce.hp.com
Don't loop through all the devices even after
finding the one we're looking for
The comments in the code seem to
all issues.
[PATCH] qla4xxx/iscsi: fix get_host_stats error propagation
This patch fixes 2 bugs.
1. qla4xxx was not always returning -EXYZ error codes when
qla4xxx_get_host_stats failed.
2. iscsi_get_host_stats was dropping the error code returned
by drivers like qla4xxx.
Signed-off-by: Mike
On 06/25/2014 11:52 AM, Christoph Hellwig wrote:
+static int scsi_queue_rq(struct blk_mq_hw_ctx *hctx, struct request *req)
+{
+ struct request_queue *q = req-q;
+ struct scsi_device *sdev = q-queuedata;
+ struct Scsi_Host *shost = sdev-host;
+ struct scsi_cmnd *cmd =
On 07/26/2014 11:21 AM, Christoph Hellwig wrote:
Here's a formal one.
James, can I get your signoff for it?
Vladimir, can I get a reviewed-by from you (or anyone else)?
---
From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001
From: James Bottomley
On 07/30/2014 07:50 AM, Hannes Reinecke wrote:
On 07/12/2014 10:51 PM, micha...@cs.wisc.edu wrote:
From: Mike Christie micha...@cs.wisc.edu
iscsi_get_host_stats was dropping the error code returned
by drivers like qla4xxx.
Signed-off-by: Mike Christie micha...@cs.wisc.edu
---
drivers
On 08/01/2014 08:31 AM, Hannes Reinecke wrote:
On 08/01/2014 12:32 AM, Mike Christie wrote:
On 07/30/2014 07:50 AM, Hannes Reinecke wrote:
On 07/12/2014 10:51 PM, micha...@cs.wisc.edu wrote:
From: Mike Christie micha...@cs.wisc.edu
iscsi_get_host_stats was dropping the error code returned
On 08/06/2014 05:37 PM, Anish Bhatt wrote
@@ -436,12 +473,12 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task
*task)
/* No unsolicit Data-Out's */
hdr-flags |= ISCSI_FLAG_CMD_FINAL;
} else {
+ unsigned in_len =
updating the boot enteries in sysfs
0004 - Fix processing CQE before freeing connection resources
0005 - Bump the driver version
Patches look ok to me. I am still behind on working on another fix for
4/5 which is more invasive, so that is ok with me.
Reviewed-by: Mike Christie micha
{
+ reason = FAILURE_SESSION_NOT_READY;
+ goto prepd_reject;
+ }
}
} else {
list_add_tail(task-running, conn-cmdqueue);
Looks ok to me.
Acked-by: Mike Christie micha...@cs.wisc.edu
On 08/27/2014 09:31 AM, Hannes Reinecke wrote:
On 08/19/2014 07:54 PM, Christoph Hellwig wrote:
On Sat, Aug 16, 2014 at 08:09:48PM -0700, K. Y. Srinivasan wrote:
The host asks the guest to scan when a LUN is removed or added.
The only way a guest can identify the removed LUN is when an I/O is
On 9/1/14, 1:06 PM, Dan Carpenter wrote:
I never heard back on this. It still looks like a very serious bug
with security implications etc.
Sorry about that. I must have missed the original. You are right. I
should have a tested patch by tomorrow.
regards,
dan carpenter
On Mon, Jun 24,
On 09/04/2014 05:27 AM, Dan Carpenter wrote:
Hello Mike Christie,
The patch 0e43895ec1f4: [SCSI] be2iscsi: adding functionality to
change network settings using iscsiadm from Apr 3, 2012, leads to
the following static checker warning:
drivers/scsi/be2iscsi/be_mgmt.c:945
/be_main.c |2 +-
drivers/scsi/be2iscsi/be_main.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Looks ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
Christoph, since this was only two patches I was not sure if you wanted
me to round it up with the other iscsi
On 09/29/2014 02:06 PM, James Bottomley wrote:
On Mon, 2014-09-29 at 13:55 -0500, micha...@cs.wisc.edu wrote:
From: Mike Christie micha...@cs.wisc.edu
Dan Carpenter found a issue where be2iscsi would copy the ip
from userspace to the driver buffer before checking the len
of the data being
On 10/07/2014 11:42 AM, bugzilla-dae...@bugzilla.kernel.org wrote:
* iscsiadm -m discovery -p 192.168.1.124 -t st
* iscsiadm -m node -p 192.168.1.124 -l
(something went wrong at the target side and the iSCSI initiator tried to
relogin)
Did this login command ever complete normally? Did you
On 10/18/2014 03:11 AM, Bart Van Assche wrote:
On 10/16/14 07:37, micha...@cs.wisc.edu wrote:
The following patches implement the SCSI command COMPARE_AND_WRITE as
a new
bio/request type REQ_CMP_AND_WRITE. COMPARE_AND_WRITE is defined in the
SCSI SBC (SCSI block command) specs as:
The
cxgbi_get_iscsi_ipv4(struct cxgbi_hba *chba)
-{
- return chba-ipv4addr;
-}
-
struct cxgbi_device *cxgbi_device_register(unsigned int, unsigned int);
void cxgbi_device_unregister(struct cxgbi_device *);
void cxgbi_device_unregister_all(unsigned int flag);
Looks ok.
Reviewed-by: Mike
Adding Vikas to verify if qla4xxx has the same issue.
On 11/10/2014 12:52 AM, Minh Duc Tran wrote:
From: Minh Tran minhduc.t...@emulex.com mailto:minhduc.t...@emulex.com
We are starting to see problems with certain open-iscsi
versions out there checking block valid bit.
nice to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
work.
Changes since V1:
- fix -attach for rdac, pointed out by Mike Christie
Look ok to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info
while getting it wrong.
This serie instead adds a flag to enable queue tracking and
handles it entirely in core code. This is a preparation for
various logic changes to the queue depth tracking code.
Looks nice to me.
Reviewed-by: Mike Christie micha...@cs.wisc.edu
--
To unsubscribe from
On 12/2/14, 9:09 PM, Martin K. Petersen wrote:
Mike == Michael Christie micha...@cs.wisc.edu writes:
Mike,
Mike This was the issue we worked with Microsoft on wasn’t it? You guys
Mike figured out it was fixed in their target in a recent release
Mike right?
The issue we worked recently was
On 12/03/2014 05:00 PM, Martin K. Petersen wrote:
Mike j...@deti74.ru's patch would work around the same problem because
Mike in sd_read_write_same, sd would see no_write_same is set and not
Mike send REPORT SUPPORTED OPERATION.
Yeah.
I still don't have a problem quirking the MS target.
},
{nCipher, Fastness Crypto, NULL, BLIST_FORCELUN},
{NAKAMICH, MJ-4.8S, NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
Thanks Martin.
Tested-by: Mike Christie micha...@cs.wisc.edu
In case other people test this patch, I wanted to warn people that the
MS iSCSI target does the same sequence
On 12/4/14, 8:17 PM, Martin K. Petersen wrote:
Mike == Mike Christie micha...@cs.wisc.edu writes:
Mike In case other people test this patch, I wanted to warn people that
Mike the MS iSCSI target does the same sequence (sends reject PDU then
Mike drops the connection on us) for any command
1 - 100 of 589 matches
Mail list logo
