RE: Disk errors

2005-01-31 Thread Salyzyn, Mark
The PERC controller looks after bad block reassignment. Sincerely -- Mark Salyzyn -Original Message- From: Kit Gerrits [mailto:[EMAIL PROTECTED] Sent: Monday, January 31, 2005 11:44 AM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org Subject: RE: Disk errors Indeed, I had an entire

RE: Disk Errors

2005-02-01 Thread Salyzyn, Mark
-Oorspronkelijk bericht- Van: Salyzyn, Mark [mailto:[EMAIL PROTECTED] Verzonden: dinsdag 1 februari 2005 4:15 Aan: Kit Gerrits Onderwerp: RE: Disk errors The controller does not appear to be busted; you have a Volume and a RAID-5. Are you missing an Array? A two drive failure

RE: Disk Errors

2005-02-02 Thread Salyzyn, Mark
From: Douglas Gilbert [mailto:[EMAIL PROTECTED] writes: All may not be lost. If a medium error occurs and the ASC and ASCQ imply the sector could be read but failed ECC then the READ LONG SCSI command should fetch the block (plus ECC and other data). For example a Fujitsu MAM3184 returns 576

RE: [2.6 patch] drivers/scsi/aacraid/: cleanups

2005-02-28 Thread Salyzyn, Mark
I approve this, please apply to kernel.org branch. Second time this has been submitted, been integrated since November 24th in 1.1.5-2370 of the Adaptec Branch of the driver. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of

RE: aacraid died on kernel 2.4.27

2005-03-11 Thread Salyzyn, Mark
] Sent: Friday, March 11, 2005 3:32 PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org Subject: Re: aacraid died on kernel 2.4.27 Salyzyn, Mark [EMAIL PROTECTED] writes: This is a processor based RAID card, so stability and complexity is virtually all rooted in the card. The problems you

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
I have to reject this change since pci_module_init() has a different return code than pci_register_driver(). The patch should look like: - error = pci_module_init(aac_pci_driver); + error = pci_register_driver(aac_pci_driver); - if (error) + if (error 0)

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
We have tested and seen a positive number being returned on late model distributions (FC3) Sincerely -- Mark Salyzyn -Original Message- From: Domen Puncer [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 15, 2005 10:57 AM To: Salyzyn, Mark Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org

RE: memcpy_toio/memcpy_fromio 64 bit safe?

2005-03-16 Thread Salyzyn, Mark
Unsigned long is less than pointer, the reference passed in to the 'dst' variable. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matthew Wilcox Sent: Wednesday, March 16, 2005 3:18 PM To: Salyzyn, Mark Cc: linux-scsi

RE: memcpy_toio/memcpy_fromio 64 bit safe?

2005-03-16 Thread Salyzyn, Mark
:18 PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org Subject: Re: memcpy_toio/memcpy_fromio 64 bit safe? On Wed, 2005-03-16 at 15:08 -0500, Salyzyn, Mark wrote: The dpt_i2o driver uses the function memcpy_toio to copy the message frame to the adapter. Under arch/x86_64/lib/io.c, it's helper

RE: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-17 Thread Salyzyn, Mark
: Wednesday, March 16, 2005 4:53 PM To: Salyzyn, Mark; Christoph Hellwig Cc: Ross Macintyre; linux-scsi Subject: RE: adaptec 2120S software under RedHat 8.0 and FC2 On Wed, 2005-03-16 at 08:02 -0500, Salyzyn, Mark wrote: The applications require the Adaptec Branch of the driver in order to function

RE: [PATCH 2.4.30-pre3] scsi_mod: add max_dma_memory and use_zone_normal params

2005-03-18 Thread Salyzyn, Mark
This is all done to work around a bug in the kernel dealing with ZONE_DMA. I applaud the fix, but so many drivers need to be rewritten to first try taking memory from the general pool, then dropping back to the DMA pool if not matching the dma_mask. Sincerely -- Mark Salyzyn -Original

RE: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-22 Thread Salyzyn, Mark
Christoph Hellwig said: We're not going to add new procfs handler for scsi HBA drivers. And that was the answer to the question, thanks for answering it. Isn't it nice to ask for guidance and get such direct answers? Christoph Hellwig then goes on a tirade: Unfortunately this problems shows

RE: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-23 Thread Salyzyn, Mark
Now you've gone and done it Christoph! ;-} Christoph Hellwig writes: legacy of Adaptec's non linux-supporting past. Cry with me for a moment... We all know that certification is the real issue here, most Penguins scoff at this requirement, but customers expect it none-the-less and pull us

RE: [Fwd: New driver aacraid-1.1.5.2391 for kernels 2.4.x problem.]

2005-04-01 Thread Salyzyn, Mark
AM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org; Vasily Averin Subject: [Fwd: New driver aacraid-1.1.5.2391 for kernels 2.4.x problem.] Hello! It seems to me that card initialization is broken in new driver aacraid-1.1.5.2391. The problem arises on Linux kernels 2.4.x, if the driver

RE: SAI_READ_CAPACITY_16?

2005-04-06 Thread Salyzyn, Mark
Thanks, needed to set shost-max_cmd_len to 16 in the driver. Sincerely -- Mark Salyzyn -Original Message- From: Ming Zhang [mailto:[EMAIL PROTECTED] Sent: Wednesday, April 06, 2005 12:12 PM To: Salyzyn, Mark Cc: Linux SCSI Subject: Re: SAI_READ_CAPACITY_16? we tested several iSCSI

RE: [PATCH] 2.6 aacraid: Fix for controller load based timeouts

2005-07-08 Thread Salyzyn, Mark
with using the WD JD drives, which are not compatible with RAID cards because their internal error recovery paths. Sincerely -- Mark Salyzyn -Original Message- From: Ryan Anderson [mailto:[EMAIL PROTECTED] Sent: Friday, July 08, 2005 1:42 PM To: Mark Haverkamp Cc: James Bottomley; Salyzyn, Mark

RE: PE1800 S-ATA RAID CERC6 with RHEL 3 / 4 ???

2005-07-11 Thread Salyzyn, Mark
One of the problems with this class (2.4.* based 64 bit) is the Software IOMMU. You may have to boot with 'swiotlb=12288' in order to free enough mapping resources for the card. RHEL4/CentOS4 does not have this problem. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL

RE: Location of the SCSI git trees has moved (again, sorry)

2005-08-02 Thread Salyzyn, Mark
James Bottomley sez: Trees for http pull (or rsync, substituting with rsync://) rsync://www.kernel.org/pub/scm/linux/kernel/git/jejb/ sez: WARNING: The rsync access method is DEPRECATED and will be REMOVED soon! rsync: server sent HTTP/1.0 403 Forbidden rather than greeting Mark Salyzyn sez:

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-04 Thread Salyzyn, Mark
Salyzyn -Original Message- From: Arjan van de Ven [mailto:[EMAIL PROTECTED] Sent: Thursday, August 04, 2005 4:17 AM To: Mark Haverkamp Cc: Salyzyn, Mark; linux-scsi; James Bottomley Subject: Re: [PATCH 7/7] aacraid: sgraw command support On Wed, 2005-08-03 at 15:39 -0700, Mark Haverkamp

RE: [PATCH 7/7] aacraid: sgraw command support

2005-08-05 Thread Salyzyn, Mark
PROTECTED] Sent: Friday, August 05, 2005 10:45 AM To: Mark Haverkamp Cc: Salyzyn, Mark; linux-scsi; James Bottomley Subject: RE: [PATCH 7/7] aacraid: sgraw command support On Fri, 2005-08-05 at 07:24 -0700, Mark Haverkamp wrote: On Thu, 2005-08-04 at 07:40 -0400, Salyzyn, Mark wrote

[PATCH] Bug 4940 Repeatable Kernel Panic on Adaptec 2015S I20 device on bootup

2005-08-08 Thread Salyzyn, Mark
Suitable for both 2.4 and 2.6 version of the driver. Applies to scsi-misc-2.6 git tree. Prevent driver from loading if another driver (i2o) has already claimed the resources associated with the card. Discussion associated with this bug can be referenced at

RE: Patch added to scsi-pending-2.6: [SCSI] ips: Update version information

2007-09-25 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Sunday, September 23, 2007 10:45 AM To: AACRAID; Bernhard Walle; James Bottomley Subject: Patch added to scsi-pending-2.6: [SCSI] ips: Update version information Your commit:

RE: kdump detection in SCSI drivers

2007-10-02 Thread Salyzyn, Mark
Pavel Machek sez: Other suggestion which came about was to parse the kernel command line and look for elfcorehdr=. Is this ok? Is kernel command line visible to the SCSI drivers? Kernel command line probably is visible, but I'd recommend against doing that. Probably just as pregnant of a

RE: [RFC] [PATCH 1/2] blk request timeout handler patches

2007-10-04 Thread Salyzyn, Mark
ACK for the trivial portion surrounding aacraid and ips! Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Thursday, October 04, 2007 2:18 PM To: linux-scsi@vger.kernel.org; [EMAIL PROTECTED]

RE: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size

2007-10-24 Thread Salyzyn, Mark
Jeff Garzik [mailto:[EMAIL PROTECTED] writes: is this needed, given that the default is already 65536? Apparently so, as we had to add it in the past, mainly because the feature to limit was not part of the SCSI layer when the original limit code was added. At that time it replaced a complicated

RE: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size

2007-10-24 Thread Salyzyn, Mark
PROTECTED] Sent: Wednesday, October 24, 2007 12:22 PM To: Salyzyn, Mark Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; [EMAIL PROTECTED]; AACRAID; [EMAIL PROTECTED] Subject: RE: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size On Wed, 24

RE: [PATCH 1/4] [SCSI] ips: remove ips_ha members that duplicate struct pci_dev members

2007-10-25 Thread Salyzyn, Mark
ACK. Inspected; Mechanical, precise and no introduction of bugs. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Garzik Sent: Wednesday, October 24, 2007 7:48 PM To: LKML; linux-scsi@vger.kernel.org Cc: [EMAIL

RE: [PATCH 2/4] [SCSI] ips: trim trailing whitespace

2007-10-25 Thread Salyzyn, Mark
ACK. Inspected; trivial, clean and no sign of any code changes. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Garzik Sent: Wednesday, October 24, 2007 7:48 PM To: LKML; linux-scsi@vger.kernel.org Cc: [EMAIL

RE: [PATCH 3/4] [SCSI] ips: PCI API cleanups

2007-10-25 Thread Salyzyn, Mark
ACK. Inspected only. Looks ok. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Garzik Sent: Wednesday, October 24, 2007 7:49 PM To: LKML; linux-scsi@vger.kernel.org Cc: [EMAIL PROTECTED] Subject: [PATCH 3/4] [SCSI]

RE: [PATCH 4/4] [SCSI] ips: handle scsi_add_host() failure, and other err cleanups

2007-10-25 Thread Salyzyn, Mark
ACK. Inspected. cleanup with zero risk. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Garzik Sent: Wednesday, October 24, 2007 7:49 PM To: LKML; linux-scsi@vger.kernel.org Cc: [EMAIL PROTECTED] Subject: [PATCH

RE: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Richard Knutsson Sent: Tuesday, October 30, 2007 6:54 AM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; Richard Knutsson Subject:

[PATCH 1/1] aacraid: forced reset override

2007-10-30 Thread Salyzyn, Mark
Some of our vendors have requested that our adapters ignore the hardware reset attempts during recovery and have enforced this with changes in Adapter Firmware. Some of our customers have requested the option to be able to reset the adapter under adverse adapter failure, we even had a few defects

RE: [PATCH] aacraid: don't assign cpu_to_le32(constant) to u8

2007-10-31 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn -Original Message- From: Stephen Rothwell [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 31, 2007 12:02 AM To: AACRAID Cc: linux-scsi@vger.kernel.org; LKML Subject: [PATCH] aacraid: don't assign cpu_to_le32(constant) to u8 Noticed on PowerPC

RE: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8

2007-11-01 Thread Salyzyn, Mark
ACK v2 Sincerely -- Mark Salyzyn -Original Message- From: Stephen Rothwell [mailto:[EMAIL PROTECTED] Sent: Thursday, November 01, 2007 2:32 AM To: AACRAID Cc: linux-scsi@vger.kernel.org; LKML Subject: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8 Noticed on

RE: [PATCH 1/1] [Bugme-new] [Bug 9133] New: aacraid driver fails withDell PowerEdge Expandable RAID Controller 3/Di

2007-11-02 Thread Salyzyn, Mark
PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Friday, November 02, 2007 6:12 AM To: Salyzyn, Mark; linux-scsi@vger.kernel.org Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: [PATCH 1/1] [Bugme-new] [Bug 9133] New: aacraid driver fails withDell PowerEdge Expandable RAID Controller 3/Di

RE: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-07 Thread Salyzyn, Mark
Christoph Hellwig [mailto:[EMAIL PROTECTED] sez: Did anyone run the driver through sparse to see if we have more issues like this? There are some warnings from sparse, none like this one. I will deal with the warnings ... Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the

[PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-07 Thread Salyzyn, Mark
Good point, thanks. The intent of the management applications utilization of this AIF report is to observe the LSB of the value of integer value in BlinkLED. The actions of the cpu_to_le32 actually breaks this and reports the wrong content in swapped architectures. This attached follow-up patch

RE: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

2007-11-08 Thread Salyzyn, Mark
confuses sparse. Rewriting so that the contexts are less programmatic is in order... Sincerely -- Mark Salyzyn -Original Message- From: Christoph Hellwig [mailto:[EMAIL PROTECTED] Sent: Thursday, November 08, 2007 12:28 PM To: Salyzyn, Mark Cc: Christoph Hellwig; Andreas Schwab

RE: SCSI dynamic power management

2007-11-19 Thread Salyzyn, Mark
Alan Stern sez: Sure. But that won't do any good if the requests get held on the queue (or failed immediately) because the disk is supposedly suspended. Somehow those requests have to be allowed to proceed while all others are forced to wait (or to fail). Not a failure. Not ready is

RE: [PATCH] Unify sysfs filenames for firmware version

2007-11-20 Thread Salyzyn, Mark
Jonathan McDowell sez: On Tue, Nov 20, 2007 at 11:35:26AM -0500, James Smart wrote: The hearburn I have with these patches is that you are changing driver-specific attributes, not common ones as enforced/requested by a subsystem. As such, you are breaking a management interface for

RE: [PATCH] Unify sysfs filenames for firmware version

2007-11-20 Thread Salyzyn, Mark
Jonathan McDowell [mailto:[EMAIL PROTECTED] sez: On Tue, Nov 20, 2007 at 12:49:49PM -0500, Salyzyn, Mark wrote: The aacraid cards, which uses hba_monitor_version, hba_kernel_version and hba_bios_version for each piece does not fit into the single 'firmware revision' common ideal While

RE: [patch 20/23] aacraid driver fails with Dell PowerEdge Expandable RAID Controller 3/Di

2007-11-26 Thread Salyzyn, Mark
From: Miquel van Smoorenburg [mailto:[EMAIL PROTECTED] +static int aac_scsi_32_64(struct fib * fib, struct scsi_cmnd * cmd) +{ +if ((sizeof(dma_addr_t) 4) + (num_physpages (0xULL PAGE_SHIFT)) + (fib-dev-adapter_info.options AAC_OPT_SGMAP_HOST64)) +

RE: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry indirectory) (fwd)

2007-12-11 Thread Salyzyn, Mark
Miquel van Smoorenburg sez: I got the 64-bit dpt_i2o driver from Adaptec some time ago, and I have added 64-bit support to the 2.6.23.1 dpt_i2o driver based on that driver. I intended to submit it for 2.6.25 or so ... if I have some time later today or tomorrow I'll try that next to see if

RE: broken dpt_i2o in 2.6.23 (was: ext2_check_page: bad entry indirectory) (fwd)

2007-12-12 Thread Salyzyn, Mark
ACK, patch looks good. Thanks for composing this patch. Glad to hear of successful test results. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Miquel van Smoorenburg . . . I just recompiled 2.6.23.9 with the 64 bit

RE: [PATCH] drivers/scsi/: Spelling fixes

2007-12-18 Thread Salyzyn, Mark
ACK ips line change. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Joe Perches Sent: Monday, December 17, 2007 2:40 PM To: [EMAIL PROTECTED] Cc: Andrew Morton; AACRAID; Andrew Vasquez; Brian King; IpsLinux; Hannes

[PATCH 1/1] aacraid: add aacraid.cache parameter to driver to control FUA and SYNCHRONIZE_CACHE policy

2008-01-08 Thread Salyzyn, Mark
aacraid.cache parameter, Disable Queue Flush commands: bit 0 - Disable FUA in WRITE SCSI commands bit 1 - Disable SYNCHRONIZE_CACHE SCSI command bit 2 - Disable only if Battery not protecting adapter supplied Cache e.g.: aacraid.cache=7 will disable the FUA and

[PATCH 1/1] aacraid: add call to flush_kernel_dcache_page for architectures that require it.

2008-01-08 Thread Salyzyn, Mark
Some architectures require a call to flush_kernel_dcache_page for processor spoofed DMA operations. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments (inline gets damaged, use attachment).

[PATCH 1/1] aacraid: add sysfs report of RAID level

2008-01-08 Thread Salyzyn, Mark
Report the RAID level string for the SCSI device representing the array. Report is in /sys/class/scsi_device/#:#:#:#/device/level. This attached patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments.

[PATCH 1/1] aacraid: big endian issues

2008-01-08 Thread Salyzyn, Mark
Big endian systems issues discovered in the aacraid driver. Somewhat reverses a patch from November 7th of last year that removed swap operations because they formerly were being assigned to an u8 array when they should have been assigned to an le32 array. This patch is largely inert for any

[PATCH] aacraid: 2.6.21-rc6-mm1 aacraid not finding device

2007-04-13 Thread Salyzyn, Mark
to 2.6.21-rc6-mm1. Please consider it for expedited inclusion. Signed-off-by: Mark Salyzyn [EMAIL PROTECTED] --- Sincerely -- Mark Salyzyn -Original Message- From: Steve Fox [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 10, 2007 6:21 PM To: Andrew Morton Cc: [EMAIL PROTECTED]; Salyzyn

RE: [KJ][PATCH]dpt_i2o.c-kzalloc

2007-04-16 Thread Salyzyn, Mark
Thanks Vignesh. Looks fine to me except I would prefer to drop the first fragment and update it another day, another cleanup. The 64 bit updates may need to be pushed now that the i2o_block driver appears to have no maintainer (Markus pulled, I have not checked with him why). The Adaptec version

[PATCH] aacraid: kzalloc

2007-04-16 Thread Salyzyn, Mark
Inspired somewhat by Vignesh Babu [EMAIL PROTECTED] patch to dpt_i2o.c to replace kmalloc/memset sequences with kzalloc, doing the same for the aacraid driver. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches. This attached patch is against current

RE: AACRAID fails to initialize after an kexec operation

2007-04-23 Thread Salyzyn, Mark
) !aac_rx_restart_adapter(dev, 0)) Sincerely -- Mark Salyzyn -Original Message- From: Vivek Goyal [mailto:[EMAIL PROTECTED] Sent: Monday, April 23, 2007 3:49 AM To: linux-scsi@vger.kernel.org; AACRAID Cc: Kexec Mailing List; Salyzyn, Mark Subject: AACRAID fails

[PATCH] aacraid: fails to initialize after a kexec operation

2007-04-23 Thread Salyzyn, Mark
- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark Sent: Monday, April 23, 2007 9:01 AM To: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org Cc: Kexec Mailing List Subject: RE: AACRAID fails to initialize after an kexec operation 2.6.21-rc6-mm1 contains

RE: [PATCH] aacraid: fails to initialize after a kexec operation

2007-04-24 Thread Salyzyn, Mark
). Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Vivek Goyal Sent: Tuesday, April 24, 2007 4:45 AM To: Salyzyn, Mark Cc: James Bottomley; Kexec Mailing List; Judith Lebzelter; linux-scsi@vger.kernel.org Subject: Re: [PATCH

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
Reject, this is already covered in aacraid_kexec_5.patch and again separately in aacraid_kexec_fix.patch. Sincerely -- Mark Salyzyn -Original Message- From: Darrick J. Wong [mailto:[EMAIL PROTECTED] Sent: Thursday, April 26, 2007 6:58 PM To: linux-scsi@vger.kernel.org Cc: Salyzyn

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
PROTECTED] On Behalf Of Salyzyn, Mark Sent: Friday, April 27, 2007 8:47 AM To: Darrick J. Wong; linux-scsi@vger.kernel.org Cc: Alexis Bruemmer Subject: RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them Reject, this is already covered in aacraid_kexec_5.patch

RE: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

2007-04-27 Thread Salyzyn, Mark
PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org; Alexis Bruemmer; Vivek Goyal; Judith Lebzelter Subject: Re: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them Salyzyn, Mark wrote: In my unit tests of aacraid_kexec_5.patch, restart was not called

RE: [PATCH] aacraid: fails to initialize after a kexec operation

2007-04-30 Thread Salyzyn, Mark
-Original Message- From: Vivek Goyal [mailto:[EMAIL PROTECTED] Sent: Monday, April 30, 2007 5:54 AM To: Salyzyn, Mark Cc: James Bottomley; Kexec Mailing List; Judith Lebzelter; linux-scsi@vger.kernel.org; Darrick J. Wong Subject: Re: [PATCH] aacraid: fails to initialize after

[PATCH] aacraid: superfluous adapter reset for IBM 8 series ServeRAID controllers

2007-05-01 Thread Salyzyn, Mark
-Original Message- From: Darrick J. Wong [mailto:[EMAIL PROTECTED] Sent: Friday, April 27, 2007 5:49 PM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org; Alexis Bruemmer; Vivek Goyal; Judith Lebzelter Subject: Re: [PATCH] aacraid: Initialize rx/rkt function pointers before calling them

[PATCH] aacraid: correct SUN products to README

2007-05-03 Thread Salyzyn, Mark
Correct SUN products in aacraid documentation, preliminary names were changed from internal project to customer product prior to release. ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patches attachments. This attached patch is against current scsi-misc-2.6

[PATCH] aacraid: Correct sa platform support. (Was: [Bug 8469] Bad EIP value on pentium3 SMP kernel-2.6.21.1)

2007-05-15 Thread Salyzyn, Mark
; . . . ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn [EMAIL PROTECTED] Sincerely -- Mark Salyzyn -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 15, 2007 1:30 AM To: Salyzyn

RE: [PATCH] aacraid: fix panic on short Inquiry

2007-05-16 Thread Salyzyn, Mark
Reject, transfer_len is an unsigned ... modified patch enclosed. Sincerely -- Mark Salyzyn -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 16, 2007 9:14 AM To: Salyzyn, Mark Cc: linux-scsi Subject: [PATCH] aacraid: fix panic on short Inquiry

[PATCH] aacraid: apply commit config for reset_devices flag

2007-05-22 Thread Salyzyn, Mark
- From: Salyzyn, Mark Sent: Wednesday, May 16, 2007 10:41 AM To: '[EMAIL PROTECTED]' Subject: RE: System does not boot if booted with reset_devices Vivek, could you please try the enclosed patch. This patch adds the aacraid.reset_devices flag and when either this or the global reset_devices flag

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
, May 23, 2007 8:51 AM To: Salyzyn, Mark Cc: SCSI Mailing List Subject: [PATCH] Un-remove aacraid devices Hi Mark, for some weird reason the aacraid driver insists on presenting all disks as 'removable' devices. This is gross hackery and causes userspace tools to not identify these devices as fixed

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
To: Salyzyn, Mark Cc: Hannes Reinecke; SCSI Mailing List Subject: RE: [PATCH] Un-remove aacraid devices On Wed, 2007-05-23 at 12:35 -0400, Salyzyn, Mark wrote: NAK This will break all our management applications, and will not allow us to manipulate the array configurations from within Linux

RE: [PATCH] Un-remove aacraid devices

2007-05-23 Thread Salyzyn, Mark
] On Behalf Of Salyzyn, Mark Sent: Wednesday, May 23, 2007 1:17 PM To: James Bottomley Cc: Hannes Reinecke; SCSI Mailing List Subject: RE: [PATCH] Un-remove aacraid devices The applications may issue the start of an expansion, but then disappear. The Firmware is responsible for completing the job

RE: [PATCH] [scsi] Remove __GFP_DMA

2007-05-23 Thread Salyzyn, Mark
The 31 bit limit for some of these cards is a problem, we currently only do __GFP_DMA for bounce buffer sg elements allocated for user supplied references in ioctls. I figure we should be using pci_alloc_consistent calls for these allocations to more accurately acquire memory within the 31 bit

RE: [patch 16/25] drivers/scsi/ips.c: remove kernel 2.4 code

2007-05-24 Thread Salyzyn, Mark
Looks fine, totally inert. Inspected, could see no flaws. Disclaimer: Resisting application to Adaptec version of the sources since we still have to support legacy distributions, will keep synchronized none-the-less. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED]

RE: [PATCH] [scsi] Remove __GFP_DMA

2007-05-24 Thread Salyzyn, Mark
So, is the sequence: p = kmalloc(upsg-sg[i].count,GFP_KERNEL); . . . addr = pci_map_single(dev-pdev, p, upsg-sg[i].count, data_dir); Going to ensure that we have a 31 bit (not 32 bit) physical address? If not, then I reject this patch. We can not consider replacement

RE: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-24 Thread Salyzyn, Mark
-scsi@vger.kernel.org; Salyzyn, Mark; Andrew Vasquez Subject: Re: [patch 14/25] SCSI: use irq_handler_t where appropriate On Wed, 2007-05-23 at 18:07 -0400, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED

RE: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-24 Thread Salyzyn, Mark
-Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thursday, May 24, 2007 10:04 AM To: Jeff Garzik Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; Salyzyn, Mark; Andrew Vasquez Subject: Re: [patch 14/25] SCSI: use irq_handler_t where appropriate On Thu, 2007-05-24

Re: [PATCH 4/5] SCSI: add cpu cache flushes after kmapping and modifying a page

2007-05-29 Thread Salyzyn, Mark
What ever became of the following patch? I have enclosed the incremental aacraid version of this patch to permit closure if the following was rejected because of another portion. This attached aacraid specific portion of the patch is against current scsi-misc-2.6. ObligatoryDisclaimer: Please

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
2.6.21.3 Michal, can you please add this to the regression list? commit 9e4d4a5d71d673901d9c1df5146ce545c2cc0cc0 Author: Salyzyn, Mark [EMAIL PROTECTED] Date: Tue May 1 11:43:06 2007 -0400 [SCSI] aacraid: superfluous adapter reset for IBM 8 series ServeRAID controllers

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
: Wednesday, May 30, 2007 9:25 AM To: Salyzyn, Mark Cc: Andrew Morton; Yinghai Lu; Eric W. Biederman; Linux Kernel Mailing List; linux-scsi@vger.kernel.org; Michal Piotrowski Subject: Re: kexec and aacraid broken On Wed, May 30, 2007 at 07:44:02AM -0400, Salyzyn, Mark wrote: I believe this issue

[PATCH] aacraid: Changeable queue depth

2007-05-30 Thread Salyzyn, Mark
Inspired by Brian King's patch to the ibmvscsi driver. Adds support for a changeable queue depth to the aacraid driver. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
Vivek Goyal [mailto:[EMAIL PROTECTED] writes: So most likely if we start disabling the interrupts in .shutdown routine we might skip resetting adapter on every kexec without any side affects? Not that simple. The .shutdown would need to perform more resource cleanups of the .remove call to

RE: kexec and aacraid broken

2007-05-30 Thread Salyzyn, Mark
Yinghai Lu [mailto:[EMAIL PROTECTED] writes: aacraid_commit_reset.patch is in the mainline already. But aacraid_commit_reset.patch is not in 2.6.22-rc3 (to which you report the issue). Does the aacraid_commit_reset.patch work to resolve this issue all by itself in the kexec'd kernel? Or

RE: kexec and aacraid broken

2007-05-31 Thread Salyzyn, Mark
No, still get adapter kernel panic Which adapter are you using? Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 14/19] aacraid: remove the non-use-sg case

2007-05-31 Thread Salyzyn, Mark
ACK, inspected and compile tested. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of FUJITA Tomonori Sent: Saturday, May 12, 2007 6:06 AM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED] Subject: [PATCH

RE: [PATCH 15/19] aacraid: convert to use the data buffer accessors

2007-05-31 Thread Salyzyn, Mark
ACK Inspected and compile tested Sincerely -- Mark Salyzyn -Original Message- From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] Sent: Saturday, May 12, 2007 6:06 AM To: Salyzyn, Mark Cc: linux-scsi@vger.kernel.org; [EMAIL PROTECTED] Subject: [PATCH 15/19] aacraid: convert to use

RE: kexec and aacraid broken

2007-05-31 Thread Salyzyn, Mark
[mailto:[EMAIL PROTECTED] sez: SUN coguar with 11731 On 5/31/07, Salyzyn, Mark [EMAIL PROTECTED] wrote: No, still get adapter kernel panic Which adapter are you using? - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

RE: [PATCH] aacraid: fix shutdown handler to also disable interrupts.

2007-06-01 Thread Salyzyn, Mark
Yes, this patch makes sure that the Adapter is shut down correctly, and thus when the kexec driver loads, it does not automatically reset the adapter during initialization. This regression was a result of adding code to the driver to detect if the adapter needed a reset as a result of an unclean

[PATCH] aacraid: add SCSI SYNCHONIZE_CACHE range checking.

2007-06-07 Thread Salyzyn, Mark
Customer running an application that issues SYNCHRONIZE_CACHE calls directly noticed the broad stroke of the current implementation in the aacraid driver resulting in multiple applications feeding I/O to the storage causing the issuing application to stall for long periods of time. By only waiting

[PATCH] aacraid: probe related code cleanup

2007-06-11 Thread Salyzyn, Mark
Sundry cleanups: 1) Use kzalloc instead of kmalloc. 2) Make sure probe worked before recalling the SCSI command to finalize processing. 3) _aac_probe_container2 and _aac_probe_container1 return value goes unused, change return to void. 4) Use a lower depth pointer reference to pick up the driver

RE: [PATCH] ips: convert to use the data buffer accessors

2007-06-13 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn -Original Message- From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 13, 2007 10:27 AM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; Salyzyn, Mark Subject: [PATCH] ips: convert to use the data buffer accessors

RE: [PATCH] i2o: convert to use the data buffer accessors

2007-06-13 Thread Salyzyn, Mark
Since Markus removed himself from the maintenance of this driver ... I will offer my ACK if he is truly absent since this driver is apparently primarily in support of the legacy Babylon class of I2O adapters from DPT and Adaptec. Sincerely -- Mark Salyzyn -Original Message- From:

[PATCH] aacraid: change srb status busy return

2007-06-19 Thread Salyzyn, Mark
This patch is more like a spelling correction than a fix. It was discovered that if we had a busy status return from the Adapter for the SCSI srb command to a physical component, that we returned DID_NO_CONNECT rather than what one would expect DID_BUS_BUSY. This attached patch is against current

[PATCH] aacraid: add support for long serial number information

2007-06-19 Thread Salyzyn, Mark
Support displaying long serial number information. Reuse sysfs handler internally as helper. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch attachments. Signed-off-by: Mark Salyzyn [EMAIL PROTECTED]

RE: [PATCH] aacraid: change srb status busy return

2007-06-19 Thread Salyzyn, Mark
James Bottomley mailto:[EMAIL PROTECTED] sez: On Tue, 2007-06-19 at 11:41 -0400, Salyzyn, Mark wrote: It was discovered that if we had a busy status return from the Adapter for the SCSI srb command to a physical component, that we returned DID_NO_CONNECT rather than what one would expect

[PATCH] aacraid: add cpu cache flush after kmapping and modifying a page

2007-06-20 Thread Salyzyn, Mark
content. Signed-off-by: Mark Salyzyn [EMAIL PROTECTED] drivers/scsi/aacraid/aachba.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Salyzyn, Mark Sent: Tuesday, May

[PATCH] aacraid: add SCSI SYNCHONIZE_CACHE range checking (take 2)

2007-06-20 Thread Salyzyn, Mark
] On Behalf Of Salyzyn, Mark Sent: Thursday, June 07, 2007 1:21 PM To: linux-scsi@vger.kernel.org Subject: [PATCH] aacraid: add SCSI SYNCHONIZE_CACHE range checking. Customer running an application that issues SYNCHRONIZE_CACHE calls directly noticed the broad stroke of the current implementation

RE: [patch 01/17] aacraid: rename check_reset

2007-07-09 Thread Salyzyn, Mark
ACK (well, I'd prefer aac_check_reset over aacraid_check_reset, but no matter). Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, July 09, 2007 3:00 PM To: [EMAIL PROTECTED] Cc: linux-scsi@vger.kernel.org; [EMAIL

[PATCH] aacraid: add vpd to inquiry

2007-07-16 Thread Salyzyn, Mark
Report VPD inquiry page 0x80 with an unique array creation serial number (CUID). When an array is created, the metadata stored on the physical drives gets an unique serial number. This serial number remains constant through array morphing or migration to other controllers. This patch is a forward

[PATCH] aacraid: correct valid container response in management ioctl

2007-07-17 Thread Salyzyn, Mark
During an Adapter Initiated scan request, the query disk ioctl reports a value of 2 rather than 1 for the valid field. This presents a problem for some legacy management applications. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences

[PATCH] aacraid: incorrect dma mapping mask during blinkled recover or user initiated reset

2007-07-17 Thread Salyzyn, Mark
Incorrect dma mask was used for blinkled (firmware assert) recovery or user initiated reset during initialization portion. Ensure that all callers of aac_fib_map_free null out the fib allocation references to prevent multiple free. Although serious sounding, no reports of these problems have

RE: [PATCH] aacraid: Resend, Fix security hole

2007-07-23 Thread Salyzyn, Mark
ACK. Unit tested with Adaptec RAID management applications with apparently no issue. Will push this into matrix testing in the coming week. Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Alan Cox Sent: Monday, July 23,

[PATCH] aacraid: sysfs adapter reset/status format change.

2007-07-23 Thread Salyzyn, Mark
We need to newline terminate responses from nodes within the sysfs tree, the Adapter status value reported by the reset adapter node is adjusted. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer: Please accept my condolences regarding Outlook's handling of patch

[PATCH 1/1] aacraid: draw line in sand, sundry cleanup and version update

2007-07-26 Thread Salyzyn, Mark
Minor unimportant cuttings from the floor bundled in with a version stamp update. Only controversial change is the dropping of Alan Cox copyright on the nark.c module since that file has no code written by him in it. This attached patch is against current scsi-misc-2.6 ObligatoryDisclaimer:

RE: [PATCH] dpt_i2o: convert to SCSI hotplug model

2007-07-31 Thread Salyzyn, Mark
ACK! Sincerely -- Mark Salyzyn -Original Message- From: Matthew Wilcox [mailto:[EMAIL PROTECTED] Sent: Monday, July 30, 2007 5:19 PM To: AACRAID; linux-scsi@vger.kernel.org Subject: [PATCH] dpt_i2o: convert to SCSI hotplug model dpt_i2o: Convert to new SCSI driver model -

  1   2   >