On 03/12/2013 05:39 AM, jayamoh...@gmail.com wrote:
From: Jayamohan.Kallickal jayamohan.kallic...@emulex.com
This patch fixes the display of proper FW Version from the driver.
Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal
(fast_io_fail_tmo);
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM
While we're at it: I recently figured that there are targets responding
to inquiry with PQ=1 PDT=31 for LUN0 if LUN0 has no backing device
(e.g. no disk mapped for the initiator host). While this is likely to
work with in-kernel lun scanning, the kernel does not even allocate an
sg dev in
just a small addendum regarding the naming of the w_lun variable
On 03/15/2013 04:54 PM, Steffen Maier wrote:
While we're at it: I recently figured that there are targets responding
to inquiry with PQ=1 PDT=31 for LUN0 if LUN0 has no backing device
(e.g. no disk mapped for the initiator host
From: Sebastian Ott seb...@linux.vnet.ibm.com
Let the driver core handle device attribute creation and removal. This
will simplify the code and eliminates races between attribute
availability and userspace notification via uevents.
Reviewed-by: Steffen Maier ma...@linux.vnet.ibm.com
Signed-off
James,
here is a series of zfcp features and bugfixes.
We would very much appreciate if you could integrate them for the
upcoming merge window preparing kernel v3.10.
The patches apply on top of the current misc branch of your scsi.git.
Apparently, I did something wrong on git-send-email so the
was only needed until the
introduction of NPIV and was withdrawn with z10 years ago.
It's time to cleanup the corresponding device driver code.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/Makefile |2
From: Sebastian Ott seb...@linux.vnet.ibm.com
Remove the now unused function zfcp_device_unregister since all
users have been converted to use device_unregister directly.
Reviewed-by: Steffen Maier ma...@linux.vnet.ibm.com
Signed-off-by: Sebastian Ott seb...@linux.vnet.ibm.com
Signed-off
From: Sebastian Ott seb...@linux.vnet.ibm.com
Let the driver core handle device attribute creation and removal. This
will simplify the code and eliminates races between attribute
availability and userspace notification via uevents.
Reviewed-by: Steffen Maier ma...@linux.vnet.ibm.com
Signed-off
From: Sebastian Ott seb...@linux.vnet.ibm.com
Set the owner member of zfcp_cfdc_fops, to ensure that the
caller of these functions holds a module reference.
Signed-off-by: Sebastian Ott seb...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi
online.
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_dbf.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
--- a/drivers/s390/scsi/zfcp_dbf.c
+++ b/drivers/s390/scsi/zfcp_dbf.c
@@ -3,7 +3,7 @@
*
* Debug traces for zfcp.
*
- * Copyright IBM
).
When FSF status FSF_EXCHANGE_CONFIG_DATA_INCOMPLETE is received the
adapter recovery will be finished without any retries. QDIO will be
up now and status changes such as LINK UP will be received now.
Signed-off-by: Daniel Hansel daniel.han...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma
and Scsi_Host do not transport FCP requests including SCSI commands
using protection data.
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Reviewed-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Cc: sta...@vger.kernel.org #3.2+
---
drivers/s390/scsi/zfcp_scsi.c | 10 +++---
1 file
.
While we are not aware of any other code path that could result in mempool
resize attempts of size zero, we still also initialize the number of status
read buffers to be posted to a static minimum number on adapter object
allocation.
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Cc: sta
On 04/26/2013 05:10 PM, James Bottomley wrote:
On Fri, 2013-04-26 at 16:13 +0200, Steffen Maier wrote:
James,
here is a series of zfcp features and bugfixes.
We would very much appreciate if you could integrate them for the
upcoming merge window preparing kernel v3.10.
The patches apply on top
;
__shost_for_each_device(sdev, shost) {
- if (channel == sdev_channel(sdev))
+ if (channel == -1 || channel == sdev_channel(sdev))
__scsi_report_device_reset(sdev, NULL);
}
}
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z
(rport);
A question just for my understanding: Calling fc_block_scsi_eh at the
end *after* our adapter recovery is OK to wait for rports to become
unblocked (or fast_io_failed)?
I would guess so.
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM
;
int ret;
zfcp_erp_adapter_reopen(adapter, 0, schrh_1);
zfcp_erp_wait(adapter);
- ret = fc_block_scsi_eh(scpnt);
+ ret = fc_block_scsi_eh(rport);
if (ret)
return ret;
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux
What base does this patch set apply to?
I failed with scsi:misc / scsi:fixes / vanilla.
On 06/27/2014 12:47 PM, Steffen Maier wrote:
On 06/27/2014 08:27 AM, Hannes Reinecke wrote:
Issuing a host reset should not rely on any commands.
So use Scsi_Host as argument for eh_host_reset_handler
correctly, that the only solution is to make all
INdirect (transitive) dependencies explicit with the LLDDs instead of
making the direct exploiter SCSI_NETLINK(?) depend on NET?
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM Deutschland Research Development
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
Martin Peschke (2):
zfcp: remove access control tables interface (port leftovers)
zfcp: auto port scan resiliency
Steffen Maier (1):
zfcp: bring back unit sysfs attributes
that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_aux.c | 6 +++--
drivers/s390/scsi/zfcp_ccw.c
zfcp_scsi_dev to zfcp_port
for the two already existing attributes hba_id and wwpn.
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Reviewed-by: Martin Peschke mpesc...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_sysfs.c | 52 +++---
1 file changed, 49
clean it up.
Sysfs flag is kept, though, for backward-compatibility.
Now it returns always 0.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_erp.c | 7 ---
drivers/s390/scsi/zfcp_fsf.c | 3
Hi Hannes,
I like the idea and most of the patch set, so I only have a few questions left
and some review comments below.
Just curious: Do you also plan to adapt systemd/udev, especially path_id for fc
transport with its open coded copy of int_to_scsilun()?
Since I don't see zfcp touched in
James,
here is a series of zfcp features and bugfixes
for the upcoming merge window preparing kernel v3.12.
The patches apply on top of the current misc branch of your scsi.git.
Steffen
Linux on System z Development
IBM Deutschland Research Development GmbH
Vorsitzender des Aufsichtsrats:
was dead in the first place.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_ext.h |2 --
drivers/s390/scsi/zfcp_fsf.c |9 -
2 files changed, 11 deletions(-)
--- a/drivers/s390/scsi/zfcp_ext.h
From: Martin Peschke mpesc...@linux.vnet.ibm.com
strict_strtoul and friends are obsolete. Use kstrtoul functions
instead.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Cc: Jingoo Han jg1@samsung.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi
From: Martin Peschke mpesc...@linux.vnet.ibm.com
minor cleanup for status read request
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_fsf.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion
clean it up.
Sysfs flag is kept, though, for backward-compatibility.
Now it returns always 0.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_erp.c |7 ---
drivers/s390/scsi/zfcp_fsf.c |3
...@vger.kernel.org #3.11+
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_sysfs.c | 14 ++
1 file changed, 14 insertions(+)
--- a/drivers/s390/scsi/zfcp_sysfs.c
+++ b/drivers/s390/scsi/zfcp_sysfs.c
@@ -27,6 +27,16 @@ static ssize_t zfcp_sysfs_##_feat##_##_n
static
daniel.vet...@ffwll.ch
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_qdio.c |8 +
include/linux/wait.h | 57 ++
2 files changed, 59 insertions(+), 6 deletions
Enabling the data router support by default
can increase performance in certain situations.
It is safe to do so and tolerated in LPAR and under z/VM
in case there is no data router support in that environment.
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Reviewed-by: Martin Peschke mpesc
Cc: sta...@vger.kernel.org #2.6.37+
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_erp.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
--- a/drivers/s390/scsi/zfcp_erp.c
+++ b/drivers/s390/scsi/zfcp_erp.c
@@ -102,10 +102,13
James,
as discussed, I split up bugfixes and features in two separate sets.
Here is a resend of zfcp bugfixes for 3.11-rc and stable.
The patches apply on top of the current fixes branch of your scsi.git.
Steffen
Linux on System z Development
IBM Deutschland Research Development GmbH
Cc: sta...@vger.kernel.org #2.6.37+
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_erp.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
--- a/drivers/s390/scsi/zfcp_erp.c
+++ b/drivers/s390/scsi/zfcp_erp.c
@@ -102,10 +102,13
From: Martin Peschke mpesc...@linux.vnet.ibm.com
minor cleanup for status read request
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_fsf.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion
James,
as discussed, I split up bugfixes and features in two separate sets.
Here is a resend of zfcp features for the upcoming merge window
preparing kernel v3.12.
The patches apply on top of the current misc branch of your scsi.git.
Compared to the original posting, I had to drop the following
was dead in the first place.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_ext.h |2 --
drivers/s390/scsi/zfcp_fsf.c |9 -
2 files changed, 11 deletions(-)
--- a/drivers/s390/scsi/zfcp_ext.h
From: Martin Peschke mpesc...@linux.vnet.ibm.com
strict_strtoul and friends are obsolete. Use kstrtoul functions
instead.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Cc: Jingoo Han jg1@samsung.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi
...@vger.kernel.org #3.11+
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
---
drivers/s390/scsi/zfcp_sysfs.c | 14 ++
1 file changed, 14 insertions(+)
--- a/drivers/s390/scsi/zfcp_sysfs.c
+++ b/drivers/s390/scsi/zfcp_sysfs.c
@@ -27,6 +27,16 @@ static ssize_t zfcp_sysfs_##_feat##_##_n
static
On 08/22/2013 06:30 PM, James Bottomley wrote:
On Thu, 2013-08-22 at 17:45 +0200, Steffen Maier wrote:
From: Martin Peschke mpesc...@linux.vnet.ibm.com
By popular demand, this patch brings back a couple of sysfs attributes
removed by commit 663e0890e31cb85f0cca5ac1faaee0d2d52880b5
[SCSI] zfcp
aborted\n, lun);
break;
}
}
}
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on System z Development
IBM Deutschland Research Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
On 10/14/2013 03:32 PM, Hannes Reinecke wrote:
On 10/14/2013 03:18 PM, Hannes Reinecke wrote:
On 10/14/2013 02:51 PM, Steffen Maier wrote:
On 10/14/2013 01:13 PM, Hannes Reinecke wrote:
On 10/13/2013 07:23 PM, Vaughan Cao wrote:
[1.] One line summary of the problem:
special sense code asc
Earlier, commit
1832a5862f2e1b4e5835611ee14bc30a8ed3cad5
[SCSI] change port speed definitions for scsi_transport_fc
changed the semantics of FC_PORTSPEED defines to match the Report Port
Speed Capabilities (RPSC) ELS of FC-GS/FS-LS instead of FC-HBA/SM-HBA.
It also mentions the problem that
:
=
- Implementation is not that complex
- LLD can choose at run time / during SCSI scan LUNs to be masked.
- SCSI Stack controls the device addition/removal during the scan
based on the LLD LUN masking config.
- SCSI Stack maintains the list of masked luns.
Steffen Maier
Hi Neerav,
thanks very much for your quick reply!
On 08/09/2012 09:29 PM, Parikh, Neerav wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Steffen Maier
Sent: Thursday, August 09, 2012 9:15 AM
Lately, commit
Hi Krishna,
On 08/14/2012 12:48 AM, Krishna Gudipati wrote:
From: Steffen Maier [mailto:ma...@linux.vnet.ibm.com]
On 08/11/2012 04:35 AM, kgudi...@brocade.com wrote:
[KRISHNA]: Steffen, yes you are right, currently in this proposal we only have
3 interfaces
exported from SCSI mid-layer
had to use this one for a while).
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Cc: James Bottomley james.bottom...@hansenpartnership.com
Cc: sta...@vger.kernel.org #3.4+
---
MAINTAINERS |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hi Julia,
sorry for the long delay until I finally responded.
Thanks a lot for your report and patch.
I'll queue this and send it for v3.6rcX hopefully soon.
On 07/08/2012 01:37 PM, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
If list_for_each_entry, etc complete a traversal of
From: Steffen Maier ma...@linux.vnet.ibm.com
In FC fabrics with large zones, the automatic port_rescan on incoming ELS
and any adapter recovery can cause quite some traffic at the very same
time, especially if lots of Linux images share an HBA, which is common on
s390. This can cause trouble
From: Steffen Maier ma...@linux.vnet.ibm.com
Duplicate fssrh_2 from a54ca0f62f953898b05549391ac2a8a4dad6482b
[SCSI] zfcp: Redesign of the debug tracing for HBA records.
complicates distinction of generic status read response from
local link up.
Duplicate fsscth1 from
From: Steffen Maier ma...@linux.vnet.ibm.com
If the mapping of FCP device bus ID and corresponding subchannel
is modified while the Linux image is suspended, the resume of FCP
devices can fail. During resume, zfcp gets callbacks from cio regarding
the modified subchannels but they can
(sdev) to the local auto variable struct
zfcp_scsi_dev *zfcp_sdev.
Signed-off-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Cc: sta...@vger.kernel.org #2.6.37+
---
drivers/s390/scsi/zfcp_fsf.c | 19 ++-
1 file changed, 14
From: Steffen Maier ma...@linux.vnet.ibm.com
The pl vector has scount elements, i.e. pl[scount-1] is the last valid
element. For maximum sized requests, payload-counter == scount after
the last loop iteration. Therefore, do bounds checking first (with
boolean shortcut) to not access the invalid
James,
here is a series of zfcp fixes for the current 3.6-rc.
The patches apply on top of the current fixes branch of your scsi.git.
Steffen
Linux on System z Development
IBM Deutschland Research Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Dirk Wittkopp
().
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Signed-off-by: Steffen Maier ma...@linux.vnet.ibm.com
Reviewed-by: Martin Peschke mpesc...@linux.vnet.ibm.com
Cc: sta...@vger.kernel.org #2.6.37+
---
drivers/s390/scsi/zfcp_cfdc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
for the zfcp part:
Acked-by: Steffen Maier ma...@linux.vnet.ibm.com
On 03/08/2015 04:19 AM, David Rientjes wrote:
Allocating a large number of elements in atomic context could quickly
deplete memory reserves, so just disallow atomic resizing entirely.
Nothing currently uses mempool_resize
On 03/15/2016 12:28 PM, Hannes Reinecke wrote:
On 03/15/2016 12:03 PM, Steffen Maier wrote:
On 03/15/2016 08:19 AM, Hannes Reinecke wrote:
On larger installations it is useful to disable automatic LUN
scanning, and only add the required LUNs via udev rules.
This can speed up bootup
_device.h
+enum scsi_scan_mode {
+ SCSI_SCAN_NONE = 0,
+ SCSI_SCAN_RESCAN,
+ SCSI_SCAN_MANUAL,
+};
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koe
e don't use recovery to open
WKA ports such as directory/nameserver, so we don't get REC records.
Therefore, introduce pseudo REC running records without any
actual recovery action but including D_ID of WKA port on open/close.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes:
ing disk!
sd : Device offlined - not ready after error recovery
For fix validation and to aid future debugging with other recoveries
we now also trace (un)blocking of rports.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: 5767620c383a ("[SCSI] zfcp: Do not unbl
SCSI records.")
commit a54ca0f62f953898b05549391ac2a8a4dad6482b
("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
Now we can distinguish written records again for offline level filtering.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: 250a1352b9
IZE: 24+20= 44
struct {rspsg; req;} gpn_ft; SIZE: 40*4+20=180
struct {req; rsp;} gspn; SIZE: 20+273= 293
struct {req; rsp;} rspn; SIZE: 277+16= 293
[136] } u;
}
SIZE: 432
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: 2c55b750a884 (
over both cases, add a new field to zfcp_fsf_ct_els
and fill it in on request to use in SAN response trace.
Strictly speaking the D_ID on SAN response is the FC frame's S_ID.
We don't need a field for the other end which is always us.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
F
This information was lost with
commit a54ca0f62f953898b05549391ac2a8a4dad6482b
("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
but is required to debug e.g. invalid handle situations.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: a54ca0f62f
bring back
commit d21e9daa63e009ce5b87bbcaa6d11ce48e07bbbe
("[SCSI] zfcp: Dont use 0 to indicate invalid LUN in rec trace")
which was lost with
commit ae0904f60fab7cb20c48d32eefdd735e478b91fb
("[SCSI] zfcp: Redesign of the debug tracing for recovery actions.")
Signed-off-b
V.
The zfcp-specific scsi host sysfs attribute "utilization"
triggers only zfcp_fsf_exchange_port_evaluate() correcting
the fc_host port_type again in case of NPIV.
Evaluate fsf_qtcb_bottom_config.connection_features
in zfcp_fsf_exchange_config_evaluate() where it belongs to.
Signed-off-by: Stef
Hi all,
here is a series of zfcp fixes all marked for stable.
They apply to the fixes branch of James' scsi.git or to v4.8-rc1.
Patches 1-3 are important functional bugfixes.
Patches 4-10 are serviceability regression fixes.
Steffen Maier (10):
zfcp: fix fc_host port_type with NPIV
zfcp: fix
save space by not dumping
any empty residual entries.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: 2c55b750a884 ("[SCSI] zfcp: Redesign of the debug tracing for SAN
records.")
Cc: <sta...@vger.kernel.org> #2.6.38+
Reviewed-by: Alexey Ishchuk <ai
ful retval = zfcp_fsf_req_send(req).
With that we can also remove the then again unnecessary unconditional
initialization of req which was introduced with that earlier commit.
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Suggested-by: Benjamin Block <bbl...@linux.vnet.ibm.com>
Signed-o
ce Obermann <lober...@redhat.com>
Cc: Benjamin Block <bbl...@linux.vnet.ibm.com>
Cc: Steffen Maier <ma...@de.ibm.com>
I would prefer <ma...@linux.vnet.ibm.com>.
Signed-off-by: Hannes Reinecke <h...@suse.com>
Martin introduced this feature (18a4d0a22ed6c54b67af7718
Hi Johannes,
On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
Hm, still behaves for me like
On 10/13/2016 06:24 PM, Johannes Thumshirn wrote:
On Thu, Oct 13, 2016 at 05:15:25PM +0200, Steffen Maier wrote:
I'm puzzled.
$ git bisect start fc_bsg master
3087864ce3d7282f59021245d8a5f83ef1caef18 is the first bad commit
commit 3087864ce3d7282f59021245d8a5f83ef1caef18
Author: Johannes
On 10/28/2016 01:31 PM, Hannes Reinecke wrote:
On 10/28/2016 11:53 AM, Steffen Maier wrote:
On 10/13/2016 06:24 PM, Johannes Thumshirn wrote:
On Thu, Oct 13, 2016 at 05:15:25PM +0200, Steffen Maier wrote:
I'm puzzled.
$ git bisect start fc_bsg master
MSG;
+ bsg_reply = job->reply;
+ bsg_reply->reply_payload_rcv_len = 0;
+ bsg_reply->result = -ENOMSG;
job->reply_len = sizeof(uint32_t);
fc_bsg_jobdone(job);
job->reply_len = sizeof(uint32_t);
fc_bsg_jobdone(job);
spin_lock_irq(q->queue_lock);
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Marti
be obvious in
testing.
Fixes: aceeffbb59bb ("zfcp: trace full payload of all SAN records
(req,resp,iels)")
Cc: <sta...@vger.kernel.org> #2.6.38+
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
diff
.h | 4 +
include/scsi/libfc.h | 2 +-
include/scsi/scsi_transport_fc.h | 62 ++----
20 files changed, 745 insertions(+), 856 deletions(-)
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & De
equeue() | |
* clear ERP_INUSE -|-+
... |
write_unlock_irqrestore(>erp_lock, flags);-+
Hence, we should check for both UNBLOCK and ERP_INUSE because they are
interleaved.
Also we need to explicitly check ERP_FAILED for the link down case
which currently does not clear the UNBLO
by default.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: a54ca0f62f95 ("[SCSI] zfcp: Redesign of the debug tracing for HBA
records.")
Cc: <sta...@vger.kernel.org> #2.6.37+
Reviewed-by: Benjamin Block <bbl...@linux.vnet.ibm.com>
---
drive
uot; in FC ingress path after TMF
Steffen Maier (2):
zfcp: do not trace pure benign residual HBA responses at default level
zfcp: fix rport unblock race with LUN recovery
drivers/s390/scsi/zfcp_dbf.c | 17 +--
drivers/s390/scsi/zfcp_dbf.h | 41 +--
dr
lt;00114782>] smp_start_secondary+0xda/0xe8
[<005d6efe>] restart_int_handler+0x56/0x6c
[<>] 0x0
Last Breaking-Event-Address:
[<003bf12e>] arch_spin_lock_wait+0x56/0xb0
Suggested-by: Steffen Maier <ma...@linux.vnet.ibm.com&
Just for the records: There's another bug below.
On 07/25/2017 04:14 PM, Steffen Maier wrote:
The scsi_device argument of zfcp_fc_fcp_tm() can now be NULL.
In zfcp_fsf_fcp_task_mgmt() resolve the still old argument scsi_cmnd
into scsi_device very early and only depend on scsi_device
can be NULL for target reset,
instead of a mandatory zfcp_scsi_dev.
Prepare zfcp_fsf_fcp_task_mgmt's caller zfcp_task_mgmt_function()
to have its function body only depend on a mandatory zfcp_port
and an optional scsi_device, which can be NULL for target reset.
Signed-off-by: Steffen Maier <
for the
target reset case, so do not depend on them unconditionally.
For the generic case, rather change to using zfcp_port directly.
This prepares to later change the function signature replacing the
scsi_cmnd argument with zfcp_port and an
optional scsi_device which can be NULL.
Signed-off-by: Steffen
ags:
* scsi_device if FCP_TMF_LUN_RESET,
* zfcp_port if FCP_TMF_TGT_RESET.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
---
drivers/s390/scsi/zfcp_fsf.c | 72
1 file changed, 46 insertions(+), 26 deletions(-)
diff --git a/drivers/s390/scsi/z
of zfcp_task_mgmt_function() used by
zfcp_scsi_eh_device_reset_handler() & zfcp_scsi_eh_target_reset_handler().
Since it was prepared in a previous patch, we only need to delete
some local auto variables which are now the intended arguments.
Signed-off-by: Steffen Maier <ma...@linux.vnet.
d come early before queue_work() was even done.
v2.6.35 commit a1dbfddd02d2 ("[SCSI] zfcp: Pass return code from
fc_block_scsi_eh to scsi eh") fixed v2.6.33 for the FAST_IO_FAIL case.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
Fixes: af4de36d911a ("[SCSI] zfcp: Bl
This reverts commit 2443c8b23aea ("[SCSI] zfcp: Merge FCP task management
setup with regular FCP command setup"), because this introduced a
dependency on the unsuitable SCSI command for scsi_eh / TMF.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
---
drivers/s390/scsi
are
optional and only used if scsi_cmnd is NULL, i.e. with TMFs.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
---
drivers/s390/scsi/zfcp_dbf.c | 51 ---
drivers/s390/scsi/zfcp_dbf.h | 26 +++---
drivers/s390/scsi/zfcp_ext.h
n() should not print that LUN!)
http://www.spinics.net/lists/linux-scsi/msg64.html
http://www.spinics.net/lists/linux-scsi/msg66.html
* Exact rport blocking logic in host_reset_handler.
http://www.spinics.net/lists/linux-scsi/msg65.html
Steffen Maier (9):
zfcp: drop unsuitable
scsi_cmnd,
introduce a new variant of the function called fc_block_rport()
taking an fc_rport as argument.
Refactor the old fc_block_scsi_eh() to simply delegate to fc_block_rport().
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
---
drivers/scsi/scsi_transport_fc.
Signed-off-by: Steffen Maier <ma...@linux.vnet.ibm.com>
---
drivers/s390/scsi/zfcp_scsi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
index 05c823ccb959..8e96196fa877 100644
--- a/drivers/s39
t_reset_handler)(struct scsi_cmnd *);
+ int (* eh_host_reset_handler)(struct Scsi_Host *);
/*
* Before the mid layer attempts to scan for a new device where none
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Res
s parts of that later patch. Seems not fully topically
separated patches to me, if this one is only about the fc_block_scsi_eh
aspect in zfcp_scsi_eh_host_reset_handler().
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research
lags);
+ if (ret == NEEDS_RETRY) {
+ msleep(1000);
+ goto retry_rport_blocked;
+ }
if (ret)
return ret;
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development
ruct fc_rport *rport);
enum blk_eh_timer_return fc_eh_timed_out(struct scsi_cmnd *scmd);
static inline struct Scsi_Host *fc_bsg_to_shost(struct bsg_job *job)
Aside from above thoughts, the coding of the argument change seems good.
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux o
mandatory zfcp_port and
an optional(!) scsi_device for the TMF call chains in zfcp.
I thought scsi_device must be optional because it only exists for LUN
reset but not for target reset.
Does this make sense?
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Developme
;
int (* eh_bus_reset_handler)(struct Scsi_Host *, int);
int (* eh_host_reset_handler)(struct Scsi_Host *);
anything else, that I quoted but did not comment, looks good
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
1 - 100 of 189 matches
Mail list logo
