Re: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message

- Original Message - From: "Laurence Oberman" To: "linux-scsi" Cc: "Hannes Reinecke" , "Ewan Milne" , "Bart Van Assche" , "James Bottomley" Sent: Tuesday, October 16, 2018 4:39:16 PM Subject: [PATCH] scsi_error: Remove scs

Re: SG does not ignore dxferp (direct io + mmap)

>> --- >> >> In other words, this commit made the bad behavior go away in 4.8. >> Need to look at this in more detail, it doesn't appear as if this patch >> was intended to fix such a problem. >> >> -Ewan > >Are you sure it did? I can repropduce copy_to_user() errors with 4.8 as well. >Using the

Re: [PATCH] libfc: unsafe refcounting in fc_rport_work()

- Original Message - From: James Bottomley <james.bottom...@hansenpartnership.com> To: Hannes Reinecke <h...@suse.de>, Martin K. Petersen <martin.peter...@oracle.com> Cc: Christoph Hellwig <h...@lst.de>, Ewan Milne <emi...@redhat.com>, linux-scsi@vger.ker

Re: [PATCH 5/5] Leftshift returned scsi_cmnd error code 16 bits

On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote: > The the scsi_cmnd error code is expected to be in the left 16 bits > of the result field. Change is to correct this. > > Signed-off-by: Satish Kharat > --- > drivers/scsi/fnic/fnic.h | 2 +- >

Re: [PATCH 4/5] Setting scsi host template to indicate that fnic does not support multiqueue

On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote: > Fnic does not support mutiqueue. Setting the scsi_host_template in > fnic_host_template to indicate that. > > Changing fnic_version from 1.6.0.21 to 1.6.0.22 > > Signed-off-by: Satish Kharat > --- >

Re: [PATCH 2/5] Cleanup the I/O that has timed out and is used to issue LUN reset

On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote: > In case of LUN reset, the device reset command is issued with one of > the I/Os that has timed out on that LUN. The change is to also return > this I/O with error status set to DID_RESET. > Fnic driver version changed from 1.6.0.19 to

Re: [PATCH 1/5] Fix to cleanup aborted IO to avoid device being offlined by mid-layer

On Mon, 2016-03-14 at 11:14 -0700, Satish Kharat wrote: > If an I/O times out and an abort issued by host, if the abort is > successful we need to set scsi status as DID_ABORT. Or else the > mid-layer error handler which looks for this error code, will > offline the device. Also if the original

Re: [PATCH 2/3] lpfc: fix misleading indentation

On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote: > On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > >>> vports = lpfc_create_vport_work_array(phba); > >>> - if (vports != NULL) > >>> + if (vports != NULL) { > >>>

Re: [PATCH] Avoid that long log lines are truncated

On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote: > While testing the latest version of the SRP initiator and target > drivers I encountered the following message in the kernel log: > > sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this > target have changed.

Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure

On Thu, 2016-03-10 at 02:14 -0800, Sumit Saxena wrote: > There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so > if MFI adapters fail this DCMD, it should not be considered as FATAL and > driver should not issue kill adapter and set per controller's instance > variable-

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

On Thu, 2016-03-10 at 11:25 +0100, Hannes Reinecke wrote: > The test for the existence vpd_pg83 is inverted. > > Fixes: 7e47976bcff ("scsi_sysfs: add 'is_bin_visible' callback") > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_sysfs.c | 2 +- > 1 file changed, 1

Re: [PATCH] sg: fix dxferp in from_to case

On Thu, 2016-03-03 at 00:31 -0500, Douglas Gilbert wrote: > This patch is in response to this report: > http://www.spinics.net/lists/linux-scsi/msg93456.html > > One of the strange things that the original sg driver did was let > the user provide both a data-out buffer (it followed the >

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

On Sat, 2016-03-05 at 18:10 -0500, Martin K. Petersen wrote: > Commit 397737223c59 ("sd: Make discard granularity match logical block > size when LBPRZ=1") accidentally set the granularity to one byte instead > of one logical block on devices that provide determistic zeroes after > UNMAP. > >

Re: [PATCH 0/2][RESEND] scsi_transport_fc: LUN masking

On Tue, 2016-02-23 at 18:21 +0800, Hannes Reinecke wrote: > On 02/22/2016 07:39 PM, Seymour, Shane M wrote: > > Hi Hannes, > > > > How do you know that a request for an async scan is complete (I'm assuming > > that you get > > add or change udev events)? Assuming that someone has manually

Re: [PATCH] snic: correctly check for array overrun on overly long version number

On Thu, 2016-02-25 at 22:58 +, Colin King wrote: > From: Colin Ian King > > The snic version number is expected to be 4 decimals in the form like > a netmask string with each number stored in an element in array v. > However, there is an off-by-one check on the

Re: [PATCHv8 20/23] scsi: Add 'access_state' attribute

On Tue, 2016-02-23 at 18:27 +0800, Hannes Reinecke wrote: > On 02/22/2016 11:34 PM, Bart Van Assche wrote: > > On 02/21/16 22:59, Hannes Reinecke wrote: > >> The main reason why I need the 'access_state' attribute is to decouple > >> the multipath daemon; at the moment the multipath daemon has to

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote: > It also appears to me upon further inspection that the existing code has > other problems. In particular, once mpt_mapresources() has returned > with a nonzero error code, it looks like iounmap() should be called, but > it is not

Re: [PATCH v2] fusion-mptbase: handle failed allocation for workqueue

On Thu, 2016-02-18 at 10:00 +0100, Johannes Thumshirn wrote: > On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote: > > the failure of ioc->reset_work_q is checked, > > but not ioc->fw_event_q. > > > > Signed-off-by: Insu Yun > > --- > > drivers/message/fusion/mptbase.c

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

On Tue, 2016-02-16 at 13:33 -0500, Insu Yun wrote: > > > On Tue, Feb 16, 2016 at 1:18 PM, Ewan Milne <emi...@redhat.com> wrote: > On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: > > the failure of ioc->reset_work_q is checked, >

Re: [PATCH] fusion-mptbase: handle failed allocation for workqueue

On Mon, 2016-02-15 at 21:50 -0500, Insu Yun wrote: > the failure of ioc->reset_work_q is checked, > but not ioc->fw_event_q. > > Signed-off-by: Insu Yun > --- > drivers/message/fusion/mptbase.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH] bio: return EINTR if copying to user space got interrupted

On Fri, 2016-02-12 at 09:39 +0100, Hannes Reinecke wrote: > Commit 35dc248383bbab0a7203fca4d722875bc81ef091 introduced a check for > current->mm to see if we have a user space context and only copies data > if we do. Now if an IO gets interrupted by a signal data isn't copied > into user space any

Re: [PATCH 20/23] scsi: Add 'access_state' attribute

On Mon, 2016-02-08 at 15:34 +0100, Hannes Reinecke wrote: > Add an 'access_state' attribute to struct scsi_device to > display the asymmetric LUN access state. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_scan.c | 1

Re: [PATCH 19/23] scsi_dh: add 'rescan' callback

On Mon, 2016-02-08 at 15:34 +0100, Hannes Reinecke wrote: > If a device needs to be rescanned the device_handler might need > to be rechecked, too. > So add a 'rescan' callback to the device handler and call it > upon scsi_rescan_device(). This comment should mention that you have also changed

Re: [PATCH 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning

her the current or this new ALUA code, the question is whether we want to handle it better. -Ewan > > Signed-off-by: Hannes Reinecke <h...@suse.de> > Reviewed-by: Ewan Milne <emi...@redhat.com> > Reviewed-by: Christoph Hellwig <h...@lst.de> > --- &g

Re: [PATCH 22/23] scsi_dh_alua: update 'access_state' field

On Mon, 2016-02-08 at 15:34 +0100, Hannes Reinecke wrote: > Track attached SCSI devices and update the 'access_state' field > whenever an ALUA state change has been detected. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 45 >

Re: [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled

See below. On Thu, 2016-02-04 at 01:48 -0500, Martin K. Petersen wrote: > When a storage device rejects a WRITE SAME command we will disable write > same functionality for the device and return -EREMOTEIO to the block > layer. -EREMOTEIO will in turn prevent DM from retrying the I/O and/or >

Re: [PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

On Mon, 2016-02-01 at 16:08 +0100, Maurizio Lombardi wrote: > If the link is not ready, the bnx2fc_eh_abort() function > should return FAILED. > > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/bnx2fc/bnx2fc_io.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

On Wed, 2016-01-20 at 11:01 -0500, Martin K. Petersen wrote: > Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length > limits") accidentally switched optimal I/O size reporting from bytes to > block layer sectors. > > Signed-off-by: Martin K. Petersen >

Re: scsi-debug regression with 4.5-rc?

So I have a report from our test people that the optimal_io_size sysfs value is now different by a factor of 512 from what it used to be... >Here is what is executed: > >modprobe scsi_debug dev_size_mb=32 sector_size=4096 opt_blks=64 >num_tgts=1 > >And here is what our test is capturing: >

Re: [PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which > translates to 32KB with the default logical block size. That's much > lower than what real storage devices typically report (256KB to 1MB). > > Bump the optimal

Re: [PATCH 2/3] sd: Reject optimal transfer length smaller than page size

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > Eryu Guan reported that loading scsi_debug would fail. This turned out > to be caused by scsi_debug reporting an optimal I/O size of 32KB which > is smaller than the 64KB page size on the PowerPC system in question. > > Add a check to

Re: [PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

On Wed, 2015-12-16 at 17:53 -0500, Martin K. Petersen wrote: > Some storage devices report a maximum transfer length which indicates > the maximum size of an I/O request that the device can process. This > limit is enforced in combination with the controller's max_hw_sectors > and DMA constraints

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: > On 11/17/2015 03:20 PM, Martin K. Petersen wrote: > >> "Lee" == Lee Duncan writes: > > > > Lee> Martin: I will be glad to update the patch, creating a modprobe > > Lee> parameter as suggested, if you find this

Re: [PATCH] ses: Fix problems with simple enclosures

On Tue, 2015-12-08 at 09:00 -0800, James Bottomley wrote: > Simple enclosure implementations (mostly USB) are allowed to return only > page 8 to every diagnostic query. That really confuses our > implementation because we assume the return is the page we asked for and > end up doing incorrect

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > sg_map -i > > > > in your system, you should see something with an inquiry string like > > enclosure. It's the /dev/sg of that you need to run sg_ses on. > >

Re: BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x900/0xe50

On Fri, 2015-12-04 at 11:16 -0800, James Bottomley wrote: > On Fri, 2015-12-04 at 11:58 -0500, Ewan Milne wrote: > > On Thu, 2015-12-03 at 23:20 +0100, Andrea Gelmini wrote: > > > On Thu, Dec 03, 2015 at 12:59:06PM -0800, James Bottomley wrote: > > > > sg_map -i &

Re: [PATCH v1 1/1] scsi_debug: check for bigger value first

On Thu, 2015-11-26 at 20:22 +0200, Andy Shevchenko wrote: > From: Andy Shevchenko > > Even for signed types we have to check for bigger positive value first. > Otherwise it will be never happened. > > Acked-by: Douglas Gilbert > Signed-off-by:

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

On Sun, 2015-11-22 at 12:11 -0500, Douglas Gilbert wrote: > Ruediger Meier observed a regression with the PREVENT ALLOW > MEDIUM REMOVAL command in lk 3.19: >http://www.spinics.net/lists/util-linux-ng/msg11448.html > > Inspection indicated the same regression with VERIFY(10). > > The patch

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote: > On 11/19/2015 09:23 AM, Christoph Hellwig wrote: > > It's pretty much guaranteed a block layer bug, most likely in the > > merge bios to request infrastucture where we don't obey the merging > > limits properly. > > > > Does either of

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: > Can't we have a joint effort here? > I've been spending a _LOT_ of time trying to debug things here, but > none of the ideas I've come up with have been able to fix anything. Yes. I'm not the one primarily looking at it, and we don't

Re: [PATCH] [SCSI] st: Remove obsolete scsi_tape.max_pfn

On Sun, 2015-11-15 at 12:48 +0100, Geert Uytterhoeven wrote: > Its last user was removed 10 years ago, in commit > 8b05b773b6030de5 ("[SCSI] convert st to use scsi_execute_async"). > > Signed-off-by: Geert Uytterhoeven > --- > drivers/scsi/st.h | 2 -- > 1 file changed, 2

Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

On Mon, 2015-10-26 at 15:54 +0100, Peter Oberparleiter wrote: > Writing a number to /sys/bus/scsi/devices//queue_ramp_up_period > returns the value of that number instead of the number of bytes written. > This behavior can confuse programs expecting POSIX write() semantics. > Fix this by returning

Re: [PATCH 0/3] SCSI: Fix hard lockup in scsi_remove_target()

On Wed, 2015-10-14 at 07:30 -0700, James Bottomley wrote: > On Wed, 2015-10-14 at 15:50 +0200, Johannes Thumshirn wrote: > > Removing a SCSI target via scsi_remove_target() suspected to be racy. When a > > sibling get's removed from the list it can occassionly happen that one CPU > > is > > stuck

Re: [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG

On Tue, 2015-09-22 at 22:15 +0200, Hannes Reinecke wrote: > On 09/22/2015 09:49 PM, Ewan Milne wrote: > > On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > >> The current ALUA device_handler has two drawbacks: > >> - We're sending a 'SET TARGET PORT

Re: [PATCH 17/23] scsi_dh_alua: use unique device id

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Use scsi_vpd_lun_id() to assign a unique device identification > to the alua port group structure. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 70 >

Re: [PATCH 01/23] scsi_dh_alua: Disable ALUA handling for non-disk devices

On Thu, 2015-08-27 at 14:40 +0200, Hannes Reinecke wrote: > Non-disk devices might support ALUA, but the firmware > implementation is untested and frequently broken. > As we're don't actually need it disable ALUA support > for non-disk device for now. > > Signed-off-by: Hannes Reinecke

Re: [PATCH 04/23] scsi_dh_alua: use standard logging functions

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Use standard logging functions instead of hand-crafted ones. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 34 > +- > 1 file changed, 15

Re: [PATCH 08/23] scsi_dh_alua: use flag for RTPG extended header

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > We should be using a flag when RTPG extended header is not > supported, that saves us sending RTPG twice for older arrays. > > Reviewed-by: Bart Van Assche > Reviewed-by: Christoph Hellwig >

Re: [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > The current ALUA device_handler has two drawbacks: > - We're sending a 'SET TARGET PORT GROUP' command to every LUN, > disregarding the fact that several LUNs might be in a port group > and will be automatically switched whenever

Re: [PATCH 09/23] scsi_dh_alua: use unaligned access macros

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of > open-coding it. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 23 --- > 1 file changed, 8

Re: [PATCH 11/23] scsi_dh_alua: Make stpg synchronous

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > We should be issuing STPG synchronously as we need to > evaluate the return code on failure. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 179 > + >

Re: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Add a function scsi_vpd_lun_id() to return a unique device > identifcation based on the designation descriptors of > VPD page 0x83. > > As devices might implement several descriptors the order > of preference is: > - NAA IEE Registered

Re: [PATCH 18/23] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning"

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > This reverts commit a8e5a2d593cbfccf530c3382c2c328d2edaa7b66 > > Obsoleted by the next patch. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 29 +++-- > 1

Re: [PATCH 13/23] scsi_dh_alua: Use separate alua_port_group structure

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > The port group needs to be a separate structure as several > LUNs might belong to the same group. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 211 >

Re: [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > When we receive a unit attention code of 'ALUA state changed' > we should recheck the state, as it might be due to an implicit > ALUA state transition. > At the same time a workqueue item might already be queued, which > should be started

Re: [PATCH 22/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Sending a 'REPORT TARGET PORT GROUP' command is a costly operation, > as the array has to gather information about all ports. > So instead of using RTPG to poll for a status update when a port > is in transitioning we should be sending a

Re: [PATCH 23/23] scsi_dh_alua: Update version to 2.0

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c >

Re: [PATCH 02/23] scsi_dh_alua: Use vpd_pg83 information

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > The SCSI device now has the VPD page 0x83 information attached, > so there is no need to query it again. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke > --- >

Re: [PATCH 05/23] scsi_dh_alua: return standard SCSI return codes in submit_rtpg

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Fixup submit_rtpg() to always return a standard SCSI return code. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 38 > +- > 1 file changed, 22

Re: [PATCH 06/23] scsi_dh_alua: fixup description of stpg_endio()

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Fixup copy-and-paste error in the description of stpg_endio(). > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff

Re: [PATCH 10/23] scsi_dh_alua: Pass buffer as function argument

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Pass in the buffer as a function argument for submit_rtpg(). > > Reviewed-by: Bart Van Assche > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 20

Re: [PATCH 07/23] scsi: remove scsi_show_sense_hdr()

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Last caller is gone, so remove it. > > Reviewed-by: Bart Van Assche > Reviewed-by: Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke > --- > include/scsi/scsi_dbg.h

Re: [PATCH 14/23] scsi_dh_alua: allocate RTPG buffer separately

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > The RTPG buffer will only evaluated within alua_rtpg(), > so we can allocate it locally there and avoid having to > put it into the global structure. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Hannes Reinecke

Re: [PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags()

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > All commands are issued synchronously, so no need to open-code > scsi_execute_req_flags() anymore. And we can get rid of the > static sense code structure element. > > Signed-off-by: Hannes Reinecke > --- >

Re: [PATCH 15/23] scsi_dh_alua: simplify sense code handling

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Most sense code is already handled in the generic > code, so we shouldn't be adding special cases here. > However, when doing so we need to check for > unit attention whenever we're sending an internal > command. > > Reviewed-by:

Re: [PATCH 21/23] scsi_dh_alua: update all port states

On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > When we read in the target port group state we should be > updating all affected port groups, otherwise we risk > running out of sync. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c

Re: [PATCH 2/2] bfa: Fix incorrect de-reference of pointer

On Thu, 2015-08-13 at 06:41 -0400, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Signed-off-by: Anil Gurumurthy > Tested-by: Sudarsana Kalluru > --- > drivers/scsi/bfa/bfa_ioc.c |2 +- >

Re: [PATCH 1/2] bfa: Fix indentation

On Thu, 2015-08-13 at 06:41 -0400, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Signed-off-by: Anil Gurumurthy > Tested-by : Sudarasana Kalluru > --- > drivers/scsi/bfa/bfa_ioc.c | 22

Re: [PATCH RESEND] scsi: Fix sense information setting in fixed sized format

On Thu, 2015-09-03 at 19:49 +0300, Sagi Grimberg wrote: > In fixed size sense format the information field is a four byte > field. > > Signed-off-by: Sagi Grimberg > Reviewed-by: Martin K. Petersen > Reviewed-by: Bart Van Assche

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote: On Tue, 2015-08-25 at 21:03 +, Winkler, Tomas wrote: + /* this should never happen */ + if (WARN_ON(!cmnd)) + return SCSI_MLQUEUE_HOST_BUSY; - if (NULL == cmnd || NULL == devip) {

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

On Tue, 2015-07-28 at 16:54 +0300, Tomas Winkler wrote: The function should never be called with cmnd NULL so put a fat WARN there. Fix also smatch wraning: schedule_resp() warn: variable dereferenced before check 'cmnd' Cc: Douglas Gilbert dgilb...@interlog.com Signed-off-by: Tomas

Re: [PATCH] scsi: fix memory leak with scsi-mq

On Thu, 2015-07-16 at 11:40 -0400, Tony Battersby wrote: Fix a memory leak with scsi-mq triggered by commands with large data transfer length. __sg_alloc_table() sets both table-nents and table-orig_nents to the same value. When the scatterlist is DMA-mapped, table-nents is overwritten

Re: [dm-devel] ALUA - rescan device capacity on zero sized block devices

On Thu, 2015-06-11 at 07:52 +0200, Hannes Reinecke wrote: On 06/10/2015 05:02 PM, Ewan Milne wrote: On Mon, 2015-04-20 at 07:58 +0200, Hannes Reinecke wrote: On 04/19/2015 12:56 AM, Christophe Varoqui wrote: About five years ago, we faced a somewhat simular issue with Symmetrix arrays

Re: [PATCH] scsi: Add ALUA state change UA handling

Looking at this closely, I didn't get the SDEV_UA text right in my previous review comment, and I think that additional enum values really ought to be added to the end, after existing ones, and code that handles them should follow suit. So, here's an adjusted patch... -Ewan [PATCH]

Re: [dm-devel] ALUA - rescan device capacity on zero sized block devices

On Fri, 2015-06-12 at 11:17 -0400, Ewan Milne wrote: There's an interesting, somewhat-related issue I've come across with iSCSI storage, when an event happens while the connection is not established (i.e. link down, or logged out for some reason). The T10 spec says that UAs are supposed

Re: [PATCH] scsi: retry MODE SENSE on unit attention

On Fri, 2015-06-12 at 08:27 +0200, Hannes Reinecke wrote: On 06/11/2015 05:07 PM, Ewan Milne wrote: On Thu, 2015-06-11 at 13:01 +0200, Hannes Reinecke wrote: The 'sd' driver is calling scsi_mode_sense() to figure out internal details. But scsi_mode_sense() never checks for any pending

Re: [PATCH] scsi: retry MODE SENSE on unit attention

On Thu, 2015-06-11 at 13:01 +0200, Hannes Reinecke wrote: The 'sd' driver is calling scsi_mode_sense() to figure out internal details. But scsi_mode_sense() never checks for any pending unit attentions, so we're getting annoying error messages like: MODE SENSE: unimplemented page/subpage:

Re: [PATCH] scsi_transport_fc: Add support for 25Gbit speed

On Thu, 2015-04-02 at 15:50 -0400, James Smart wrote: Add FC transport support for 25Gbit speed Signed-off-by: James Smart james.sm...@emulex.com --- drivers/scsi/scsi_transport_fc.c | 1 + include/scsi/scsi_transport_fc.h | 1 + 2 files changed, 2 insertions(+) diff --git

Re: iSCSI regression with linux 3.9 and 4.0

On Mon, 2015-03-23 at 09:53 +0100, Christian Hesse wrote: I reverted these two commits: commit 3a9794d32984b67a6d8992226918618f0e51e5d5 Author: Brian King brk...@linux.vnet.ibm.com Date: Thu Jan 29 15:54:40 2015 -0600 sd: Fix max transfer length for 4k disks commit

Re: iSCSI regression with linux 3.9 and 4.0

On Fri, 2015-03-20 at 13:57 +0100, Christian Hesse wrote: Hello everybody! I reported this issue at LKML [0] but received no answer. Hopefully linux-scsi is a better place... Beginning with linux 3.19 I see an iSCSI regressen. This works perfectly with linux 3.18.x (tested with 3.18.6)

Re: [PATCH] scsi: sd: add a capacity_override attribute

On Tue, 2015-03-17 at 14:08 -0400, Alan Stern wrote: This patch provides a sysfs interface allowing users to override the capacity of a SCSI disk. This will help in situations where a buggy USB-SATA adapter fails to support READ CAPACITY(16) and reports only the low 32 bits of the capacity in

Re: iSCSI regression with linux 3.9 and 4.0

On Fri, 2015-03-20 at 11:04 -0400, Ewan Milne wrote: Does your target support the Block Limits VPD (page B0)? (i.e. can you run sg_inq /dev/sda -p bl from the sg3_utils package?) I meant /dev/sdb, sorry. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH] scsi: sd: add a capacity_override attribute

On Fri, 2015-03-20 at 11:19 -0400, Alan Stern wrote: On Fri, 20 Mar 2015, Ewan Milne wrote: On Tue, 2015-03-17 at 14:08 -0400, Alan Stern wrote: This patch provides a sysfs interface allowing users to override the capacity of a SCSI disk. This will help in situations where a buggy

Re: iSCSI regression with linux 3.9 and 4.0

On Fri, 2015-03-20 at 15:31 +0100, Christian Hesse wrote: Ewan Milne emi...@redhat.com on Fri, 2015/03/20 09:51: On Fri, 2015-03-20 at 13:57 +0100, Christian Hesse wrote: Hello everybody! I reported this issue at LKML [0] but received no answer. Hopefully linux-scsi is a better

Re: iSCSI regression with linux 3.9 and 4.0

On Fri, 2015-03-20 at 16:24 +0100, Christian Hesse wrote: Ewan Milne emi...@redhat.com on Fri, 2015/03/20 11:04: On Fri, 2015-03-20 at 15:31 +0100, Christian Hesse wrote: Ewan Milne emi...@redhat.com on Fri, 2015/03/20 09:51: On Fri, 2015-03-20 at 13:57 +0100, Christian Hesse wrote

Re: [PATCH] scsi: sd: add a capacity_override attribute

On Fri, 2015-03-20 at 12:03 -0400, Alan Stern wrote: On Fri, 20 Mar 2015, Ewan Milne wrote: On Fri, 2015-03-20 at 11:19 -0400, Alan Stern wrote: On Fri, 20 Mar 2015, Ewan Milne wrote: On Tue, 2015-03-17 at 14:08 -0400, Alan Stern wrote: This patch provides a sysfs interface

Re: [PATCH 3/4] ch: remove debug noise in ch_do_scsi

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: The midlayer logging already prints the cdb details if the logging level is high enough, no need to duplicate this in the ch driver. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/ch.c | 8 1 file changed,

Re: [PATCH 4/4] sr: reduce debug noise in sr_do_ioctl

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: The midlayer scsi logging already logs the command and sense code if the logging level is high enough, no need to duplicate that in the sr driver. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/sr_ioctl.c | 18

Re: [PATCH 2/4] scsi: annotate sdev_prefix_printk and scmd_printk as printf-like

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- include/scsi/scsi_device.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index

Re: [PATCH 1/4] scsi: always use format argumets for dev_printk

On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_logging.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c index

Re: [PATCH] scsi: Avoid crashing if device uses DIX but adapter does not support it

On Wed, 2015-01-14 at 20:18 -0500, Martin K. Petersen wrote: Ewan == Ewan D Milne emi...@redhat.com writes: Ewan This can happen if a multipathed device uses DIX and another path Ewan is added via an adapter that does not support it. Multipath Ewan should not allow this path to be added,

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

On Mon, 2015-01-12 at 14:29 +0100, Hannes Reinecke wrote: On 01/12/2015 02:12 PM, Ewan Milne wrote: On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs, and it doesn't display any additional information

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

On Mon, 2015-01-12 at 09:57 -0500, Ewan Milne wrote: On Mon, 2015-01-12 at 14:29 +0100, Hannes Reinecke wrote: On 01/12/2015 02:12 PM, Ewan Milne wrote: On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs

Re: [PATCH 9/9] scsi_error: do not display kernel pointer in message logs

On Thu, 2015-01-08 at 07:43 +0100, Hannes Reinecke wrote: It is not good practice to display the kernel pointer in any message logs, and it doesn't display any additional information. And as we know have block-layer assigned tags we can use them to differentiate the messages. So remove any

[LSF/MM ATTEND] [LSF/MM TOPIC]

, when these properties change, we do not always handle it very well (e.g. multipath stops using a path if the capacity changes, even if it the only good path to the device...) -Ewan Milne emi...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH V6 0/3] scsi: Configure number of LUs reported by 'report-luns'

On Tue, 2014-12-16 at 11:01 -0500, Rob Evers wrote: This patch set retrieves the number of LUs available on a target using the report-luns command by re-sizing the returned data buffer and retrying report luns. A minor bug fix is included. scsi_mod parameter max_report_luns is no longer

Re: [PATCH] lpfc: correct device removal deadlock after link bounce

On Tue, 2014-12-30 at 12:08 -0500, James Smart wrote: This patch, applicable to 8G/4G/2G adapters, adds a call that resumes transmit operations after a link bounce. Without it, targets that tried to suspend exchanges after a link bounce (such as tape devices using sequence level error

Re: [PATCH] scsi_debug: fix sanity check in resp_rsup_opcodes

On Mon, 2014-12-22 at 11:37 -0500, Douglas Gilbert wrote: David Binderman pointed out in this post: http://marc.info/?l=linux-scsim=141924469523474w=2 a sanity check that was flawed. See attached fix. Should be applied to lk 3.19.0-rc1 and Christoph's branches. ChangeLog: fix

Re: [PATCH] scsi_debug: fix compare and write errors

On Wed, 2014-11-26 at 12:45 -0500, Douglas Gilbert wrote: From: Douglas Gilbert dgilb...@interlog.com Date: Wed, 26 Nov 2014 12:33:48 -0500 Subject: [PATCH] scsi_debug fix compare and write errors Kernel build tools pointed out a memory leak so that has been fixed and its error paths

Re: [PATCH] scsi_debug: improve driver description in Kconfig

On Wed, 2014-11-26 at 14:55 -0500, Douglas Gilbert wrote: From: Douglas Gilbert dgilb...@interlog.com Date: Wed, 26 Nov 2014 14:41:55 -0500 Subject: [PATCH] scsi_debug improve driver description in Kconfig Try to give a more accurate driver description and some extra useful information in

  1   2   >