Re: [PATCH 18/28] pm8001: switch to generic DMA API

Christoph Hellwig 于2018年10月11日周四 下午9:38写道： > > Switch from the legacy PCI DMA API to the generic DMA API. > > Signed-off-by: Christoph Hellwig Reviewed-by: Jack Wang Thanks, Jack

mpt3sas remove device erros

Hi, We have ssd failure sometimes, and mpt3sas remove the devices automatically, and readd again. For example [Tue Jul 31 13:46:58 2018] sd 11:0:4:0: device_block, handle(0x000d) [Tue Jul 31 13:47:00 2018] sd 11:0:4:0: device_unblock and setting to running, handle(0x000d) [Tue Jul 31 13:47:00

Re: [PATCH, RESEND] Avoid that SCSI device removal through sysfs triggers a deadlock

gt; https://www.mail-archive.com/linux-scsi@vger.kernel.org/msg54525.html. > > Suggested-by: Eric W. Biederman > Fixes: ac0ece9174ac ("scsi: use device_remove_file_self() instead of > device_schedule_callback()") > Signed-off-by: Bart Van Assche > Cc: Eric W. Biederman > Cc: Tejun Heo > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Ingo Molnar > Cc: Oleg Nesterov > Cc: Looks good to me! Reviewed-by: Jack Wang

Re: How to Locate drive directly attached to mpt3sas HBA

2018-03-19 18:44 GMT+01:00 James Bottomley <james.bottom...@hansenpartnership.com>: > On Mon, 2018-03-19 at 17:30 +0100, Jack Wang wrote: >> > >> > >> > > >> > > And I think either mpt2sas and/or mpt3sas HBAs (I don't have my >> > >

Re: How to Locate drive directly attached to mpt3sas HBA

> >> And I think either mpt2sas and/or mpt3sas HBAs (I don't have my hardware >> nearby) have a SMP target hidden away somewhere. Perhaps someone from >> LSI/Avago/Broadcom could supply more information about that. Indeed, mpt3sas has internal enclosure some how. snip from "sas3ircu 0 display"

Re: How to Locate drive directly attached to mpt3sas HBA

2018-03-19 15:20 GMT+01:00 Douglas Gilbert <dgilb...@interlog.com>: > On 2018-03-19 11:40 AM, Jack Wang wrote: >> >> Hi list, >> >> Any one knows how can I locate a HDD directly attached to mpt3sas, >> sas3ircu only supports LOCATE commd to locates

How to Locate drive directly attached to mpt3sas HBA

Hi list, Any one knows how can I locate a HDD directly attached to mpt3sas, sas3ircu only supports LOCATE commd to locates driver installed in a disk enclosure, but not directly attached. I know microsemi/PMCs supports SGPIO interface to locate drive eg: Adp80xxapp sgpio 0 set 0 1 I searched

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-02-27 12:50 GMT+01:00 John Garry : > On 27/02/2018 06:59, Jason Yan wrote: >> >> When ata device doing EH, some commands still attached with tasks are not >> passed to libata when abort failed or recover failed, so libata did not >> handle these commands. After these

[PATCH] sd: succeed check_event if device is not removable

From: Jack Wang <jinpu.w...@profitbricks.com> The check_events interface was added for check if device changes, mainly for device is removable eg. CDROM In sd_open, it checks if device is removable then check_disk_change. when the device is not removable, we can simple succeeds the call w

Re: PMC(Adaptec) 7805H(7H series) HBA compatibility problem with many Seagate HDDs

+cc Viswas from micorsemi. maybe he can help. 2018-01-12 12:15 GMT+01:00 : > > Hello, we have a long standing issue for a couple of years with our SAS HBA. > > It happens no matter what distribution we use(Debian, CentOS, Ubuntu). > > When we bought this HBA we had

Re: [PATCH 0/2] sd: Fix a deadlock between event checking and device removal

2017-11-17 18:01 GMT+01:00 Bart Van Assche <bart.vanass...@wdc.com>: > On Fri, 2017-11-17 at 16:14 +0100, Jack Wang wrote: >> I suspect could be missing run queue or lost IO, IMHO it's unlikely >> below disk probing fix the bug. > > If the system is still in this st

Re: [PATCH 0/2] sd: Fix a deadlock between event checking and device removal

2017-11-14 18:33 GMT+01:00 Bart Van Assche <bart.vanass...@wdc.com>: > On Tue, 2017-11-14 at 18:01 +0100, Jack Wang wrote: >> I suspect we run into same bug you were trying to fix in this patch >> set. we're running in v4.4.50 >> >> I was trying to reproduce it, bu

Re: [PATCH 0/2] sd: Fix a deadlock between event checking and device removal

2016-11-14 19:35 GMT+01:00 Bart Van Assche : > On 11/12/2016 09:47 PM, James Bottomley wrote: >> >> On Fri, 2016-11-11 at 16:38 -0800, Bart Van Assche wrote: >>> >>> Hello James and Martin, >>> >>> This short patch series fixes a deadlock that I ran into for the >>>

Re: [PATCH v4 05/11] libsas: Use dynamic alloced work to avoid sas event lost

nregister_ports(struct sas_ha_struct *sas_ha) > sas_deform_port(sas_ha->sas_phy[i], 0); > > } > + > +const work_func_t sas_port_event_fns[PORT_NUM_EVENTS] = { > + [PORTE_BYTES_DMAED] = sas_porte_bytes_dmaed, > + [PORTE_BROADCAST_RCVD] = sas_porte_broadcast_rcvd, > + [PORTE_LINK_RESET_ERR] = sas_porte_link_reset_err, > + [PORTE_TIMER_EVENT] = sas_porte_timer_event, > + [PORTE_HARD_RESET] = sas_porte_hard_reset, > +}; > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h > index 99f32b5..c80321b 100644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -292,6 +292,7 @@ struct asd_sas_port { > struct asd_sas_event { > struct sas_work work; > struct asd_sas_phy *phy; > + int event; > }; > > static inline struct asd_sas_event *to_asd_sas_event(struct work_struct > *work) > @@ -301,17 +302,20 @@ static inline struct asd_sas_event > *to_asd_sas_event(struct work_struct *work) > return ev; > } > > +static inline void INIT_SAS_EVENT(struct asd_sas_event *ev, void > (*fn)(struct work_struct *), > + struct asd_sas_phy *phy, int event) > +{ > + INIT_SAS_WORK(>work, fn); > + ev->phy = phy; > + ev->event = event; > +} > + > + > /* The phy pretty much is controlled by the LLDD. > * The class only reads those fields. > */ > struct asd_sas_phy { > /* private: */ > - struct asd_sas_event port_events[PORT_NUM_EVENTS]; > - struct asd_sas_event phy_events[PHY_NUM_EVENTS]; > - > - unsigned long port_events_pending; > - unsigned long phy_events_pending; > - > int error; > int suspended; > > -- > 2.5.0 > Looks good, thanks! Reviewed-by: Jack Wang <jinpu.w...@profitbricks.com>

Re: [PATCH v4 07/11] libsas: make the event threshold configurable

0644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -679,6 +679,7 @@ extern int sas_bios_param(struct scsi_device *, > sector_t capacity, int *hsc); > extern struct scsi_transport_template * > sas_domain_attach_transport(struct sas_domain_function_template *); > +extern struct device_attribute dev_attr_phy_event_threshold; > > int sas_discover_root_expander(struct domain_device *); > > -- > 2.5.0 > Looks good, thanks! Reviewed-by: Jack Wang <jinpu.w...@profitbricks.com>

Re: [PATCH 3/6] pm80xx : Different SAS addresses for phys.

fferent SAS addresses, this will cause duplicate > domain unless we set the strict_wide_port to 1. > > Regards, > Viswas G Ok, understand now! Acked-by: Jack Wang <jinpu.w...@profitbricks.com> Thanks! > > >> -Original Message- >> From: Jack Wang [mailto:xjt

Re: [PATCH 1/6] pm80xx : redefine sas_identify_frame structure

efinition. > > Regards, > Viswas G Hi Viswas, The spasti field is only for pm80xx, not for pm8001, I think it's better to move sas_identify_frame_local to pm80xx_hwi.h. Regards, Jack > >> -Original Message- >> From: Jack Wang [mailto:xjtu...@gmail.com] >&g

Re: [PATCH 5/6] pm80xx : panic on ncq error cleaning up the read log

= 0; > pm8001_ha_dev->id |= NCQ_READ_LOG_FLAG; > pm8001_ha_dev->id |= NCQ_2ND_RLE_FLAG; > > -- > 2.12.3 > Thanks. Looks good to me! Acked-by: Jack Wang <jinpu.w...@profitbricks.com>

Re: [PATCH 4/6] pm80xx : Corrected SATA abort handling.

2015-01-30 7:06 GMT+01:00 Viswas G : > Modified SATA abort handling with following steps: > 1) Set device state as recovery. > 2) Send phy reset. > 3) Wait for reset completion. > 4) After successful reset, abort all IO's to the device. > 5) After aborting all IO's to

Re: [PATCH 2/6] pm80xx: ILA and inactive firmware version through sysfs

rivers/scsi/pm8001/pm80xx_hwi.h > index 1ee2ec210065..d8e5d81e83f1 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.h > +++ b/drivers/scsi/pm8001/pm80xx_hwi.h > @@ -1349,6 +1349,8 @@ typedef struct SASProtocolTimerConfig > SASProtocolTimerConfig_t; > #define MAIN_SAS_PHY_ATTR_TABLE_OFFSET 0x90 /* DWORD 0x24 */ > #define MAIN_PORT_RECOVERY_TIMER 0x94 /* DWORD 0x25 */ > #define MAIN_INT_REASSERTION_DELAY 0x98 /* DWORD 0x26 */ > +#define MAIN_MPI_ILA_RELEASE_TYPE 0xA4 /* DWORD 0x29 */ > +#define MAIN_MPI_INACTIVE_FW_VERSION 0XB0 /* DWORD 0x2C */ > > /* Gereral Status Table offset - byte offset */ > #define GST_GSTLEN_MPIS_OFFSET 0x00 > -- > 2.12.3 > Thanks, looks good to me. Acked-by: Jack Wang <jinpu.w...@profitbricks.com>

Re: [PATCH 3/6] pm80xx : Different SAS addresses for phys.

2015-01-30 7:06 GMT+01:00 Viswas G : > Different SAS addresses are assigned for each set of phys. > > Signed-off-by: Viswas G > --- > drivers/scsi/pm8001/pm8001_init.c | 13 + > drivers/scsi/pm8001/pm80xx_hwi.c | 3 +-- > 2 files

Re: [PATCH 1/6] pm80xx : redefine sas_identify_frame structure

2015-01-30 7:06 GMT+01:00 Viswas G : > sas_identify structure defined by pm80xx doesn't have CRC field. > So added a new sas_identify structure without CRC. > > Signed-off-by: Raj Dinesh > Signed-off-by: Viswas G > --- >

Re: [PATCH 6/6] pm80xx : corrected linkrate value.

ine LINKRATE_60(0x04 << 8) > #define LINKRATE_120 (0x08 << 8) > > /* phy_profile */ > -- > 2.12.3 > Thanks Viswas, how did this happen, checked pm8001_hwi.h, it's right. Anyway, looks good to me! Acked-by: Jack Wang <jinpu.w...@profitbricks.com>

[PATCH] MAINTAINERS: remove pmchba list for PM8001

From: Jack Wang <jinpu.w...@profitbricks.com> The email address is undeliverable for some time now, so just remove it. Signed-off-by: Jack Wang <jinpu.w...@profitbricks.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 12a5

Re: Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

below > wrong error message even though vSES device has failed the command > with illegal request error message and it has not returned any wrong > diagnostic page. > > sdev_printk(KERN_ERR, sdev, > "Wrong diagnostic page; asked for %d got %u\n", > page_code, recv_page_code); > > Thanks, > Sreekanth Hi Sreekanth, To me, we should fix ses module to check 00h List of Supported Diagnostic Pages first before ask for 07h. Add James in CC. Cheers, Jack Wang

Re: Help needed for a SCSI hang (SATA drives)

2017-03-07 1:54 GMT+01:00 V : > Hi, > > I am reaching out regarding a SCSI error handler issue, which we see > in our lab systems. > > Environment: Ubuntu 4.4.0-31-generic > > Issue: Write IOs are getting stuck in our system randomly. All drives > seen with the issue are

Re: mvsas escalated kernel crash and ata mapping mvsas driver question

= 1 is not to much Yes, sdq maps to ata21. Regards, Jack > > Kind regards, > > Jelle de Jong > > On 26/01/17 11:17, Jack Wang wrote: >> >> 2017-01-26 10:51 GMT+01:00 Jelle de Jong <jelledej...@powercraft.nl>: >>> >>> Hello everybody, &

Re: mvsas escalated kernel crash and ata mapping mvsas driver question

2017-01-26 10:51 GMT+01:00 Jelle de Jong : > Hello everybody, > > I got a server that seemingly random gets kernel crashes, due to an > escalation of events from most likely the mvsas based disk controller. > > The harddisk should be okay, I replaced a whole bunch to be

Re: [Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

ers. > We will submit those soon with all the buf fixes and performance > tuning changes. > > Regards, > Viswas G > > On Thu, Jul 7, 2016 at 10:04 PM, <bugzilla-dae...@bugzilla.kernel.org> wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=121531 >> >

Re: [SCSI] pm80xx: Phy settings support for motherboard controller.

> > drivers/scsi/pm8001/pm80xx_hwi.c:4554 mpi_set_phy_profile_req() > error: uninitialized symbol 'tag'. > Thanks for reporting, attached patch should fix the warning. From e30af801d9ee9979b2a7a2af815cb395c2255a09 Mon Sep 17 00:00:00 2001 From: Jack Wang <jinpu.w...@pro

[PATCH 3/3] mvsas: remove SCSI host before detaching from SAS transport

stem. Fix it by remove scsi host first, this way scsi core will not send commands down after detaching SAS transport. This is a follow up fix for Benjamin's fix for pm80xx. See also: http://www.spinics.net/lists/linux-scsi/msg90088.html Signed-off-by: Jack Wang <jinpu.w...@profitbricks.com> --- dr

[PATCH 1/3] isci: remove SCSI host before detaching from SAS transport

stem. Fix it by remove scsi host first, this way scsi core will not send commands down after detaching SAS transport. This is a follow up fix for Benjamin's fix for pm80xx. See also: http://www.spinics.net/lists/linux-scsi/msg90088.html Signed-off-by: Jack Wang <jinpu.w...@profitbricks.com> --- d

[PATCH 2/3] aic94xx: remove SCSI host before detaching from SAS transport

stem. Fix it by remove scsi host first, this way scsi core will not send commands down after detaching SAS transport. This is a follow up fix for Benjamin's fix for pm80xx. See also: http://www.spinics.net/lists/linux-scsi/msg90088.html Signed-off-by: Jack Wang <jinpu.w...@profitbricks.com> --- driv

Re: [PATCH 1/8] pm80xx: configure PHY settings based on subsystem vendor ID

Reviewed-by: Jack Wang <jinpu.w...@profitbricks.com> Thanks Jack 2015-10-30 15:53 GMT+01:00 Benjamin Rood <benjaminjr...@gmail.com>: > Previuosly, all PMC Sierra 80xx controllers are assumed to be a > motherboard controller, except if the subsystem vendor ID was equal to >

Re: [PATCH 7/8] pm80xx: wait a minimum of 500ms before issuing commands to SPCv

2015-10-30 15:53 GMT+01:00 Benjamin Rood : > The documentation for the 8070 and 8072 SPCv chip explicitly states that > a minimum of 500ms must elapse before issuing commands, otherwise the > SPCv may not process them and the firmware may get into an unrecoverable > state

Re: [PATCH 8/8] pm80xx: avoid a panic if MSI(X) interrupts are disabled

/* Tasklet for non msi-x interrupt handler */ > - if ((!pdev->msix_cap) || (pm8001_ha->chip_id == chip_8001)) > + if ((!pdev->msix_cap || !pci_msi_enabled()) || > + (pm8001_ha->chip_id == chip_8001)) > tasklet_init(_ha->taskl

Re: [PATCH] pm80xx: remove the SCSI host before detaching from SAS transport

2015-10-30 21:01 GMT+01:00 Benjamin Rood : > Previously, when this module was unloaded via 'rmmod' with at least one > drive attached, the SCSI error handler thread would become stuck in an > infinite recovery loop and lockup the system, necessitating a reboot. > > Once

Re: [PATCH 2/8] pm80xx: add support for PMC Sierra 8070 and PMC Sierra 8072 SAS controllers

|| (dev->device == 0X8077)) > + || (dev->device == 0X8077) \ > + || (dev->device == 0X8070) \ > + || (dev->device == 0X8072)) > > #define

Re: [PATCH 0/8] pm80xx: Driver updates

|5 +- 6 files changed, 112 insertions(+), 36 deletions(-) For the whole patchset: Reviewed-by: Jack Wang jinpu.w...@profitbricks.com PS: company policy requests to use the email address of the company, please cc me to above address next time, I will send a patch to update my email

Re: [PATCH] pm80xx: Added pm8006 controller support

Sorry for delay, I missed this patch. Acked-by: Jack Wang xjtu...@gmail.com 2015-02-12 7:34 GMT+01:00 Suresh Thiagarajan suresh.thiagara...@pmcs.com: Added the pm8006 controller id in pci table Signed-off-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com Signed-off-by: Viswas G viswa

Re: [PATCH 10/11] scsi: don't force tagged_supported in drivers

2014-11-04 8:54 GMT+01:00 Christoph Hellwig h...@lst.de: Now that we also get proper values in cmd-request-tag for untagged commands, there is no need to force tagged_supported to on in drivers that need host-wide tags. Signed-off-by: Christoph Hellwig h...@lst.de ---

Re: [Bug 85151] pm80xx + 7805H + HP SAS port expander = mpi_smp_completion 2604:smp IO status 0x2 and sas: expander ... discovery failed(0xffffffa6)

Cc pmchba maillist. 2014-09-25 18:20 GMT+02:00 bugzilla-dae...@bugzilla.kernel.org: https://bugzilla.kernel.org/show_bug.cgi?id=85151 --- Comment #6 from Jack Wang xjtu...@gmail.com --- Ah, I forgot no bsg node if expander discover failed:( HBA SAS address is 0, does not matter. From my

Re: [PATCH 3/3] pm8001: Update MAINTAINERS list

If it works, then I'm fine with this, thanks. Please add my ack if needed: Acked-by: Jack Wang xjtu...@gmail.com 2014-07-31 14:53 GMT+02:00 Suresh Thiagarajan suresh.thiagara...@pmcs.com: On Wed, Jul 30, 2014 at 5:42 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed

Re: [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix()

Hi Alex, Looks Ok for me. Please feel free to add my: Reviewed-by: Jack Wang xjtu...@gmail.com Thanks, Jack 2014-07-26 10:33 GMT+02:00 Alexander Gordeev agord...@redhat.com: On Wed, Jul 16, 2014 at 08:05:22PM +0200, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement

Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up uninitialized variables

Looks good, thanks Rickard. Acked-by: Jack Wang xjtu...@gmail.com On 06/01/2014 03:13 PM, Rickard Strandqvist wrote: There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off

Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once

Thanks Rickard, From my point of view, looks good, but I'd like to get review from Anand (cc-ed). Anand, could you share your opinion? Regards, Jack On 06/25/2014 04:01 PM, Rickard Strandqvist wrote: A struct member variable is set to different values without having used in between. This

Re: [PATCH V2] pm80xx: Fix hibernation issue

Thanks Brad for testing and fixing. Acked-by: Jack Wang xjtu...@gmail.com On 06/19/2014 05:13 PM, bradley.gr...@gmail.com wrote: From: Bradley Grove bgr...@attotech.com During hibernation, the HBA firmware may lose power and forget the device id info. This causes the HBA to reject IO upon

Re: [PATCH] pm8001: Fix potential null pointer dereference and memory leak.

On 06/17/2014 01:15 PM, Maurizio Lombardi wrote: The pm8001_get_phy_settings_info() function does not check the kzalloc() return value and does not free the allocated memory. Signed-off-by: Maurizio Lombardi mlomb...@redhat.com Looks good, thanks Acked-by: Jack Wang xjtu...@gmail.com

Re: [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks

))); + kfree(payload.func_specific); return str - buf; } static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show, NULL); Thanks, looks good. Acked-by: Jack Wang xjtu...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH 16/22] pm8001: Fix invalid success return when request_irq() failed

-by: Jack Wang xjtu...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 17/22] pm8001: Use pci_enable_msix_range()

; } + pci_disable_msix(pm8001_ha-pdev); + break; } } + return rc; } #endif Thanks, looks fine. Acked-by: Jack Wang xjtu...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH V2] pm80xx: Spinlock fix

-off-by: Oleg Nesterov o...@redhat.com Signed-off-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com Signed-off-by: Viswas G viswa...@pmcs.com Looks good to me, thanks. Acked-by: Jack Wang xjtu...@gmail.com --- drivers/scsi/pm8001/pm8001_hwi.c | 84

Re: [PATCH] pm80xx: Spinlock fix

On 12/23/2013 02:07 PM, Tomas Henzl wrote: On 12/18/2013 12:28 PM, Viswas G wrote: From 9338d4bc92b23b4c283f9bd6812646ab74866a40 Mon Sep 17 00:00:00 2001 From: Suresh Thiagarajan suresh.thiagara...@pmcs.com Date: Mon, 16 Dec 2013 21:15:20 +0530 Subject: [PATCH] pm80xx: Spinlock fix

Re: [PATCH] pm80xx: Spinlock fix

use global flags, you may change interrupt state depends on context. On Mon, Dec 23, 2013 at 8:45 AM, Suresh Thiagarajan suresh.thiagara...@pmcs.com wrote: -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, December 23, 2013 7:03 PM To: Tomas Henzl; Viswas G

Re: [PATCH 0/2] pm80xx: Fix ATTO pm8001 based HBA support

. pm80xx: Enable BAR shift to avoid BIOS conflict with MPI space for ATTO pm8001 based HBAs. drivers/scsi/pm8001/pm8001_hwi.c | 6 +++--- drivers/scsi/pm8001/pm8001_init.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) Looks fine, thanks Acked-by: Jack Wang xjtu

Re: [PATCH 0/2] pm8001 driver code cleanup

On 11/27/2013 06:40 AM, Viswas G wrote: We are resubmitting the following patches in the new patch set pm80xx : Removing redundant code snippets pm80xx : Fixed return value issue Please discard the previous patches we submitted for the same. [PATCH 5/6] pm80xx : Removing redundant code

Re: [PATCH 5/6] pm80xx : Removing redundant code snippets

On 11/20/2013 08:21 AM, Viswas G wrote: Removed redundant code snipptes in pm8001_hwi.c and pm8001_ctl.c Signed-off-by: Viswas G viswa...@pmcs.com Looks good, thanks Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm8001_ctl.c | 22

Re: [PATCH 6/6] pm80xx : Fixed return value issue

On 11/20/2013 08:22 AM, Viswas G wrote: pm8001_get_gsm_dump() was returning 1 in error case instead of negative error code. Signed-off-by: Viswas G viswa...@pmcs.com Looks good, thanks Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm8001_hwi.c |8

Re: [PATCH V1 1/3] pm80xx: Fix for direct attached device.

attached SATA device delay is not enough. It will give crash for set device state command response and wait_for_completion is the best solution for this. Nice catch, Reviewed-by: Jack Wang jinpu.w...@profitbricks.com PS: the signed-off chain is not right, From author should come first here Nikith

Re: [PATCH V1 2/3] pm80xx: Resetting the phy state.

...@pmcs.com Nice catch, Thanks Reviewed-by: Jack Wang jinpu.w...@profitbricks.com PS: same about the signed-off chain. --- drivers/scsi/pm8001/pm8001_hwi.c |2 ++ drivers/scsi/pm8001/pm8001_hwi.h |4 drivers/scsi/pm8001/pm80xx_hwi.c |2 ++ drivers/scsi/pm8001/pm80xx_hwi.h |2

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

-Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, November 04, 2013 4:00 PM To: Viswas G Cc: linux-scsi@vger.kernel.org; Sangeetha Gnanasekaran; Nikith Ganigarakoppal; Anand Kumar Santhanam; Suresh Thiagarajan Subject: Re: [PATCH 11/11] pm80xx : gpio feature

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

Port product revision level: smp_read_gpio /dev/bsg/sas_host0 Read GPIO register response: GPIO_CFG[0]: version: 0 GPIO enable: 1 cfg register count: 2 gp register count: 1 supported drive count: 16 Regards, Jack -Original Message- From: Jack Wang [mailto:xjtu

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

Hi Viswas, As ioctl interface is not welcome for new feature, that's why we removed ioctl interface when pm8001 accepted into mainline. I suggest you use bsg interface for this, see sas_host_smp.c for details. Regards, Jack On 10/22/2013 02:20 PM, Viswas G wrote: Signed-off-by: Viswas G

Re: [PATCH V2 01/10] pm80xx: Device id changes to support series 8 controllers.

linkrate support also on 6g, if so, then : Reviewed-by: Jack Wang jinpu.w...@profitbricks.com /* SSC Disable and SAS Analog ST configuration */ /** payload.ase_sh_lm_slr_phyid = diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h b/drivers/scsi/pm8001/pm80xx_hwi.h index 2b760ba

Re: [PATCH V2 02/10] pm80xx: IButton feature support for motherboard controllers.

. IButton security feature support for motherboard controllers. Signed-off-by: anandkumar.santha...@pmcs.com Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm80xx_hwi.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff

Re: [PATCH V2 03/10] pm80xx: Indirect SMP request fix

transfer mode in case of SMP request. Signed-off-by: anandkumar.santha...@pmcs.com Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm80xx_hwi.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers

Re: [PATCH V2 04/10] pm80xx: Display controller BIOS version

-by: anandkumar.santha...@pmcs.com As I know no all controller with BIOS support, but it's fine to have this. Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm8001_ctl.c | 34 ++ drivers/scsi/pm8001/pm8001_ctl.h |2 ++ 2 files changed

Re: [PATCH V2 05/10] pm80xx: Phy settings support for motherboard controller.

snip #ifdef PM8001_USE_MSIX /** * pm8001_setup_msix - enable MSI-X interrupt @@ -847,6 +872,9 @@ static int pm8001_pci_probe(struct pci_dev *pdev, } pm8001_init_sas_add(pm8001_ha); + /* phy setting support for motherboard controller */ + if (pdev-subsystem_vendor

Re: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device.

On 09/26/2013 07:37 AM, Anand wrote: From 5ddec5ef3033b4fee08dcdc7ba8b434425453e9d Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Tue, 17 Sep 2013 16:47:21 +0530 Subject: [PATCH V2 06/10] pm80xx: Print SAS address of IO failed device. Signed-off-by:

Re: [PATCH V2 07/10] pm80xx: Set device state response logic fix.

-by: anandkumar.santha...@pmcs.com Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm8001_hwi.c |6 -- drivers/scsi/pm8001/pm8001_sas.c |9 - 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b

Re: [PATCH V2 08/10] pm80xx: Queue rotation logic for inbound and outbound queues

On 09/26/2013 07:40 AM, Anand wrote: From 678d8085ace7c471dc140420c41dc4ad70300d60 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Wed, 18 Sep 2013 11:12:59 +0530 Subject: [PATCH V2 08/10] pm80xx: Queue rotation logic for inbound and outbound queues.

Re: [PATCH V2 09/10] pm80xx: 4G boundary fix

On 09/26/2013 07:42 AM, Anand wrote: From 4715339743d45a6ef862bc0f5d5ec404b4667f94 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Wed, 18 Sep 2013 11:14:54 +0530 Subject: [PATCH V2 09/10] pm80xx: 4G boundary fix. Signed-off-by:

Re: [PATCH V2 10/10] pm80xx: Firmware logging support

facilities, Inbound outbound queues dump. Non fatal dump in case of IO failures. Fatal dump in case of firmware failure. Signed-off-by: anandkumar.santha...@pmcs.com Reviewed-by: Jack Wang jinpu.w...@profitbricks.com --- drivers/scsi/pm8001/pm8001_ctl.c | 129 + drivers

Re: [PATCH V2 05/10] pm80xx: Phy settings support for motherboard controller.

their own settings. I still think you'd better add a list for devices know to support phy setting similar as IS_SPC12G, there are some devices in the driver support list do not have default setting I suspect. Jack -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent

Re: Drivers: scsi: FLUSH timeout

On 09/21/2013 07:24 AM, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, September 20, 2013 1:32 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com;

Re: Bypass block layer and Fill SCSI lower layer driver queue

On 09/18/2013 08:41 AM, Alireza Haghdoost wrote: Hi I am working on a high throughput and low latency application which does not tolerate block layer overhead to send IO request directly to fiber channel lower layer SCSI driver. I used to work with libaio but currently I am looking for a

Re: [PATCH 2/5] pm80xx: IButton feature support and Indirect SMP fix.

On 09/16/2013 05:53 PM, Anand wrote: From db345f70bef0b07655d887f2d0398faf666f4a48 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Tue, 3 Sep 2013 15:21:29 +0530 Subject: [PATCH 2/5] pm80xx: IButton feature support and Indirect SMP fix. IButton

Re: [PATCH 1/5] pm80xx: Device id changes to support series 8 controllers.

); MODULE_AUTHOR(Jack Wang jack_w...@usish.com); +MODULE_AUTHOR(Anand Kumar Santhanam anandkumar.santha...@pmcs.com); +MODULE_AUTHOR(Sangeetha Gnanasekaran sangeetha.gnanaseka...@pmcs.com); MODULE_DESCRIPTION( - PMC-Sierra PM8001/8081/8088/8089 SAS/SATA controller driver

Re: [PATCH 4/5] pm80xx: Print SAS address of IO failed device, 4G boundary fix.

On 09/16/2013 05:58 PM, Anand wrote: From 3574b24db1a5472df9cef88010fabad7742351e5 Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Tue, 3 Sep 2013 16:55:54 +0530 Subject: [PATCH 4/5] pm80xx: Print SAS address of IO failed device, 4G boundary fix.

[PATCH]export device_busy for sdev

)... Which give admin more hint about the situation. Best regards, Jack From cbca8a40fe3837789129e210365488d329d8a440 Mon Sep 17 00:00:00 2001 From: Jack Wang jinpu.w...@profitbricks.com Date: Thu, 12 Sep 2013 16:57:16 +0200 Subject: [PATCH] export device_busy for sdev If you mutiple devices connect

Re: [PATCHv2] pm80xx: fix Adaptec 71605H hang

On 07/31/2013 05:19 PM, Jack Wang wrote: On 07/26/2013 06:43 PM, Hans Verkuil wrote: The IO command size is 128 bytes for these new controllers as opposed to 64 for the old 8001 controller. The Adaptec out-of-tree driver did this correctly. After comparing the two this turned out

Re: aic94xx and kernel panic

On 08/16/2013 10:26 AM, Evgeny wrote: Hello. I've been testing vanilla 3.4.45 (config attached), 3.4.56 kernels on centos 5.9 with Adaptec AIC-9410W SAS controller: There's some fix in libsas about error handle , As I remember most of patch finally merged in 3.7, could you try newer kernel?

Re: aic94xx and kernel panic

, you need to figure out your self. PS: the aic94xx is out of maintain for some years as I see. You may need to update to newer hardware. Jack 19.08.2013 12:03, Jack Wang пишет: On 08/16/2013 10:26 AM, Evgeny wrote: Hello. I've been testing vanilla 3.4.45 (config attached), 3.4.56 kernels

Re: [PATCHv2] pm80xx: fix Adaptec 71605H hang

the IO command size, instead use pm8001_ha-iomb_size as that is the correct value for both old and new controllers. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: sta...@vger.kernel.org # for v3.10 and up snip Thanks Hans. Looks good now. Acked-by: Jack Wang xjtu...@gmail.com

Re: SAS Management Protocol (SMP) on Windows

On 07/22/2013 03:43 PM, Douglas Gilbert wrote: On 13-07-22 04:26 AM, Hugh Chin wrote: I'm developing SMP application by Python. I've ran it on Linux, it works fine. But now I have to run it on Windows. Of course, it didn't work. So far I know that Windows seems doesn't have bsg driver. But

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

Hi Hans, On 07/14/2013 10:45 AM, Hans Verkuil wrote: Hi Anand, On 07/12/2013 03:14 PM, Anand Kumar Santhanam wrote: Hans, I reviewed the code changes and I did not see major differences except for the fact that in adaptec driver we have 64 interrupt handlers to handle 64 MSI-X. This was

Re: [PATCH] pm80xx: fix Adaptec 71605H hang

On 07/14/2013 10:25 AM, Hans Verkuil wrote: The IO command size is 128 bytes for these new controllers as opposed to 64 for the old 8001 controller. The Adaptec out-of-tree driver did this correctly. After comparing the two this turned out to be the crucial difference. Thanks Hans for this

Re: The pm80xx driver hangs in 3.10 with the Adaptec 71605H HBA

Hi Anand, On 07/15/2013 02:37 PM, Anand Kumar Santhanam wrote: Hi Hans, Pls find responses inline. Regards Anand -Original Message- From: Jack Wang [mailto:xjtu...@gmail.com] Sent: Monday, July 15, 2013 2:24 PM To: Hans Verkuil Cc: Anand Kumar Santhanam; lindar_liu; linux

Re: [PATCH 8/9] scsi/pm8001: use pdev-pm_cap instead of pci_find_capability(..,PCI_CAP_ID_PM)

On 06/18/2013 10:23 AM, Yijing Wang wrote: Pci core has been saved pm cap register offset by pdev-pm_cap in pci_pm_init() in init path. So we can use pdev-pm_cap instead of using pci_find_capability(pdev, PCI_CAP_ID_PM) for better performance and simplified code. I think Lindar already

RE:[PATCH v11 6/9] Make scsi_remove_host() wait until error handling finished

@@ -646,14 +703,20 @@ static int scsi_try_target_reset(struct scsi_cmnd *scmd) static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd) { int rtn; - struct scsi_host_template *hostt = scmd-device-host-hostt; + struct Scsi_Host *host = scmd-device-host; +

RE: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

I'm not sure it's possible to avoid such a race without introducing a new mutex. How about something like the (untested) SCSI core patch below, and invoking scsi_block_eh() and scsi_unblock_eh() around any reconnect activity not initiated from the SCSI EH thread ? [PATCH] Add

Re: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

On 06/24/2013 05:50 PM, Bart Van Assche wrote: On 06/24/13 15:48, Jack Wang wrote: I'm not sure it's possible to avoid such a race without introducing a new mutex. How about something like the (untested) SCSI core patch below, and invoking scsi_block_eh() and scsi_unblock_eh() around any

Re: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

On 06/19/2013 05:27 PM, Bart Van Assche wrote: On 06/19/13 15:44, Jack Wang wrote: +/* + * It can occur that after fast_io_fail_tmo expired and before + * dev_loss_tmo expired that the SCSI error handler has + * offlined one or more devices. doesn't

RE: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

+ /* + * It can occur that after fast_io_fail_tmo expired and before + * dev_loss_tmo expired that the SCSI error handler has + * offlined one or more devices. scsi_target_unblock() doesn't + * change the state of these devices

RE:[PATCH 10/10] [RFC] SCSI: esas2r: Add Makefile, Kconfig, and MAINTAINERS files

S: Supported -F: drivers/block/nvme* +F: drivers/block/nvme.c F: include/linux/nvme.h I don't think you want to change this, it seems you are not generate your patch set against scsi misc branch? Regards, Jack -- To unsubscribe from this list: send the line unsubscribe

re :SCSI error handling -- one error blocks the whole SCSI host

, your understanding is right. and when one error happens on one lun, scsi core do hold the whole scsi host. I think Hannes has some good proposal weeks ago, it looks reasonable, but don't what the status now. Regards Jack Wang -- To unsubscribe from this list: send the line unsubscribe linux-scsi

[PATCH] pm8001: updated MAINTAINERS list

Sorry for resend, I forget to change the format to text. From 960e481828a03d211f5e20e626036876b39600dc Mon Sep 17 00:00:00 2001 From: Jack Wang jack_w...@usish.com Date: Tue, 5 Mar 2013 21:17:55 -0500 Subject: [PATCH] update mail address with my private gmail address for pm8001 driver Signed-off

[PATCH] libsas: use right function to alloc smp response

right function to alloc smp reponse Signed-off-by: John Gong john_g...@usish.com Signed-off-by: Jack Wang jack_w...@usish.com --- drivers/scsi/libsas/sas_expander.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas

RE: How to online remove an error scsi disk from the system?

accordingly? Am I missing something here? Thanks, Tao [Jack Wang] Hi Tao, Have you tried: echo 1 /sys/block/sdv/device/delete echo - - - /sys/class/scsi_host/host another way is : find out which phy the disk attached to and: echo 1 /sys/class/sas_phy/phy-x:x:x/link_reset Jack

RE: How to online remove an error scsi disk from the system?

On 02/01/2013 04:50 PM, Jack Wang wrote: Hi All, In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems to me

  1   2   >