On 04/04/2013 02:23 PM, Bjorn Helgaas wrote:
On Wed, Mar 20, 2013 at 10:35 PM, Myron Stowe myron.st...@redhat.com wrote:
With the 0x1b4b vendor ID #define in place, convert hard-coded ID values.
Also, unify the previous SCSI specific use of this vendor ID to the new
macro.
Signed-off-by: Myron
On 01/23/2013 02:09 AM, Aaron Lu wrote:
This patch adds runtime pm support for sr.
It did this by increasing the runtime usage_count of the device when
its block device is accessed. And decreasing the runtime usage_count
of the device when the access is done.
If there is media inside, runtime
On 01/15/2013 04:20 AM, Aaron Lu wrote:
The ODD can be enabled for ZPODD if the following three conditions are
satisfied:
1 The ODD supports device attention;
2 The platform can runtime power off the ODD through ACPI;
3 The ODD is either slot type or drawer type.
For such ODDs, zpodd_init is
On 01/15/2013 04:21 AM, Aaron Lu wrote:
For ODDs, the upper layer will poll for media change every few
seconds, which will make it enter and leave suspend state very
often. And as each suspend will also cause a hard/soft reset,
the gain of runtime suspend is very little while the ODD may
On 01/11/2013 01:44 PM, Tejun Heo wrote:
Hello,
On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote:
OK, will make it atomic in next version, thanks for the advice.
Perhaps I can add two scsi helper functions in scsi_lib.c like:
void sdev_disable_disk_events(struct scsi_device *sdev)
{
On 12/03/2012 11:23 AM, Tejun Heo wrote:
Hello, James.
On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote:
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index e65c62e..1756151 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -160,6
On 11/09/2012 02:18 PM, Jeff Moyer wrote:
Signed-off-by: Jeff Moyer jmo...@redhat.com
---
drivers/ata/libata-scsi.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Acked-by: Jeff Garzik jgar...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-scsi
On 09/29/2012 06:31 PM, Rafael J. Wysocki wrote:
On Saturday, September 29, 2012, Alan Stern wrote:
Can arbitrary SCSI devices be ZP, or does this notion apply only to
ATAPI-based drives? That's the key question, and the answer determines
where the ZP support belongs.
I agree. That said for
On 09/29/2012 06:44 PM, Rafael J. Wysocki wrote:
On Saturday, September 29, 2012, Aaron Lu wrote:
On 09/29/2012 10:29 PM, Alan Stern wrote:
On Sat, 29 Sep 2012, Aaron Lu wrote:
I don't think this is a good idea, quite frankly. sr seems to be a too
generic place for that.
Does this mean sr
On 09/30/2012 10:47 AM, Alan Stern wrote:
On Sun, 30 Sep 2012, Aaron Lu wrote:
Makes sense to me, but there is a problem if I want to block events
checking for the disk, as I do not have a pointer to the gendisk in ATA
layer.
You may discover the gendisk by going the ATA - SCSI - block
On 09/30/2012 03:43 PM, Alan Stern wrote:
On Sun, 30 Sep 2012, Jeff Garzik wrote:
The simple fact of only ZPODD devices out there are ATA is not the
decision-maker for where the code should live. It is more a question
where ZPODD belongs in the device/command set model currently employed.
I
On 09/25/2012 06:38 AM, James Bottomley wrote:
On Tue, 2012-09-25 at 01:21 -0400, Jeff Garzik wrote:
Can you be more specific about sysfs location? A runtime-writable (via
sysfs!) module parameter for a module-wide default seemed appropriate.
Well, if it's really important, the same thing
drivers/scsi/sd.c |4
drivers/scsi/sd.h |2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 4df73e5..d15074b 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK);
-sdev-powered_off) {
+ ata_dev-sdev-need_eject = 1;
+ pm_runtime_resume(ata_dev-sdev-sdev_gendev);
+ }
}
these bits are Acked-by: Jeff Garzik jgar...@redhat.com
but obviously that is contingent upon acceptance of the upper level SCSI
and ACPI changes
(
dev-sdev-sdev_gendev, NULL,
- dev-sdev-ready_to_power_off ?
+ power_off_allowed ?
ACPI_STATE_D3 : ACPI_STATE_D3_HOT);
Acked-by: Jeff Garzik jgar...@redhat.com
with the same
On 09/18/2012 04:31 AM, Aaron Lu wrote:
I agree that it is better handled in libata's SALT, I tried to do this
but didn't find a good way so I introduced this flag. The SALT is 1-1
mapping, I'm not sure how to handle this 1-2 mapping.
That is the crux of the matter: it is rather difficult
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote:
linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback':
Use min_t(size_t, ...) to fix.
Signed-off-by: Tony Hung tony.h...@tw.promise.com
---
diff --git a/linux-3.2.0/drivers/ata/ahci.c
On 09/25/2012 12:06 AM, James Bottomley wrote:
On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote:
drivers/scsi/sd.c |4
drivers/scsi/sd.h |2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
I'm not opposed in principle to doing this (except that it should be a
sysfs
On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote:
Meanwhile there already has a number of SATA disks that have supported
this feature. So I think maybe we can enable it.
Regards,
Zheng
Blindly enabling FUA by default in my opinion is not a good idea at all.
I believe the focus should be on
On 09/04/2012 10:24 AM, Aaron Lu wrote:
From: Aaron Lu aaron...@intel.com
Hard disk may also be runtime powered off, so set can_power_off flag
for it too if condition satisfies.
Signed-off-by: Aaron Lu aaron...@intel.com
Acked-by: Jeff Garzik jgar...@redhat.com
--
To unsubscribe from
,
+ dev-sdev-may_power_off ?
+ ACPI_STATE_D3_COLD : ACPI_STATE_D3_HOT);
if (acpi_state 0)
acpi_bus_set_power(handle, acpi_state);
Acked-by: Jeff Garzik jgar...@redhat.com
--
To unsubscribe from this list: send
number of servers.
CC: Jeff Garzik j...@garzik.org
Signed-off-by: Zheng Liu wenqing...@taobao.com
---
drivers/ata/libata-core.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 23763a1..3627251 100644
On 08/16/2012 07:04 AM, Dan Carpenter wrote:
The 1 (slot_idx % 32) condition is always true. The intent was to
test a bit field here using bitwise AND. We do the test correctly a few
lines later in the do while loop.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Jeff
On 08/03/2012 05:50 AM, Aaron Lu wrote:
Hello,
Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any
comments?
Typically you follow the pattern of similar exports in the file (or in
the API, if no others are in the file).
Jeff
--
To unsubscribe from this list: send
On 07/26/2012 06:05 AM, Aaron Lu wrote:
v3:
Rebase on top of scsi-misc tree;
Add the sr related patches previously in Jeff's libata tree;
Re-organize the sr patches.
A problem for now: for patch
scsi: sr: support zero power ODD(ZPODD)
I can't set a flag in libata-acpi.c since a related function
On 07/26/2012 10:41 AM, Aaron Lu wrote:
On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote:
On 07/26/2012 06:05 AM, Aaron Lu wrote:
I can't set a flag in libata-acpi.c since a related function is
missing in scsi-misc tree. Will fix this when 3.6-rc1 released.
What does this mean
Reported-by: Hannes Reinecke h...@suse.com
Signed-off-by: Dan Williams dan.j.willi...@intel.com
---
drivers/ata/libata-core.c | 10 ++
drivers/scsi/ipr.c|3 +--
drivers/scsi/libsas/sas_ata.c |5 +
include/linux/libata.h|3 +--
Acked-by: Jeff Garzik
On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote:
Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
tags/upstream
Oh, I forgot to point out the merge commit, making my HEAD more recent
than might
On 07/25/2012 04:35 PM, Jeff Garzik wrote:
Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
tags/upstream
(text copied from the upstream-linus tag)
Notable changes:
* Updating libata to directly bind with ACPI
On 07/25/2012 06:06 PM, Linus Torvalds wrote:
On Wed, Jul 25, 2012 at 1:43 PM, Jeff Garzik j...@garzik.org wrote:
On Wed, Jul 25, 2012 at 04:35:51PM -0400, Jeff Garzik wrote:
Please pull 641589bff714f39b33ef1d7f02eaa009f2993b64 from
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata
On 07/25/2012 06:31 PM, Linus Torvalds wrote:
On Wed, Jul 25, 2012 at 3:26 PM, Jeff Garzik jgar...@pobox.com wrote:
Even so, separately, it still needed that post-merge compile fix.
And that's yet another example of how *NOT* to do things.
If the merge has errors like that, then they should
On 07/25/2012 07:30 PM, Linus Torvalds wrote:
On Wed, Jul 25, 2012 at 3:58 PM, Jeff Garzik jgar...@pobox.com wrote:
What is the right course in when a post-merge change is needed?
Just describe the issue and the required change. Than I can just do it
as part of the merge, and now the whole
dan.j.willi...@intel.com
Acked-by: Jeff Garzik jgar...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Jeff Garzik jgar...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
James Bottomley wrote:
On Mon, 2008-02-25 at 10:34 -0600, Brian King wrote:
The new libata-eh is used for more than just EH. It is used for device
probing, device revalidation, and power management. It is also woken for
all command failures and is where the request sense for ATAPI devices is
Matthew Wilcox wrote:
On Mon, Feb 25, 2008 at 11:40:35PM +0100, Andi Kleen wrote:
(I must have fixed it somehow because it works on parisc, which is most
unforgiving of drivers which do DMA without the DMA API).
At least on x86 the DMA API cannot do ISA bouncing.
You're saying that if I set
Ke Wei wrote:
On Sat, Feb 23, 2008 at 11:28:50AM -0500, Jeff Garzik wrote:
Ke Wei wrote:
Convert rough draft Marvell 6440 driver to a working driver.
Added support for SAS and SATA devices, hotplug, wide port, and expanders.
This patch is based on:
branch 'mvsas' of
git.kernel.org:/pub/scm
James Bottomley wrote:
This is the latest crop of bug fixes plus one new driver: mvsas. We're
[...]
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
Ke Wei (1):
mvsas: convert from rough draft to working driver
I know I am probably shooting myself in the foot
Jeff Garzik wrote:
On the net driver side of things, I have a few new net drivers that I
have queued for 2.6.26, because they did not make the merge window. This
is inconsistent with your apparently policy.
s/apparently/apparent/
Sometimes my fingers don't type the words that come out of my
- Fix build 'make randconfig' build warning spotted by Toralf Foerster:
drivers/scsi/mvsas.c: In function 'mvs_hexdump':
drivers/scsi/mvsas.c:715: error: implicit declaration of function 'isalnum'
- Remove unneeded prototypes (spotted by hch)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED
Olof Johansson wrote:
Hi,
On Sat, Feb 23, 2008 at 09:13:33AM -0600, James Bottomley wrote:
Jeff Garzik (1):
mvsas: Add Marvell 6440 SAS/SATA driver
[...]
drivers/scsi/mvsas.c| 2981
I just noticed that the file permissions
Andrew Morton wrote:
On Sat, 23 Feb 2008 12:31:02 -0800 (PST) Linus Torvalds [EMAIL PROTECTED]
wrote:
On Sat, 23 Feb 2008, Jeff Garzik wrote:
I know I am probably shooting myself in the foot here, since I am the original
author of mvsas, but...
Should we be adding new drivers during -rc
()
- delete pointless zero-initializations of ha struct members, as these
are zeroed when ha is allocated (and never assigned any other value,
prior to the explicit zero initializations)
- consolidate thrice-repeated spinlock init
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
NOTE: Applies on top
Christoph Hellwig wrote:
Eventually we shoud just kill the INT_COAL ifdefed code. It has never
been enabled and clutters up the driver quite badly.
Noted (queued)... fine by me, and makes life easier.
+#ifdef CONFIG_EISA
+ if ((ha-type == GDT_EISA) (ha-ccb_phys))
+
Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a less
James Bottomley wrote:
Currently aic94xx has no exported I_T_nexus_reset function. This is a
bit of a huge problem, since sas_ata relies on this function to
perform an ATA phy reset and also it means that if abort fails, we
really have no bigger hammer to hit everything with.
Plumb in the
Ke Wei wrote:
Added support for Expander. Based on version 0.1 for mvsas.
Signed-off-by: Ke Wei [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
old mode 100644
new mode 100755
index 03638b9..3c7a154
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -2,6
Darrick J. Wong wrote:
Provide a facility to use the request_firmware() interface to get a SAS
address from userspace. This can be used by SAS LLDDs that cannot
obtain the address from the host adapter.
Resend of 8 Oct. 2007 patch, now based off 2.6.25-rc2 + scsi_misc.
Signed-off-by: Darrick
Boaz Harrosh wrote:
On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote:
I still don't have a card for testing myself. Again anyone
wants to send me a card. Intel people anybody home?
Apparently Intel sold
James Bottomley wrote:
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index c825239..1b53e92 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -595,85 +595,107 @@ static int __init gdth_search_isa(ulong32 bios_adr)
#endif /* CONFIG_ISA */
#ifdef CONFIG_PCI
-static void
assign-only gdth_pci_str::io_mm
Note: If the indentation seems weird, that's because a line was
converted from spaces to tabs, when it was modified.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
NOTE: this patch series supercedes the previous gdth: convert to PCI
hotplug API patch.
drivers/scsi
Boaz Harrosh wrote:
From: Sergio Luis [EMAIL PROTECTED]
Fix compilation warning in gdth.c, which was using the deprecated
pci_find_device.
drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at
include/linux/pci.h:495)
Changing it to use pci_get_device, instead.
James Bottomley wrote:
On Thu, 2008-02-14 at 15:13 -0500, Jeff Garzik wrote:
Boaz Harrosh wrote:
From: Sergio Luis [EMAIL PROTECTED]
Fix compilation warning in gdth.c, which was using the deprecated
pci_find_device.
[...]
This patch is already upstream... (unfortunately)
I think
Boaz Harrosh wrote:
do you intend this to be pushed into 2.6.25-rcx or this is already
for 2.6.26? Should we put this in -mm tree for testing?
Not intended for 2.6.25. I just wanted to get this in process
somewhere, and keep this issue moving. I would definitely prefer to
have this tested
Comments noted for my next round of revisions (its a low priority, so
definitely not this week). Good spotting, thanks!
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Linux Kernel Mailing List wrote:
Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99109301d103fbf0de43fc5a580a406c12a501e0
Commit: 99109301d103fbf0de43fc5a580a406c12a501e0
Parent: 61c92814dc324b541391757062ff02fbf3b08086
Author: Sergio Luis
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/gdth.c | 143 +++-
1 file changed, 86 insertions(+), 57 deletions(-)
06196f50915da97bb897495863f9f084d785c1e4
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index c825239
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info
Jens Axboe wrote:
On Fri, Feb 08 2008, Jeff Garzik wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
Bart Van Assche wrote:
On Feb 5, 2008 6:50 PM, Jeff Garzik [EMAIL PROTECTED] wrote:
For remotely accessing data, iSCSI+fs is quite simply more overhead than
a networked fs. With iSCSI you are doing
local VFS - local blkdev - network
whereas a networked filesystem is
local
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info.
Ke Wei wrote:
Added support for hotplug and wide port.
Signed-off-by: Ke Wei [EMAIL PROTECTED]
---
drivers/scsi/mvsas.c | 445 ++
1 files changed, 339 insertions(+), 106 deletions(-)
Technically speaking, everything is looking great so far.
FUJITA Tomonori wrote:
On Tue, 5 Feb 2008 11:21:33 -0500
Pete Wyckoff [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote on Mon, 04 Feb 2008 19:53 +0200:
FIXME: I need help with this driver (Pete?)
I used scsi_sense() in a none const way. But since
scsi_tgt is the ULD here, it can
Bart Van Assche wrote:
On Feb 4, 2008 11:57 PM, Jeff Garzik [EMAIL PROTECTED] wrote:
Networked block devices are attractive because the concepts and
implementation are more simple than networked filesystems... but usually
you want to run some sort of filesystem on top. At that point you might
Olivier Galibert wrote:
On Mon, Feb 04, 2008 at 05:57:47PM -0500, Jeff Garzik wrote:
iSCSI and NBD were passe ideas at birth. :)
Networked block devices are attractive because the concepts and
implementation are more simple than networked filesystems... but usually
you want to run some sort
Vladislav Bolkhovitin wrote:
Jeff Garzik wrote:
iSCSI is way, way too complicated.
I fully agree. From one side, all that complexity is unavoidable for
case of multiple connections per session, but for the regular case of
one connection per session it must be a lot simpler.
Actually
Ingo Molnar wrote:
* Jeff Garzik [EMAIL PROTECTED] wrote:
Ingo Molnar wrote:
so please tell me Jeff. If Greg, who is the super-maintainer of your
code area, and who deals with your code every day and changes it
every minute and hour, simply did not Cc: the SCSI list - how am i, a
largely
Boaz Harrosh wrote:
Use of new scsi_eh API for setting sense information into
the scsi command.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/gdth.c | 47 ++-
drivers/scsi/gdth.h |1 +
2 files changed, 27 insertions(+), 21
Andrew Morton wrote:
Actually I (and probably others) generally avoid cc'ing mailing lists on
patch traffic. I spew out enough script-generated traffic as it is.
You pretty much always ensure the driver author gets CC'd, which is
exemplary :)
Jeff
-
To unsubscribe from this
James Bottomley wrote:
It's here in sr_ioctl.c:
Ah, indeed. My grep-fu sucks today.
I'm not averse to simply nuking the printk ... it's probably valueless
in a modern kernel, since something dbussy is supposed to tell you to
put a CD in the drive, not something in the kernel.
The
Alan Cox wrote:
better. So for example, I personally suspect that ATA-over-ethernet is way
better than some crazy SCSI-over-TCP crap, but I'm biased for simple and
low-level, and against those crazy SCSI people to begin with.
Current ATAoE isn't. It can't support NCQ. A variant that did NCQ
Andrew Morton wrote:
On Mon, 4 Feb 2008 15:24:55 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
wrote:
On Sunday 03 February 2008, Andrew Morton wrote:
With latest -mm, running fc8 I am getting this in the logs,
^^^
= SCSI/libata
cc:ing Jeff
once per second.
Linus Torvalds wrote:
On Mon, 4 Feb 2008, Jeff Garzik wrote:
Well, speaking as a complete nutter who just finished the bare bones of an
NFSv4 userland server[1]... it depends on your approach.
You definitely are a complete nutter ;)
If the userland server is the _only_ one accessing
Linus Torvalds wrote:
On Mon, 4 Feb 2008, Matt Mackall wrote:
But ATAoE is boring because it's not IP. Which means no routing,
firewalls, tunnels, congestion control, etc.
The thing is, that's often an advantage. Not just for performance.
NBD and iSCSI (for all its hideous growths) can take
James Bottomley wrote:
The aic94xx sequencer has a very finely honed sense of DMA transfers.
It's fully automated, and handles both ATA DMA and ATA PIO in the
sequencer engine (so all the driver sees is DMA).
ditto AHCI, and most other DMA engines
It reports both underrun and overrun
Ingo Molnar wrote:
===
--- linux.orig/drivers/scsi/lpfc/lpfc_init.c
+++ linux/drivers/scsi/lpfc/lpfc_init.c
@@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
uint16_t iotag;
int bars =
Ingo Molnar wrote:
it would have been totally appropriate for me to just send a mail to
lkml with the proper subject line about the breakage. (I might even have
decided to stay completely silent about the issue and fix it for my own
build, letting you guys figure it out.)
Oh come on... You
Ingo Molnar wrote:
* Jeff Garzik [EMAIL PROTECTED] wrote:
Ingo Molnar wrote:
it would have been totally appropriate for me to just send a mail to lkml
with the proper subject line about the breakage. (I might even have
decided to stay completely silent about the issue and fix it for my own
Ingo Molnar wrote:
so please tell me Jeff. If Greg, who is the super-maintainer of your
code area, and who deals with your code every day and changes it every
minute and hour, simply did not Cc: the SCSI list - how am i, a largely
outside party in this matter, supposed to notice that 3
James Bottomley wrote:
Could we please get this in ... I thought I mentioned several times that
it fixes a fatal oops in both aic94xx and ipr.
Tejun has a persistent objection... see other email.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the
James Bottomley wrote:
The lack of interrupt enable looks potentially fatal...
See my comments on this specific issue, in this thread, for the reason
why that function isn't used...
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
Grant Grundler wrote:
On Jan 25, 2008 8:43 AM, Ke Wei [EMAIL PROTECTED] wrote:
The attached is Marvell 6440 SAS/SATA driver. I will try to send email
by git-send-email.
I know this isn't part of this patch:
#define mr32(reg) readl(regs + MVS_##reg)
#define mw32(reg,val) writel((val),
James Bottomley wrote:
Actually, I don't think it's a smaller I/O issue. The SMART protocol
specifically mandates that the transfers for SMART READ DATA and SMART
READ LOG shall be 512 bytes). However, the pio transfer routine does
seem to be assuming sector alignment as well, which will be
Comments inline, mostly minor stuff cleaning up the source.
Major problem though: your mailer converted tabs to spaces, so our
automated patch tools won't work on your submission. It usually takes a
few attempts to get your email setup working, such that all the
automated tools used in the
James Bottomley wrote:
if (BLK_DEF_MAX_SECTORS max_sectors)
q-max_hw_sectors = q-max_sectors = max_sectors;
else {
q-max_sectors = BLK_DEF_MAX_SECTORS;
q-max_hw_sectors = max_sectors;
}
}
So it imposes a maximum possible
Matthew Hall wrote:
ACPI: PCI Interrupt Link [LT3D] enabled at IRQ 46
ACPI: PCI Interrupt :80:07.0[A] - Link [LT3D] - GSI 46 (level,
low) - IRQ 46
sata_nv :80:07.0: Using ADMA mode
PCI: Unable to reserve mem region #6:[EMAIL PROTECTED] for device
:80:07.0
ACPI: PCI interrupt for
Matthew Wilcox wrote:
On Wed, Jan 09, 2008 at 12:36:26PM -0800, Jon Watte wrote:
Stefan Richter wrote:
Those systems (servers) typically have enough memory to tolerate a few
extra KB of code without problems. In fact most PCs these days have.
It would be a stupid solution nevertheless.
Ke Wei wrote:
The 88SE6440 driver :
The driver is based on bare code from Jeff Garzik. And it can work
under linux kernel 2.6.23.
By far, Can discover and find SAS HDD, but SATA is currently
unsupported. Command queue depth can be above 1.
Most error handling, and some phy handling code
Jeff Garzik wrote:
1) To make it easier for people to review and test the driver, I would
suggest posting a diff against 2.6.24-rc7 (or 2.6.23), ignoring my
original code. Thus, it would result in a patch
Er, that sentence was incomplete. Continuing...
Thus it would result in a patch
James Bottomley wrote:
ATA requires that all DMA transfers begin and end on word boundaries.
Because of this, a large amount of machinery grew up in ide to adjust
scatterlists on this basis. However, as of 2.5, the block layer has a
dma_alignment variable which ensures both the beginning and
Darrick J. Wong wrote:
Hrm... does this patch help? You'll get a bunch of ATA/SAS disk errors
printed to the screen if you yank the disk, but at least libsas won't
get stuck waiting for the cache-flush commands to time out.
---
sd will get hung up issuing commands to flush write cache if a SAS
Darrick J. Wong wrote:
On Tue, Dec 04, 2007 at 05:48:33PM -0500, Jeff Garzik wrote:
As an aside, issues like this really really imply a need to move libsas
away from the old libata EH stuff (like brking did with ipr, in patches).
Hm... does the new libata EH handle the case of device
Darrick J. Wong wrote:
On Mon, Dec 03, 2007 at 05:09:54PM +0100, Krzysztof B??aszkowski wrote:
I noticed also another failure when i removed a drive. The event was not
notified by anything (ie the block device and corresponding sg were
registered) so i run dd on this truly virtual drive.
dd
Brian King wrote:
The following three patches convert ipr to use the new libata EH APIs.
In the process of doing this, I first looked into implementing this
in a similar manner to how libata SAS is done today, which is hooking
into target_alloc/target_destroy to allocate/delete sata ports. While
the interface usage
consistent, which in turn enables the possibility of directly
referencing Scsi_Host from all NCR5380_intr() invocations.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
Resend #1. Originally sent on Oct 26.
Please send upstream for 2.6.24-rc in some form, this fixes obvious
free_irq
Darrick J. Wong wrote:
sparse complains about the mixing of enums in libsas. Since the
underlying numeric values of both enums are the same, combine them
to get rid of the warning.
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
---
drivers/scsi/aic94xx/aic94xx_dev.c |6 +++---
Linus Torvalds wrote:
On Sun, 4 Nov 2007, Jeff Garzik wrote:
The end to CD-ROM polling... newer SATA ATAPI hardware will emit
'asynchronous notification' events when media is changed. This adds
support.
I *really* didn't want to pull this.
Not only is it after the -rc1 period, but I also
drivers/scsi/scsi_scan.c |3 +
drivers/scsi/scsi_sysfs.c | 47 +++
include/scsi/scsi_device.h | 25
5 files changed, 216 insertions(+), 3 deletions(-)
commit f26792d5c63344e14540ced4b19deb29e360bb8d
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Mon Oct 29 17
Matthew Wilcox wrote:
On Sun, Nov 04, 2007 at 10:44:23AM -0800, Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Move RAID_ATTRS into the SCSI Transports sub-menu.
Fix some help text whitespace in Transports.
Ummm ... RAID isn't really a SCSI property, is it? How about putting it
in
Randy Dunlap wrote:
Jeff Garzik wrote:
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Move RAID class configuration to the BLOCK menu since it is not
SCSI-specific.
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
block/Kconfig|5 +
drivers/scsi/Kconfig |7
1 - 100 of 499 matches
Mail list logo
