Re: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()

2015-09-28 Thread Hannes Reinecke
On 09/22/2015 09:17 PM, Ewan Milne wrote: [ .. ] > > scsi_vpd_lun_id() is an exported function, but does not check if > sdev->vpd_pg83 != NULL > (i.e. no VPD 83 info), and we will crash if it is NULL. Also, why return > -EAGAIN? > What will be different next time? Maybe a different errno

Re: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()

2015-09-22 Thread Ewan Milne
On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > Add a function scsi_vpd_lun_id() to return a unique device > identifcation based on the designation descriptors of > VPD page 0x83. > > As devices might implement several descriptors the order > of preference is: > - NAA IEE Registered

Re: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()

2015-09-01 Thread Christoph Hellwig
On Thu, Aug 27, 2015 at 02:41:14PM +0200, Hannes Reinecke wrote: > Add a function scsi_vpd_lun_id() to return a unique device > identifcation based on the designation descriptors of > VPD page 0x83. > > As devices might implement several descriptors the order > of preference is: > - NAA IEE

Re: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()

2015-09-01 Thread Hannes Reinecke
On 09/01/2015 12:22 PM, Christoph Hellwig wrote: > On Thu, Aug 27, 2015 at 02:41:14PM +0200, Hannes Reinecke wrote: >> Add a function scsi_vpd_lun_id() to return a unique device >> identifcation based on the designation descriptors of >> VPD page 0x83. >> >> As devices might implement several

[PATCH 16/23] scsi: Add scsi_vpd_lun_id()

2015-08-27 Thread Hannes Reinecke
Add a function scsi_vpd_lun_id() to return a unique device identifcation based on the designation descriptors of VPD page 0x83. As devices might implement several descriptors the order of preference is: - NAA IEE Registered Extended - EUI-64 based 16-byte - EUI-64 based 12-byte - NAA IEEE