On 08/13/2014 04:09 PM, Sagi Grimberg wrote:
On 8/6/2014 4:25 PM, Boaz Harrosh wrote:
Hey Boaz,
So in the current flow, I still don't think it is wrong/buggy, the
transfer byte length related to scsi buffer length
(In iscsi for sure
but I think that for all transports it is the same).
On 8/6/2014 4:25 PM, Boaz Harrosh wrote:
On 08/06/2014 03:43 PM, Sagi Grimberg wrote:
Hi Boaz,
I hate that you introduced this new transfer_length variable. It does
not exist. In BIDI supporting driver there is out_len and in_len just
as original code.
Effectively, out_len and in_len are
Hi Boaz,
On 7/27/2014 1:08 PM, Boaz Harrosh wrote:
SNIP
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 26dc005..3f46234 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -338,7 +338,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
BTW: When reading DIFF devices, don't you have extra bits to read as
well? How does the DIFF read works? Please get me up to speed. I'm
not familiar with this protocol? (I'd imagine that if say an app
reads X bytes with DIFF info, it
On 06/11/2014 12:09 PM, Sagi Grimberg wrote:
In case protection information exists over the wire
iscsi header data length is required to include it.
Use protection information aware scsi helpers to set
the correct transfer length.
In order to avoid breakage, remove iser transfer length
On 06/23/2014 03:59 PM, Christoph Hellwig wrote:
This patch causes a regression when using the iscsi initiator over
TCP for me. When mounting a newly created ext4 filesystem I get the
following BUG:
[ 31.611803] BUG: unable to handle kernel NULL pointer dereference at
000c
This patch causes a regression when using the iscsi initiator over
TCP for me. When mounting a newly created ext4 filesystem I get the
following BUG:
[ 31.611803] BUG: unable to handle kernel NULL pointer dereference at
000c
[ 31.613563] IP: [8197b38d]
In case protection information exists over the wire
iscsi header data length is required to include it.
Use protection information aware scsi helpers to set
the correct transfer length.
In order to avoid breakage, remove iser transfer length
checks for each task as they are not always true and
8 matches
Mail list logo