Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-08 Thread Akinobu Mita
2013/6/7 Martin K. Petersen : >> "Akinobu" == Akinobu Mita writes: > > Akinobu> So Martin and Douglas, can I have your ACKs on this patch > Akinobu> series for now? > > Only concern is the one I mentioned before: You're mapping and unmapping > the ppage for every 8 bytes of protection informat

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-06 Thread Martin K. Petersen
> "Akinobu" == Akinobu Mita writes: Akinobu> So Martin and Douglas, can I have your ACKs on this patch Akinobu> series for now? Only concern is the one I mentioned before: You're mapping and unmapping the ppage for every 8 bytes of protection information. That seems a bit excessive. However

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-02 Thread Douglas Gilbert
On 13-06-01 10:51 PM, Akinobu Mita wrote: 2013/5/29 Martin K. Petersen : I have some patches pending as part of my next DIF/DIX update that makes some of these things more palatable at the block/SCSI level. Akinobu voiced interest in finishing the scsi_debug work on top of my code. Yes. I'm i

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-02 Thread Douglas Gilbert
On 13-05-26 04:01 AM, Akinobu Mita wrote: This patch set includes bug fixes which I hit when I was tried testing the data integrity support in scsi_debug on x86_32. And it also includes cleanups which helps increasing readability and further bug fixing in data integrity support. * Changes from

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-01 Thread Akinobu Mita
2013/5/29 Martin K. Petersen : > I have some patches pending as part of my next DIF/DIX update that makes > some of these things more palatable at the block/SCSI level. Akinobu > voiced interest in finishing the scsi_debug work on top of my code. Yes. I'm interested in that work. Before I start

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-28 Thread Martin K. Petersen
> "Doug" == Douglas Gilbert writes: Doug> No PI, why not? This was tested on lk 3.9.4 with your patches Doug> applied. I've been communicating with Akinobu offline about this. The reason is that I really only implemented DIX support in scsi_debug. The dif module parameter is only there to s

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-28 Thread Douglas Gilbert
Perhaps I'm missing something but I can never get DIF stuff to do what I want in scsi_debug. It was like this before your patches as well. Assume this set up: # lsscsi -gp [1:0:0:0]diskATA ST3320620AS 3.AA /dev/sda /dev/sg0 - - [6:0:9:0]diskSEAGATE ST3300065

[PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-26 Thread Akinobu Mita
This patch set includes bug fixes which I hit when I was tried testing the data integrity support in scsi_debug on x86_32. And it also includes cleanups which helps increasing readability and further bug fixing in data integrity support. * Changes from v2 - Add new bug fix patch for UNMAP command