; Bart Van Assche
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 3/7] scsi: ufs: Add fill task management request
>
On Wed, Sep 05, 2018 at 07:08:50PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> > But on the other hand, task management request and response UPIUs
> > are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 &
> > 10.7.7).
> > and
On Wed, Sep 05, 2018 at 03:53:41PM +, Avri Altman wrote:
> But on the other hand, task management request and response UPIUs
> are honorable members of the ufs spec (JEDEC 220C paragraphs 10.7.6 & 10.7.7).
> and indeed they lives in ufs.h, where they should.
There is no other use anywhere.
> On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> > Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> > It doesn't specify any inner structure of the task management
> > request or response, just a bunch of 8 DW each.
> > I guess this is why it is defined as a
On Wed, Sep 05, 2018 at 07:30:03AM +, Avri Altman wrote:
> Looking into the UFSHCI spec (JESD223C March 2016) paragraph 6.2,
> It doesn't specify any inner structure of the task management
> request or response, just a bunch of 8 DW each.
> I guess this is why it is defined as a __le32 array.
. Bottomley
> ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; Stanislav Nijnikov
> ; Avi Shchislowski
> ; Alex Lemberg ;
> Subhash Jadavani ; Vinayak Holikatti
>
> Subject: Re: [PATCH v3 3/7] scsi: ufs: Add fill task management request
>
> In general this looks good,
In general this looks good, but a question below:
> index ed37914..d18832a 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -5598,6 +5598,32 @@ static int ufshcd_clear_tm_cmd(struct ufs_hba *hba,
> int tag)
> return err;
> }
>
> +static void
Do that in preparation to re-use ufshcd_issue_tm_cmd code.
Signed-off-by: Avri Altman
---
drivers/scsi/ufs/ufshcd.c | 50 +++
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index
8 matches
Mail list logo
