On Wed, Feb 13 2008 at 19:36 +0200, James Bottomley [EMAIL PROTECTED] wrote:
snip
---
From: Boaz Harrosh [EMAIL PROTECTED]
Subject: [PATCH] gdth: bugfix for the at-exit problems
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused
Hi,
On Thursday 14 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Tuesday 12 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Monday 11 February 2008, Kamalesh Babulal wrote:
Nish Aravamudan wrote:
On 2/7/08,
On Wed, 13 Feb 2008 13:43:24 -0800
Tim Pepper [EMAIL PROTECTED] wrote:
We recently upgraded a production x86_64 machine with serveraid
cards to 2.6.24 and noted that /proc/scsi/scsi showed garbage for our
serveraid service processors. sg_inq also returned garbage from the
service processors'
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Thursday 14 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Tuesday 12 February 2008, Kamalesh Babulal wrote:
Bartlomiej Zolnierkiewicz wrote:
Hi,
On Monday 11
On Tue, 12 Feb 2008 15:40:24 -0500
Pete Wyckoff [EMAIL PROTECTED] wrote:
If blk_rq_map_user requires more than one bio, and fails mapping
somewhere after the first bio, it will return with rq-bio set to
non-NULL, but it will have already unmapped the partial bio. The
out: error exit section
This is a bugfix for the 2.6.24.x stable releases.
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
So del_timer_sync the timer before we delete the cards.
also the reboot
Hi,
commit
99109301d103fbf0de43fc5a580a406c12a501e0
in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci refcount on
exit. Also you do not so on fail paths... I wonder why these mistakes happen
every second time somebody tries to do such change.
It leaked into mainline yet
On 02/14/2008 03:44 PM, Jiri Slaby wrote:
Hi,
commit
99109301d103fbf0de43fc5a580a406c12a501e0
in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci
refcount on exit. Also you do not so on fail paths... I wonder why these
mistakes happen every second time somebody tries to do
On Wed, 2008-02-13 at 23:43 -0500, Jeff Garzik wrote:
Linux Kernel Mailing List wrote:
Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99109301d103fbf0de43fc5a580a406c12a501e0
Commit: 99109301d103fbf0de43fc5a580a406c12a501e0
Parent:
On 02/14/2008 03:47 PM, Jiri Slaby wrote:
On 02/14/2008 03:44 PM, Jiri Slaby wrote:
Hi,
commit
99109301d103fbf0de43fc5a580a406c12a501e0
in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci
refcount on exit. Also you do not so on fail paths... I wonder why
these mistakes happen
On 02/14/2008 03:47 PM, Jiri Slaby wrote:
On 02/14/2008 03:44 PM, Jiri Slaby wrote:
commit
99109301d103fbf0de43fc5a580a406c12a501e0
in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci
[...]
BTW if you have more than one card, you protected the driver from no
race, since you
Le Thu, 14 Feb 2008 16:10:24 +0100,
Thomas Petazzoni [EMAIL PROTECTED] a écrit :
I have not identified which commit broke the driver, but I confirm
that Tomonori's patch fixes the problem.
I suspect that the issue has been introduced by
d10fb2c7b5ce1b475df50cde9262d2c3fe3d296e, added in 2.6.24
On Thu, 2008-02-14 at 13:07 +0100, Bartlomiej Zolnierkiewicz wrote:
I worry that another git-bisect session will be needed unless SCSI
developers are already aware of the problem source.
Yinghai Lu noticed that it may be actually a SES problem:
http://lkml.org/lkml/2008/2/14/88
[ I
On Wed, Feb 13 2008 at 21:38 +0200, Jan Engelhardt [EMAIL PROTECTED] wrote:
On Feb 13 2008 11:03, Boaz Harrosh wrote:
I've tested this patch now - and it works fine. Now rmmod, halt and
reboot also works.
Stefan Priebe
This is grate news Stefan. Thank you very much for all your time
and
On 01/31/2008 03:29 AM, Darrick J. Wong wrote:
On Wed, Jan 30, 2008 at 06:59:34PM +0800, Keith Hopkins wrote:
V28. My controller functions well with a single drive (low-medium load).
Unfortunately, all attempts to get the mirrors in sync fail and usually hang
the whole box.
Adaptec
On Thu, 2008-02-14 at 13:58 +0200, Boaz Harrosh wrote:
This is a bugfix for the 2.6.24.x stable releases.
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
So del_timer_sync
On Thu, 2008-02-14 at 16:10 +0100, Thomas Petazzoni wrote:
I just upgraded my system from 2.6.23.8 to 2.6.24.2, and when loading
the advansys module, it paniced, with Kernel BUG at advansys.c:6335.
The issue is that the overrun buffer is not aligned on 8 bytes.
The patch
On Thu, Feb 14 2008 at 18:10 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Thu, 2008-02-14 at 13:58 +0200, Boaz Harrosh wrote:
This is a bugfix for the 2.6.24.x stable releases.
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This
James Bottomley wrote:
On Tue, 2008-02-12 at 15:54 -0500, Pete Wyckoff wrote:
iscsi_iser does not have any hardware DMA restrictions. Add a
slave_configure function to remove any DMA alignment restriction,
allowing the use of direct IO from arbitrary offsets within a page.
Also disable page
Adrian Bunk wrote:
This patch makes the following needlessly global functions static:
- __iscsi_unblock_session()
- iscsi_session_state_name()
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Looks good. Thanks.
Acked-by: Mike Christie [EMAIL PROTECTED]
-
To unsubscribe from this list: send the
Mike Christie wrote:
James Bottomley wrote:
On Thu, 2008-02-14 at 11:56 -0600, Mike Christie wrote:
You really don't want to do this. That signals to the block layer that
we have an iommu, although it's practically the same thing as a 64 bit
DMA mask ... but I'd just leave it to the DMA mask
On Thu, 2008-02-14 at 11:56 -0600, Mike Christie wrote:
You really don't want to do this. That signals to the block layer that
we have an iommu, although it's practically the same thing as a 64 bit
DMA mask ... but I'd just leave it to the DMA mask to set this up
correctly. Anything else
James Bottomley wrote:
On Thu, 2008-02-14 at 11:56 -0600, Mike Christie wrote:
You really don't want to do this. That signals to the block layer that
we have an iommu, although it's practically the same thing as a 64 bit
DMA mask ... but I'd just leave it to the DMA mask to set this up
Mike Christie wrote:
Mike Christie wrote:
James Bottomley wrote:
On Thu, 2008-02-14 at 11:56 -0600, Mike Christie wrote:
You really don't want to do this. That signals to the block layer
that
we have an iommu, although it's practically the same thing as a 64 bit
DMA mask ... but I'd just
Submitted are a new set of patches, that fix lots of problems
with the gdth driver.
It fixes the following problems:
- scan for drives on hosts. (Already in mainline)
- truly fixes the exit/reboot problems but does call flush() before
reboot.
- fix crash when accessing array with icpcon
The recent patch named:
[SCSI] gdth: !use_sg cleanup and use of scsi accessors
has done a bad job in handling internal commands issued by gdth_execute().
Internal commands are issued with device gdth_cmd_str ready made directly
to the card, without any mapping or translations of scsi
This is a bugfix for the 2.6.24.x stable releases.
gdth_exit would first remove all cards then stop the timer
and would not sync with the timer function. This caused a crash
in gdth_timer() when module was unloaded.
So del_timer_sync the timer before we delete the cards.
also the reboot
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
Sent: Thursday, February 14, 2008 8:16 AM
To: Miller, Mike (OS Dev)
Subject: [Bug 9859] hp smart array E200i kernel panic upon boot
http://bugzilla.kernel.org/show_bug.cgi?id=9859
[EMAIL PROTECTED] changed:
Boaz Harrosh wrote:
From: Sergio Luis [EMAIL PROTECTED]
Fix compilation warning in gdth.c, which was using the deprecated
pci_find_device.
drivers/scsi/gdth.c:645: warning: 'pci_find_device' is deprecated (declared at
include/linux/pci.h:495)
Changing it to use pci_get_device, instead.
On Thu, 2008-02-14 at 15:13 -0500, Jeff Garzik wrote:
Boaz Harrosh wrote:
From: Sergio Luis [EMAIL PROTECTED]
Fix compilation warning in gdth.c, which was using the deprecated
pci_find_device.
[...]
This patch is already upstream... (unfortunately)
I think, in spite of the cover name
James Bottomley wrote:
On Thu, 2008-02-14 at 15:13 -0500, Jeff Garzik wrote:
Boaz Harrosh wrote:
From: Sergio Luis [EMAIL PROTECTED]
Fix compilation warning in gdth.c, which was using the deprecated
pci_find_device.
[...]
This patch is already upstream... (unfortunately)
I think, in
On Tue, 2008-02-12 at 18:49 -0500, Jeff Garzik wrote:
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Nice work, thanks. This is PCI only I take it. ISA and EISA look like
they'll be a tad more troublesome, so PCI only is fine.
---
drivers/scsi/gdth.c | 143
This patch makes theneedlessly global lpfc_disable_node() static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/scsi/lpfc/lpfc_crtn.h|1 -
drivers/scsi/lpfc/lpfc_hbadisc.c |2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
c3ed441728e0116d0e545837d84cbe337740a3de
Thanks to James pointing out the problems with the BLK_BOUNCE_ANY
for IB devices, this revised patch contains only the DMA alignment
fix for iSER.
Mike, can you take care of this and the other two patches in the
series:
[PATCH 2/3] iscsi iser: increase max_sectors
[PATCH 3/3] iscsi iser:
Boaz Harrosh wrote:
do you intend this to be pushed into 2.6.25-rcx or this is already
for 2.6.26? Should we put this in -mm tree for testing?
Not intended for 2.6.25. I just wanted to get this in process
somewhere, and keep this issue moving. I would definitely prefer to
have this tested
Comments noted for my next round of revisions (its a low priority, so
definitely not this week). Good spotting, thanks!
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
As Sumant mentioned earlier we will check if it is possible to
allow random delete and still allow the devices to be seen.
With this patch we will be blocking a feature that is possibly
used with the legacy driver. The applications may still allow random
delete and that could
Adrian Bunk wrote:
This patch makes theneedlessly global lpfc_disable_node() static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
ACK
-- james s
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Thu, 14 Feb 2008 15:55:49 -0800
Tim Pepper [EMAIL PROTECTED] wrote:
On Thu 14 Feb at 20:48:38 +0900 [EMAIL PROTECTED] said:
I have a slight doubt on the breakup code though I'm not sure you hit
the code. Reverting only the breakup part works? The patch is against
2.6.24.
I've
On Fri 15 Feb at 09:13:16 +0900 [EMAIL PROTECTED] said:
Thanks. So we surely have a bug in the non-breakup part.
I've just found one bug. Can you try this patch against 2.6.24?
Tested and unfortunately no change. Behaves same as the breakup-revert patch.
--
Tim Pepper [EMAIL PROTECTED]
http://bugzilla.kernel.org/show_bug.cgi?id=8004
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
41 matches
Mail list logo
