Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-10-21 16:47 GMT+03:00 Johannes Thumshirn : > On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote: >> 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn : >> > On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote: >> > > 2015-08-21 7:29 GMT+03:00 Dāvis

Re: [PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > A race condition appear to exist between request completion when > scsi_done() is called to end the request and set the tag back to > -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error > handling which aborts the

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

On Wed, 2015-10-21 at 17:26 +0300, Dāvis Mosāns wrote: > 2015-10-21 16:47 GMT+03:00 Johannes Thumshirn : > > On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote: > > > 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn > > >: > > > > On Tue, 2015-10-20 at

Re: [PATCH v3 12/15] scsi: ufs: reduce the interrupts for power mode change requests

2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > DME commands such as Hibern8 enter/exit and gear switch generate 2 > completion interrupts, one for confirmation that command is received > by local UniPro and 2nd one is the final confirmation after communication > with remote

Re: [PATCH v3 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes

2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > According to UFS device specification REQUEST_SENSE command can > only report back up to 18 bytes of data. > > Signed-off-by: Gilad Broner > Signed-off-by: Yaniv Gardi > > --- >

Re: [PATCH v3 09/15] scsi: ufs: add retries for hibern8 enter

2015-09-02 19:13 GMT+09:00 Yaniv Gardi : > If hibern8 enter command fails then UFS link state may be unknown which > may result into timeout of all the commands issued after failure. > > This change does 2 things (for pre-defined number of retry counts) after > hibern8 enter

Re: [PATCH v1 07/17] scsi: ufs: separate device and host quirks

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > diff --git a/drivers/scsi/ufs/ufs_quirks.c b/drivers/scsi/ufs/ufs_quirks.c > new file mode 100644 > index 000..b649bbf > --- /dev/null > +++ b/drivers/scsi/ufs/ufs_quirks.c > @@ -0,0 +1,101 @@ > +/* > + * Copyright (c)

Re: [PATCH v1 01/17] scsi: ufs-qcom: add number of lanes per direction

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 1c37a7d..9638553 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -40,6 +40,7 @@ > #include > #include > > +#include >

Re: [PATCH v1 12/17] scsi: ufs: add retry for query descriptors

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > Query commands have 100ms timeout and it may timeout if they are > issued in parallel to ongoing read/write SCSI commands, this change > adds the retry (max: 10) in case command timeouts. > > Signed-off-by: Subhash Jadavani

Re: [PATCH v1 06/17] scsi :ufs: verify hba controller hce reg value

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > Sometimes due to hw issues it takes some time to the > host controller register to update. In order to verify the register > has updated, a polling is done until its value is set. > > In addition the functions ufshcd_hba_stop() and

Re: [PATCH v1 08/17] scsi: ufs: split broken LCC quirk

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > Currently when UFSHCD_BROKEN_LCC quirk is defined, LCC is getting > disabled on both host and device side but there could be a need > where we don't want to disable the LCC on both side hence this change > splits the quirk in 2

Re: [PATCH v1 02/17] scsi: ufs: add option to change default UFS power management level

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > UFS device and link can be put in multiple different low power modes > hence UFS driver supports multiple different low power modes. > By default UFS driver selects the default (optimal) low power mode > (which gives moderate power

Re: [PATCH v1 14/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > Optimal values of local UniPro parameters like PA_Hibern8Time & > PA_TActivate can help reduce the hibern8 exit latency. If both host and > device supports UniPro ver1.6 or later, these parameters will be > automatically tuned

Re: [PATCH v1 16/17] scsi: ufs: add delay before putting UFS rails in low power modes

2015-09-13 23:52 GMT+09:00 Yaniv Gardi : > We put the UFS device in sleep state & UFS link in hibern8 state during > runtime suspaned. After this we put all the UFS rails in low power > modes immediately but it seems some devices may still draw more than > sleep current from

Re: [PATCH v4 00/11] exynos-ufs: add support for Exynos

A Gentle Reminder !! On 10/14/2015 06:25 PM, Alim Akhtar wrote: This patch-set introduces UFS (Universal Flash Storage) host support for Samsung Exynos SoC. Mostly, it consists of UFS PHY and host specific driver. And it also contains some quirks handling for Exynos. NOTE: ** This series has a

[PATCH v6 31/37] cxlflash: Correct trace string

The trace following the failure of alloc_mem() incorrectly identifies which function failed. This can lead to misdiagnosing a failure. Fix the string to correctly indicate that alloc_mem() failed. Reported-by: Brian King Signed-off-by: Matthew R. Ochs

[PATCH v6 32/37] cxlflash: Fix to avoid potential deadlock on EEH

Ioctl threads that use scsi_execute() can run for an excessive amount of time due to the fact that they have lengthy timeouts and retry logic built in. Under normal operation this is not an issue. However, once EEH enters the picture, a long execution time coupled with the possibility that a

[PATCH v6 30/37] cxlflash: Fix to avoid corrupting adapter fops

The fops owned by the adapter can be corrupted in certain scenarios, opening a window where certain fops are temporarily NULLed before being reset to their proper value. This can potentially lead software to make incorrect decisions, leaving the user with the inability to function as intended. An

[PATCH v6 28/37] MAINTAINERS: Add cxlflash driver

Add stanza for cxlflash SCSI driver. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King Reviewed-by: Andrew Donnellan --- MAINTAINERS | 9 +

[PATCH v6 29/37] cxlflash: Fix to double the delay each time

From: Manoj Kumar The operator used to double the master context response delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl Signed-off-by: Matthew R. Ochs

[PATCH v6 13/37] cxlflash: Fix to avoid stall while waiting on TMF

Borrowing the TMF waitq's spinlock causes a stall condition when waiting for the TMF to complete. To remedy, introduce our own spin lock to serialize TMF and use the appropriate wait services. Also add a timeout while waiting for a TMF completion. When a TMF times out, report back a failure such

[PATCH v6 14/37] cxlflash: Fix location of setting resid

The resid is incorrectly set which can lead to unnecessary retry attempts by the stack. This is due to resid _always_ being set using a value returned from the adapter. Instead, the value should only be interpreted and set when in an underrun scenario. Signed-off-by: Matthew R. Ochs

[PATCH v6 07/37] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v6 06/37] cxlflash: Fix to avoid sizeof(bool)

Using sizeof(bool) is considered poor form for various reasons and sparse warns us of that. Correct by changing type from bool to u8. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v6 16/37] cxlflash: Fix async interrupt bypass logic

A bug was introduced earlier in the development cycle when cleaning up logic statements. Instead of skipping bits that are not set, set bits are skipped, causing async interrupts to not be handled correctly. To fix, simply add back in the proper evaluation for an unset bit. Signed-off-by:

[PATCH v6 27/37] cxlflash: Fix to prevent stale AFU RRQ

Following an adapter reset, the AFU RRQ that resides in host memory holds stale data. This can lead to a condition where the RRQ interrupt handler tries to process stale entries and/or endlessly loops due to an out of sync generation bit. To fix, the AFU RRQ in host memory needs to be cleared

[PATCH v6 17/37] cxlflash: Remove dual port online dependency

At present, both ports must be online for the device to configure properly. Remove this dependency and the unnecessary internal LUN override logic as well. Additionally, as a refactoring measure, change the return code variable name to match that used throughout the driver. With this change, the

[PATCH v6 24/37] cxlflash: Fix MMIO and endianness errors

Sparse uncovered several errors with MMIO operations (accessing directly) and handling endianness. These can cause issues when running in different environments. Introduce __iomem and proper endianness tags/swaps where appropriate to make driver sparse clean. Signed-off-by: Matthew R. Ochs

[PATCH v6 25/37] cxlflash: Fix to prevent EEH recovery failure

The process_sense() routine can perform a read capacity which can take some time to complete. If an EEH occurs while waiting on the read capacity, the EEH handler will wait to obtain the context's mutex in order to put the context in an error state. The EEH handler will sit and wait until the

[PATCH v6 26/37] cxlflash: Correct spelling, grammar, and alignment mistakes

There are several spelling and grammar mistakes throughout the driver. Additionally there are a handful of places where there are extra lines and unnecessary variables/statements. These are a nuisance and pollute the driver. Fix spelling and grammar issues. Update some comments for clarity and

[PATCH v6 23/37] cxlflash: Fix function prolog parameters and return codes

Several function prologs have incorrect parameter names and return code descriptions. This can lead to confusion when reviewing the source and creates inaccurate documentation. To remedy, update the function prologs to properly reflect parameter names and return codes. Signed-off-by: Matthew R.

[PATCH v6 00/37] cxlflash: Miscellaneous bug fixes and corrections

This patch set contains various fixes and corrections for issues that were found during test and code review. The series is based upon the code upstreamed in 4.3 (rebased to Dan Carpenter's 9/22 patch) and is intended for 4.4. The entire set is bisectable. Please reference the changelog below for

[PATCH v6 20/37] cxlflash: Fix to prevent workq from accessing freed memory

The workq can process work in parallel with a remove event, leading to a condition where the workq handler can access freed memory. To remedy, the workq should be terminated prior to freeing memory. Move the termination call earlier in remove and use cancel_work_sync() instead of flush_work() as

[PATCH v6 19/37] cxlflash: Correct usage of scsi_host_put()

Currently, scsi_host_put() is being called prematurely in the remove path and is missing entirely in an error cleanup path. The former can lead to memory being freed too early with subsequent access potentially corrupting data whilst the former would result in a memory leak. Move the usage on

[PATCH v6 18/37] cxlflash: Fix AFU version access/storage and add check

The AFU version is stored as a non-terminated string of bytes within a 64-bit little-endian register. Presently the value is read directly (no MMIO accessor) and is stored in a buffer that is not big enough to contain a NULL terminator. Additionally the version obtained is not evaluated against a

[PATCH v6 21/37] cxlflash: Correct behavior in device reset handler following EEH

When the device reset handler is entered while a reset operation is taking place, the handler exits without actually sending a reset (TMF) to the targeted device. This behavior is incorrect as the device is not reset. Further complicating matters is the fact that a success is returned even when

[PATCH v6 03/37] cxlflash: Fix read capacity timeout

From: Manoj Kumar The timeout value for read capacity is too small. Certain devices may take longer to respond and thus the command may prematurely timeout. Additionally the literal used for the timeout is stale. Update the timeout to 30 seconds (matches the value used in

[PATCH v6 02/37] cxlflash: Replace magic numbers with literals

From: Manoj Kumar Magic numbers are not meaningful and can create confusion. As a remedy, replace them with descriptive literals. Replace 512 with literal MAX_SECTOR_UNIT. Replace 5 with literal CMD_RETRIES. Signed-off-by: Matthew R. Ochs

[PATCH v6 34/37] cxlflash: Fix to escalate to LINK_RESET on login timeout

From: Manoj Kumar A 'login timed out' asynchronous error interrupt is generated if no response is seen to a FLOGI within 2 seconds. If the time out error is not escalated to a LINK_RESET the port will not be available for use. This fix provides the required escalation.

[PATCH v6 33/37] cxlflash: Fix to avoid leaving dangling interrupt resources

When running with an unsupported AFU, the cxlflash driver fails the probe. When the driver is removed, the following Oops is encountered on a show_interrupts() thread: Call Trace: [c01fba5a7a10] [0003] 0x3 (unreliable) [c01fba5a7a60] [c053dcf4] vsnprintf+0x204/0x4c0

[PATCH v6 22/37] cxlflash: Remove unnecessary scsi_block_requests

The host reset handler is called with I/O already blocked, thus there is no need to explicitly block and unblock I/O in the handler. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N. Kumar Reviewed-by: Brian King

[PATCH v6 37/37] cxlflash: Fix to avoid bypassing context cleanup

Contexts may be skipped over for cleanup in situations where contention for the adapter's table-list mutex is experienced in the presence of a signal during the execution of the release handler. This can lead to two known issues: - A hang condition on remove as that path tries to wait for users

[PATCH v6 35/37] cxlflash: Fix to avoid corrupting port selection mask

The port selection mask of a LUN can be corrupted when the manage LUN ioctl (DK_CXLFLASH_MANAGE_LUN) is issued more than once for any device. This mask indicates to the AFU which port[s] can be used for a data transfer to/from a particular LUN. The mask is critical to ensuring the correct

[PATCH v6 15/37] cxlflash: Fix host link up event handling

Following a link up event, the LUNs available to the host may have changed. Without rescanning the host, the LUN topology is unknown to the user. In such a state, the user would be unable to locate provisioned resources. To remedy, the host should be rescanned after a link up event.

[PATCH v6 36/37] cxlflash: Fix to avoid lock instrumentation rejection

When running with lock instrumentation (e.g. lockdep), some of the instrumentation can become disabled at probe time for a cxlflash adapter. This is due to a missing lock registration for the tmf_slock. The fix is to call spin_lock_init() for the tmf_slock during probe. Signed-off-by: Matthew R.

[PATCH v6 12/37] cxlflash: Fix to avoid spamming the kernel log

During run-time the driver can be very chatty and spam the system kernel log. Various print statements can be limited and/or moved to development-only mode. Additionally, numerous prints can be converted to trace the corresponding device. Lastly, one spelling correction was made: 'entra' to

Re: [PATCH v5 34/34] cxlflash: Fix to escalate to LINK_RESET on login timeout

Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v6 10/37] cxlflash: Make functions static

Found during code inspection, that the following functions are not being used outside of the file where they are defined. Make them static. int cxlflash_send_cmd(struct afu *, struct afu_cmd *); void cxlflash_wait_resp(struct afu *, struct afu_cmd *); int cxlflash_afu_reset(struct cxlflash_cfg

[PATCH v6 04/37] cxlflash: Fix potential oops following LUN removal

When a LUN is removed, the sdev that is associated with the LUN remains intact until its reference count drops to 0. In order to prevent an sdev from being removed while a context is still associated with it, obtain an additional reference per-context for each LUN attached to the context. This

[PATCH v6 01/37] cxlflash: Fix to avoid invalid port_sel value

From: Manoj Kumar If two concurrent MANAGE_LUN ioctls are issued with the same WWID parameter, it would result in an incorrect value of port_sel. This is because port_sel is modified without any locks being held. If the first caller stalls after the return from

[PATCH v6 08/37] cxlflash: Fix to avoid CXL services during EEH

During an EEH freeze event, certain CXL services should not be called until after the hardware reset has taken place. Doing so can result in unnecessary failures and possibly cause other ill effects by triggering hardware accesses. This translates to a requirement to quiesce all threads that may

[PATCH v6 11/37] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Suggested-by: Shane Seymour Signed-off-by: Matthew R. Ochs

[PATCH v6 05/37] cxlflash: Fix data corruption when vLUN used over multiple cards

If the same virtual LUN is accessed over multiple cards, only accesses made over the first card will be valid. Accesses made over the second card will go to the wrong LUN causing data corruption. This is because the global LUN's mode word was being used to determine whether the LUN table for that

[PATCH v6 09/37] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs Signed-off-by: Manoj N.

[PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with the goal of getting rid of this macro completely, as this macro is deprecated. Signed-off-by: Muhammad Falak R Wani --- drivers/scsi/wd719x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] scsi: wd719x: Use module_pci_driver

Remove boilerplate code by using macro module_pci_driver. For drivers whose __init and __exit paths only register and unregister to the pci API, it is preferred to use this macro. Signed-off-by: Muhammad Falak R Wani --- drivers/scsi/wd719x.c | 13 + 1 file

Re: [PATCH v6 37/37] cxlflash: Fix to avoid bypassing context cleanup

On 22/10/15 07:16, Matthew R. Ochs wrote: Contexts may be skipped over for cleanup in situations where contention for the adapter's table-list mutex is experienced in the presence of a signal during the execution of the release handler. This can lead to two known issues: - A hang condition

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

On Wed, 2015-10-21 at 16:18 +0300, Dāvis Mosāns wrote: > 2015-10-21 10:33 GMT+03:00 Johannes Thumshirn : > > On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote: > > > 2015-08-21 7:29 GMT+03:00 Dāvis Mosāns : > > > > When pci_pool_alloc fails in

AUF DEINE ANTWORT WARTEND

AUF DEINE ANTWORT WARTEND Ich bin mit diesem Medium, um Sie über die Transaktion zur Abgabe von $ 2150 (einundzwanzig Millionen fünfhunderttausend US-Dollar) auf meinem Bank in China, Sie als Empfänger zu informieren. Es ist 100% sicher, wobei der Finanzvorstand des verstorbenen

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-10-21 10:33 GMT+03:00 Johannes Thumshirn : > On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote: >> 2015-08-21 7:29 GMT+03:00 Dāvis Mosāns : >> > When pci_pool_alloc fails in mvs_task_prep then task->lldd_task >> > stays >> > NULL but it's later used

Re: [PATCH 1/7] bnx2fc: Update copyright for 2015.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/57xx_hsi_bnx2fc.h |4 ++-- > drivers/scsi/bnx2fc/bnx2fc.h |4 ++-- >

Re: [PATCH 4/7] bnx2fc: Fix FCP RSP residual parsing.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/bnx2fc_io.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git

Re: [PATCH 2/7] bnx2fc: Remove 'NetXtreme II' from source files.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/57xx_hsi_bnx2fc.h |2 +- > drivers/scsi/bnx2fc/Kconfig|5 ++--- >

Re: [PATCH 3/7] bnx2fc: Set ELS transfer length correctly for middle path commands.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/bnx2fc_els.c |1 + > drivers/scsi/bnx2fc/bnx2fc_io.c |8 ++-- > 2 files changed, 7

Re: [PATCH 6/7] bnx2fc: Add HZ to task management timeout.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/bnx2fc.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

Re: [PATCH 7/7] bnx2fc: Update version number to 2.9.6.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis > --- > drivers/scsi/bnx2fc/bnx2fc.h |2 +- > drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +- > 2 files changed, 2

Re: [PATCH 5/7] bnx2fc: Remove explicit logouts.

On 10/19/2015 09:40 PM, Chad Dupuis wrote: > Explicit logouts from bnx2fc were causing race conditions in either returning > stale SCSI commands or not allowing a target to log back in. > > Signed-off-by: Giridhar Malavali > Signed-off-by: Chad Dupuis

Re: [PATCH] hpsa: add in sas transport

On 10/20/2015 10:07 PM, Don Brace wrote: >> -Original Message- >> From: Hannes Reinecke [mailto:h...@suse.de] >> Sent: Wednesday, September 30, 2015 2:50 AM >> To: Don Brace; linux-scsi@vger.kernel.org >> Subject: Re: [PATCH] hpsa: add in sas transport >> >> On 09/30/2015 12:21 AM, Don

Re: [PATCH v2] scsi: Export SCSI Inquiry data to sysfs

On 09/24/2015 04:54 PM, Johannes Thumshirn wrote: > > Ping? > I really would like to see them included, as with this we can move the udev rules over to not issuing any SG_IO commands during event processing. This helps a lot for multipath failover scenarios. Cheers, Hannes -- Dr. Hannes

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

On Tue, 2015-10-20 at 20:41 +0300, Dāvis Mosāns wrote: > 2015-08-21 7:29 GMT+03:00 Dāvis Mosāns : > > When pci_pool_alloc fails in mvs_task_prep then task->lldd_task > > stays > > NULL but it's later used in mvs_abort_task as slot which is passed > > to mvs_slot_task_free

SIL3132 APM X-gene 1 timeout error

Hi All, I am seeing the following messages during boot up of latest kernel image on APM X-Gene 1 Mustang board with sil3132 card plugged in and 2 disks connected. Similar messages are also seen during dd/xdd operations. This happens even when libata.force=noncq parameter is set on command line.