Re: [PATCH] mptscsih: remove bogus interpretation of request->ioprio

> "Christoph" == Christoph Hellwig writes: Christoph> Having an I/O priority does not mean we should send all Christoph> requests as HEAD OF QUEUE tags. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH] scsi: ufs: changing maintainer

> "Joao" == Joao Pinto writes: Joao> I am going to leave Synopsys and so this patch changes the Joao> Maintainer for UFS Synopsys' specific drivers to my colleagues Joao> Manjunath and Prabu. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH 00/24] FCoE VN2VN fixes, part two

> "Hannes" == Hannes Reinecke writes: Hannes> Hi all, here's now the second part of my FCoE VN2VN patchset. Hannes> The key points are: Hannes> - Configurable R_A_TOV/E_D_TOV Hannes> - Rework PRLI handling to fix a longstanding bug Hannes> - Correctly handle timed-out xids

Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

> "Subhash" == Subhash Jadavani writes: Subhash> UFS devfreq clock scaling work may require clocks to be ON if Subhash> it need to execute some UFS commands hence it may request for Subhash> clock hold before issuing the command. But if UFS clock gating Subhash> work

Re: [PATCH 0/2] Locking issue in libiscsi and be2iscsi

> "Jitendra" == Jitendra Bhivare writes: Jitendra> These patches are being resent with required changes as per Jitendra> comments for [PATCH 02/28] be2iscsi: Replace _bh with Jitendra> _irqsave/irqrestore Jitendra> In IO handling path, there is no spin_lock

Re: [PATCH 11/24] libfc: Return LS_RJT_BUSY for PRLI in status PLOGI

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: Occasionally it might happen that we receive a PRLI while we're still waiting for our PLOGI response. In that case we should return 'busy' LS status instead of 'plogi required' LS status. Reviewed-by: Bart Van Assche

Re: [PATCH 13/24] libfc: safeguard against invalid exchange index

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: The cached exchange index might be invalid, in which case we should drop down to allocate a new one. And we should not try to access an invalid exchange when responding to a BA_ABTS. Reviewed-by: Bart Van Assche -- To

Re: [PATCH 14/24] libfc: quarantine timed out xids

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: When a sequence times out we have no idea what happened to the frame. And we do not know if we will ever receive the frame. Hence we cannot re-use the xid as we would risk data corruption if the xid had been re-used and the timed out frame would be

Re: [PATCH 19/24] libfc: Check xid when looking up REC exchanges

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: We currently can only lookup the local xid, so we need to reject REC with empty rxid. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 18/24] libfc: wait for E_D_TOV when out-of-order sequence is received

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: When detecting an out-of-order sequence we should be waiting for E_D_TOV before trying to abort the sequence. The response might still be stuck in the queue somewhere. Reviewed-by: Bart Van Assche -- To unsubscribe

Re: [PATCH 22/24] fcoe: FIP debugging

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: Add additional statements for debugging FIP frames. > [ ... ] @@ -2442,15 +2446,21 @@ static void fcoe_ctlr_vn_probe_req(struct fcoe_ctlr *fip, */ if (fip->lp->wwpn > rdata->ids.port_name &&

Re: [PATCH 23/24] fcoe: correct sending FIP VLAN packets on VLAN 0

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: The FIP VLAN frame consists of an ethernet header followed by the FIP VLAN frame, so we need to skip the ethernet header if we want to check the FIP opcode. Reviewed-by: Bart Van Assche -- To unsubscribe from this

Re: [PATCH 24/24] fcoe: filter out frames from invalid vlans

On 10/13/2016 06:11 AM, Hannes Reinecke wrote: Any multicase address is set on all interfaces, the base interface and any VLAN interfaces on top of this. So we might receive frames which are not destined for us. Reviewed-by: Bart Van Assche -- To unsubscribe from

Re: [PATCH 20/24] fcoe: set default TC priority

On 10/13/2016 06:10 AM, Hannes Reinecke wrote: If DCB is not enabled or compiled in we still should be setting a sane default priority. So put FCoE frames in priority class 'interactive' and FIP frames in priority class 'besteffort'. Reviewed-by: Bart Van Assche --

Re: [PATCH 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

> "Finn" == Finn Thain writes: Finn> This patch series has fixes for compatibility, reliability and Finn> performance issues and some cleanup. It also includes a new Finn> version of Ondrej Zary's patch that merges g_NCR5380_mmio into Finn> g_NCR5380. Finn> I've

Re: Patch: [Open-FCoE] Revert commit 3e22760d4db6fd89e0be46c3d132390a251da9c6 due to performance issues

> "Laurence" == Laurence Oberman writes: Laurence> This patch reverts commit Laurence> 3e22760d4db6fd89e0be46c3d132390a251da9c6. Laurence> This revert came about because of efforts by Ewan Milne, Laurence> Curtis Taylor and I. In researching this issue, significant

Re: [PATCH 1/1] [4.9-rc] ipr: Fix async error WARN_ON

> "Brian" == Brian King writes: Brian> Commit afc3f83cb4a5 ("scsi: ipr: Add asynchronous error Brian> notification") introduced the warn on shown below. To fix this, Brian> rather than attempting to send the KOBJ_CHANGE uevent from Brian> interrupt context, which

Re: [PATCH] scsi: hpsa: remove unneeded void pointer cast

> "Javier" == Javier Martinez Canillas writes: Javier> It's not necessary to cast the result of kmalloc, since void Javier> pointers are promoted to any other type. This also fixes Javier> following coccinelle warning: Javier> casting value returned by memory

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

> "Steffen" == Steffen Maier writes: Steffen> could you please queue this as fix for one of my patches that Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH v3 00/17] lpfc: Update driver to version 11.2.0.2

> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.2.0.2 Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH] MAINTAINERS: remove defunct iss storage mailing list

> "Javier" == Javier Martinez Canillas writes: Javier> It appears that the mailing list email address doesn't exist Javier> anymore: : host smtp.hp.com[15.73.96.116] Javier> said: 550 5.1.1 Javier> : Recipient address

Re: [PATCH v3 05/17] lpfc: Make lpfc_prot_xxx params per hba parameters

On 10/14/2016 12:06 AM, James Smart wrote: > > Make lpfc_prot_mask and lpfc_prot_guard per hba parameters > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 06/17] lpfc: Code clean up for lpfc_iocb_cnt parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code clean up for lpfc_iocb_cnt parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 07/17] lpfc: Code cleanup for lpfc_enable_rrq parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code cleanup for lpfc_enable_rrq parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 08/17] lpfc: Code cleanup for lpfc_aer_support parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code cleanup for lpfc_aer_support parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 09/17] lpfc: Code cleanup for lpfc_topology parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code cleanup for lpfc_topology parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote: > Hm, still behaves for me like I reported for v2: > http://marc.info/?l=linux-scsi=147637177902937=2 Hi Steffen, Can you please try the following on top of 2/16? diff --git a/drivers/scsi/scsi_transport_fc.c

Re: [PATCH v3 15/17] lpfc: Synchronize link speed with boot driver

On Thu, Oct 13, 2016 at 03:06:16PM -0700, James Smart wrote: > > Synchronize link speed with boot driver > > Link speed settings set by the boot driver are reported by the hw. > Driver will attempt to read them, and if set, will respect their > values. > The driver can override the settings with

Re: [PATCH v3 02/17] lpfc: Correct embedded io wq element size

On 10/14/2016 12:06 AM, James Smart wrote: > > Correct embedded io wq element size. Embedded element sizes are > 128 byte elements > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn

Re: [PATCH v3 03/17] lpfc: Fix sg_reset on SCSI device causing kernel crash

On 10/14/2016 12:06 AM, James Smart wrote: > > Fix sg_reset on SCSI device causing kernel crash > > Driver could reference stale node pointers in task mgmt call. > Changed to use resetting cmd and look up node pointer in task mgmt > function. > > Signed-off-by: Dick Kennedy

Re: [PATCH v3 04/17] lpfc: Set driver environment data on adapter

On 10/14/2016 12:06 AM, James Smart wrote: > > Set driver environment data on adapter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- > drivers/scsi/lpfc/lpfc_hw4.h |

Re: [PATCH v3 01/17] Fix few small typos in lpfc_scsi.c

On 10/14/2016 12:06 AM, James Smart wrote: > > From: "Milan P. Gandhi" > > This patch does a cleanup and fixes few small typos in lpfc_scsi.c > > Signed-off-by: Milan P. Gandhi > Signed-off-by: James Smart > Reviewed-by:

Re: [PATCH v3 15/17] lpfc: Synchronize link speed with boot driver

On 10/14/2016 12:06 AM, James Smart wrote: > > Synchronize link speed with boot driver > > Link speed settings set by the boot driver are reported by the hw. > Driver will attempt to read them, and if set, will respect their > values. > The driver can override the settings with its own if

Re: [PATCH v3 10/17] lpfc: Code cleanup for lpfc_max_scsicmpl_time parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code cleanup for lpfc_max_scsicmpl_time parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 11/17] lpfc: Code cleanup for lpfc_sriov_nr_virtfn parameter

On 10/14/2016 12:06 AM, James Smart wrote: > > Code cleanup for lpfc_sriov_nr_virtfn parameter > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 14/17] lpfc: Correct panics with eh_timeout and eh_deadline

On 10/14/2016 12:06 AM, James Smart wrote: > > Correct panics with eh_timeout and eh_deadline > > We were having double completions on our SLI-3 version of adapters. > Solved by clearing our command pointer before calling scsi_done. > > The eh paths potentially ran simulatenously and would see

Re: [PATCH v3 13/17] lpfc: Fix lost target in pt-to-pt connect

On 10/14/2016 12:06 AM, James Smart wrote: > > Fix lost target in pt-to-pt connect > > Change reject code to something that allows a retry > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn

Re: [PATCH v3 12/17] lpfc: Revise strings with full lpfc parameter name

On 10/14/2016 12:06 AM, James Smart wrote: > > Revise strings with full lpfc parameter name > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- >

Re: [PATCH v3 16/17] lpfc: Fix fw download on SLI-4 FC adapters

On Thu, Oct 13, 2016 at 03:06:17PM -0700, James Smart wrote: > > Fix fw download on SLI-4 FC adapters > > Driver performs a quick validation of magic numbers in the fw > download image. Driver needed to be updated for more recent > magic numbers. > > Signed-off-by: Dick Kennedy

Re: [GIT PULL] final round of SCSI updates for the 4.8+ merge window

On Fri, 14 Oct 2016, James Bottomley wrote: > This is just a set of minor updates and fixes which weren't quite ready > in time for the first pull request. The only real thing of note is > Mike Christie is stepping down as Maintainer of iscsi to be replaced by > Lee Duncan and Chris Leech. > >

[PATCH 1/3] target: Re-add missing SCF_ACK_KREF assignment in v4.1.y

From: Nicholas Bellinger This patch fixes a regression in >= v4.1.y code where the original SCF_ACK_KREF assignment in target_get_sess_cmd() was dropped upstream in commit 054922bb, but the series for addressing TMR ABORT_TASK + LUN_RESET with fabric session reinstatement

[PATCH 0/3] target: Bug-fixes for v4.9-rc1

From: Nicholas Bellinger Hi folks, Here are three outstanding target bug-fixes encountered during failure and longevity testing with v4.1.y code. The patch #1 is a v4.1+ regression where the missing upstream assignment of SCF_ACK_KREF results in se_cmd->cmd_kref leakage

[PATCH 2/3] target: Make EXTENDED_COPY 0xe4 failure return COPY TARGET DEVICE NOT REACHABLE

From: Nicholas Bellinger This patch addresses a bug where EXTENDED_COPY across multiple LUNs results in a CHECK_CONDITION when the source + destination are not located on the same physical node. ESX Host environments expect sense COPY_ABORTED w/ COPY TARGET DEVICE NOT

[PATCH 3/3] target: Don't override EXTENDED_COPY xcopy_pt_cmd SCSI status code

From: Dinesh Israni This patch addresses a bug where a local EXTENDED_COPY WRITE or READ backend I/O request would always return SAM_STAT_CHECK_CONDITION, even if underlying xcopy_pt_cmd->se_cmd generated a different SCSI status code. ESX host environments expect to hit

Re: [PATCH v3 16/17] lpfc: Fix fw download on SLI-4 FC adapters

On 10/14/2016 12:06 AM, James Smart wrote: > > Fix fw download on SLI-4 FC adapters > > Driver performs a quick validation of magic numbers in the fw > download image. Driver needed to be updated for more recent > magic numbers. > > Signed-off-by: Dick Kennedy >

Re: [PATCH v3 17/17] lpfc: lpfc version changed to 11.2.0.2

On 10/14/2016 12:06 AM, James Smart wrote: > > lpfc version changed to 11.2.0.2 > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > Reviewed-by: Johannes Thumshirn > --- > drivers/scsi/lpfc/lpfc_version.h | 2

Re: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

On 09/08/2016 01:25 PM, James Bottomley wrote: On Thu, 2016-09-08 at 18:15 +, Don Brace wrote: -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC Series 9 */ How are people that load aacraid in their initrd going to boot after this? -- Martin K. Petersen Oracle

[PATCH] scsi: ufs: changing maintainer

I am going to leave Synopsys and so this patch changes the Maintainer for UFS Synopsys' specific drivers to my colleagues Manjunath and Prabu. Signed-off-by: Joao Pinto --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS

[bug report] smartpqi: initial commit of Microsemi smartpqi driver

Hello Kevin Barnett, The patch 6c223761eb54: "smartpqi: initial commit of Microsemi smartpqi driver" from Jun 27, 2016, leads to the following static checker warning: drivers/scsi/smartpqi/smartpqi_init.c:3513 pqi_submit_raid_request_synchronous() warn: inconsistent returns

[PATCH] scsi: aic7xxx: fix ahc_delay and ahd_delay

They are buggy: while (usec > 0) udelay(usec % 1024); usec -= 1024; For example, for usec = 100*1024 + 1, old code will udelay(1) 101 times, i.e. it will be approximately equivalent to udelay(101), not the expected udelay(102400). This did not bite because

[GIT PULL] final round of SCSI updates for the 4.8+ merge window

This is just a set of minor updates and fixes which weren't quite ready in time for the first pull request. The only real thing of note is Mike Christie is stepping down as Maintainer of iscsi to be replaced by Lee Duncan and Chris Leech. The patch is available here:

Re: [PATCH v4 1/4] block: Add iocontext priority to request

The 10/14/2016 07:54, Hannes Reinecke wrote: > On 10/13/2016 09:53 PM, Adam Manzanares wrote: > > Patch adds an association between iocontext ioprio and the ioprio of a > > request. This value is set in blk_rq_set_prio which takes the request and > > the ioc as arguments. If the ioc is valid in

Re: [PATCH v5 2/4] fusion: remove iopriority handling

Th 10/13/2016 22:34, Christoph Hellwig wrote: > > Style wise you can further remove the extra parens around > > SCpnt->device->tagged_supported > > As well as the now redundant braces. > > I did send a patch looking just like that earlier :) I'll remove the patch from the patchset. I must have