Re: [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > Fix comments style (do not use documented comment style) and add some > comments to clarify some functions. Also fix some functions signature > indentation and remove a useless blank line in sd_zbc_read_zones(). > > No functional change is

Re: [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > Zoned block devices have no write constraints for conventional zones. > So write locking of conventional zones is not necessary and can even > hurt performance by unnecessarily operating the disk under low queue > depth. To avoid this, use the disk

Re: [PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > In the case of a ZBC disk used with scsi-mq, zone write locking does > not prevent write reordering in sequential zones. Unlike the legacy > case, zone locking is done after the command request is removed from > the scheduler dispatch queue. That is,

[PATCH 1/3] fcoe: move fcoe_interface_remove() out of fcoe_interface_cleanup()

This closes a possible race condition in _fcoe_create() where we drop the rtnl_lock() before calling fcoe_interface_remove(). Signed-off-by: Hannes Reinecke Reviewed-by: Lee Duncan Acked-by: Johannes Thumshirn --- drivers/scsi/fcoe/fcoe.c | 12

[PATCH 3/3] fcoe: open-code fcoe_destroy_work() for NETDEV_UNREGISTER

When a NETDEV_UNREGISTER notification is received the network device is _deleted_ after the callback returns. So we cannot use a workqueue here, as this would cause an inversion when removing the device as the netdev is already gone. This manifests with a nasty warning during shutdown: sysfs

[PATCHv2 0/3] fcoe: fixup device_del() inversion

Hi all, when shutting down an FCoE target system one is greeted with a flood of kernel warnings about sysfs group 81eff0e0 not found for kobject 'XXX' Reason here is that the fcoe driver tries to remove devices from a workqueue, but the NETDEV_UNREGISTER notification expects any calls

[PATCH 2/3] fcoe: separate out fcoe_vport_remove()

Separate out fcoe_vport_remove() from fcoe_destroy_work(). Required for the next patch. Signed-off-by: Hannes Reinecke Reviewed-by: Lee Duncan Acked-by: Johannes Thumshirn --- drivers/scsi/fcoe/fcoe.c | 55

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

On Fri, Sep 15, 2017 at 01:21:52PM +0800, shuw...@redhat.com wrote: > From: Shu Wang > > Kmemleak reports about a thousand false positives for fusion-> > cmd_list[]. Root casue is the cmd_list objects are allocated from > slab allocator, and stored its pointer in object

Re: [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > instead of open coding, use the min() macro to calculate a report zones > reply buffer length in sd_zbc_check_zone_size() and the round_up() > macro for calculating the number of zones in sd_zbc_setup(). > > No functional change is introduced by

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw > assignments and move the calculation of sdkp->zone_shift together > with the assignment of the verified zone_blocks value in > sd_zbc_check_zone_size(). > > No functional change

[PATCH V3 00/12] scsi-mq support for ZBC disks

This series implements support for ZBC disks used through the scsi-mq I/O path. The current scsi level support of ZBC disks guarantees write request ordering using a per-zone write lock which prevents issuing simultaneously multiple write commands to a zone, doing so avoid reordering of

[PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation

Fix comments style (do not use documented comment style) and add some comments to clarify some functions. Also fix some functions signature indentation and remove a useless blank line in sd_zbc_read_zones(). No functional change is introduced by this patch. Signed-off-by: Damien Le Moal

[PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions

The functions blk_mq_sched_free_hctx_data(), blk_mq_sched_try_merge(), blk_mq_sched_try_insert_merge() and blk_mq_sched_request_inserted() are all exported symbols but are declared only internally in block/blk-mq-sched.h. Move these declarations to the new file include/linux/blk-mq-sched.h to make

[PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h

Move standard macro definitions for the zone types and zone conditions to scsi_proto.h together with the definitions related to the REPORT ZONES command. While at it, define all values in the enums to be clear. Also remove unnecessary includes in sd_zbc.c. No functional change is introduced by

[PATCH V3 07/12] scsi: sd_zbc: Use well defined macros

instead of open coding, use the min() macro to calculate a report zones reply buffer length in sd_zbc_check_zone_size() and the round_up() macro for calculating the number of zones in sd_zbc_setup(). No functional change is introduced by this patch. Signed-off-by: Damien Le Moal

[PATCH V3 06/12] scsi: sd_zbc: Rearrange code

Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw assignments and move the calculation of sdkp->zone_shift together with the assignment of the verified zone_blocks value in sd_zbc_check_zone_size(). No functional change is introduced by this patch. Signed-off-by: Damien Le Moal

[PATCH V3 03/12] block: Add zoned block device information to request queue

Components relying only on the requeuest_queue structure for managing and controlling block devices (e.g. I/O schedulers) have a limited view/knowledged of the device being controlled. For instance, the device capacity cannot be known easily, which for a zoned block device also result in the

[PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions

__blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported symbols but ar eonly declared in the block internal file block/blk-mq-debugfs.h. which is not cleanly accessible to files outside of the block directory. Move the declaration of these functions to the new file

Re: [PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > Allocate and initialize the disk request queue zoned structure on disk > revalidate. As the bitmap allocation for the seq_zones field of the > zoned structure is identical to the allocation of the zones write lock > bitmap, introduce the helper

Re: [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics()

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > The three values starting at byte 8 of the Zoned Block Device > Characteristics VPD page B6h are 32 bits values, not 64bits. So use > get_unaligned_be32() to retrieve the values and not get_unaligned_be64() > > Fixes: 89d947561077 ("sd: Implement

[PATCH V3 12/12] block: Introduce zoned I/O scheduler

The zoned I/O scheduler is mostly identical to mq-deadline and retains the same configuration attributes. The main difference is that the zoned scheduler will ensure that at any time at most one write request per sequential zone is in flight (has been dispatched to the disk) in order to protect

[PATCH V3 11/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

In the case of a ZBC disk used with scsi-mq, zone write locking does not prevent write reordering in sequential zones. Unlike the legacy case, zone locking is done after the command request is removed from the scheduler dispatch queue. That is, at the time of zone locking, the write command may

[PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics()

The three values starting at byte 8 of the Zoned Block Device Characteristics VPD page B6h are 32 bits values, not 64bits. So use get_unaligned_be32() to retrieve the values and not get_unaligned_be64() Fixes: 89d947561077 ("sd: Implement support for ZBC devices") Cc:

[PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones

Zoned block devices have no write constraints for conventional zones. So write locking of conventional zones is not necessary and can even hurt performance by unnecessarily operating the disk under low queue depth. To avoid this, use the disk request queue seq_zones bitmap to allow any write to be

[PATCH V3 09/12] scsi: sd_zbc: Initialize device queue zoned structure

Allocate and initialize the disk request queue zoned structure on disk revalidate. As the bitmap allocation for the seq_zones field of the zoned structure is identical to the allocation of the zones write lock bitmap, introduce the helper sd_zbc_alloc_zone_bitmap(). Using this helper, wait for the

Re: [PATCH V3 12/12] block: Introduce zoned I/O scheduler

On 09/15/2017 12:06 PM, Damien Le Moal wrote: > The zoned I/O scheduler is mostly identical to mq-deadline and retains > the same configuration attributes. The main difference is that the > zoned scheduler will ensure that at any time at most one write request > per sequential zone is in flight

[PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table is returned; the remaining part will then contain stale kernel memory information. This patch zeroes out the entire table to avoid this issue. Signed-off-by: Hannes Reinecke --- drivers/scsi/sg.c | 5 ++--- 1

[PATCH 1/2] sg: factor out sg_fill_request_table()

Factor our sg_fill_request_table() for better readability. Signed-off-by: Hannes Reinecke --- drivers/scsi/sg.c | 62 --- 1 file changed, 36 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c

[PATCH 0/2] sg: fix infoleak when using SG_GET_REQUEST_TABLE

KMSAN detected a possible infoleak when using SG_GET_REQUEST_TABLE ioctl. This patchset fixes it. As usual, comments and reviews are welcome. Hannes Reinecke (2): sg: factor out sg_fill_request_table() sg: fixup infoleak when using SG_GET_REQUEST_TABLE drivers/scsi/sg.c | 65

Re: [PATCH V3 10/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > + * There is no write constraints on conventional zones. So any write ^^^ Should this have been "There are no"? > - if (sdkp->zones_wlock && > - test_and_set_bit(zno, sdkp->zones_wlock)) > + if

Re: [PATCH 1/2] sg: factor out sg_fill_request_table()

On Fri, 2017-09-15 at 14:05 +0200, Hannes Reinecke wrote: > Factor our sg_fill_request_table() for better readability. Reviewed-by: Bart Van Assche

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw > assignments and move the calculation of sdkp->zone_shift together > with the assignment of the verified zone_blocks value in > sd_zbc_check_zone_size(). Both functions

Re: [PATCH V3 03/12] block: Add zoned block device information to request queue

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > @@ -492,6 +497,10 @@ struct request_queue { > struct blk_integrity integrity; > #endif /* CONFIG_BLK_DEV_INTEGRITY */ > > +#ifdef CONFIG_BLK_DEV_ZONED > + struct blk_zonedzoned; > +#endif > + > #ifdef CONFIG_PM

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

On Fri, 2017-09-15 at 13:21 +0800, shuw...@redhat.com wrote: > @@ -4548,9 +4556,11 @@ megasas_free_fusion_context(struct megasas_instance > *instance) > > if (is_vmalloc_addr(fusion)) > vfree(fusion); > - else > + else { > +

Re: [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported > symbols but ar eonly declared in the block internal file are only? > block/blk-mq-debugfs.h. which is not cleanly accessible to

Re: [PATCH RESEND] lpfc: Don't return internal MBXERR_ERROR code from probe function

On 9/14/2017 6:19 PM, Martin K. Petersen wrote: James/Dick, Please review! It seemed to be changing so I was waiting for the final posting... -- james

Re: [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > The functions blk_mq_sched_free_hctx_data(), blk_mq_sched_try_merge(), > blk_mq_sched_try_insert_merge() and blk_mq_sched_request_inserted() are > all exported symbols but are declared only internally in > block/blk-mq-sched.h. Move these

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

On Fri, 2017-09-15 at 14:05 +0200, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. Reviewed-by: Bart

Re: [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros

On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > instead of open coding, use the min() macro to calculate a report zones > reply buffer length in sd_zbc_check_zone_size() and the round_up() > macro for calculating the number of zones in sd_zbc_setup(). Reviewed-by: Bart Van Assche

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

On 2017-09-15 08:05 AM, Hannes Reinecke wrote: When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table is returned; the remaining part will then contain stale kernel memory information. This patch zeroes out the entire table to avoid this issue. Signed-off-by: Hannes Reinecke

Re: [PATCH 1/2] sg: factor out sg_fill_request_table()

On 2017-09-15 08:05 AM, Hannes Reinecke wrote: Factor our sg_fill_request_table() for better readability. Signed-off-by: Hannes Reinecke Acked-by: Douglas Gilbert Thanks. --- drivers/scsi/sg.c | 62

Re: [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions

On Fri, Sep 15, 2017 at 07:06:34PM +0900, Damien Le Moal wrote: > __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported > symbols but ar eonly declared in the block internal file > block/blk-mq-debugfs.h. which is not cleanly accessible to files outside > of the block directory. >

Re: [PATCH V3 07/12] scsi: sd_zbc: Use well defined macros

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On Fri, Sep 15, 2017 at 02:51:03PM +, Bart Van Assche wrote: > On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > > Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw > > assignments and move the calculation of sdkp->zone_shift together > > with the assignment of the

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

On Fri, Sep 15, 2017 at 02:05:16PM +0200, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. > >

Re: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

> + if ((le32_to_cpu(dresp->status) == ST_OK) && > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) { > + _aac_probe_container2(context, fibptr); > + return; if (dresp->status == cpu_to_le32(ST_OK) &&

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

Looks good. James, I expect I'll be getting this through the normal SCSI pulls.. Linus On Fri, Sep 15, 2017 at 5:05 AM, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain

RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

> -Original Message- > From: Dave Carroll [mailto:david.carr...@microsemi.com] > Sent: Friday, September 15, 2017 10:04 AM > To: Martin K . Petersen ; James Bottomley > > Cc: Dave Carroll ; linux-scsi

Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

Colin, > The pointer eqe is always non-null inside the while loop, so the check > to see if eqe is NULL is redudant and hence can be removed. Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] sg: factor out sg_fill_request_table()

Hannes, > Factor our sg_fill_request_table() for better readability. ^^^ out Fixed typo and applied to 4.14/scsi-fixes. I had to do it by hand so please check. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

Hannes, > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table > is returned; the remaining part will then contain stale kernel memory > information. This patch zeroes out the entire table to avoid this > issue. Applied to 4.14/scsi-fixes. Thank you! -- Martin K. Petersen

Re: [PATCH] bnx2i: Clean up unused pointers in bnx2i_hwi

Christos, > Pointers bnx2i_cmd are set but never used, so they can be removed. Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

Dave, > The logic for supporting large drives was previously tied to 4Kn > support for SmartIOC-2000. As SmartIOC-2000 does not support volumes > using 4Kn drives, use the intended option flag AAC_OPT_NEW_COMM_64 to > determine support for volumes greater than 2T. Applied to 4.14/scsi-fixes.

[PATCH] scsi: fdomain: Fix a resource leak in an error handling path in '__fdomain_16x0_detect()'

All error handling paths 'goto fail' in this function. If 'scsi_register()' fails, we should also go there, otherwise a 'pci_dev_put(pdev)' will be missing. Signed-off-by: Christophe JAILLET --- In order to keep consistance with the rest of the file, I've ignored

Re: [PATCH V2 0/9] pm80xx updates

Viswas, > This patch set include some bug fixes and enhancement for pm80xx > driver. You are still sending mail from 2015. Please fix your system time. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

Colin, > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 740 bytes. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv2 0/3] fcoe: fixup device_del() inversion

Hannes, > when shutting down an FCoE target system one is greeted with a flood > of kernel warnings about Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH 1/5] block: don't call blk_mq_delay_run_hw_queue() in case of BLK_STS_RESOURCE

If .queue_rq() returns BLK_STS_RESOURCE, blk-mq will rerun the queue in the three situations: 1) if BLK_MQ_S_SCHED_RESTART is set - queue is rerun after one rq is completed, see blk_mq_sched_restart() which is run from blk_mq_free_request() 2) BLK_MQ_S_TAG_WAITING is set - queue is rerun after

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

I think the megaraid fusion code has a deeper problem here. Instead of playing weird games with get_free_pages and vmalloc the structure just needs to shrink by moving all the arrays of MAX_MSIX_QUEUES_FUSION size into a separate allocation for each, and then we have normall, small kmalloc

Re: [PATCH V3 02/12] block: Fix declaration of blk-mq scheduler functions

Same as for patch 1: this should stay local to block/ - we don't want random drivers to grow I/O schedulers.

Re: [PATCH V3 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/5] block: don't call blk_mq_delay_run_hw_queue() in case of BLK_STS_RESOURCE

On Sat, 2017-09-16 at 00:44 +0800, Ming Lei wrote: > If .queue_rq() returns BLK_STS_RESOURCE, blk-mq will rerun > the queue in the three situations: > > 1) if BLK_MQ_S_SCHED_RESTART is set > - queue is rerun after one rq is completed, see blk_mq_sched_restart() > which is run from

Re: [PATCH 1/2] sg: factor out sg_fill_request_table()

On Fri, Sep 15, 2017 at 02:05:15PM +0200, Hannes Reinecke wrote: > Factor our sg_fill_request_table() for better readability. > > Signed-off-by: Hannes Reinecke Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

On Fri, Sep 15, 2017 at 5:05 AM, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. > >

RE: [PATCH V2 0/9] pm80xx updates

Thanks Martin. Do we need to send V3 patch set with corrected date ? Regards, Viswas G > -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Saturday, September 16, 2017 1:06 AM > To: Viswas G > Cc:

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On Sat, 2017-09-16 at 07:35 +0900, Damien Le Moal wrote: > rw16 is mandatory for ZBC drives. So it has to be set to true. If the > HBA does not support rw16 (why would that happen ?), then the disk > should not be used. It's good that all HBAs support rw16. But it's nontrivial to analyze whether

RE: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use

> > Fix possible indexing array of bound for >hba_map[bus][cid], where bus > and cid boundary check happens later. > > Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") > Signed-off-by: Nikola Pajkovsky > --- > drivers/scsi/aacraid/linit.c | 20

[PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

The logic for supporting large drives was previously tied to 4Kn support for SmartIOC-2000. As SmartIOC-2000 does not support volumes using 4Kn drives, use the intended option flag AAC_OPT_NEW_COMM_64 to determine support for volumes greater than 2T. cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH V3 03/12] block: Add zoned block device information to request queue

> +struct blk_zoned { > + unsigned intnr_zones; > + unsigned long *seq_zones; > +}; > + > struct blk_zone_report_hdr { > unsigned intnr_zones; > u8 padding[60]; > @@ -492,6 +497,10 @@ struct request_queue { > struct blk_integrity integrity; >

Re: [PATCH V3 04/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On Fri, 2017-09-15 at 19:51 +0200, h...@lst.de wrote: > On Fri, Sep 15, 2017 at 02:51:03PM +, Bart Van Assche wrote: > > On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: > > > Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw > > > assignments and move the calculation

Re: [PATCH V3 01/12] block: Fix declaration of blk-mq debugfs functions

On 9/16/17 02:45, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 07:06:34PM +0900, Damien Le Moal wrote: >> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported >> symbols but ar eonly declared in the block internal file >> block/blk-mq-debugfs.h. which is not cleanly

RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

Hi Christoph, > > + if ((le32_to_cpu(dresp->status) == ST_OK) && > > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) { > > + _aac_probe_container2(context, fibptr); > > + return; > > if (dresp->status ==

Re: [PATCH V3 06/12] scsi: sd_zbc: Rearrange code

On 9/16/17 06:02, Bart Van Assche wrote: > On Fri, 2017-09-15 at 19:51 +0200, h...@lst.de wrote: >> On Fri, Sep 15, 2017 at 02:51:03PM +, Bart Van Assche wrote: >>> On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw

Re: [PATCH V3 05/12] scsi: sd_zbc: Fix comments and indentation

On 9/15/17 19:44, Hannes Reinecke wrote: > On 09/15/2017 12:06 PM, Damien Le Moal wrote: >> Fix comments style (do not use documented comment style) and add some >> comments to clarify some functions. Also fix some functions signature >> indentation and remove a useless blank line in

Re: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

Dave, > Hi Christoph, > >> > + if ((le32_to_cpu(dresp->status) == ST_OK) && >> > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) { >> > + _aac_probe_container2(context, fibptr); >> > + return; >> >> if

Re: [PATCH RESEND] lpfc: Don't return internal MBXERR_ERROR code from probe function

Stefano, > Internal error codes happen to be positive, thus the PCI driver > core won't treat them as failure, but we do. This would cause a > crash later on as lpfc_pci_remove_one() is called (e.g. as > shutdown function). Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle

Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk

Colin, > csk is always null on the error return path and so the non-null check > and call to cxgbi_sock_closed on csk is redundant and can be removed. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use

Nikola, > Fix possible indexing array of bound for >hba_map[bus][cid], > where bus and cid boundary check happens later. Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 00/11] Enhance libsas hotplug feature

Jason, > Yijing Wang handed over this topic to me. We are working on it the > last two months. We have tested the patchset for a long time. Here is > the new version. Applied patches 1-4 and 11 to 4.15/scsi-queue. I suggest you resubmit the rest to get them back on people's radar. -- Martin