Re: [PATCH v1 7/9] ufs: sysfs: unit descriptor

2017-12-26 Thread kbuild test robot
/linux/commits/Stanislav-Nijnikov/ufs-sysfs-read-only-access-to-device-descriptors-attributes-and-flags/20171226-075252 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce

Re: [PATCH v1 9/9] ufs: sysfs: attributes

2017-12-26 Thread kbuild test robot
/linux/commits/Stanislav-Nijnikov/ufs-sysfs-read-only-access-to-device-descriptors-attributes-and-flags/20171226-075252 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce

[PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tomer Tayar
This series advances all qed* drivers to use firmware 8.33.1.0 which brings new capabilities and initial support of new HW. The changes are mostly in qed, and include changes in the FW interface files, as well as updating the FW initialization and debug collection code. The protocol drivers have

[PATCH v2 net-next 4/4] qed*: Advance drivers' version to 8.33.0.20

2017-12-26 Thread Tomer Tayar
Signed-off-by: Ariel Elior Signed-off-by: Chad Dupuis Signed-off-by: Manish Rangankar Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 8

Re: [PATCH v1 8/9] ufs: sysfs: flags

2017-12-26 Thread kbuild test robot
/linux/commits/Stanislav-Nijnikov/ufs-sysfs-read-only-access-to-device-descriptors-attributes-and-flags/20171226-075252 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce

[PATCH v3 net-next 4/4] qed*: Advance drivers' version to 8.33.0.20

2017-12-26 Thread Tomer Tayar
Signed-off-by: Ariel Elior Signed-off-by: Chad Dupuis Signed-off-by: Manish Rangankar Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 8

RE: [PATCH 14/29] scsi: aacraid: Move function around to match existing code

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:40 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

RE: [PATCH 21/29] scsi: aacraid: Refactor resolve luns code and scsi functions

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:43 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

RE: [PATCH 15/29] scsi: aacraid: Create helper functions to get lun info

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:41 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

[PATCH v3 net-next 0/4] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tomer Tayar
This series advances all qed* drivers to use firmware 8.33.1.0 which brings new capabilities and initial support of new HW. The changes are mostly in qed, and include changes in the FW interface files, as well as updating the FW initialization and debug collection code. The protocol drivers have

RE: [PATCH 25/29] scsi: aacraid: Reschedule host scan in case of failure

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 10:45 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

RE: [PATCH 00/28] aacraid: Refactor for sas transport and bug fixes

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 7:07 AM > To: Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com;

Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread David Miller
This says "0/3" and then a 4 patch series shows up...

RE: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tayar, Tomer
From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, December 26, 2017 8:08 PM > Subject: Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0 > > > This says "0/3" and then a 4 patch series shows up... Sorry, my bad. Will send a fixed series.

[PATCH] documentation: add a target/iscsi driver document

2017-12-26 Thread Randy Dunlap
From: Randy Dunlap Add a driver-api document for target/iSCSI interfaces. Signed-off-by: Randy Dunlap --- This patch depends on 4 previous patches to driver source files: [PATCH] target: fix kernel-doc warnings in

RE: [PATCH 01/29] scsi: aacraid: Fix udev inquiry race condition

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Thursday, December 21, 2017 9:54 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

RE: [PATCH 03/29] scsi: aacraid: Fix hang in kdump

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 7:14 AM > To: Raghava Aditya Renukunta > ; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com; linux-scsi@vger.kernel.org >

Re: [RFC] sg3_utils: sgp_dd: work around on pthread_cancel for android

2017-12-26 Thread Bean Huo (beanhuo)
Hi, Bart > >On Sat, 2017-12-23 at 10:19 +, Bean Huo (beanhuo) wrote: >> Doug wrote: >> > This seems to work in Linux but may not work in Android: >> > AC_SEARCH_LIBS([pthread_cancel], [pthread], >> > [AC_DEFINE(HAVE_PTHREAD_CANCEL, 1, [Found pthread_cancel])], []) >> > >> > Bean, could you

RE: [PATCH 08/29] scsi: aacraid: Move code to wait for IO completion to shutdown func

2017-12-26 Thread Raghava Aditya Renukunta
> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@wdc.com] > Sent: Friday, December 22, 2017 8:27 AM > To: j...@linux.vnet.ibm.com; Raghava Aditya Renukunta > ; linux-scsi@vger.kernel.org; > martin.peter...@oracle.com > Cc:

[PATCH v2 07/30] scsi: aacraid: Refactor reset_host store function

2017-12-26 Thread Raghava Aditya Renukunta
Refactored the reset_host store function to make consistent across code bases Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/linit.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH v2 05/30] scsi: aacraid: Fix ioctl reset hang

2017-12-26 Thread Raghava Aditya Renukunta
Driver would hang when attempting to send reset from the ioctl interface, since it would wait to retrieve the ioctl mutex at send shutdown. Set adapter shutdown and unlock mutex before sending down reset request. Signed-off-by: Raghava Aditya Renukunta

[PATCH v2 21/30] scsi: aacraid: Refactor resolve luns code and scsi functions

2017-12-26 Thread Raghava Aditya Renukunta
Resolve luns checks the if a sdev is already present in the os to figure out if it needs to be removed. Internally the driver exposes HBA on bus 2 even though its bus 1 in the fw. Its mildly confusing. Refactor out the sdev lookup into its function to check if sdev has been added to the kernel or

[PATCH v2 28/30] scsi: aacraid: Remove unused rescan variable

2017-12-26 Thread Raghava Aditya Renukunta
Remove unused rescan variable. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 19 +-- drivers/scsi/aacraid/aacraid.h | 6 +++--- drivers/scsi/aacraid/commsup.c | 14 +++---

[PATCH v2 30/30] scsi: aacraid: Update driver version to 50877

2017-12-26 Thread Raghava Aditya Renukunta
Update driver Version to 50877 Signed-off-by: Raghava Aditya Renukunta --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index

[PATCH v2 24/30] scsi: aacraid: Use hotplug handling function in place of scsi_scan_host

2017-12-26 Thread Raghava Aditya Renukunta
Driver uses scsi_scan_host to add new devices in the driver init path, which adds all the fw exposed devices. The drivers resorts to queue command checks to block out commands to _hidden_ devices. Use the hotplug handler code to add new devices during driver init and other areas, this is only for

[PATCH v2 11/30] scsi: aacraid: Refactor and rename to make mirror existing changes

2017-12-26 Thread Raghava Aditya Renukunta
Rename variables and functions to make bmic identify, report phy luns to make them consistent across code internal existing code bases Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 36

[PATCH v2 15/30] scsi: aacraid: Create helper functions to get lun info

2017-12-26 Thread Raghava Aditya Renukunta
Created inline function to retrieve lun info for each device from the phy luns structure. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: Use get_unaligned_be32 instead of open ended conversion drivers/scsi/aacraid/aachba.c | 54

[PATCH v2 03/30] scsi: aacraid: Fix hang in kdump

2017-12-26 Thread Raghava Aditya Renukunta
Driver attempts to perform a device scan and device add after coming out of reset. At times when the kdump kernel loads and it tries to perform eh recovery, the device scan hangs since its commands are blocked because of the eh recovery. This should have shown up in normal eh recovery path (Should

[PATCH v2 17/30] scsi: aacraid: Add helper function to set queue depth

2017-12-26 Thread Raghava Aditya Renukunta
Add helper function to set queue depth from information retrieved from the bmic phy structure. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 37 - 1 file changed, 24

[PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

2017-12-26 Thread Raghava Aditya Renukunta
The device hotplug events are processed only after retrieving the updated lun information from the fw. Does not make sense to keep them separate. Merge both the hotplug handling and safw adapter setup code into single function. Signed-off-by: Raghava Aditya Renukunta

[PATCH v2 23/30] scsi: aacraid: Block concurrent hotplug event handling

2017-12-26 Thread Raghava Aditya Renukunta
Currently driver will attempt to process hotplug events concurrently based on the FW interrupt. Protect safw update function with a scan mutex. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 1 +

[PATCH v2 06/30] scsi: aacraid: Allow reset_host sysfs var to recover Panicked Fw

2017-12-26 Thread Raghava Aditya Renukunta
It is possible to restart the controller via the use of the reset_host sysfs variable. This does work for controllers that can no longer respond, since driver will attempt to send down a shutdown in this path. Check if the controller is able to receive commands before sending down a shutdown

[PATCH v2 26/30] scsi: aacraid: Fix hang while scanning in eh recovery

2017-12-26 Thread Raghava Aditya Renukunta
Add back the ability to scan for hotplug changes while eh was in progress. Schedule a rescan for a later time in the eh recovery code and wait for eh to complete in the rescan worker. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None

[PATCH v2 19/30] scsi: aacraid: Process hba and container hot plug events in single function

2017-12-26 Thread Raghava Aditya Renukunta
The hotplug handler code is duplicated for hba handling and container handling. Merged function to handle hba and container hot plug events into the resolve luns functions. Added a bunch of helper functions to check the validity of a given target and to check if bus, target is container device.

[PATCH v2 27/30] scsi: aacraid: Skip schedule rescan in case of kdump

2017-12-26 Thread Raghava Aditya Renukunta
There is a chance of the driver to be stuck in kdump if drives start acting up in kdump discovery process and the kernel decides to send eh resets, which would prompt rescan to be scheduled. Do not perform a rescan in kdump context, since we do not expect a hotplug event during kdump and all the

[PATCH v2 18/30] scsi: aacraid: Merge func to get container information

2017-12-26 Thread Raghava Aditya Renukunta
Merge aac_get_containers to setup target function, so that information about all the present devices can be retrieved in one shot. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 4

[PATCH v2 20/30] scsi: aacraid: Added macros to help loop through known buses and targets

2017-12-26 Thread Raghava Aditya Renukunta
Added macros to loop through the MAX SUPPORTED Buses and Targets. This will make the code a bit easier to read. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aacraid.h | 4 drivers/scsi/aacraid/commsup.c | 34

[PATCH v2 01/30] scsi: aacraid: Fix udev inquiry race condition

2017-12-26 Thread Raghava Aditya Renukunta
When udev requests for a devices inquiry string, it might create multiple threads causing a race condition on the shared inquiry resource string. Created a buffer with the string for each thread. Cc: Fixes: 3bc8070fb75b3315 ([SCSI] aacraid: SMC vendor identification)

[PATCH v2 16/30] scsi: aacraid: Save bmic phy information for each phy

2017-12-26 Thread Raghava Aditya Renukunta
Save the bmic information for each phy, so that it can processed in target setup function. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: Removed unused phy_luns variable drivers/scsi/aacraid/aachba.c | 84

[PATCH v2 29/30] scsi: aacraid: Remove AAC_HIDE_DISK check in queue command

2017-12-26 Thread Raghava Aditya Renukunta
Earlier driver would scan throgh all supported buses and targets and add devices that responded. It would add devices that were _hidden_ by the fw. Driver would invalidate commands sent to _hidden_ devices via the AAC_HIDE_DISK check. Since the driver now adds only the devices that are supposed

[PATCH v2 25/30] scsi: aacraid: Reschedule host scan in case of failure

2017-12-26 Thread Raghava Aditya Renukunta
If the driver fails to retrieve information from the fw (could happen when the fw is not fully in its senses), the driver does nothing and change is not processed correctly by the driver Schedule host rescan in case of failure. This is only for SAFW, since the information retrieval failure will

[PATCH v2 12/30] scsi: aacraid: Add target setup helper function

2017-12-26 Thread Raghava Aditya Renukunta
Add helper function to setup targets devices and create the base for the upcoming patches Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 18 +- drivers/scsi/aacraid/aacraid.h | 2 +-

[PATCH v2 02/30] scsi: aacraid: Do not attempt abort when Fw panicked

2017-12-26 Thread Raghava Aditya Renukunta
Check if the adapter can receive abort requests, before sending aborts Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/linit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/aacraid/linit.c

[PATCH v2 13/30] scsi: aacraid: Untangle targets setup from report phy luns

2017-12-26 Thread Raghava Aditya Renukunta
Remove function call to process targets from the report phy luns function and make it a function in its own right. This will help understand the flow of the code. Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None

[PATCH v2 08/30] scsi: aacraid: Move code to wait for IO completion to shutdown func

2017-12-26 Thread Raghava Aditya Renukunta
Ideally driver needs to wait for IO to be submitted or responded to before shutdown. Move code to wait for IO completion into shutdown path Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/comminit.c | 36

[PATCH 00/30] aacraid: Refactor for sas transport and bug fixes

2017-12-26 Thread Raghava Aditya Renukunta
This patchset primarily lays the foundation for adding sas transport support to the aacraid driver. Being said these patches are mainly code refactors, bug fixes and improvements. - Fixed a udev inquiry race condition - Fixed a kdump hang issue which occurs in case of error recovery in kdump -

[PATCH v2 04/30] scsi: aacraid: Do not remove offlined devices

2017-12-26 Thread Raghava Aditya Renukunta
As part of the recovery process, the drivers removes offline devices ( done by the kernel) and then tries to add them back in the rescan code. Removing the device is like taking a sledgehammer to a nail. Set the device as running if it is marked offline. Signed-off-by: Raghava Aditya Renukunta

[PATCH v2 09/30] scsi: aacraid: Create bmic submission function from bmic identify

2017-12-26 Thread Raghava Aditya Renukunta
safw command submission is duplicated across many functions. Move the safw submission code from bmic identify into its own function for common use Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 147

[PATCH v2 10/30] scsi: aacraid: Change phy luns function to use common bmic function

2017-12-26 Thread Raghava Aditya Renukunta
Edit function that retrieves phy lun information to use common bmic function Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: Added missing colon to match kernel coding style drivers/scsi/aacraid/aachba.c | 75

[PATCH v2 14/30] scsi: aacraid: Move function around to match existing code

2017-12-26 Thread Raghava Aditya Renukunta
Move the function to get phy luns information to the top of function to set target information Signed-off-by: Raghava Aditya Renukunta --- Changes in V2: None drivers/scsi/aacraid/aachba.c | 112 +- 1 file changed,