Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 22, 2018 at 06:37:45AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > >

[PATCH v2] scsi: ufs: add trace event for ufs upiu

2018-03-22 Thread Ohad Sharabi
Add UFS Protocol Information Units(upiu) trace events for ufs driver, used to trace various ufs transaction types- command, task-management and device management. The trace-point format is generic and can be easily adapted to trace other upius if needed. Currently tracing ufs transaction of type

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > -

[Bug 199155] /sys/block/dev/device/model truncates to 16 characters

2018-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199155 --- Comment #3 from d gilbert (dgilb...@interlog.com) --- On 2018-03-22 05:08 AM, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=199155 > > --- Comment #2 from Bryan Seitz (seit...@gmail.com) --- > Is

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread kbuild test robot
Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread kbuild test robot
Hi Arnaldo, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6 next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Martin K. Petersen
Johannes, >> Please remove the '-' and left align the commit message. > > Gnah, too late. Martin has already applied the patch. And he already removed the '-' and left aligned the commit message :) -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Johannes Thumshirn
On Thu, Mar 22, 2018 at 08:45:33AM -0400, Martin K. Petersen wrote: > > And he already removed the '-' and left aligned the commit message :) Thanks a lot :) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053

Re: [PATCH v2] scsi: ufs: add trace event for ufs upiu

2018-03-22 Thread Bart Van Assche
On Thu, 2018-03-22 at 13:50 +0200, Ohad Sharabi wrote: > +static void ufshcd_add_cmd_upiu_trace(struct ufs_hba *hba, unsigned int tag, > + const char *str) > +{ > + struct utp_upiu_req *rq = hba->lrb[tag].ucd_req_ptr; > + > + trace_ufshcd_upiu(dev_name(hba->dev), str, (u8

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread Thomas Gleixner
On Thu, 22 Mar 2018, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > wrote: > > >

Re: [PATCH v2 07/38] cxlflash: Setup function acTag range

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:20, Uma Krishnan a écrit : The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. The platform-specific acTag range for the link is obtained using the OCXL provider services and then assigned to the host function based on

Re: [PATCH v2 16/38] cxlflash: MMIO map the AFU

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:22, Uma Krishnan a écrit : When the AFU is configured, the global and per process MMIO regions are presented by the configuration space. Save these regions and map the global MMIO region that is used to access all of the control and provisioning data in the AFU.

Re: [PATCH v2 19/38] cxlflash: Support AFU state toggling

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:22, Uma Krishnan a écrit : The AFU should be enabled following a successful configuration and disabled near the end of the cleanup path. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs --- Reviewed-by:

Re: [PATCH v2 06/38] cxlflash: Read host function configuration

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:20, Uma Krishnan a écrit : Per the OCXL specification, the underlying host can have multiple AFUs per function with each function supporting its own configuration. The host function configuration is read on the initialization path to evaluate the number of functions present

Re: [PATCH v2 11/38] cxlflash: Adapter context support for OCXL

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : Add support to create and release the adapter contexts for OCXL and provide means to specify certain contexts as a master. The existing cxlflash core has a design requirement that each host will have a single host context available by default. To

aacraid issues in 4.16-rc

2018-03-22 Thread Justin Forbes
The Fedora QA folks have run into a regression with aacraid in the 4.16 rc kernels. This is not an issue with 4.15.x kernels. Essentially things just do not work unless 'aac_sync_mode=1' is passed on the command line. The failures show logs of aacraid: Host adapter abort request aacraid:

Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by:

Re: [PATCH v2 10/38] cxlflash: Setup AFU PASID

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : Per the OCXL specification, the maximum PASID supported by the AFU is indicated by a field within the configuration space. Similar to acTags, implementations can choose to use any sub-range of PASID within their assigned range. For cxlflash, the

Re: [PATCH v2 12/38] cxlflash: Use IDR to manage adapter contexts

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : A range of PASIDs are used as identifiers for the adapter contexts. These contexts may be destroyed and created randomly. Use an IDR to keep track of contexts that are in use and assign a unique identifier to new ones. Signed-off-by: Uma Krishnan

Re: [PATCH v2 13/38] cxlflash: Support adapter file descriptors for OCXL

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : Allocate a file descriptor for an adapter context when requested. In order to allocate inodes for the file descriptors, a pseudo filesystem is created and used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

Re: [PATCH v2 09/38] cxlflash: Setup AFU acTag range

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : The OCXL specification supports distributing acTags amongst different AFUs and functions on the link. As cxlflash devices are expected to only support a single AFU and function, the entire range that was assigned to the function is also assigned to

Re: [PATCH v2 21/38] cxlflash: Setup function OCXL link

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:22, Uma Krishnan a écrit : After reading and modifying the function configuration, setup the OCXL link using the OCXL provider services. The link is released when the adapter is unconfigured. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

Re: [PATCH v2] target/file: add support of direct and async I/O

2018-03-22 Thread Christoph Hellwig
> > DIF (PI) emulation doesn't work when a target uses async I/O, because > DIF metadata is saved in a separate file, and it is another non-trivial > task how to synchronize writing in two files, so that a following read > operation always returns a consisten metadata for a specified block. As

smp affinity and kworker io submission

2018-03-22 Thread Kashyap Desai
Hi, I am running FIO script on Linux 4.15. This is generic behavior even on 3.x kernels as well. I wanted to know if my observation is correct or not. Here is FIO command - numactl -C 0-2 fio single --bs=4k --iodepth=64 --rw=randread --ioscheduler=none --group_report --numjobs=2 If driver is

Re: [PATCH v2] target/file: add support of direct and async I/O

2018-03-22 Thread Bryant G. Ly
On 3/22/18 12:34 PM, Christoph Hellwig wrote: >> DIF (PI) emulation doesn't work when a target uses async I/O, because >> DIF metadata is saved in a separate file, and it is another non-trivial >> task how to synchronize writing in two files, so that a following read >> operation always returns a

Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by:

[Bug 199155] /sys/block/dev/device/model truncates to 16 characters

2018-03-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199155 Bryan Seitz (seit...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v2] target/file: add support of direct and async I/O

2018-03-22 Thread Andrei Vagin
On Thu, Mar 22, 2018 at 10:34:34AM -0700, Christoph Hellwig wrote: > > > > DIF (PI) emulation doesn't work when a target uses async I/O, because > > DIF metadata is saved in a separate file, and it is another non-trivial > > task how to synchronize writing in two files, so that a following read >

[PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-03-22 Thread Long Li
From: Long Li Unlike SCSI and FC, we don't use multiple channels for IDE. Also fix the calculation for sub-channels. Change log: v2: Addressed comment on incorrect number of sub-channels. (Michael Kelley ) Signed-off-by: Long Li

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-22 Thread Thomas Gleixner
On Wed, 21 Mar 2018, Linus Torvalds wrote: > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > wrote: > > > > assert_spin_locked(>t_state_lock); > > -

Re: [PATCH] scsi: sd: Remember that READ CAPACITY(16) succeeded

2018-03-22 Thread Menion
Maybe is worth to add a log in KERN_NOTICE also 2018-03-14 17:47 GMT+01:00 Laurence Oberman : > On Wed, 2018-03-14 at 12:15 -0400, Martin K. Petersen wrote: >> The USB storage glue sets the try_rc_10_first flag in an attempt to >> avoid wedging poorly implemented legacy USB

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Johannes Thumshirn
On Thu, Mar 22, 2018 at 09:34:17AM +0100, Johannes Thumshirn wrote: > On Wed, Mar 21, 2018 at 01:32:31PM -0500, Don Brace wrote: > > From: Kevin Barnett > > > > - skip deleting PQI operational queues when there is > > an error creating a new queue group. It's not

答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-03-22 Thread liwei (CM)
Hi, Arnd Sorry to bother you again, please take the time to review the patch. Are there any other suggestions? Looking forward to your reply. -邮件原件- 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann 发送时间: 2018年2月19日 17:58 收件人: liwei (CM) 抄送: Rob Herring; Mark

[PATCH 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

2018-03-22 Thread Long Li
From: Long Li This is a best effort for estimating on how busy the ring buffer is for that channel, based on available buffer to write in percentage. It is still possible that at the time of actual ring buffer write, the space may not be available due to other processes may

[PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

2018-03-22 Thread Long Li
From: Long Li In Vmbus, we have defined a function to calculate available ring buffer percentage to write. Use that function and remove duplicate netvsc code. Signed-off-by: Long Li --- drivers/net/hyperv/netvsc.c | 17 +++--

[PATCH 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

2018-03-22 Thread Long Li
From: Long Li Netvsc has a similar function to calculate how much ring buffer in percentage is available to write. This function is useful for storvsc and other vmbus devices. Define a similar function in vmbus to be used by storvsc. Signed-off-by: Long Li

Re: [PATCH] scsi: sd: Remember that READ CAPACITY(16) succeeded

2018-03-22 Thread Bart Van Assche
On Wed, 2018-03-14 at 12:15 -0400, Martin K. Petersen wrote: > The USB storage glue sets the try_rc_10_first flag in an attempt to > avoid wedging poorly implemented legacy USB devices. > > If the device capacity is too large to be expressed in the provided > response buffer field of READ

Re: [PATCH v2 12/38] cxlflash: Use IDR to manage adapter contexts

2018-03-22 Thread Uma Krishnan
> On Mar 22, 2018, at 11:40 AM, Frederic Barrat > wrote: > > > > Le 26/02/2018 à 23:21, Uma Krishnan a écrit : >> A range of PASIDs are used as identifiers for the adapter contexts. These >> contexts may be destroyed and created randomly. Use an IDR to keep track

Fiber Channel in LIO / TCM

2018-03-22 Thread TomK
Curious if there will be continued development and support of Fiber Channel in LIO / TCM? I haven't seen much in the way in terms of commits on github or the linux-iscsi.org/wiki/Fibre_Channel page in recent months / years so wondering about it's future. -- Cheers, Tom K.

[PATCH v2] target/file: add support of direct and async I/O

2018-03-22 Thread Andrei Vagin
There are two advantages: * Direct I/O allows to avoid the write-back cache, so it reduces affects to other processes in the system. * Async I/O allows to handle a few commands concurrently. DIO + AIO shows a better perfomance for random write operations: Mode: O_DSYNC Async: 1 $ ./fio --bs=4K