On Wed, Aug 08, 2018 at 10:30:19PM +0200, Ondrej Zary wrote:
> Then it crashes with null-pointer dereference in aha1542_reset.
Must be the dma_unmap. Updated patch below:
---
>From 98a9c770430cde972923838b990b2b9cf7b95816 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig
Date: Thu, 2 Aug 2018
Tomas,
> Fixes: 2b548dd3790f95c2e174d51c2c8ada71b6505b4e
> scsi: mpt3sas: Fix calltrace observed while running IO & reset
>
> Maybe both patches could be merged.
Merged the fix into the patch above.
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We accidentally return success instead of -ENOMEM on this error path.
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On 08/08/2018 12:56, Dan Carpenter wrote:
We accidentally return success instead of -ENODEV on this error path.
Sorry to nitpick, but - as I see - the only way for
sas_domain_attach_transport() to fail is if the kzalloc() in
sas_attach_transport() fails, so should this be -ENOMEM? Other
On Tue, Aug 07, 2018 at 07:30:17PM +0200, Ondrej Zary wrote:
> On Tuesday 07 August 2018 09:29:59 Christoph Hellwig wrote:
> > Looks like the dma allocation is too late. Updated version below:
> >
> > ...
>
> Crashes a bit later now:
Next try:
---
>From 9dd7a3eb89d1cc72c001daeb80e44de7c5fb5b00
On Wed, Aug 8, 2018 at 1:27 AM, Bart Van Assche wrote:
> On Tue, 2018-08-07 at 21:46 +0530, Sreekanth Reddy wrote:
>> [Sreekanth] In the patch description I mentioned that I have done a
>> manual mistake and I am correcting with this patch.
>>
>> Hope I have answered all of your quires.
>
> Not
On Tue, 2018-08-07 at 20:39 -0700, Himanshu Madhani wrote:
> From: Quinn Tran
To me this seems to be a real bug fix rather than a patch that only suppresses
a static checker complaint. If that is the case, please mention this in the
patch subject.
Thanks,
Bart.
On Wed, Aug 08, 2018 at 03:16:57PM +0100, John Garry wrote:
> On 08/08/2018 12:56, Dan Carpenter wrote:
> > We accidentally return success instead of -ENODEV on this error path.
>
> Sorry to nitpick, but - as I see - the only way for
> sas_domain_attach_transport() to fail is if the kzalloc() in
On Wed, 2018-07-18 at 01:22 -0400, Sreekanth Reddy wrote:
> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
> i.e. driver should reset smid value to zero after decrementing chain_offset
> counter in chain_lookup table but in current code, driver is resetting smid
> value
We accidentally return success instead of -ENOMEM on this error path.
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Dan Carpenter
---
v2: return -ENOMEM instead of -ENODEV
diff --git a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c
index
On 08/08/2018 15:29, Dan Carpenter wrote:
We accidentally return success instead of -ENOMEM on this error path.
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Dan Carpenter
thanks
Reviewed-by: John Garry
---
v2: return -ENOMEM instead of -ENODEV
diff --git
On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote:
> A LLD companion for the ufs scsi transport.
This description is misleading. How about changing this into "Add a bsg
endpoint that supports UPIUs"?
diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
> new file mode 100644
>
On Wed, Aug 08, 2018 at 06:26:25PM +0200, Ondrej Zary wrote:
> Looks like you attached wrong file (same as the previous one).
This should be better:
---
>From afa1c18bd98168fb690d905fc84a2db6f0d617b6 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig
Date: Thu, 2 Aug 2018 14:22:46 +0200
Subject:
On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote:
> + lrbp->command_type = (hba->ufs_version == UFSHCI_VERSION_10 ||
> + hba->ufs_version == UFSHCI_VERSION_11) ?
> + UTP_CMD_TYPE_DEV_MANAGE :
> +
On Wednesday 08 August 2018 11:14:33 Christoph Hellwig wrote:
> On Tue, Aug 07, 2018 at 07:30:17PM +0200, Ondrej Zary wrote:
> > On Tuesday 07 August 2018 09:29:59 Christoph Hellwig wrote:
> > > Looks like the dma allocation is too late. Updated version below:
> > >
> > > ...
> >
> > Crashes a
On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote:
> + if (ret || !(*desc_len))
> + return -EINVAL;
No parentheses around *desc_len please.
Thanks,
Bart.
On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote:
> A “ufs-port” is purely a software object. Evidently, the function
> template takes no port as an argument, as the driver has no concept
> of "port". We only need it as a hanging point in the bsg device tree,
> so maybe a more appropriate
We accidentally return success instead of -ENODEV on this error path.
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c
index 80e5b283fd81..cb8191afc1dc 100644
---
Hi Bart,
> On Aug 8, 2018, at 8:10 AM, Bart Van Assche wrote:
>
> External Email
>
> On Tue, 2018-08-07 at 20:39 -0700, Himanshu Madhani wrote:
>> From: Quinn Tran
>
> To me this seems to be a real bug fix rather than a patch that only suppresses
> a static checker complaint. If that is the
When T10 PI is enabled on a backing device for the iblock backstore, the
PI SGL for the entire command is attached to the first bio only. This
works fine if the command is covered by a single bio, but results in
integrity verification errors for the other bios in a multi-bio command.
Split the
21 matches
Mail list logo
