Responding to those issues not already addressed by Bryant.
On 6/23/16 9:22 AM, Christoph Hellwig wrote:
+ vscsi->flags &= (~PROCESSING_MAD);
No need for the braces here. (ditto for many other places later on)
Fixed.
+static struct ibmvscsis_tport
On 5/18/16 12:53 AM, Nicholas A. Bellinger wrote:
Hi Michael,
On Fri, 2016-05-13 at 17:15 -0500, Michael Cyr wrote:
If a command with a Simple task attribute is failed due to a Unit
Attention, then a subsequent command with an Ordered task attribute will
hang forever. The reason
Conflict status has a lower precedence than a Unit
Attention, and so this would also seem to be the appropriate place to
call target_check_reservation. I'm less sure about
target_alua_state_check, since I'm not very familiar with ALUA.
Signed-off-by: Michael Cyr <mike...@linux.vnet.ibm.co
of target_complete_failure_work.
Signed-off-by: Michael Cyr <mike...@linux.vnet.ibm.com>
Reviewed-by: Andy Grover <agro...@redhat.com>
---
drivers/target/target_core_user.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1082 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.h |5 +-
2 files changed, 486 insertions(+), 601 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tg
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 5c4b979..4dbbe4b 100644
--- a/d
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
index 34f758c..5c4b979 100644
--- a/driver
The first one seems bigger than it is, because I needed to rearrange the
order of some functions.
Michael Cyr (3):
Synchronization of cmds during termination conditions
Properly handle if target_submit_cmd/tmr fails
Return correct partition name/number to client
drivers/scsi/ibmvscsi_tgt
This patch adds code to disconnect from the client, which will make sure
any outstanding commands have been completed, before continuing on with
the remove operation.
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
---
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/drivers/scsi/ibmvscsi_tgt/ib
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/drivers/scsi/
the queue with phyp.
One consquence to this is that we have no need for the PART_UP_WAIT_ENAB
state, since we can't get an Init Message from the client in our CRQ if
we're waiting to be enabled, since we haven't registered the queue yet.
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signe
Various fixes and cleanups for the ibmvscsis driver.
The first is a sort of prequel to the second, which is the primary
change (and the biggest). The rest are fairly small fixes.
Michael Cyr (6):
ibmvscsis: Rearrange functions for future patches
ibmvscsis: Synchronize cmds
declare a function
at the top of the file. However, this will be removed in the next patch,
since the code requiring the predeclaration will be removed.
Signed-off-by: Michael Cyr <mike...@us.ibm.com>
Signed-off-by: Bryant G. Ly <bryan...@linux.vnet.ibm.com>
---
drivers/scsi/
On 4/7/17 12:01 PM, Bryant G. Ly wrote:
On 4/7/17 11:36 AM, Bart Van Assche wrote:
On Fri, 2017-04-07 at 11:12 -0500, Bryant G. Ly wrote:
So from this stack trace it looks like the ibmvscsis driver is
sending an
extra response through send_messages even though an abort was issued.
IBMi,
16 matches
Mail list logo
