Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

On Thu, Jun 4, 2015 at 9:32 AM, Akinobu Mita akinobu.m...@gmail.com wrote: Hi Yaniv, 2015-06-03 18:37 GMT+09:00 Yaniv Gardi yga...@codeaurora.org: @@ -321,7 +313,22 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev) goto out; } - hba-vops =

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: Hi Yaniv, 2015-06-03 18:37 GMT+09:00 Yaniv Gardi yga...@codeaurora.org: @@ -321,7 +313,22 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev) goto

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: [...] If ufshcd-pltfrm driver is loaded before ufs-qcom, (what actually happens always), then the

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

On Wed, Jun 17, 2015 at 2:42 AM, Dov Levenglick d...@codeaurora.org wrote: On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote: 2015-06-05 5:53 GMT+09:00 yga...@codeaurora.org: [...] If ufshcd-pltfrm

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

On Wed, Jun 17, 2015 at 8:17 AM, Dov Levenglick d...@codeaurora.org wrote: On Wed, Jun 17, 2015 at 2:42 AM, Dov Levenglick d...@codeaurora.org wrote: On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick d...@codeaurora.org wrote: On Sun, Jun 7, 2015 at 10:32 AM, yga...@codeaurora.org wrote:

Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell

On Aug 21, 2015 3:10 PM, Yaniv Gardi yga...@codeaurora.org wrote: Add a write memory barrier to make sure descriptors prepared are actually written to memory before ringing the doorbell. We have also added the write memory barrier after ringing the doorbell register so that controller sees

Re: [PATCH v2 6/8] scsi: ufs: make the UFS variant a platform device

O n Aug 20, 2015 6:59 AM, Yaniv Gardi yga...@codeaurora.org wrote: This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only serves as

Re: [PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute

On Aug 21, 2015 3:10 PM, Yaniv Gardi yga...@codeaurora.org wrote: Sometimes queries from the device might return a failure so it is recommended to retry sending the query, before giving up. This change adds a wrapper to retry sending a query attribute, in cases where we need to wait longer,

Re: [PATCH v8 6/8] scsi: ufs: make the UFS variant a platform device

On Sun, Oct 25, 2015 at 5:50 AM, Yaniv Gardi wrote: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it

Re: [PATCH v3 02/32] devicetree: bindings: scsi: HiSi SAS

On Tue, Nov 10, 2015 at 12:32:07AM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry > Signed-off-by: Zhangfei Gao > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 81 >

Re: [PATCH v5 10/11] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller

On Mon, Nov 09, 2015 at 10:56:26AM +0530, Alim Akhtar wrote: > From: Seungwon Jeon > > This adds Exynos Universal Flash Storage (UFS) Host Controller DT bindings. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > --- >

Re: [PATCH v4 02/32] devicetree: bindings: scsi: HiSi SAS

On Mon, Nov 16, 2015 at 09:05:48PM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry <john.ga...@huawei.com> > Signed-off-by: Zhangfei Gao <zhangfei@linaro.org> Acked-by: Rob Herring <r...@kernel.org> &g

Re: [PATCH v2 02/17] scsi: ufs: add option to change default UFS power management level

On Mon, Oct 26, 2015 at 05:40:57PM +0200, Yaniv Gardi wrote: > UFS device and link can be put in multiple different low power modes > hence UFS driver supports multiple different low power modes. > By default UFS driver selects the default (optimal) low power mode > (which gives moderate power

Re: [PATCH v3 02/32] devicetree: bindings: scsi: HiSi SAS

On Tue, Nov 10, 2015 at 5:09 AM, John Garry <john.ga...@huawei.com> wrote: > On 09/11/2015 18:01, Rob Herring wrote: >> >> On Tue, Nov 10, 2015 at 12:32:07AM +0800, John Garry wrote: >>> >>> Add devicetree bindings for HiSilicon SAS driver. >>> >

Re: [PATCH 02/25] devicetree: bindings: scsi: HiSi SAS

On Mon, Oct 12, 2015 at 10:20 AM, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. In the future, please use get_maintainers.pl. > Signed-off-by: John Garry > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 63 >

Re: [PATCH v5 20/32] scsi: hisi_sas: add v1 hw interrupt init

On Tue, Nov 17, 2015 at 10:50 AM, John Garry wrote: > Add code to interrupts, so now we can get a phy up > interrupt when a disk is connected. So I started looking at why you are using of_irq_count which drivers shouldn't need to. In patch 5 you use it to allocate memory

Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell

On Thu, Aug 27, 2015 at 7:11 AM, yga...@codeaurora.org wrote: On Tue, Aug 25, 2015 at 7:36 AM, yga...@codeaurora.org wrote: On Aug 21, 2015 3:10 PM, Yaniv Gardi yga...@codeaurora.org wrote: Add a write memory barrier to make sure descriptors prepared are actually written to memory before

Re: [PATCH v3 6/8] scsi: ufs: make the UFS variant a platform device

On Sun, Aug 23, 2015 at 8:09 AM, Yaniv Gardi yga...@codeaurora.org wrote: This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only

Re: [PATCH v3 6/8] scsi: ufs: make the UFS variant a platform device

On Sun, Aug 30, 2015 at 3:43 AM, yga...@codeaurora.org wrote: On Sun, Aug 23, 2015 at 8:09 AM, Yaniv Gardi yga...@codeaurora.org wrote: This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The

Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell

On Tue, Aug 25, 2015 at 7:36 AM, yga...@codeaurora.org wrote: On Aug 21, 2015 3:10 PM, Yaniv Gardi yga...@codeaurora.org wrote: Add a write memory barrier to make sure descriptors prepared are actually written to memory before ringing the doorbell. We have also added the write memory

Re: [PATCH v4 6/8] scsi: ufs: make the UFS variant a platform device

_init() routine, that does exactly the same, but only >being called by the new probe function of the UFS variant. > > Signed-off-by: Yaniv Gardi <yga...@codeaurora.org> > > --- > Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 57 ++ > .../devicetree

Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

On Wed, Sep 2, 2015 at 9:45 AM, Yaniv Gardi wrote: > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel." >

Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

_init() routine, that does exactly the same, but only >being called by the new probe function of the UFS variant. > > Signed-off-by: Yaniv Gardi <yga...@codeaurora.org> Reviewed-by: Rob Herring <r...@kernel.org> I may or may not get around to providing an ack or

Re: [PATCH v5 6/8] scsi: ufs: make the UFS variant a platform device

On Wed, Sep 2, 2015 at 3:32 AM, Yaniv Gardi wrote: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it

Re: [PATCH v2 01/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

On 09/17/2015 04:45 AM, Alim Akhtar wrote: > From: Seungwon Jeon > > This patch introduces Exynos UFS PHY driver. This driver > supports to deal with phy calibration and power control > according to UFS host driver's behavior. > > Signed-off-by: Seungwon Jeon

Re: [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data

On Mon, Oct 5, 2015 at 4:06 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Monday 05 October 2015 13:44:29 Alim Akhtar wrote: >> CCing Rob Herring, >> >> Hi Arnd, >> >> On 10/01/2015 04:59 PM, Arnd Bergmann wrote: >> > On Thursday 01 October 2015 18:

Re: [PATCH] hisi_sas: use platform_get_irq()

On Thu, Dec 10, 2015 at 9:02 AM, John Garry <john.ga...@huawei.com> wrote: > It is preferred that drivers use platform_get_irq() > instead of irq_of_parse_and_map(), so replace. You may be able to stop including of_irq.h with this change. Otherwise, Acked-by: Rob Herring <

Re: [PATCH] scsi: hisi_sas: remove dependency on of_irq_count

t; Since of_irq_count cannot be used by the driver, use > fixed names. > > Signed-off-by: John Garry <john.ga...@huawei.com> > Signed-off-by: Zhangfei Gao <zhangfei@linaro.org> Acked-by: Rob Herring <r...@kernel.org> > > diff --git a/drivers/scsi/hisi_sas/hisi_sa

Re: [v4 01/14] scsi: ufs-qcom: add number of lanes per direction

| 19 +++ > drivers/scsi/ufs/ufshcd.c | 1 + > drivers/scsi/ufs/ufshcd.h | 2 ++ > 5 files changed, 47 insertions(+), 17 deletions(-) Acked-by: Rob Herring <r...@kernel.org> -- To unsubscribe from this list: send th

Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

On Thu, Feb 11, 2016 at 12:13:06PM +, Joao Pinto wrote: > This patch has the goal to add support for DesignWare UFS Controller > specific operations and to add specific platform and pci drivers. > > Signed-off-by: Joao Pinto > --- > Changes v6->v7 (Arnd Bergmann): > -

Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

On Fri, Feb 12, 2016 at 11:52 AM, Joao Pinto <joao.pi...@synopsys.com> wrote: > Hi Rob, > > On 2/12/2016 4:36 PM, Rob Herring wrote: >> On Thu, Feb 11, 2016 at 12:13:06PM +, Joao Pinto wrote: >>> +Required properties: >>> +- compatible: compatibl

Re: [PATCH v2 01/23] devicetree: bindings: hisi_sas: add v2 HW bindings

.ga...@huawei.com> > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 21 > ++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) Acked-by: Rob Herring <r...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v8 2/3] added UFS 2.0 capabilities

> Changes v0->v7: > - Nothing changed (just to keep up with patch set version). > > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 4 +-- Acked-by: Rob Herring <r...@kernel.org> > drivers/scsi/ufs/ufshcd.c | 29 > +++--- &

Re: [PATCH v8 3/3] add support for DWC UFS Host Controller

On Mon, Feb 15, 2016 at 03:25:13PM +, Joao Pinto wrote: > This patch has the goal to add support for DesignWare UFS Controller > specific operations and to add specific platform and pci drivers. > > Signed-off-by: Joao Pinto > --- > Changes v7->v8 (Akinobu Mita): > - DME

Re: [PATCH v12 8/9] add TC G210 platform driver

On Mon, Apr 04, 2016 at 11:48:23AM +0100, Joao Pinto wrote: > > Hi Rob, > > On 4/4/2016 6:15 AM, Rob Herring wrote: > > On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote: > >> This patch adds a glue platform driver for the Synopsys G210 Test Chip. > >

Re: [PATCH v10 2/6] added UFS 2.0 capabilities

| 29 > +++--- > drivers/scsi/ufs/ufshci.h | 1 + > 3 files changed, 28 insertions(+), 6 deletions(-) Acked-by: Rob Herring <r...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [RESEND] [PATCH v11 2/6] added UFS 2.0 capabilities

On Thu, Mar 17, 2016 at 7:39 AM, Joao Pinto <joao.pi...@synopsys.com> wrote: > Adding UFS 2.0 support to the UFS core driver. > > Signed-off-by: Joao Pinto <jpi...@synopsys.com> > Acked-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Rob Herring <r...@kernel

Re: [PATCH v11 5/6] add TC G210 platform driver

On Mon, Mar 07, 2016 at 12:09:20PM +, Joao Pinto wrote: > This patch adds a glue platform driver for the Synopsys G210 Test Chip. > > Signed-off-by: Joao Pinto > --- > Changes v10->v11 (Arnd Bergmann): > - vops structs are now passed in .data > Changes v0->v10: > - This

Re: [PATCH v5 01/15] scsi: ufs-qcom: add number of lanes per direction

bro...@codeaurora.org> > Signed-off-by: Yaniv Gardi <yga...@codeaurora.org> > > --- > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 3 ++ Acked-by: Rob Herring <r...@kernel.org> > drivers/scsi/ufs/ufs-qcom.c| 39 >

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

Re: [PATCH v2 1/3] devicetree: bindings: scsi: hisi_sas add hip07 support

; --- > Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <r...@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support

On Tue, Sep 20, 2016 at 06:48:58PM +0800, John Garry wrote: > Add support for hip07 chipset to bindings. > > Chipset hip07 has v2 hw. > > The sas-v2 quirk amt is expanded to cover hip07. > > Signed-off-by: John Garry > Signed-off-by: Xiang Chen

Re: [PATCH v1 07/12] scsi: ufs: add option to change default UFS power management level

On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote: > UFS device and link can be put in multiple different low power modes hence > UFS driver supports multiple different low power modes. By default UFS > driver selects the default (optimal) low power mode (which gives moderate >

Re: [PATCH v1 07/12] scsi: ufs: add option to change default UFS power management level

On Tue, Dec 13, 2016 at 2:16 PM, Subhash Jadavani <subha...@codeaurora.org> wrote: > On 2016-12-13 12:04, Rob Herring wrote: >> >> On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote: >>> >>> UFS device and link can be put in multiple different l

[PATCH] scsi: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring <r...@kernel.org> Cc: "James E.J. Bottomley" <j...@linux.vnet.ibm.com> C

Re: [PATCH v3 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Tue, Aug 29, 2017 at 04:41:13PM +0800, Li Wei wrote: > add ufs node document for Hisilicon > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 35 > ++ > 1 file changed, 35 insertions(+) > create mode 100644

Re: [PATCH v4 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Fri, Oct 13, 2017 at 03:49:33PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 47 > ++ > 1 file changed, 47 insertions(+) > create mode 100644

Re: [PATCH v6 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Thu, Dec 07, 2017 at 06:20:23PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- Version history? > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 38 > ++ > 1 file changed, 38 insertions(+) >

Re: 答复: [PATCH v9 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Tue, Apr 24, 2018 at 8:54 AM, liwei (CM) <liwei...@huawei.com> wrote: > Hi, Rob > > Thanks for your patience. > > Hi, Arnd > > From Rob's suggestion, we have to list the properties node in ufs-hisi.txt > bingings even if documented in the common binding. > &g

Re: [PATCH RFC 1/3] scsi: ufs: set the device reference clock setting

On Tue, May 22, 2018 at 09:51:38AM +0530, Sayali Lokhande wrote: > From: Subhash Jadavani > > UFS host supplies the reference clock to UFS device and UFS device > specification allows host to provide one of the 4 frequencies (19.2 MHz, > 26 MHz, 38.4 MHz, 52 MHz) for

Re: [PATCH v4 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Fri, Oct 20, 2017 at 04:50:42PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 47 > ++ > 1 file changed, 47 insertions(+) > create mode 100644

Re: [PATCH v7 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Sat, Jan 06, 2018 at 05:51:14PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 43 > ++ > 1 file changed, 43 insertions(+) > create mode 100644

Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas: add LED feature for v2 hw

es I have of trying to support that after the chip was done. Seems you have the same fortune. :) What happens if you have a different CPLD or SGPIO control? Really this should probably be a separate node, but the kernel isn't setup for separate SGPIO drivers either. Reviewed-by: Rob Herring <r...@kernel.org> Rob

Re: [PATCH] scsi: ufs-qcom: add number of lanes per direction

On Mon, Feb 05, 2018 at 08:02:07PM +0800, Can Guo wrote: > From: Gilad Broner > > Different platforms may have different number of lanes for the UFS link. > Add parameter to device tree specifying how many lanes should be > configured for the UFS link. And don't print err

Re: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

ns(+) > create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt Reviewed-by: Rob Herring <r...@kernel.org>

Re: [PATCH v4 01/10] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

is in the PHY signal > attenuation readings. > > This patch add an devicetree property, "hisilicon,signal-attenuation", > which is used to describe the signal attenuation of an board. > > Cc: Rob Herring <robh...@kernel.org> > Cc: Mark Rutland <mark.rutl...

Re: [PATCH 1/2] scsi: ufs: Add UFS platform driver for Cadence UFS

On Wed, Mar 28, 2018 at 11:25:34AM +, Janek Kotas wrote: > This patch adds a device tree platform > driver description for Cadence UFS Controller. You have exactly the same subject for both patches. Don't do that. For bindings, the preferred subject prefix is "dt-bindings: ufs: ". > >

Re: [PATCH v9 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Tue, Apr 17, 2018 at 10:08:11PM +0800, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 29 > ++ > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 10

Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

is in the PHY signal > attenuation readings. > > This patch add an devicetree property, signal-attenuation, which > is used to describe the signal attenuation of an board. > > Cc: Rob Herring <robh...@kernel.org> > Cc: Mark Rutland <mark.rutl...@arm.com> > Signed

Re: [PATCH v2 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

On Fri, Mar 2, 2018 at 10:10 AM, John Garry <john.ga...@huawei.com> wrote: > On 02/03/2018 15:57, Rob Herring wrote: >> >> On Fri, Mar 2, 2018 at 9:06 AM, John Garry <john.ga...@huawei.com> wrote: >>> >>> > From: Xiaofei Tan <tanxiao...@hua

Re: [PATCH v2] scsi: ufs-qcom: add number of lanes for Tx and Rx links

lt;c...@codeaurora.org> > --- > > Changes since v1: > - Change commit subject for better description. > - Incorporated Rob's review comments to use lanes-tx and lanes-rx > to handle asymmetric Tx/Rx links. > > .../devicetree/bindings/ufs/ufshcd-pltfrm

Re: [PATCH v2 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

ese registers is in the PHY signal > attenuation readings. > > This patch add an devicetree property, hisi-signal-attenuation, > which is used to describe the signal attenuation of an board. > > Cc: Rob Herring <robh...@kernel.org> > Cc: Mark Rutland <mark.rutl...@arm