On 04/17/2018 12:00 PM, Bean Huo (beanhuo) wrote:
#Cat trace
iozone-4055 [000] 665.039276: block_unplug: [iozone] 1 Sync
iozone-4055 [000] ...1 665.039278: block_rq_insert: 8,48 WS 0 () 39604352 +
128 tag=18 [iozone]
iozone-4055 [000] ...1 665.039280: block_rq_issue: 8,48 WS 0 ()
>On Mon, 2018-04-16 at 20:27 +, Bean Huo (beanhuo) wrote:
>> By the way, these patches are not to add new feature, they are just to
>> add print tag along with the other exist printed request parameters.
>
>Are you aware that there are two tag fields in struct request, namely "tag"
>and "intern
Hi, Steve
Right, Please see below portion log from ftrace and blktrace,
There is no any impact on blktrace.
>
>Looking at the code from
>git://git.kernel.org/pub/scm/linux/kernel/git/axboe/blktrace.git
>
>It appears that it does not rely on the ftrace ring buffers.
>
>So I'm guessing blktrace is
On Mon, 16 Apr 2018 21:30:54 +
Bart Van Assche wrote:
> Hello Steve,
>
> The tool I'm most concerned about is blktrace. I'm not sure though how this
> tool receives event data from the block layer core.
Yeah, blktrace is "special", it looks like it registers its callbacks
from the tracepoin
On Mon, 2018-04-16 at 17:24 -0400, Steven Rostedt wrote:
> On Mon, 16 Apr 2018 20:49:12 +
> Bart Van Assche wrote:
>
> > Which tools process these strings? Has it been verified whether or not
> > the tools that process these strings still work fine with this patch
> > applied?
>
> Ideally, t
On Mon, 16 Apr 2018 20:49:12 +
Bart Van Assche wrote:
> Which tools process these strings? Has it been verified whether or not
> the tools that process these strings still work fine with this patch
> applied?
Ideally, tools shouldn't process trace event strings, but I'm sure some
do. :-/
Ge
On Mon, 2018-04-16 at 21:10 +, Bean Huo (beanhuo) wrote:
> Hi, Bart
>
> > mi...@redhad.com; linux-bl...@vger.kernel.org; raja...@google.com
> > Subject: [EXT] Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in
> > SCSI
> > trace events
> >
> &g
Hi, Bart
>mi...@redhad.com; linux-bl...@vger.kernel.org; raja...@google.com
>Subject: [EXT] Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI
>trace events
>
>On Mon, 2018-04-16 at 14:31 +, Bean Huo (beanhuo) wrote:
>> TP_printk("host_no=%u channe
On Mon, 2018-04-16 at 14:31 +, Bean Huo (beanhuo) wrote:
> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u prot_sgl=%u" \
> - " prot_op=%s cmnd=(%s %s raw=%s)",
> + " prot_op=%s tag=%d cmnd=(%s %s raw=%s)",
>
> [ ... ]
> TP_printk("host_no=%u c
On Mon, 2018-04-16 at 20:27 +, Bean Huo (beanhuo) wrote:
> By the way, these patches are not to add new feature, they are just to
> add print tag along with the other exist printed request parameters.
Are you aware that there are two tag fields in struct request, namely "tag"
and "internal_tag
>>> This patch is not acceptable because it adds support for tag tracing
>>> to the legacy block layer only. Any patch that adds a new feature to
>>> the legacy block layer must also add it to blk-mq.
>>>
>> To be honest, I don't understand your point, can you give me more
>explanation?
>
>The lega
On 04/16/18 10:05, Bean Huo (beanhuo) wrote:
On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt
wrote:
On Mon, 16 Apr 2018 14:31:49 +
"Bean Huo (beanhuo)" wrote:
Print the request tag along with other information while tracing a
command
Hi, Bart
>On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
>> On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt
>wrote:
>> > On Mon, 16 Apr 2018 14:31:49 +
>> > "Bean Huo (beanhuo)" wrote:
>> >
>> > > Print the request tag along with other information while tracing a
>> > > command.
>> > >
On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
> On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt wrote:
> > On Mon, 16 Apr 2018 14:31:49 +
> > "Bean Huo (beanhuo)" wrote:
> >
> > > Print the request tag along with other information
> > > while tracing a command.
> > >
> > > Signed-off
On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt wrote:
> On Mon, 16 Apr 2018 14:31:49 +
> "Bean Huo (beanhuo)" wrote:
>
>> Print the request tag along with other information
>> while tracing a command.
>>
>> Signed-off-by: Bean Huo
Acked-by: Rajat Jain
>> ---
>
> I don't see any issue with
On Mon, 16 Apr 2018 14:31:49 +
"Bean Huo (beanhuo)" wrote:
> Print the request tag along with other information
> while tracing a command.
>
> Signed-off-by: Bean Huo
> ---
I don't see any issue with the tracing part.
Acked-by: Steven Rostedt (VMware)
Others need to check the content.
16 matches
Mail list logo