Re: [PATCH 00/13] replace print_symbol() with printk()-s

2017-12-20 Thread Sergey Senozhatsky
On (12/11/17 19:10), Joe Perches wrote: [..] > As far as I'm concerned, as soon as there is > no longer a single user in the kernel tree, > better to delete it instead. sounds good to me. can drop it, once the series upstreamed. 8< --- From: Sergey Senozhatsky

[PATCH 2/2] ARC: handle gcc generated __builtin_trap for older compiler

2017-12-20 Thread Vineet Gupta
ARC gcc prior to GNU 2018.03 release didn't have a target specific __builtin_trap() implementation, generating default abort() call. Implement the abort() call - emulating what newer gcc does for the same, as suggested by Arnd. Signed-off-by: Vineet Gupta ---

[PATCH 1/2] ARC: handle gcc generated __builtin_trap()

2017-12-20 Thread Vineet Gupta
gcc toggle -fisolate-erroneous-paths-dereference (default at -O2 onwards) isolates faulty code paths such as null pointer access, divide by zero etc by emitting __builtin_trap() Newer ARC gcc generates TRAP_S 5 instruction correspondingly which this patch handles. If user mode, the task is

Re: [PATCH] bug.h: Work around GCC PR82365 in BUG()

2017-12-20 Thread Vineet Gupta
On 12/20/2017 12:12 PM, Arnd Bergmann wrote: Sorry, I didn't realize we are missing the stack trace now which you removed from the patch - why ? Did u intend to reduce inline generated code for the stack dump calls - which sounds like a great idea. But it would only work for the synchronous

Re: [PATCH] bug.h: Work around GCC PR82365 in BUG()

2017-12-20 Thread Arnd Bergmann
On Wed, Dec 20, 2017 at 7:52 PM, Vineet Gupta wrote: > On 12/20/2017 01:01 AM, Arnd Bergmann wrote: >> >> On Tue, Dec 19, 2017 at 11:38 PM, Vineet Gupta >> wrote: >>> >>> On 12/19/2017 12:13 PM, Arnd Bergmann wrote: > I

Re: [PATCH] bug.h: Work around GCC PR82365 in BUG()

2017-12-20 Thread Vineet Gupta
On 12/20/2017 01:01 AM, Arnd Bergmann wrote: On Tue, Dec 19, 2017 at 11:38 PM, Vineet Gupta wrote: On 12/19/2017 12:13 PM, Arnd Bergmann wrote: I suppose BUG() implies "dead end" like semantics - which ARC was lacking before ? Correct. Using __builtin_trap()

Re: [PATCH 00/13] replace print_symbol() with printk()-s

2017-12-20 Thread Sergey Senozhatsky
On (12/11/17 21:50), Sergey Senozhatsky wrote: > > A rather automatic replacement of print_symbol() > with direct printk() calls. print_symbol() uses extra stack > buffer (KSYM_SYMBOL_LEN 128 bytes) and, basically, should > be identical to printk(%pS). > > I can't test all of the

Re: [PATCH] bug.h: Work around GCC PR82365 in BUG()

2017-12-20 Thread Arnd Bergmann
On Tue, Dec 19, 2017 at 11:38 PM, Vineet Gupta wrote: > On 12/19/2017 12:13 PM, Arnd Bergmann wrote: >> >> >>> I suppose BUG() implies "dead end" like semantics - which ARC was lacking >>> before ? >> >> Correct. Using __builtin_trap() here avoids the 'control reaches