Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

On Sat, Dec 12, 2015 at 12:15:09AM +0100, Danny Milosavljevic wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > > + SOC_SINGLE_TLV("Line-In Playback

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi CK, Hi Mark, (I've added Mark - since he committed the original soc-ops line of code below - and the list) On Mon, 7 Dec 2015 07:30:07 +0100 Code Kipper wrote: [...] > > +static DECLARE_TLV_DB_SCALE(sun4i_codec_linein_output_volume_scale, -150, > > 150, 0); > These

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi Chen-Yu, On Fri, 11 Dec 2015 11:23:33 +0800 Chen-Yu Tsai wrote: > If everything is known beforehand, having 2 separate read only tables is > probably better. No need for maintainers / reviewers to squint. :) Yeah, that's what v6 already does. Suggestion 4 was to copy it at

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi, On Tue, Dec 08, 2015 at 11:51:44AM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Tue, 8 Dec 2015 10:09:50 +0100 > Maxime Ripard wrote: > > > > Now I added an ugly hack to make Mic Gain work on A10 as well - but I > > > don't have > > > A10

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi, On Fri, Dec 11, 2015 at 2:57 AM, Danny Milosavljevic wrote: > Hi Maxime, > >> There's no need to have two at the same time, they're mutually >> exclusive. > > Hmmm. I don't understand it properly then... > Let's say two different compatibles in two different device

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

On Thu, Dec 10, 2015 at 07:57:36PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > > There's no need to have two at the same time, they're mutually > > exclusive. > > Hmmm. I don't understand it properly then... > Let's say two different compatibles in two different device tree nodes > match

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi Maxime, On Tue, 8 Dec 2015 10:09:50 +0100 Maxime Ripard wrote: > > Now I added an ugly hack to make Mic Gain work on A10 as well - but I don't > > have > > A10 hardware. Let's see what they say. > > That I really prefer having nothing over an "ugly hack"

Re: [linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi Danny, On Sun, Dec 06, 2015 at 07:53:07PM +0100, Danny Milosavljevic wrote: > Hi, > > this is the fourth version of the patch that adds inputs to sun4i-codec. > > The inputs added are: > - FM-In Left and Right > - Line-In Left and Right > - Mic1-In > - Mic2-In > > Changes compared to v3

[linux-sunxi] [PATCH v4] sun4i-codec: add inputs

Hi, this is the fourth version of the patch that adds inputs to sun4i-codec. The inputs added are: - FM-In Left and Right - Line-In Left and Right - Mic1-In - Mic2-In Changes compared to v3 are: - Names of the input are not uppercase anymore. - bit index constants are now named as in the A20