[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Thu, 30 Jun 2016 23:16:35 +0200 Maxime Ripard wrote: > > > I'm sorry, but the whole point of the initial serie was to rework and > > > simplify things, precisely because dealing with the clk_factors code > > > was just too difficult nowadays. And this doesn't

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Thu, 30 Jun 2016 23:16:35 +0200 Maxime Ripard wrote: > > - in case a driver requests a reset, this last one should exist. > > But, this reset may point to a void one (reg = null) when the real > > reset has been moved to the prepare/unprepare of the

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Thu, 30 Jun 2016 23:16:35 +0200 Maxime Ripard wrote: > > - some fixed_factor clocks may have a gate. > > Which ones? I know only the "osc12M" in the A83T. It is used by the ehci1. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Wed, Jun 29, 2016 at 10:12:56AM +0200, Jean-Francois Moine wrote: > On Tue, 28 Jun 2016 22:45:02 +0200 > Maxime Ripard wrote: > > > On Tue, Jun 28, 2016 at 05:37:35PM +0200, Jean-Francois Moine wrote: > > > +/* --- prepare / enable --- */ > > > +int

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Tue, 28 Jun 2016 22:45:02 +0200 Maxime Ripard wrote: > On Tue, Jun 28, 2016 at 05:37:35PM +0200, Jean-Francois Moine wrote: > > +/* --- prepare / enable --- */ > > +int ccu_prepare(struct clk_hw *hw) > > +{ > > + struct ccu *ccu = hw2ccu(hw); > > + > > +

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

Quoting Maxime Ripard (2016-06-28 13:45:02) > What's the point of this, if we're not using (or exposing for that > matter) any of it? > > I'm sorry, but the whole point of the initial serie was to rework and > simplify things, precisely because dealing with the clk_factors code > was just too

[linux-sunxi] Re: [PATCH 1/3] clk: sunxi: Add a driver for the CCU

On Tue, Jun 28, 2016 at 05:37:35PM +0200, Jean-Francois Moine wrote: > +/* --- prepare / enable --- */ > +int ccu_prepare(struct clk_hw *hw) > +{ > + struct ccu *ccu = hw2ccu(hw); > + > + if (!ccu->reset_reg && !ccu->bus_reg) > + return 0; > + > +#if CCU_DEBUG > +