Hi,
Thanks for working on this.
First, make sure to read Documentation/SubmittingPatches. The
guidelines in there might seem tedious, but it's there to enforce that
we keep the kernel homogenous.
Most notably, you should make sure that:
- you run scripts/checkpatch.pl on your patches
- you
Hello Maxime,
Sorry for inconvenience. I'll follow the guidelines, will implement the
review comment and resubmit the patch for review.
On Fri, Dec 5, 2014 at 3:31 PM, Maxime Ripard
maxime.rip...@free-electrons.com wrote:
Hi,
Thanks for working on this.
First, make sure to read
On Thursday 04 December 2014 04:23:44 vishnupatekar wrote:
+
+#define DRIVER_NAME sunxi-ps2
+
+#define RESSIZE(res)(((res)-end - (res)-start)+1)
Remove this and use the existing resource_size() function
+
+struct sunxips2data {
+ int irq;
+ spinlock_t ps2_lock;
Hi Arnd,
On December 5, 2014 2:33:11 AM PST, Arnd Bergmann a...@arndb.de wrote:
On Thursday 04 December 2014 04:23:44 vishnupatekar wrote:
+
+struct sunxips2data {
+int irq;
+spinlock_t ps2_lock;
+void __iomem *base_address; /* virt address of control registers*/
+struct
On Friday 05 December 2014 07:01:17 Dmitry Torokhov wrote:
On December 5, 2014 2:33:11 AM PST, Arnd Bergmann a...@arndb.de wrote:
On Thursday 04 December 2014 04:23:44 vishnupatekar wrote:
+
+struct sunxips2data {
+int irq;
+spinlock_t ps2_lock;
+void __iomem
On December 5, 2014 7:50:18 AM PST, Arnd Bergmann a...@arndb.de wrote:
On Friday 05 December 2014 07:01:17 Dmitry Torokhov wrote:
On December 5, 2014 2:33:11 AM PST, Arnd Bergmann a...@arndb.de
wrote:
On Thursday 04 December 2014 04:23:44 vishnupatekar wrote:
+
+struct sunxips2data {
+
On Thu, Dec 04, 2014 at 04:23:44AM +0530, vishnupatekar wrote:
---
drivers/input/serio/Kconfig |9 ++
drivers/input/serio/Makefile|1 +
drivers/input/serio/sunxi-ps2.c | 305
+++
3 files changed, 315 insertions(+)
create mode 100644
Hello Dmitry,
Thank you for comments.
I'll implement these comments and resend it for review.
On Thursday, December 4, 2014, Dmitry Torokhov dmitry.torok...@gmail.com
wrote:
On Thu, Dec 04, 2014 at 04:23:44AM +0530, vishnupatekar wrote:
---
drivers/input/serio/Kconfig |9 ++
