[linux-sunxi] Re: [PATCH 1/5] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller

On Thu, Dec 26, 2013 at 11:33:06PM +0100, Hans de Goede wrote: On 12/26/2013 11:15 PM, Dmitry Torokhov wrote: Are we 1000% sure that the device is quiesced here and we will not get a stray interrupt? Even if we are sure I'd still rather allocate input device earlier, together with ts

[linux-sunxi] Re: [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor

Hi Hans, On Fri, Dec 27, 2013 at 03:59:56PM +0100, Hans de Goede wrote: + + if (!ts-input) + goto leave; + if (reg_val FIFO_DATA_PENDING) { x = readl(ts-base + TP_DATA); y = readl(ts-base + TP_DATA); @@ -140,6 +151,7 @@ static irqreturn_t

[linux-sunxi] Re: [PATCH 1/4] input: Add new sun4i-lradc-keys drivers

Hi Hans, On Wed, Jan 01, 2014 at 08:30:07PM +0100, Hans de Goede wrote: +Required properties: + - compatible: allwinner,sun4i-lradc-keys + - reg: mmio address range of the chip + - interrupts: interrupt to which the chip is connected + - allwinner,chan0-step: step in mV between keys must be

Re: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC

On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown broo...@kernel.org wrote: On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: On Tue, Mar 18, 2014 at 03:59:19PM +, Lee Jones wrote: + of_id =

[linux-sunxi] Re: [PATCH v3 04/10] input: misc: Add driver for AXP20x Power Enable Key

Hi Carlo, On Thu, Mar 27, 2014 at 10:29:18PM +0100, Carlo Caione wrote: This patch add support for the Power Enable Key found on MFD AXP202 and AXP209. Besides the basic support for the button, the driver adds two entries in sysfs to configure the time delay for power on/off. Signed-off-by:

[linux-sunxi] Re: [PATCH v4 4/9] input: misc: Add driver for AXP20x Power Enable Key

On Fri, Apr 11, 2014 at 11:38:08AM +0200, Carlo Caione wrote: This patch add support for the Power Enable Key found on MFD AXP202 and AXP209. Besides the basic support for the button, the driver adds two entries in sysfs to configure the time delay for power on/off. Signed-off-by: Carlo

Re: [linux-sunxi] [PATCH v4 2/2] input: sun4i-ts: Add support for temperature sensor

On Mon, May 12, 2014 at 04:44:51PM +0800, Chen-Yu Tsai wrote: Hi, On Sun, May 11, 2014 at 4:06 PM, Hans de Goede hdego...@redhat.com wrote: @@ -232,14 +284,39 @@ static int sun4i_ts_probe(struct platform_device *pdev) writel(STYLUS_UP_DEBOUN(5) | STYLUS_UP_DEBOUN_EN(1) |

[linux-sunxi] Re: [PATCH v5 4/8] input: misc: Add driver for AXP20x Power Enable Key

to configure the time delay for power on/off. Signed-off-by: Carlo Caione ca...@caione.org Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com How are we merging it? MFD tree? Thanks. -- Dmitry -- You received this message because you

[linux-sunxi] Re: [PATCH 1/2] touchscreen: sun4i-ts: A10 (sun4i) has double the temperature precision

Hi Hans, On Mon, Jun 16, 2014 at 08:24:28PM +0200, Hans de Goede wrote: Testing has revealed that the temperature in the rtp controller of the A10 (sun4i) SoC has a resolution of 50 milli degrees / step, where as the A13 (sun5i) and later models have 100 milli degrees / step. Add a new

[linux-sunxi] Re: [PATCH 2/3] drivers:input:ps2 Added sunxi A20 ps2 driver, changed makefile and Kconfig

On Thu, Dec 04, 2014 at 04:23:44AM +0530, vishnupatekar wrote: --- drivers/input/serio/Kconfig |9 ++ drivers/input/serio/Makefile|1 + drivers/input/serio/sunxi-ps2.c | 305 +++ 3 files changed, 315 insertions(+) create mode 100644

[linux-sunxi] Re: [PATCH 2/3] drivers:input:ps2 Added sunxi A20 ps2 driver, changed makefile and Kconfig

Hi Arnd, On December 5, 2014 2:33:11 AM PST, Arnd Bergmann a...@arndb.de wrote: On Thursday 04 December 2014 04:23:44 vishnupatekar wrote: + +struct sunxips2data { +int irq; +spinlock_t ps2_lock; +void __iomem *base_address; /* virt address of control registers*/ +struct

[linux-sunxi] Re: [PATCH 2/3] drivers:input:ps2 Added sunxi A20 ps2 driver, changed makefile and Kconfig

On December 5, 2014 7:50:18 AM PST, Arnd Bergmann a...@arndb.de wrote: On Friday 05 December 2014 07:01:17 Dmitry Torokhov wrote: On December 5, 2014 2:33:11 AM PST, Arnd Bergmann a...@arndb.de wrote: On Thursday 04 December 2014 04:23:44 vishnupatekar wrote: + +struct sunxips2data

[linux-sunxi] Re: [PATCH resend v2] input: Add new sun4i-lradc-keys driver

On Wednesday, December 17, 2014 03:43:31 PM Hans de Goede wrote: + /* +* lradc supports only one keypress at a time, release does not give +* any info as to which key was released, so we cache the keycode. +*/ + if ((ints CHAN0_KEYDOWN_IRQ)

[linux-sunxi] Re: [PATCH v3] input: Add new sun4i-lradc-keys driver

parsing into a separate function; - make sure keymap is not empty; - change 'ret' variable to 'error'; Thanks! -- Dmitry Input: sun4i-lradc-keys - misc changes From: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/keyboard

[linux-sunxi] Re: [PATCH v3] input: Add new sun4i-lradc-keys driver

On Sat, Dec 20, 2014 at 11:44:37AM +0100, Hans de Goede wrote: Hi Dmitry, On 18-12-14 18:51, Dmitry Torokhov wrote: Hi Hans, On Thu, Dec 18, 2014 at 11:23:13AM +0100, Hans de Goede wrote: Allwinnner sunxi SoCs have a low resolution adc (called lradc) which is specifically designed

[linux-sunxi] Re: [PATCH v8 3/6] input: misc: Add driver for AXP20x Power Enable Key

for power on/off. Signed-off-by: Carlo Caione ca...@caione.org Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com [w...@csie.org: make axp20x_pek_remove() static; remove driver owner field] Signed-off-by: Chen-Yu Tsai w...@csie.org Hmm, it looks like MFD parts are in mainline, so I can actually

[linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

On Mon, Jan 26, 2015 at 08:28:29PM +0100, Hans de Goede wrote: Hi, On 26-01-15 17:58, Priit Laes wrote: No commit message? Please write an informative commit msg, like why we want this patch, I guess it is to help figuring out the voltage levels for various buttons when creating a

[linux-sunxi] Re: [PATCH v8 4/6] input: misc: Add ABI docs for AXP20x PEK

Hi Chen-Yu, On Fri, Jan 16, 2015 at 12:00:31AM +0800, Chen-Yu Tsai wrote: On Tue, Dec 23, 2014 at 10:53 AM, Chen-Yu Tsai w...@csie.org wrote: From: Carlo Caione ca...@caione.org Add ABI entries for the PEK found on PMU X-Powers AXP202 and AXP209. Hi Dmitry, Would it be possible to

[linux-sunxi] Re: [PATCH v4 2/5] ARM:sunxi:drivers:input Add support for A10/A20 PS2

On Mon, Jan 19, 2015 at 11:37:38AM +0530, Vishnu Patekar wrote: Hello Dmitry, Thank you for review comments. Please see in-lined. On Sun, Jan 18, 2015 at 3:55 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Vishnu, On Fri, Jan 16, 2015 at 07:33:38PM +0530, Vishnu Patekar

[linux-sunxi] Re: [PATCH v4 2/5] ARM:sunxi:drivers:input Add support for A10/A20 PS2

Hi Vishnu, On Fri, Jan 16, 2015 at 07:33:38PM +0530, Vishnu Patekar wrote: Signed-off-by: VishnuPatekar vishnupatekar0...@gmail.com --- drivers/input/serio/Kconfig | 11 ++ drivers/input/serio/Makefile|1 + drivers/input/serio/sun4i-ps2.c | 330

Re: [linux-sunxi] Re: [PATCH v4 2/5] ARM:sunxi:drivers:input Add support for A10/A20 PS2

On Wed, Jan 21, 2015 at 04:52:04PM +0530, Vishnu Patekar wrote: Hello Dmitry, On Tue, Jan 20, 2015 at 6:05 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Jan 19, 2015 at 11:37:38AM +0530, Vishnu Patekar wrote: Hello Dmitry, Thank you for review comments. Please see

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

On Tue, Jan 27, 2015 at 11:49:49AM +0200, Priit Laes wrote: On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: Hi, On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit Laes wrote: --- Like Hans was pointing out, commit log and signed-off-by please

[linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

On Tue, Jan 27, 2015 at 10:03:35AM +0100, Hans de Goede wrote: Hi, On 26-01-15 23:06, Dmitry Torokhov wrote: On Mon, Jan 26, 2015 at 08:28:29PM +0100, Hans de Goede wrote: Hi, On 26-01-15 17:58, Priit Laes wrote: No commit message? Please write an informative commit msg, like why we

[linux-sunxi] Re: [PATCH v5 2/4] ARM:sunxi:drivers:input Add support for A10/A20 PS2

Hi Vishnu, On Sun, Jan 25, 2015 at 07:10:07PM +0530, Vishnu Patekar wrote: Signed-off-by: VishnuPatekar vishnupatekar0...@gmail.com --- drivers/input/serio/Kconfig | 11 ++ drivers/input/serio/Makefile|1 + drivers/input/serio/sun4i-ps2.c | 347

Re: [linux-sunxi] Re: [PATCH] arm: sunxi: input: RFC: Add sysfs voltage for sun4i-lradc driver

On Tue, Jan 27, 2015 at 08:44:47PM +0100, Maxime Ripard wrote: On Tue, Jan 27, 2015 at 11:52:34AM +0100, Hans de Goede wrote: Hi, On 27-01-15 10:49, Priit Laes wrote: On Tue, 2015-01-27 at 10:18 +0100, Maxime Ripard wrote: Hi, On Mon, Jan 26, 2015 at 06:58:32PM +0200, Priit

[linux-sunxi] Re: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens

On Sun, Mar 22, 2015 at 12:00:55PM +0100, Hans de Goede wrote: Hi, On 22-03-15 05:03, Dmitry Torokhov wrote: Hi Hans, On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote: + error = devm_request_threaded_irq(dev, client-irq, NULL, icn8318_irq

[linux-sunxi] Re: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens

Hi Hans, On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de Goede wrote: + error = devm_request_threaded_irq(dev, client-irq, NULL, icn8318_irq, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, Shouldn't we let DT data tell us what trigger to use? I.e. just leave

[linux-sunxi] Re: [PATCH 0/3] touchscreen: sun4i-ts: A10 (sun4i) has a different temperature curve

Hi Hans, On Sun, Mar 08, 2015 at 09:53:39PM +0100, Hans de Goede wrote: Hi Dmitry, Maxime, et al. Here is a patch-set for the sun4i-ts driver temperature sensor support, it consists of 2 fixes: 1) Use a better temperature curve for A10 SoCs to avoid reporting a way to high temperature.

[linux-sunxi] Re: [PATCH 1/3] touchscreen: sun4i-ts: A10 (sun4i) has a different temperature curve

On Sun, Mar 08, 2015 at 09:53:40PM +0100, Hans de Goede wrote: Testing has revealed that the temperature in the rtp controller of the A10 (sun4i) SoC has a different curve then on the A13 (sun5i) and later models. Add a new sun5i-a13-ts compatible to differentiate the newer models and set

[linux-sunxi] Re: [PATCH] touchscreen: sun4i-ts: Really fix A10 temperature reporting

On Mon, Mar 09, 2015 at 10:37:50AM +0100, Hans de Goede wrote: The commit titled: touchscreen: sun4i-ts: A10 (sun4i) has a different temperature curve contains a math error, the offset it uses is in degrees, but the actual code applies the offset before multiplying by stepsize :| Given that

[linux-sunxi] Re: [PATCH v3] input: Add support for ChipOne icn8318 based touchscreens

On Tue, Mar 24, 2015 at 06:45:03PM +0100, Hans de Goede wrote: Hi, On 03/22/2015 11:42 PM, Dmitry Torokhov wrote: On Sun, Mar 22, 2015 at 12:00:55PM +0100, Hans de Goede wrote: Hi, On 22-03-15 05:03, Dmitry Torokhov wrote: Hi Hans, On Tue, Mar 10, 2015 at 06:05:33PM +0100, Hans de

Re: [linux-sunxi] Re: [PATCH] Input: sun4i-ts - allow to adjust some settings via device-tree properties.

On Wed, Mar 18, 2015 at 12:01:58PM +0100, Hans de Goede wrote: Hi, On 18-03-15 11:37, Maxime Ripard wrote: On Thu, Mar 12, 2015 at 04:45:50PM +0100, Jens Thiele wrote: This commit introduces two new optional device-tree properties: tp-sensitive-adjust: adjust sensitivity of pen down

[linux-sunxi] Re: [PATCH] input: axp20x-pek: Fix reporting button state as inverted

On Sun, Jun 14, 2015 at 12:42:21PM +0200, Hans de Goede wrote: Currently we are reporting the button state as inverted on all boards with an axp209 pmic, tested on a ba10-tvbox, bananapi, bananapro, cubietruck and utoo-p66 tablet. The axp209 datasheet clearly states that the power button

[linux-sunxi] Re: [PATCH] touchscreen: sun4i-ts: Really fix A10 temperature reporting

On Tue, Jun 23, 2015 at 09:46:20PM +0200, Hans de Goede wrote: Hi, On 06/23/2015 05:06 PM, m.silentcr...@gmail.com wrote: Hi Hans, is it possible that this patch (and the parent commit Input: sun4i-ts - allow controlling filter and sensitivity via DT) has quite an adversial effect on

Re: [linux-sunxi] Re: [PATCH] input: axp20x-pek: Fix reporting button state as inverted

On Wed, Jun 24, 2015 at 11:19:39AM +0200, Carlo Caione wrote: On Wed, Jun 24, 2015 at 3:42 AM, Chen-Yu Tsai w...@csie.org wrote: On Tue, Jun 23, 2015 at 5:30 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sun, Jun 14, 2015 at 12:42:21PM +0200, Hans de Goede wrote: Currently we

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

On Mon, Aug 03, 2015 at 09:56:09AM +0200, Carlo Caione wrote: On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai w...@csie.org wrote: Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its cells. Signed-off-by: Chen-Yu Tsai w...@csie.org

Re: [linux-sunxi] Re: [PATCH] Input: axp20x-pek: Add module alias

On Tue, Aug 04, 2015 at 05:04:55PM +0800, Chen-Yu Tsai wrote: On Tue, Aug 4, 2015 at 4:42 PM, Paul Bolle pebo...@tiscali.nl wrote: On ma, 2015-08-03 at 15:48 +0800, Chen-Yu Tsai wrote: Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its

[linux-sunxi] Re: [PATCH 2/4] devicetree: bindings: Add header file with evdev type and abs/rel code defines

On Thu, Sep 10, 2015 at 11:40 AM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > > On 10-09-15 20:34, Dmitry Torokhov wrote: >> >> On Thu, Sep 10, 2015 at 10:25 AM, Rob Herring <r...@kernel.org> wrote: >>> >>> On 09/09/2015 04:11 AM, Han

[linux-sunxi] Re: [PATCH 2/4] devicetree: bindings: Add header file with evdev type and abs/rel code defines

On Thu, Sep 10, 2015 at 10:25 AM, Rob Herring wrote: > On 09/09/2015 04:11 AM, Hans de Goede wrote: >> This header provides evdev constants for linux,code, and linux,input-* >> properties. >> >> Signed-off-by: Hans de Goede >> --- >>

[linux-sunxi] Re: [PATCH 2/4] devicetree: bindings: Add header file with evdev type and abs/rel code defines

On Thu, Sep 10, 2015 at 3:48 PM, Rob Herring <r...@kernel.org> wrote: > +Ian > > On 09/10/2015 01:50 PM, Hans de Goede wrote: >> Hi, >> >> On 10-09-15 20:42, Dmitry Torokhov wrote: >>> On Thu, Sep 10, 2015 at 11:40 AM, Hans de Goede <hdego...@redhat.com

[linux-sunxi] Re: [PATCH 3/4] input: Add new sun4i-keypad driver

Hi Yassin, On Wed, Sep 16, 2015 at 12:05:56AM +1000, yassinjaf...@gmail.com wrote: > From: Yassin Jaffer > > Allwinnner SUN4i Keypad controller is used to interface a SoC > with a matrix-typekeypad device. > The keypad controller supports multiple row and column lines. >

[linux-sunxi] Re: [PATCH v3] touchscreen: pixcir_i2c: Add support for wake and enable gpios

On Sun, Nov 22, 2015 at 04:19:50PM -0600, Rob Herring wrote: > On Sun, Nov 22, 2015 at 04:57:33PM +0100, Hans de Goede wrote: > > From: Sander Vermin > > > > On some devices the wake and enable pins of the pixcir touchscreen > > controller are connected to gpios and these must

[linux-sunxi] Re: [PATCH 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

On Fri, Nov 20, 2015 at 12:17:10PM +0100, Hans de Goede wrote: > From: Sander Vermin > > On some devices the wake and enable pins of the pixcir touchscreen > controller are connected to gpios and these must be controlled by the > driver for the device to operate properly. > >

[linux-sunxi] Re: [PATCH v2 4/7] touchscreen: pixcir_i2c: Add support for wake and enable gpios

On Fri, Nov 20, 2015 at 02:24:49PM +0100, Hans de Goede wrote: > From: Sander Vermin > > On some devices the wake and enable pins of the pixcir touchscreen > controller are connected to gpios and these must be controlled by the > driver for the device to operate properly. > >

[linux-sunxi] Re: [PATCH v5 32/46] pwm: deprecate pwm_config(), pwm_enable() and pwm_disable()

Hi Boris, On Wed, Mar 30, 2016 at 10:03:55PM +0200, Boris Brezillon wrote: > Prefix those function as deprecated to encourage all existing users to > switch to pwm_apply_state(). Why not keep at least some of them as wrappers where we do not need to chnage several parameters at once? It is much

[linux-sunxi] Re: [PATCH v5 36/46] input: misc: max77693: switch to the atomic API

Hi Boris, On Wed, Mar 30, 2016 at 10:03:59PM +0200, Boris Brezillon wrote: > pwm_config/enable/disable() have been deprecated and should be replaced > by pwm_apply_state(). > > Signed-off-by: Boris Brezillon > --- > drivers/input/misc/max77693-haptic.c | 23

[linux-sunxi] Re: [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote: > Call pwm_apply_args() just after requesting the PWM device so that the > polarity and period are initialized according to the information provided > in pwm_args. > > This is an intermediate state, and pwm_apply_args() should be

[linux-sunxi] Re: [PATCH 1/5] dt-bindings: add vendor prefix for ILI Technology Corp

On Mon, Oct 10, 2016 at 5:33 PM, Icenowy Zheng wrote: > ILI Technology Corp (a.k.a Ilitek, http://www.ilitek.com/index-e.asp ) is a > company that produces LCD driver ICs and touch screen controller ICs. Was there patch 3/5? I do not see it in my mailbox. > > Signed-off-by:

[linux-sunxi] Re: [PATCH 3/5] Input: add driver for Ilitek ili2139 touch IC

Hi Icenowy, On Tue, Oct 11, 2016 at 08:33:57AM +0800, Icenowy Zheng wrote: > This driver adds support for Ilitek ili2139 touch IC, which is used in > several Colorfly tablets (for example, Colorfly E708 Q1, which is an > Allwinner A31s tablet with mainline kernel support). > > Theortically it

[linux-sunxi] Re: [PATCH 3/5] Input: add driver for Ilitek ili2139 touch IC

On Wed, Oct 12, 2016 at 02:34:01AM +0800, Icenowy Zheng wrote: > > > 12.10.2016, 01:40, "Dmitry Torokhov" <dmitry.torok...@gmail.com>: > > Hi Icenowy, > > > > On Tue, Oct 11, 2016 at 08:33:57AM +0800, Icenowy Zheng wrote: > >>  This driver add

[linux-sunxi] Re: [PATCH v3 05/11] Documentation: DT: bindings: input: touschcreen: remove sun4i documentation

t; > > Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> > > Acked-by: Rob Herring <r...@kernel.org> > > --- > > > > added in v2 > > > > .../bindings/input/touchscreen/sun4i.txt | 38 > > --

[linux-sunxi] Re: [PATCH 6/9] Input: goodix - Add vcc-supply regulator support

On Mon, Dec 03, 2018 at 03:45:44PM +0530, Jagan Teki wrote: > vcc-supply property is need for some Goodix CTP controller like GT5663 > where 3.3V external pull-up regulator connected via controller VCC pin. > > So, enable the regulator for those it attached the vcc-supply. > > Signed-off-by:

[linux-sunxi] Re: [PATCH RESEND v4 1/4] input: sun4i-a10-lradc-keys: Add support for A83T

On Wed, Mar 27, 2019 at 03:33:36AM +0100, meg...@megous.com wrote: > From: Ziping Chen > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC, > however, the A10 SoC's vref of lradc internally is divided by 2/3 and > the A83T SoC's vref of lradc internally is divided by 3/4,

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > Hello Dmitry, > > On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmitry Torokhov wrote: > > Hi Ondrej, > > > > On Mon, Oct 28, 2019 at 11:15:02PM +0100, Ondrej Jirman wrote: > > > Allow the driv

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

Hi Ondrej, On Mon, Oct 28, 2019 at 11:15:02PM +0100, Ondrej Jirman wrote: > Allow the driver to wakeup the system on key press. > > Signed-off-by: Ondrej Jirman > --- > drivers/input/keyboard/sun4i-lradc-keys.c | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) >

Re: [linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys: Add wakup support

On Tue, Oct 29, 2019 at 02:45:59AM +0100, Ondřej Jirman wrote: > On Mon, Oct 28, 2019 at 05:12:50PM -0700, Dmitry Torokhov wrote: > > On Tue, Oct 29, 2019 at 12:56:26AM +0100, Ondřej Jirman wrote: > > > On Mon, Oct 28, 2019 at 04:38:28PM -0700, Dmi

[linux-sunxi] Re: [PATCH 1/3] input: edt-ft5x06: Add support for regulator

On Tue, Oct 29, 2019 at 01:58:04AM +0100, Ondrej Jirman wrote: > From: Mylčne Josserand > > Add the support for enabling optional regulator that may be used as VCC > source. > > Signed-off-by: Ondrej Jirman > Signed-off-by: Mylčne Josserand Applied, thank you. > --- >

[linux-sunxi] Re: [PATCH 0/3] Add touchscreen support for TBS A711 Tablet

On Tue, Oct 29, 2019 at 01:58:03AM +0100, Ondrej Jirman wrote: > This is a resurrection of https://lkml.org/lkml/2018/7/25/143 > > Compared to v4 of Mylčne's series I've dropped all attempts to > power off the chip during suspend. This patch just enables the > regulator during probe and disables

[linux-sunxi] Re: [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants

Hi Samuel, On Sun, Jan 12, 2020 at 09:20:32PM -0600, Samuel Holland wrote: > There are many devices, including several mobile battery-powered > devices, using other AXP variants as their PMIC. Enable them to use > the power key as a wakeup source. Are these X86 or ARM devices? If anything, I'd

[linux-sunxi] Re: [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration

On Mon, Jan 13, 2020 at 11:48:35AM +0100, Hans de Goede wrote: > Hi, > > On 13-01-2020 04:20, Samuel Holland wrote: > > Unlike most other power button drivers, this driver unconditionally > > enables its wakeup IRQ. It should be using device_may_wakeup() to > > respect the userspace configuration

[linux-sunxi] Re: [PATCH v2 1/2] Input: axp20x-pek - Respect userspace wakeup configuration

On Wed, Jan 15, 2020 at 11:50:08AM +0100, Hans de Goede wrote: > Hi, > > On 15-01-2020 06:12, Samuel Holland wrote: > > Unlike most other power button drivers, this driver unconditionally > > enables its wakeup IRQ. It should be using device_may_wakeup() to > > respect the userspace configuration

[linux-sunxi] Re: [PATCH v2 2/2] Input: axp20x-pek - Enable wakeup for all AXP variants

On Tue, Jan 14, 2020 at 11:12:53PM -0600, Samuel Holland wrote: > There are many devices, including several mobile battery-powered > devices, using other AXP variants as their PMIC. Allow them to use > the power key as a wakeup source. > > Reviewed-by: Hans de Goede > Signed-off-by: Samuel

[linux-sunxi] Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios

On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > It is possible to turn the motor on/off just by enabling/disabling > the vcc-supply. > > Signed-off-by: Ondrej Jirman > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 1 - > 1 file

[linux-sunxi] Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios

On Wed, May 13, 2020 at 01:05:57AM +0200, Ondřej Jirman wrote: > On Tue, May 12, 2020 at 03:52:12PM -0700, Dmitry Torokhov wrote: > > On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > > > It is possible to turn the motor on/off just by enabling/disabling &g

[linux-sunxi] Re: [PATCH v4 2/4] input: gpio-vibra: Allow to use vcc-supply alone to control the vibrator

Hi Ondrej, On Tue, Jul 14, 2020 at 12:23:01PM +0200, Ondrej Jirman wrote: > Make enable-gpio optional to allow using this driver with boards that > have vibrator connected to a power supply without intermediate gpio > based enable circuitry. > > Also avoid a case where neither regulator nor

[linux-sunxi] Re: [PATCH] input: sun4i-lradc-keys - Add wakup support

Hi Samuel, On Sun, Jan 03, 2021 at 04:54:46AM -0600, Samuel Holland wrote: > From: Ondrej Jirman > > Allow the driver to wake up the system on key press. Since using the > LRADC as a wakeup source requires keeping on an additional power domain, > disable the wakeup source by default. Why isn't

[linux-sunxi] Re: [PATCH v5 05/20] Input: axp20x-pek: Bail out if AXP has no interrupt line connected

Hi Andre, On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote: > On at least one board (Orangepi Zero2) the AXP305 PMIC does not have its > interrupt line connected to the CPU (mostly because the H616 SoC does > not feature an NMI pin anymore). > After allowing the AXP driver to