[linux-sunxi] Re: [U-Boot] cmd, nand: add an option to disable the verification when writing in raw mode

2016-07-25 Thread Boris Brezillon
On Sun, 24 Jul 2016 20:41:30 -0500 Scott Wood <o...@buserror.net> wrote: > On Wed, Jun 15, 2016 at 10:42:18AM +0200, Boris Brezillon wrote: > > diff --git a/cmd/nand.c b/cmd/nand.c > > index 583a18f..3a5e3a0 100644 > > --- a/cmd/nand.c > > +++ b/cmd/nand.c &g

[linux-sunxi] Re: [PATCH v7 1/2] mtd: nand: sunxi: update DT bindings

2016-06-24 Thread Boris Brezillon
On Fri, 24 Jun 2016 13:00:04 +0800 Icenowy Zheng wrote: > Document the reset lines > > Signed-off-by: Icenowy Zheng Applied both. Thanks, Boris > --- > Changes in v7: > - Rebased for nand/next branch. > - Merged the two part of "Optional properties"

[linux-sunxi] Re: [PATCH v6 2/2] mtd: nand: sunxi: add reset line support

2016-06-23 Thread Boris Brezillon
y should it return > -EPROBE_DEFER again? Sorry, I just had a brainfart :-). Your implementation is correct. BTW, can you avoid top-posting and reply inline? > > 24.06.2016, 00:01, "Boris Brezillon" <boris.brezil...@free-electrons.com>: > > On Mon, 20 Jun 2016 12:48:38

[linux-sunxi] Re: [PATCH v6 2/2] mtd: nand: sunxi: add reset line support

2016-06-23 Thread Boris Brezillon
On Mon, 20 Jun 2016 12:48:38 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be > deasserted before they can enter working state. > > Signed-off-by: Icenowy Zheng > --- >  Changes in v2: >    - Corrected the

[linux-sunxi] Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-20 Thread Boris Brezillon
Hi Philipp, On Mon, 20 Jun 2016 14:05:54 +0200 Philipp Zabel <p.za...@pengutronix.de> wrote: > Am Sonntag, den 19.06.2016, 14:06 +0200 schrieb Boris Brezillon: > > +Philipp > > > > On Sun, 19 Jun 2016 19:37:39 +0800 > > Icenowy Zheng <icen...@aosc.xyz>

[linux-sunxi] Re: [PATCH 0/3] mtd: nand: sunxi: fix SLC NAND support

2016-06-20 Thread Boris Brezillon
On Mon, 6 Jun 2016 13:59:11 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > Hello, > > Those 3 patches aims a fixing support for SLC NANDs with rather small > NAND pages (<= 4k). > > The first patch promote 512 bytes ECC steps to 1k steps, which s

[linux-sunxi] Re: [PATCH] mtd: nand: sunxi: Fix OOB bytes retrieval in read_chunks_dma()

2016-06-20 Thread Boris Brezillon
On Wed, 15 Jun 2016 11:22:12 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > The column address passed to the RNDOUT operation was missing the page > size offset. > Applied. > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> >

[linux-sunxi] Re: [U-Boot,v3,3/7] spl: nand: support redundant u-boot image

2016-06-20 Thread Boris Brezillon
On Sun, 19 Jun 2016 19:07:47 -0500 Scott Wood <o...@buserror.net> wrote: > On Mon, Jun 06, 2016 at 10:16:58AM +0200, Boris Brezillon wrote: > > On modern NAND it's more than recommended to have a backup copy of the > > u-boot binary to recover from corruption: bitflips are qu

[linux-sunxi] Re: [PATCH v4 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 23:40:35 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be deasserted > before they can enter working state. This commit added the reset line process > to the driver. > > Signed-off-by: Icenowy Zheng

[linux-sunxi] Re: [PATCH v3 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
On Sun, 19 Jun 2016 23:01:28 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be deasserted > before they can enter working state. This commit added the reset line process > to the driver. > > Signed-off-by: Icenowy Zheng

[linux-sunxi] Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
le errors. But there may be other reasons for devm_reset_control_get_optional() to fail. The only one that is really reflecting that the reset line is not defined in the DT is -ENOENT. > > 19.06.2016, 20:53, "Boris Brezillon" <boris.brezil...@free-electrons.com>: > &g

[linux-sunxi] Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
aintainer). > > > 19.06.2016, 20:06, "Boris Brezillon" <boris.brezil...@free-electrons.com>: > > +Philipp > > > > On Sun, 19 Jun 2016 19:37:39 +0800 > > Icenowy Zheng <icen...@aosc.xyz> wrote: > > > >>  The NAND controller on some sun8

[linux-sunxi] Re: [PATCH 2/2] mtd: nand: sunxi: add reset line support

2016-06-19 Thread Boris Brezillon
+Philipp On Sun, 19 Jun 2016 19:37:39 +0800 Icenowy Zheng wrote: > The NAND controller on some sun8i chips needs its reset line to be deasserted > before they can enter working state. This commit added the reset line process > to the driver. > > Signed-off-by: Icenowy Zheng

[linux-sunxi] Re: [PATCH v3 0/7] spl: nand: sunxi: implement auto-detection

2016-06-15 Thread Boris Brezillon
On Mon, 6 Jun 2016 10:16:55 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > Hello, > > This patch series aims at adding support for NAND auto-detection to > the sunxi SPL NAND driver. > > As explained in patch 7, this auto-detection is nothing m

[linux-sunxi] [PATCH] mtd: nand: sunxi: Fix OOB bytes retrieval in read_chunks_dma()

2016-06-15 Thread Boris Brezillon
The column address passed to the RNDOUT operation was missing the page size offset. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Fixes: 614049a8d904 ("mtd: nand: sunxi: add support for DMA assisted operations") --- drivers/mtd/nand/sunxi_nand.c | 6 --

[linux-sunxi] [PATCH] cmd, nand: add an option to disable the verification when writing in raw mode

2016-06-15 Thread Boris Brezillon
platforms, where the ROM code tests several hardcoded configs, which are not necessarily matching the NAND characteristics). Add an extension to the nand write.raw command allowing one to disable the verification step. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- cmd/

[linux-sunxi] [PATCH] ARM: sunxi/dt: make the CHIP inherit from allwinner,sun5i-a13

2016-06-14 Thread Boris Brezillon
The sun4i-timer driver registers its sched_clock only if the machine is compatible with "allwinner,sun5i-a13", "allwinner,sun5i-a10s" or "allwinner,sun4i-a10". Add the missing "allwinner,sun5i-a13" string to the machine compatible. Signed-off-b

[linux-sunxi] Re: [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-06-09 Thread Boris Brezillon
Hi Siarhei, On Fri, 10 Jun 2016 01:07:45 +0300 Siarhei Siamashka <siarhei.siamas...@gmail.com> wrote: > On Wed, 1 Jun 2016 14:54:24 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Wed, 1 Jun 2016 14:41:36 +0300 > > Siarhei Siama

[linux-sunxi] [PATCH v2 1/6] sunxi: Add missing macros to configure the NAND controller clk

2016-06-08 Thread Boris Brezillon
We need some macros to manipulate the NAND controller clock. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 5 + 1 file changed, 5 insertions(+) diff --gi

[linux-sunxi] [PATCH v2 5/6] mtd: nand: Add a full-id entry for the H27QCG8T2E5R‐BCF NAND

2016-06-08 Thread Boris Brezillon
Add a full-id entry for the H27QCG8T2E5R‐BCF NAND. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- drivers/mtd/nand/nand_ids.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/nand_ids.c b

[linux-sunxi] [PATCH v2 2/6] mtd: nand: add common DT init code

2016-06-08 Thread Boris Brezillon
s, etc.), then they can do so between calling nand_scan_ident() and nand_scan_tail(). The original commit has been slightly reworked to use the fdtdec_xxx() helpers (instead of the of_() ones). Signed-off-by: Brian Norris <computersforpe...@gmail.com> Signed-off-by: Boris Brezillon <boris

[linux-sunxi] [PATCH v2 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-08 Thread Boris Brezillon
We already have an SPL driver for the sunxi NAND controller, now add the normal/standard one. The source has been copied from Linux 4.6 with a few changes to make it work in u-boot. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@r

[linux-sunxi] [PATCH v2 4/6] sun5i: Add NAND controller to the sun5i DTSI

2016-06-08 Thread Boris Brezillon
From: Maxime Ripard <maxime.rip...@free-electrons.com> Add the NAND controller definition to sun5i.dtsi. Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/d

[linux-sunxi] [PATCH v2 6/6] sunxi: Enable NAND controller on the CHIP

2016-06-08 Thread Boris Brezillon
Enable the NAND controller in the sun5i-r8-chip.dts. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- arch/arm/dts/sun5i-a10s.dtsi | 14 ++ arch/arm/dts/sun5i-a13-olinuxino.dts | 15 +

[linux-sunxi] Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 22:31:38 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > On Mon, 6 Jun 2016 22:59:03 +0300 > Aleksei Mamlin <mamli...@gmail.com> wrote: > > > On Mon, 6 Jun 2016 20:55:49 +0200 > > Boris Brezillon <boris

[linux-sunxi] Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

2016-06-06 Thread Boris Brezillon
On Tue, 7 Jun 2016 00:06:45 +0300 Aleksei Mamlin <mamli...@gmail.com> wrote: > On Mon, 6 Jun 2016 22:31:38 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Mon, 6 Jun 2016 22:59:03 +0300 > > Aleksei Mamlin <mamli...@gmail.com> wr

[linux-sunxi] Re: [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
On Mon, 06 Jun 2016 18:54:03 -0500 Scott Wood <o...@buserror.net> wrote: > On Mon, 2016-06-06 at 20:31 +0200, Boris Brezillon wrote: > > On Mon, 06 Jun 2016 12:56:48 -0500 > > Scott Wood <o...@buserror.net> wrote: > > > > > On Mon, 2016-0

[linux-sunxi] Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 22:59:03 +0300 Aleksei Mamlin <mamli...@gmail.com> wrote: > On Mon, 6 Jun 2016 20:55:49 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Mon, 6 Jun 2016 13:24:22 +0300 > > Aleksei Mamlin <mamli...@gmail.c

[linux-sunxi] Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table

2016-06-06 Thread Boris Brezillon
= {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} }, > + SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640, > + NAND_ECC_INFO(40, SZ_1K), 0 }, > > LEGACY_ID_NAND("NAND 4MiB 5V 8-bit", 0x6B, 4, SZ_8K, SP_OPTIONS), > LEGACY_ID_NAND("NAND 4M

[linux-sunxi] Re: [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 13:24:24 +0300 Aleksei Mamlin <mamli...@gmail.com> wrote: > Enable the NFC and describe the NAND flash connected to this controller. > > Signed-off-by: Aleksei Mamlin <mamli...@gmail.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons

[linux-sunxi] Re: [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 13:24:23 +0300 Aleksei Mamlin <mamli...@gmail.com> wrote: > Enable the NFC and describe the NAND flash connected to this controller. > > Signed-off-by: Aleksei Mamlin <mamli...@gmail.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons

[linux-sunxi] Re: [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

2016-06-06 Thread Boris Brezillon
On Mon, 06 Jun 2016 12:56:48 -0500 Scott Wood <o...@buserror.net> wrote: > On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote: > > On Mon, 6 Jun 2016 17:36:10 +0200 > > Hans de Goede <hdego...@redhat.com> wrote: > > > > > > +#ifndef CONFIG

[linux-sunxi] Re: [PATCH v3 1/2] mtd: nand: sunxi: add support for DMA assisted operations

2016-06-06 Thread Boris Brezillon
On Fri, 15 Apr 2016 15:10:30 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > The sunxi NAND controller is able to pipeline ECC operations only when > operated in DMA mode, which improves a lot NAND throughput while keeping > CPU usage low. Applied both.

[linux-sunxi] [PATCH 6/6] sunxi: Enable NAND controller on the CHIP

2016-06-06 Thread Boris Brezillon
Enable the NAND controller in the sun5i-r8-chip.dts. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/dts/sun5i-a10s.dtsi | 14 ++ arch/arm/dts/sun5i-a13-olinuxino.dts | 15 +++ arch/arm/dts/sun5i-r8-chip.dts

[linux-sunxi] [PATCH 5/6] mtd: nand: Add a full-id entry for the H27QCG8T2E5R‐BCF NAND

2016-06-06 Thread Boris Brezillon
Add a full-id entry for the H27QCG8T2E5R‐BCF NAND. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/nand_ids.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c index 561d2cd..ce0a14e

[linux-sunxi] [PATCH 0/6] sunxi: Add NAND controller driver

2016-06-06 Thread Boris Brezillon
://patchwork.ozlabs.org/patch/627928/ Boris Brezillon (4): sunxi: Add missing macros to configure the NAND controller clk mtd: nand: Add the sunxi NAND controller driver mtd: nand: Add a full-id entry for the H27QCG8T2E5R‐BCF NAND sunxi: Enable NAND controller on the CHIP Brian Norris (1): mtd: nand: add

[linux-sunxi] [PATCH 2/6] mtd: nand: add common DT init code

2016-06-06 Thread Boris Brezillon
s, etc.), then they can do so between calling nand_scan_ident() and nand_scan_tail(). The original commit has been slightly reworked to use the fdtdec_xxx() helpers (instead of the of_() ones). Signed-off-by: Brian Norris <computersforpe...@gmail.com> Signed-off-by: Boris Brezillon <boris

[linux-sunxi] [PATCH 1/6] sunxi: Add missing macros to configure the NAND controller clk

2016-06-06 Thread Boris Brezillon
We some macro to manipulate the NAND controller clock. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/include/asm/arch-sunxi/clock_sun4i.h | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/include/asm/arch-sunxi/clock_sun4i.h b/arch/arm/i

[linux-sunxi] Re: [PATCH 3/3] mtd: nand: sunxi: fix subpage write

2016-06-06 Thread Boris Brezillon
On Mon, 6 Jun 2016 13:59:14 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: Oops, I forgot to add this commit message: " Implement ecc->write_subpage() to prevent core code from assigning this hook to nand_write_subpage_hwecc(). This default implementation tri

[linux-sunxi] [PATCH 1/3] mtd: nand: sunxi: prefer 1k ECC blocks when applicable

2016-06-06 Thread Boris Brezillon
you to correct the case where most of your bitflips are concentrated in a single 512bytes portion. This fact makes the 1k ECC block size more advantageous than the 512bytes one. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand.c | 6 ++

[linux-sunxi] [PATCH 0/3] mtd: nand: sunxi: fix SLC NAND support

2016-06-06 Thread Boris Brezillon
AND that requires ECC steps != 512 | 1024. The last patch implements ecc->write_subpage(), thus fixing a NULL pointer dereference when the NAND chip supports subpage write. Best Regards, Boris Boris Brezillon (3): mtd: nand: sunxi: prefer 1k ECC blocks when applicable mtd: nand: sunxi: check ecc->si

[linux-sunxi] [PATCH 2/3] mtd: nand: sunxi: check ecc->size values

2016-06-06 Thread Boris Brezillon
Verify that the ecc->size value is either 512 or 1024 bytes. This should always be the case if this field was assigned to the nand->ecc_step_size_ds value, but can be wrong when the user overloaded this value with the nand-ecc-step-size DT property. Signed-off-by: Boris Brezillon <bor

[linux-sunxi] [PATCH 3/3] mtd: nand: sunxi: fix subpage write

2016-06-06 Thread Boris Brezillon
Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c index 252cbbf..409acbe

[linux-sunxi] [PATCH sunxi-tools v4 2/4] nand-image-builder: Add error messages to check_image_info()

2016-06-06 Thread Boris Brezillon
Add error messages explaining what is wrong or missing in the arguments passed by to the sunxi-nand-image-builder tool. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Bernhard Nortmann <bernhard.nortm...@web.de> --- Changes since v1: - Drop uneeded brac

[linux-sunxi] [PATCH sunxi-tools v4 1/4] nand-image-builder: Fix the copyright header

2016-06-06 Thread Boris Brezillon
of the original source code I copied from the kernel). Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes since v1: - Add a link to the original bch.c source file --- nand-image-builder.c | 49 - 1 file chan

[linux-sunxi] [PATCH sunxi-tools v4 4/4] nand-image-builder: Fix --help/-h option

2016-06-06 Thread Boris Brezillon
--help/-h is not working correctly (it's printing the help context on stderr instead of stdout). Adding a valid shortcut for --help solves the problem. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Bernhard Nortmann <bernhard.nortm...@web.de> ---

[linux-sunxi] [PATCH sunxi-tools v4 3/4] nand-image-builder: Rework the help context

2016-06-06 Thread Boris Brezillon
Add explanations on where the options to pass to the tool should be extracted from, and add two examples to illustrate this explanation. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Bernhard Nortmann <bernhard.nortm...@web.de> --- Changes since v3

[linux-sunxi] [PATCH v3 1/7] spl: nand: sunxi: remove support for so-called 'syndrome' mode

2016-06-06 Thread Boris Brezillon
the config parameters through Kconfig options. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- drivers/mtd/nand/sunxi_nand_spl.c | 56 ++- 1 file changed, 14 insertions(+), 42 deleti

[linux-sunxi] [PATCH v3 3/7] spl: nand: support redundant u-boot image

2016-06-06 Thread Boris Brezillon
to specify the offset of the redundant u-boot image. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> # Conflicts: # common/spl/spl_nand.c # drivers/mtd/nand/Kconfig --- common/spl/spl_nand.c| 5 +

[linux-sunxi] [PATCH v3 4/7] spl: nand: sunxi: stop guessing the redundant u-boot offset

2016-06-06 Thread Boris Brezillon
Use CONFIG_SYS_NAND_U_BOOT_OFFS_REDUND value instead of trying to guess where the redundant u-boot image is based on simple (and most of the time erroneous) heuristics. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com>

[linux-sunxi] [PATCH v3 6/7] spl: nand: sunxi: split 'load page' and 'read page' logic

2016-06-06 Thread Boris Brezillon
values in NFC registers each time we read a page. These new functions are passed a pointer to an nfc_config struct to limit the number of parameters. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- driv

[linux-sunxi] [PATCH v3 5/7] spl: nand: sunxi: rework status polling loop

2016-06-06 Thread Boris Brezillon
the max_number_of_retries parameters and the MAX_RETRIES macro into timeout_us and DEFAULT_TIMEOUT_US to reflect that we're actually waiting a given amount of time and not only a number of retries. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@r

[linux-sunxi] [PATCH v3 2/7] spl: nand: rework SYS_NAND_U_BOOT_OFFS Kconfig option dependency

2016-06-06 Thread Boris Brezillon
on NAND_SUNXI and make it dependent on SPL selection. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- drivers/mtd/nand/Kconfig | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/na

[linux-sunxi] [PATCH v3 7/7] spl: nand: sunxi: add support for NAND config auto-detection

2016-06-06 Thread Boris Brezillon
'trial and error' mechanism. With this new approach we can get rid of the fixed config list that was used in the sunxi NAND SPL driver. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- Changes since v1: - fix the nand_max_

[linux-sunxi] [PATCH v3 0/7] spl: nand: sunxi: implement auto-detection

2016-06-06 Thread Boris Brezillon
boot-time here). Patch 6 and 7 are implementing the auto-detection logic. Best Regards, Boris Changes since v2: - rework the Kconfig options for SYS_U_BOOT_OFFS and SYS_U_BOOT_REDUND_OFFS Changes since v1: - added Hans ack - fixed 2 typos in patch 7 Boris Brezillon (7): spl: nand: sunxi

[linux-sunxi] Re: [PATCH v2 2/7] spl: nand: rename the SYS_NAND_U_BOOT_OFFS Kconfig option

2016-06-04 Thread Boris Brezillon
On Sat, 04 Jun 2016 02:14:09 -0500 Scott Wood <o...@buserror.net> wrote: > On Sat, 2016-06-04 at 08:06 +0200, Boris Brezillon wrote: > > On Fri, 03 Jun 2016 20:08:49 -0500 > > Scott Wood <o...@buserror.net> wrote: > > > > > This doesn't work. CONFIG_S

[linux-sunxi] Re: [PATCH v2 3/7] spl: nand: support redundant u-boot image

2016-06-04 Thread Boris Brezillon
On Fri, 03 Jun 2016 20:15:16 -0500 Scott Wood <o...@buserror.net> wrote: > On Wed, 2016-06-01 at 13:23 +0200, Boris Brezillon wrote: > > On modern NAND it's more than recommended to have a backup copy of the > > u-boot binary to recover from corruption: bitflips are quite co

[linux-sunxi] Re: [PATCH v2 2/7] spl: nand: rename the SYS_NAND_U_BOOT_OFFS Kconfig option

2016-06-04 Thread Boris Brezillon
On Fri, 03 Jun 2016 20:08:49 -0500 Scott Wood <o...@buserror.net> wrote: > On Wed, 2016-06-01 at 13:23 +0200, Boris Brezillon wrote: > > The SYS_NAND_U_BOOT_OFFS is quite generic, but the Kconfig entry is forced > > to explicitly depend on platforms that are

[linux-sunxi] [PATCH sunxi-tools v3 1/4] nand-image-builder: Fix the copyright header

2016-06-03 Thread Boris Brezillon
of the original source code I copied from the kernel). Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes since v1: - Add a link to the original bch.c source file --- nand-image-builder.c | 49 - 1 file chan

[linux-sunxi] [PATCH sunxi-tools v3 2/4] nand-image-builder: Add error messages to check_image_info()

2016-06-03 Thread Boris Brezillon
Add error messages explaining what is wrong or missing in the arguments passed by to the sunxi-nand-image-builder tool. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Bernhard Nortmann <bernhard.nortm...@web.de> --- Changes since v1: - Drop uneeded brac

[linux-sunxi] [PATCH sunxi-tools v3 3/4] nand-image-builder: Rework the help context

2016-06-03 Thread Boris Brezillon
Add explanations on where the options to pass to the tool should be extracted from, and add two examples to illustrate this explanation. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes since v2: - limit line width in the help context Changes since v1:

[linux-sunxi] [PATCH sunxi-tools v3 4/4] nand-image-builder: Fix --help/-h option

2016-06-03 Thread Boris Brezillon
--help/-h is not working correctly (it's printing the help context on stderr instead of stdout). Adding a valid shortcut for --help solves the problem. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- nand-image-builder.c | 4 ++-- 1 file changed, 2 insertions

[linux-sunxi] [PATCH sunxi-tools v2 3/3] nand-image-builder: Rework the help context

2016-06-02 Thread Boris Brezillon
Add explanations on where the options to pass to the tool should be extracted from, and add two examples to illustrate this explanation. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes since v1: - use shorter option names - rework the help context --- nand

[linux-sunxi] [PATCH sunxi-tools v2 1/3] nand-image-builder: Fix the copyright header

2016-06-02 Thread Boris Brezillon
of the original source code I copied from the kernel). Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Changes since v1: - Add a link to the original bch.c source file --- nand-image-builder.c | 49 - 1 file chan

Re: [linux-sunxi] [PATCH v2 7/7] spl: nand: sunxi: add support for NAND config auto-detection

2016-06-01 Thread Boris Brezillon
On Wed, 1 Jun 2016 15:35:07 +0300 Siarhei Siamashka <siarhei.siamas...@gmail.com> wrote: > On Wed, 1 Jun 2016 13:23:24 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > NAND chips are supposed to expose their capabilities through advanced >

[linux-sunxi] Re: [PATCH sunxi-tools 3/3] nand-image-builder: Add more details in the help context

2016-06-01 Thread Boris Brezillon
On Wed, 1 Jun 2016 14:43:22 +0200 Bernhard Nortmann <bernhard.nortm...@web.de> wrote: > Am 01.06.2016 um 11:05 schrieb Boris Brezillon: > > Add explanation on where the options to pass to the tool should be > > extracted from, and add two examples to illustrate this explan

[linux-sunxi] Re: [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-06-01 Thread Boris Brezillon
On Wed, 1 Jun 2016 14:41:36 +0300 Siarhei Siamashka <siarhei.siamas...@gmail.com> wrote: > On Mon, 30 May 2016 19:02:13 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > On Mon, 30 May 2016 19:46:17 +0300 > > Siarhei Siamashka &l

[linux-sunxi] [PATCH v2 5/7] spl: nand: sunxi: rework status polling loop

2016-06-01 Thread Boris Brezillon
the max_number_of_retries parameters and the MAX_RETRIES macro into timeout_us and DEFAULT_TIMEOUT_US to reflect that we're actually waiting a given amount of time and not only a number of retries. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@r

[linux-sunxi] [PATCH v2 1/7] spl: nand: sunxi: remove support for so-called 'syndrome' mode

2016-06-01 Thread Boris Brezillon
the config parameters through Kconfig options. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- drivers/mtd/nand/sunxi_nand_spl.c | 56 ++- 1 file changed, 14 insertions(+), 42 deleti

[linux-sunxi] [PATCH v2 4/7] spl: nand: sunxi: stop guessing the redundant u-boot offset

2016-06-01 Thread Boris Brezillon
Use CONFIG_SPL_NAND_U_BOOT_OFFS_REDUND value instead of trying to guess where the redundant u-boot image is based on simple (and most of the time erroneous) heuristics. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com>

[linux-sunxi] [PATCH v2 7/7] spl: nand: sunxi: add support for NAND config auto-detection

2016-06-01 Thread Boris Brezillon
'trial and error' mechanism. With this new approach we can get rid of the fixed config list that was used in the sunxi NAND SPL driver. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- Changes since v1: - fix the nand_max_

[linux-sunxi] [PATCH v2 2/7] spl: nand: rename the SYS_NAND_U_BOOT_OFFS Kconfig option

2016-06-01 Thread Boris Brezillon
selection. common/spl/spl_nand.c now sets CONFIG_SYS_NAND_U_BOOT_OFFS to CONFIG_SPL_NAND_U_BOOT_OFFS only when it's undefined. This way we stay compatible with the existing behavior. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@r

[linux-sunxi] [PATCH v2 3/7] spl: nand: support redundant u-boot image

2016-06-01 Thread Boris Brezillon
to specify the offset of the redundant u-boot image. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- common/spl/spl_nand.c| 8 drivers/mtd/nand/Kconfig | 6 ++ 2 files changed, 14 insertions(+)

[linux-sunxi] [PATCH v2 6/7] spl: nand: sunxi: split 'load page' and 'read page' logic

2016-06-01 Thread Boris Brezillon
values in NFC registers each time we read a page. These new functions are passed a pointer to an nfc_config struct to limit the number of parameters. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Hans de Goede <hdego...@redhat.com> --- driv

[linux-sunxi] [PATCH v2 0/7] spl: nand: sunxi: implement auto-detection

2016-06-01 Thread Boris Brezillon
ly important to make the "trial and error" approach efficient (we try to limit the impact on boot-time here). Patch 6 and 7 are implementing the auto-detection logic. Best Regards, Boris Changes since v1: - added Hans ack - fixed 2 typos in patch 7 Boris Brezillon (7): spl: nand: sunxi

[linux-sunxi] Re: [PATCH 7/7] spl: nand: sunxi: add support for NAND config auto-detection

2016-06-01 Thread Boris Brezillon
On Fri, 20 May 2016 15:55:51 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > NAND chips are supposed to expose their capabilities through advanced > mechanisms like READID, ONFI or JEDEC parameter tables. While those > methods are appropriate for the bootload

[linux-sunxi] [PATCH sunxi-tools 1/3] nand-image-builder: Fix the copyright header

2016-06-01 Thread Boris Brezillon
of the original source code I copied from the kernel). Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- Hi, A PR containing those 2 patches has been seent [1], but please review the changes before merging the PR. Thanks, Boris [1]https://github.com/linux-sunxi/sunxi

[linux-sunxi] [PATCH sunxi-tools 3/3] nand-image-builder: Add more details in the help context

2016-06-01 Thread Boris Brezillon
Add explanation on where the options to pass to the tool should be extracted from, and add two examples to illustrate this explanation. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- nand-image-builder.c | 17 +++-- 1 file changed, 15 insertions

[linux-sunxi] [PATCH sunxi-tools 2/3] nand-image-builder: Add error messages to check_image_info()

2016-06-01 Thread Boris Brezillon
Add error messages explaining what is wrong or missing in the arguments passed by to the sunxi-nand-image-builder tool. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- nand-image-builder.c | 30 +- 1 file changed, 25 insertions(+), 5 del

Re: [linux-sunxi] [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-05-31 Thread Boris Brezillon
Hi Bernhard, On Mon, 30 May 2016 23:23:31 +0200 Bernhard Nortmann <bernhard.nortm...@web.de> wrote: > Am 30.05.2016 um 17:12 schrieb Boris Brezillon: > > Generating raw NAND images is particularly useful for boot0 images > > creation since the mainline driver is not suppor

[linux-sunxi] Re: [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-05-30 Thread Boris Brezillon
On Mon, 30 May 2016 19:46:17 +0300 Siarhei Siamashka <siarhei.siamas...@gmail.com> wrote: > On Mon, 30 May 2016 17:24:16 +0200 > Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > > > Hi Hans, > > > > On Mon, 30 May 2016 17:12:53 +0200 &g

[linux-sunxi] Re: [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-05-30 Thread Boris Brezillon
Hi Hans, On Mon, 30 May 2016 17:12:53 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > Generating raw NAND images is particularly useful for boot0 images > creation since the mainline driver is not supporting the funky layout > used by Allwinner's ROM code to

[linux-sunxi] [PATCH sunxi-tools] Add a tool to generate raw NAND images

2016-05-30 Thread Boris Brezillon
be flashed before soldering on the NAND on the board (using a regular NAND programmer). The tool takes care of generating ECC bytes and randomizing data as expected by the NAND controller, and re-arranging the ECC/data sections correctly. Signed-off-by: Boris Brezillon <boris.brezil...@f

[linux-sunxi] [PATCH 0/7] spl: nand: sunxi: implement auto-detection

2016-05-20 Thread Boris Brezillon
ly important to make the "trial and error" approach efficient (we try to limit the impact on boot-time here). Patch 6 and 7 are implementing the auto-detection logic. Best Regards, Boris Boris Brezillon (7): spl: nand: sunxi: remove support for so-called 'syndrome' mode spl: nand: rename th

[linux-sunxi] [PATCH 1/7] spl: nand: sunxi: remove support for so-called 'syndrome' mode

2016-05-20 Thread Boris Brezillon
the config parameters through Kconfig options. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand_spl.c | 56 ++- 1 file changed, 14 insertions(+), 42 deletions(-) diff --git a/drivers/mtd/nand/sunxi_nand_sp

[linux-sunxi] [PATCH 5/7] spl: nand: sunxi: rework status polling loop

2016-05-20 Thread Boris Brezillon
the max_number_of_retries parameters and the MAX_RETRIES macro into timeout_us and DEFAULT_TIMEOUT_US to reflect that we're actually waiting a given amount of time and not only a number of retries. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand_spl.

[linux-sunxi] [PATCH 7/7] spl: nand: sunxi: add support for NAND config auto-detection

2016-05-20 Thread Boris Brezillon
'trial and error' mechanism. With this new approach we can get rid of the fixed config list that was used in the sunxi NAND SPL driver. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand_spl.c | 262 +- 1 file c

[linux-sunxi] [PATCH 4/7] spl: nand: sunxi: stop guessing the redundant u-boot offset

2016-05-20 Thread Boris Brezillon
Use CONFIG_SPL_NAND_U_BOOT_OFFS_REDUND value instead of trying to guess where the redundant u-boot image is based on simple (and most of the time erroneous) heuristics. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand_spl.

[linux-sunxi] [PATCH 3/7] spl: nand: support redundant u-boot image

2016-05-20 Thread Boris Brezillon
to specify the offset of the redundant u-boot image. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- common/spl/spl_nand.c| 8 drivers/mtd/nand/Kconfig | 6 ++ 2 files changed, 14 insertions(+) diff --git a/common/spl/spl_nand.c b/common/spl/spl_

[linux-sunxi] [PATCH 6/7] spl: nand: sunxi: split 'load page' and 'read page' logic

2016-05-20 Thread Boris Brezillon
values in NFC registers each time we read a page. These new functions are passed a pointer to an nfc_config struct to limit the number of parameters. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/mtd/nand/sunxi_nand_spl.c

[linux-sunxi] [PATCH 2/7] spl: nand: rename the SYS_NAND_U_BOOT_OFFS Kconfig option

2016-05-20 Thread Boris Brezillon
selection. common/spl/spl_nand.c now sets CONFIG_SYS_NAND_U_BOOT_OFFS to CONFIG_SPL_NAND_U_BOOT_OFFS only when it's undefined. This way we stay compatible with the existing behavior. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- common/spl/spl_nand.c

[linux-sunxi] Re: [U-Boot] Porting Linux's MTD/NAND changes into U-Boot

2016-05-16 Thread Boris Brezillon
Hi Scott, On Tue, 03 May 2016 00:06:45 -0500 Scott Wood <o...@buserror.net> wrote: > On Mon, 2016-04-25 at 22:53 +0200, Boris Brezillon wrote: > > On Mon, 25 Apr 2016 13:36:46 -0400 > > Tom Rini <tr...@konsulko.com> wrote: > > > > > On Mon, Apr 25,

[linux-sunxi] Re: [U-Boot] Porting Linux's MTD/NAND changes into U-Boot

2016-05-03 Thread Boris Brezillon
Hi Scott, On Tue, 03 May 2016 00:06:45 -0500 Scott Wood <o...@buserror.net> wrote: > On Mon, 2016-04-25 at 22:53 +0200, Boris Brezillon wrote: > > On Mon, 25 Apr 2016 13:36:46 -0400 > > Tom Rini <tr...@konsulko.com> wrote: > > > > > On Mon, Apr 25,

[linux-sunxi] Re: [PATCH v4 09/11] drm: sun4i: tv: Add NTSC output standard

2016-04-26 Thread Boris Brezillon
On Mon, 25 Apr 2016 15:22:50 +0200 Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Add the settings to support the NTSC standard. > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.co

[linux-sunxi] Re: [PATCH v4 08/11] drm: sun4i: tv: Add PAL output standard

2016-04-26 Thread Boris Brezillon
lt;maxime.rip...@free-electrons.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/sun4i/sun4i_tv.c | 42 > > 1 file changed, 42 insertions(+) > > diff --git a/drivers/gpu/drm/sun4i/

[linux-sunxi] Re: [PATCH v4 07/11] drm: sun4i: Add composite output

2016-04-26 Thread Boris Brezillon
t for that TV encoder. > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/sun4i/Makefile | 2 + > drivers/gpu/drm/sun4i/sun4i_tv.c | 621 >

[linux-sunxi] Re: [PATCH v4 06/11] drm: sun4i: Add RGB output

2016-04-26 Thread Boris Brezillon
ignals directly. > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/gpu/drm/sun4i/Makefile | 1 + > drivers/gpu/drm/sun4i/sun4i_drv.c | 24 &

[linux-sunxi] Re: [PATCH v4 05/11] drm: Add Allwinner A10 Display Engine support

2016-04-26 Thread Boris Brezillon
(HDMI, TV, VGA) or not. > > Add a driver with a limited set of features for now, and we will hopefully > support all of them eventually > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> Just 2 comments below. Once addressed you can add my Reviewed-by: B

[linux-sunxi] Re: [U-Boot] Porting Linux's MTD/NAND changes into U-Boot

2016-04-25 Thread Boris Brezillon
On Mon, 25 Apr 2016 13:36:46 -0400 Tom Rini <tr...@konsulko.com> wrote: > On Mon, Apr 25, 2016 at 04:43:14PM +0200, Boris Brezillon wrote: > > > Hi Scott, > > > > I've recently contributed a lot of MTD/NAND related patches (and intend > > to continue doi

[linux-sunxi] Porting Linux's MTD/NAND changes into U-Boot

2016-04-25 Thread Boris Brezillon
ther people are also working on merging the BBT code of the NAND and OneNAND framework. Which unfortunately means that we're not done porting invasive changes to U-Boot :-/. Any advice is welcome. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http:

  1   2   3   4   5   6   7   8   9   10   >