Re: [PATCH net-next 0/3] trace: use TP_STORE_ADDRS macro

2024-03-25 Thread Jason Xing
On Mon, Mar 25, 2024 at 11:43 AM Jason Xing wrote: > > From: Jason Xing > > Using the macro for other tracepoints use to be more concise. > No functional change. > > Jason Xing (3): > trace: move to TP_STORE_ADDRS related macro to net_probe_common.h > trace: use TP_STORE_ADDRS() macro in

Re: [PATCH net-next v2 0/3] tcp: make trace of reset logic complete

2024-03-25 Thread Jason Xing
On Tue, Mar 26, 2024 at 10:23 AM Jakub Kicinski wrote: > > On Tue, 26 Mar 2024 10:13:55 +0800 Jason Xing wrote: > > Yesterday, I posted two series to do two kinds of things. They are not > > the same. Maybe you get me wrong :S > > Ah, my bad, sorry about that. I see that they are different now.

Re: [PATCH net-next v2 0/3] tcp: make trace of reset logic complete

2024-03-25 Thread Jakub Kicinski
On Tue, 26 Mar 2024 10:13:55 +0800 Jason Xing wrote: > Yesterday, I posted two series to do two kinds of things. They are not > the same. Maybe you get me wrong :S Ah, my bad, sorry about that. I see that they are different now. One is v1 the other v2, both targeting tcp tracing... Easy to miss

Re: [PATCH net-next v2 0/3] tcp: make trace of reset logic complete

2024-03-25 Thread Jason Xing
On Tue, Mar 26, 2024 at 9:30 AM Jakub Kicinski wrote: > > On Mon, 25 Mar 2024 14:28:28 +0800 Jason Xing wrote: > > Before this, we miss some cases where the TCP layer could send rst but > > we cannot trace it. So I decided to complete it :) > > > > v2 > > 1. fix spelling mistakes > > Not only do

Re: [PATCH net-next v2 0/3] tcp: make trace of reset logic complete

2024-03-25 Thread Jakub Kicinski
On Mon, 25 Mar 2024 14:28:28 +0800 Jason Xing wrote: > Before this, we miss some cases where the TCP layer could send rst but > we cannot trace it. So I decided to complete it :) > > v2 > 1. fix spelling mistakes Not only do you post it before we "officially" open net-next but also ignoring the

Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional

2024-03-25 Thread Steven Rostedt
On Mon, 25 Mar 2024 11:38:48 +0900 Masami Hiramatsu (Google) wrote: > On Fri, 22 Mar 2024 09:03:23 -0700 > Andrii Nakryiko wrote: > > > Introduce CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING config option to > > control whether ftrace low-level code performs additional > > rcu_is_watching()-based

Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional

2024-03-25 Thread Andrii Nakryiko
On Sun, Mar 24, 2024 at 7:38 PM Masami Hiramatsu wrote: > > On Fri, 22 Mar 2024 09:03:23 -0700 > Andrii Nakryiko wrote: > > > Introduce CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING config option to > > control whether ftrace low-level code performs additional > > rcu_is_watching()-based validation

[PATCH net-next v2 3/3] tcp: add location into reset trace process

2024-03-25 Thread Jason Xing
From: Jason Xing In addition to knowing the 4-tuple of the flow which generates RST, the reason why it does so is very important because we have some cases where the RST should be sent and have no clue which one exactly. Adding location of reset process can help us more, like what

[PATCH net-next v2 1/3] trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters

2024-03-25 Thread Jason Xing
From: Jason Xing Introducing entry_saddr and entry_daddr parameters in this macro for later use can help us record the reverse 4-tuple by analyzing the 4-tuple of the incoming skb when receiving. Signed-off-by: Jason Xing --- include/trace/events/tcp.h | 21 +++-- 1 file

[PATCH net-next 1/3] trace: move to TP_STORE_ADDRS related macro to net_probe_common.h

2024-03-25 Thread Jason Xing
From: Jason Xing Put the macro into another standalone file for better extension. Some tracepoints can use this common part in the future. Signed-off-by: Jason Xing --- include/trace/events/net_probe_common.h | 29 + include/trace/events/tcp.h | 29

[PATCH net-next v2 2/3] trace: tcp: fully support trace_tcp_send_reset

2024-03-25 Thread Jason Xing
From: Jason Xing Prior to this patch, what we can see by enabling trace_tcp_send is only happening under two circumstances: 1) active rst mode 2) non-active rst mode and based on the full socket That means the inconsistency occurs if we use tcpdump and trace simultaneously to see how rst

[PATCH net-next v2 0/3] tcp: make trace of reset logic complete

2024-03-25 Thread Jason Xing
From: Jason Xing Before this, we miss some cases where the TCP layer could send rst but we cannot trace it. So I decided to complete it :) v2 1. fix spelling mistakes Jason Xing (3): trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters trace: tcp: fully support trace_tcp_send_reset tcp:

[PATCH net-next 2/3] trace: use TP_STORE_ADDRS() macro in inet_sk_error_report()

2024-03-25 Thread Jason Xing
From: Jason Xing As the title said, use the macro directly like the patch[1] did to avoid those duplications. No functional change. [1] commit 6a6b0b9914e7 ("tcp: Avoid preprocessor directives in tracepoint macro args") Signed-off-by: Jason Xing --- include/trace/events/sock.h | 18

[PATCH net-next 3/3] trace: use TP_STORE_ADDRS() macro in inet_sock_set_state()

2024-03-25 Thread Jason Xing
From: Jason Xing As the title said, use the macro directly like the patch[1] did to avoid those duplications. No functional change. [1] commit 6a6b0b9914e7 ("tcp: Avoid preprocessor directives in tracepoint macro args") Signed-off-by: Jason Xing --- include/trace/events/sock.h | 17

[PATCH net-next 0/3] trace: use TP_STORE_ADDRS macro

2024-03-25 Thread Jason Xing
From: Jason Xing Using the macro for other tracepoints use to be more concise. No functional change. Jason Xing (3): trace: move to TP_STORE_ADDRS related macro to net_probe_common.h trace: use TP_STORE_ADDRS() macro in inet_sk_error_report() trace: use TP_STORE_ADDRS() macro in

Re: [PATCH] ftrace: make extra rcu_is_watching() validation check optional

2024-03-25 Thread Google
On Fri, 22 Mar 2024 09:03:23 -0700 Andrii Nakryiko wrote: > Introduce CONFIG_FTRACE_VALIDATE_RCU_IS_WATCHING config option to > control whether ftrace low-level code performs additional > rcu_is_watching()-based validation logic in an attempt to catch noinstr > violations. > > This check is