Re: Linux USB file storage gadget with new UDC

2013-03-22 Thread Felipe Balbi
On Fri, Mar 22, 2013 at 10:36:57AM +0800, victor yeo wrote: Hi, First you have to figure out why it isn't working. What does the debugging information show? Here is some debugging information: receive GET_DESCRIPTOR, 80, 6 index 0 value 200 len 20 receive SET_CONFIGURATION, 0,

[PATCH 1/4] usb: gadget: mv_u3d: remove unused headers

2013-03-22 Thread Felipe Balbi
none of those headers are used by the driver, removing them still compiles fine. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/mv_u3d_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d_core.c b/drivers/usb/gadget/mv_u3d_core.c index

[PATCH 2/4] usb: gadget: mv_u3d: remove outdated selects

2013-03-22 Thread Felipe Balbi
USB_GADGET_{DUAL,SUPER}SPEED symbols have been removed by commit 85b8614 (usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED), for some reason mv_u3d_core was lost. Remove those selects now. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/Kconfig | 2 -- 1 file changed, 2

[PATCH 4/4] usb: gadget: mv_u3d: drop ARCH dependency

2013-03-22 Thread Felipe Balbi
this driver compiles fine everywhere which means we can use linux-next to compile it for us frequently. By dropping the arch dependency, we also ensure driver writers don't add virtual arch-depdencies to the driver by e.g. using the wrong headers. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH 3/4] usb: gadget: mv_u3d: fix sparse warnings

2013-03-22 Thread Felipe Balbi
Fix the following sparse warnings: drivers/usb/gadget/mv_u3d_core.c: In function ‘mv_u3d_ep_queue’: drivers/usb/gadget/mv_u3d_core.c:812:2: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] drivers/usb/gadget/mv_u3d_core.c:822:14: warning: cast from pointer to

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-22 Thread Roger Quadros
Hi Frank, On 03/22/2013 04:45 AM, Frank Rowand wrote: On 03/21/13 07:41, Alan Stern wrote: On Wed, 20 Mar 2013, Frank Rowand wrote: Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently fails to

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-22 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 March 2013 10:40 PM, Stephen Warren wrote: On 03/21/2013 12:23 AM, kishon wrote: Hi, On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote: On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding

[PATCH 0/4] Towards configfs - usb OBEX function conversion to the new interface

2013-03-22 Thread Andrzej Pietrasiewicz
This is a follow-up to this thread: http://www.spinics.net/lists/linux-usb/msg82418.html which is a prerequisite for applying the patches being sent here. I am creating a separate series because the above mentioned thread becomes very long. The prerequisite for providing the configfs interface

[PATCH 1/4] usb/gadget: f_obex: convert to new function interface with backward compatibility

2013-03-22 Thread Andrzej Pietrasiewicz
Converting f_obex to the new function interface requires converting the f_obex's function code and its users. This patch converts the f_obex.c to the new function interface. The file is now compiled into a separate usb_f_obex.ko module. The old function interface is provided by means of

[PATCH 4/4] usb/gadget: f_obex: remove compatibility layer

2013-03-22 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_obex.c | 54 --- 1 files

[PATCH 3/4] usb/gadget: nokia: convert to new interface of f_obex

2013-03-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/nokia.c | 110 +-- 2 files changed, 75 insertions(+), 36 deletions(-) diff --git

[PATCH 2/4] usb/gadget: serial: convert to new interface of f_obex

2013-03-22 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/serial.c | 42 +++--- 2 files changed, 4 insertions(+), 39 deletions(-) diff --git

Re: [PATCH 3/5] usb: chipidea: udc: add the define TD_COUNT and fix all users

2013-03-22 Thread Michael Grzeschik
On Thu, Mar 21, 2013 at 09:07:42AM +0800, Peter Chen wrote: On Wed, Mar 20, 2013 at 10:30:47AM +0100, Michael Grzeschik wrote: On Wed, Mar 20, 2013 at 09:17:06AM +0800, Peter Chen wrote: On Tue, Mar 19, 2013 at 01:02:59PM +0100, Michael Grzeschik wrote: On Tue, Mar 19, 2013 at 09:34:54AM

Re: [PATCH 07/14] usb: chipidea: udc: rework bailout of _hardware_dequeue

2013-03-22 Thread Michael Grzeschik
On Wed, Mar 20, 2013 at 11:26:46PM +0100, Michael Grzeschik wrote: Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/udc.c

Re: [PATCH 10/14] usb: chipidea: udc: fix buffer count of each TD

2013-03-22 Thread Michael Grzeschik
On Wed, Mar 20, 2013 at 11:26:49PM +0100, Michael Grzeschik wrote: Each TD can maintain five buffer pointers. Each of them is 4k aligned. There is no need to limit this to less then possible. This patch lowers the overhead of extra TDs. Signed-off-by: Michael Grzeschik

Re: [PATCH 12/14] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-03-22 Thread Michael Grzeschik
On Wed, Mar 20, 2013 at 11:26:51PM +0100, Michael Grzeschik wrote: The prepared memory for the qhead needs to be contiguos and 2K aligned. We change the code from allocating extra buffer for every ep qhead to one big area. This patch lowers the amount of code to prepare the memory.

Re: [PATCH v2 14/14] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-22 Thread Michael Grzeschik
On Wed, Mar 20, 2013 at 11:26:53PM +0100, Michael Grzeschik wrote: This patch removes the limitation of having a limited amount of only four active tds on one endpoint. We use the linked list implementation to manage all tds which get added and removed by hardware_{en,de}queue.

[PATCH 04/12] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-22 Thread Michael Grzeschik
Its not needed to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH 02/12] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-22 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 06/12] usb: chipidea: udc: configure iso endpoints

2013-03-22 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de --- Changes since v3: - added QH_ISO_TRANS macro -

[PATCH v2 10/12] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-03-22 Thread Michael Grzeschik
The prepared memory for the qhead needs to be contiguos and 2K aligned. We change the code from allocating extra buffer for every ep qhead to one big area. This patch lowers the amount of code to prepare the memory. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- Changes since

[PATCH 08/12] usb: chipidea: udc: use gfp_flags in _hardware_enqueue

2013-03-22 Thread Michael Grzeschik
The option gfp_flags is prepared in ep_queue and currently not used. This patch propagates the flag through all users down to the dma_pool_alloc function to consume it. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 10 +- 1 file changed, 5

[PATCH v2 11/12] usb: chipidea: udc: manage dynamic amount of tds with an linked list

2013-03-22 Thread Michael Grzeschik
Instead of having a limited number of usable tds in the udc we use a linked list to support dynamic amount of needed tds for all special gadget types. This improves throughput. This patch also adresses a possible momory leak in _ep_nuke found while porting the request handling to an linked list.

[PATCH v3 12/12] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-03-22 Thread Michael Grzeschik
This patch removes the limitation of having a limited amount of only four active tds on one endpoint. We use the linked list implementation to manage all tds which get added and removed by hardware_{en,de}queue. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- Changes since v2:

[PATCH v2 03/12] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-22 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- Changes since v1: - fixed patch description drivers/usb/chipidea/udc.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[PATCH 05/12] usb: chipidea: udc: rework ep_enable cap setting

2013-03-22 Thread Michael Grzeschik
This patch reworks the cap value from several read and write operations to one single operation. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH v2 07/12] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-22 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside

[PATCH 01/12] usb: chipidea: udc: use {read,write}l to handle mapped data

2013-03-22 Thread Michael Grzeschik
The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The packed attribute leads the compiler to generate one byte operations for addressing the mapped memory as it believes

[PATCH v2 09/12] usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-22 Thread Michael Grzeschik
A static count of transfer descriptors was used everywhere in the driver with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT, and replaces all users of this value. This way its possible to have only one parameter to change and limit the amount of buffer pointers per TD.

Re: [PATCH v4 06/12] usb: chipidea: udc: configure iso endpoints

2013-03-22 Thread Sergei Shtylyov
Hello. On 22-03-2013 17:20, Michael Grzeschik wrote: The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de ---

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-22 Thread Alan Stern
On Thu, 21 Mar 2013, Soeren Moch wrote: Hi Alan, Soeren Could you word the description a bit better. If Alan did not get it without a bit of thought, few others are going to understand it without a better explanation. Thanks Andrew Alan, can you come up with a better

[PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Felipe Balbi
fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2349:68: warning: Using plain integer as NULL pointer

[PATCH 2/6] usb: gadget: dummy: fix sparse warning

2013-03-22 Thread Felipe Balbi
fix the following sparse warning: drivers/usb/gadget/dummy_hcd.c:1912:12: warning: symbol 'usb3_bos_desc' was not declared. Should it be static? Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/dummy_hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/6] usb: gadget: pch_udc: fix sparse warnings

2013-03-22 Thread Felipe Balbi
fix the following sparse warnings: drivers/usb/gadget/pch_udc.c:1483:9: warning: context imbalance in 'complete_req' - unexpected unlock drivers/usb/gadget/pch_udc.c:2408:28: warning: context imbalance in 'pch_udc_svc_control_out' - unexpected unlock Signed-off-by: Felipe Balbi ba...@ti.com

Problems with the pl2303 USB-serial driver

2013-03-22 Thread Henrik Grindal Bakken
Hi. I work on a product which, sadly, is stuck on a vendor kernel based on 2.6.37. I use a usb-to-serial dongle which uses the pl2303 driver. I have a problem in that after some use (after a while of 'normal' use, and after up to a couple of minutes of quite intensive use), the driver stops

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Sergei Shtylyov
Hello. On 22-03-2013 19:15, Felipe Balbi wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2349:68:

[PATCH] USB: EHCI: fix bug in iTD/siTD DMA pool allocation

2013-03-22 Thread Alan Stern
From: Soeren Moch sm...@web.de [Description written by Alan Stern] Soeren tracked down a very difficult bug in ehci-hcd's DMA pool management of iTD and siTD structures. Some background: ehci-hcd gives each isochronous endpoint its own set of active and free itd's (or sitd's for full-speed

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Sergei Shtylyov
Hello. On 03/22/2013 06:52 PM, Felipe Balbi wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2349:68:

Re: Linux USB file storage gadget with new UDC

2013-03-22 Thread Alan Stern
On Fri, 22 Mar 2013, victor yeo wrote: you need to send the entire data, without editting. How are you accessing your plataform ? Do you have a serial console by any chance ? You can use tools such as minicom to capture all the information via serial console. I have a serial console

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Felipe Balbi
On Fri, Mar 22, 2013 at 08:22:27PM +0300, Sergei Shtylyov wrote: Hello. On 03/22/2013 06:52 PM, Felipe Balbi wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using

dwc2: Host channel not always released on dequeue

2013-03-22 Thread Matthijs Kooijman
Hi folks, I've been trying to get the dwc2 driver running on a Ralink RT3052 board, with success (I'm still cleaning up the platform bindings and I want to see if they work for the raspberry pi as well, but my latest patches are here if you're interested:

Help with analysing an USB problem with Garmin nuvi and VirtualBox

2013-03-22 Thread Roger James
Hi, I apologize if this is slightly OT, but I am in need of help from some USB gurus. I am trying to analyse a problem with (my) Garmin nuvi GPS units attached to an Ubuntu 12.04 system running Windows (both XP and Windows 8 exhibit the same problem) inside VirtualBox. The unit should

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Greg KH
On Fri, Mar 22, 2013 at 08:22:27PM +0300, Sergei Shtylyov wrote: Did you run the patch thru checkpatch.pl or did you intentionally leave spaces between function/macro names and (? patch was written to fix the sparse warning, not the checkpatch errors which are all over this driver. Fixing

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-22 Thread Michael Grzeschik
On Thu, Mar 07, 2013 at 11:54:03PM +0100, Michael Grzeschik wrote: Hey Alex, On Thu, Jan 24, 2013 at 11:42:53AM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote: Nearly every SoC from

[PATCH 7/11 resend] USB: EHCI: split needs_rescan into two flags

2013-03-22 Thread Alan Stern
This patch (as1662) does some more QH-related cleanup in ehci-hcd. The qh-needs_rescan flag is currently used for two different purposes; the patch replaces it with two separate flags for greater clarity: qh-dequeue_during_giveback indicates that a completion handler dequeued an URB (implying that

[PATCH 9/11 resend] USB: EHCI: convert singly-linked lists to list_heads

2013-03-22 Thread Alan Stern
This patch (as1664) converts ehci-hcd's async_unlink, async_iaa, and intr_unlink from singly-linked lists to standard doubly-linked list_heads. Originally it didn't seem necessary to use list_heads, because items are always added to and removed from these lists in FIFO order. But now with more

[PATCH 11/11 resend] USB: EHCI: remove unused variable in unlink_empty_async()

2013-03-22 Thread Alan Stern
This patch (as1669) removes the check_unlinks_later flag in ehci-hcd's unlink_empty_async(). It wasn't being used for anything and should have been removed in an earlier patch, but I forgot about it. Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-q.c |5

USB port power-off and system suspend

2013-03-22 Thread Alan Stern
Tianyu: Did you ever test the port power-off mechanism with system suspend? Right now it doesn't seem like it would work, because it relies on runtime PM to turn off the port power, and runtime PM doesn't operate normally during a system suspend. Alan Stern -- To unsubscribe from this list:

[PATCH 5/11 resend] USB: EHCI: changes related to qh_refresh()

2013-03-22 Thread Alan Stern
This patch (as1638) makes several changes to the ehci-hcd driver, all related to the qh_refresh() function. This function must be called whenever an idle QH gets linked back into either the async or the periodic schedule. Change a BUG_ON() in the qh_update routine to a WARN_ON().

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-22 Thread Tony Camuso
On 03/14/2013 05:42 PM, Alexis R. Cortes wrote: Hi Sarah, On 3/11/2013 5:20 PM, Sarah Sharp wrote: On Mon, Mar 11, 2013 at 05:33:26PM +, Cortes, Alexis wrote: Hi Sarah, Sorry for my delayed response, I was investigating this. By 'Inactive' state you mean the Compliance mode? since

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Sergei Shtylyov
Hello. On 03/22/2013 07:58 PM, Felipe Balbi wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2349:68:

[GIT PATCH] USB fixes for 3.9-rc3

2013-03-22 Thread Greg KH
The following changes since commit 1d9d8639c063caf6efc2447f5f26aa637f844ff6: perf,x86: fix kernel crash with PEBS/BTS after suspend/resume (2013-03-15 09:26:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.9-rc3 for

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Michal Nazarewicz
On Fri, Mar 22 2013, Felipe Balbi wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2349:68: warning:

Re: [PATCH 2/6] usb: gadget: dummy: fix sparse warning

2013-03-22 Thread Michal Nazarewicz
On Fri, Mar 22 2013, Felipe Balbi wrote: fix the following sparse warning: drivers/usb/gadget/dummy_hcd.c:1912:12: warning: symbol 'usb3_bos_desc' was not declared. Should it be static? Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Michal Nazarewicz min...@mina86.com ---

Re: [BUG] bisected: PandaBoard smsc95xx ethernet driver error from USB timeout

2013-03-22 Thread Frank Rowand
On 03/22/13 03:03, Mats Liljegren wrote: Frank Rowand wrote: On 03/21/13 07:41, Alan Stern wrote: On Wed, 20 Mar 2013, Frank Rowand wrote: Hi All, Not quite sure quite where the problem is (USB, OMAP, smsc95xx driver, other???), so casting the nets wide... The PandaBoard frequently

RE: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-22 Thread Cortes, Alexis
Hi Tony, Well, considering the circumstances, the only issue I see here is that the system won't be able to wake on a device connect if the port to which the device was connected enters in compliance mode (I might add that compliance mode is not a 100% of the times failure), however I haven't

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-22 Thread Tony Camuso
On 03/22/2013 02:33 PM, Cortes, Alexis wrote: Hi Tony, Well, considering the circumstances, the only issue I see here is that the system won't be able to wake on a device connect if the port to which the device was connected enters in compliance mode (I might add that compliance mode is not

RE: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-22 Thread Cortes, Alexis
I will prefer to leave this question to Sarah. Best Regards, Alexis Cortes. -Original Message- From: Tony Camuso [mailto:tcam...@redhat.com] Sent: Friday, March 22, 2013 12:58 PM To: Cortes, Alexis Cc: Sarah Sharp; Alan Stern; linux-usb@vger.kernel.org; r...@sisk.pl;

Re: [PATCH 1/6] usb: gadget: net2280: fix sparse warnings

2013-03-22 Thread Felipe Balbi
Hi, On Fri, Mar 22, 2013 at 09:59:11PM +0300, Sergei Shtylyov wrote: fix the following sparse warnings: drivers/usb/gadget/net2280.c:2063:13: warning: Using plain integer as NULL pointer drivers/usb/gadget/net2280.c:2321:68: warning: Using plain integer as NULL pointer

Re: Help with analysing an USB problem with Garmin nuvi and VirtualBox

2013-03-22 Thread Alan Stern
On Fri, 22 Mar 2013, Alan Stern wrote: On Fri, 22 Mar 2013, Roger James wrote: Hi, I apologize if this is slightly OT, but I am in need of help from some USB gurus. I am trying to analyse a problem with (my) Garmin nuvi GPS units attached to an Ubuntu 12.04 system running Windows

Re: Help with analysing an USB problem with Garmin nuvi and VirtualBox

2013-03-22 Thread Roger James
On 22/03/13 19:59, Alan Stern wrote: On Fri, 22 Mar 2013, Alan Stern wrote: On Fri, 22 Mar 2013, Roger James wrote: Hi, I apologize if this is slightly OT, but I am in need of help from some USB gurus. I am trying to analyse a problem with (my) Garmin nuvi GPS units attached to an Ubuntu

Re: Help with analysing an USB problem with Garmin nuvi and VirtualBox

2013-03-22 Thread Alan Stern
On Fri, 22 Mar 2013, Roger James wrote: Sorry Alan, My bad. I stuck a binary file on pastebin by mistake. It is a binary wireshark trace (I think that is pcap). Here it is via dropbox https://dl.dropbox.com/u/84613021/wireshark.log I will make a pair of host linux and a guest

Re: Help with analysing an USB problem with Garmin nuvi and VirtualBox

2013-03-22 Thread Roger James
On 22/03/13 21:31, Alan Stern wrote: On Fri, 22 Mar 2013, Roger James wrote: Sorry Alan, My bad. I stuck a binary file on pastebin by mistake. It is a binary wireshark trace (I think that is pcap). Here it is via dropbox https://dl.dropbox.com/u/84613021/wireshark.log I will make a pair

[PATCH] staging: dwc2: fix wrong setting of DMA masks

2013-03-22 Thread Paul Zimmerman
We were setting the DMA masks in dwc2_driver_probe(), but that is before the driver parameters have been set to their default values. That meant the DMA masks could be set wrong. Fix it by moving the DMA mask setting into dwc2_hcd_init(), after the driver parameters have been set. This required a

[PATCH] staging: dwc2: always release host channel after dequeueing

2013-03-22 Thread Paul Zimmerman
Previously, when an active urb was dequeued, its host channel would not always be released. There is some special handling for this in dwc2_hc_chhltd_intr_dma, but when it was the last urb/qtd in its qh, a safeguard in dwc2_hc_n_intr would short-circuit and prevent the regular interrupt handlers