Re: Linux USB file storage gadget with new UDC

2013-03-28 Thread victor yeo
Hi, Here is the gadget log when receiving SCSI_READ_10 from Linux host. g_file_storage gadget: bulk-out, length 31: : 55 53 42 43 0f 00 00 00 00 10 00 00 80 00 0a 28 0010: 00 00 00 00 00 00 00 08 00 00 00 00 e0 f8 02 SCSI CDB: 28 00 00 00 00 00 00 00 08 00 g_file_storage

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent Hi Ravi, On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: Hi I am observing issue while streaming video from usb camera connected to host controller based on mentor graphics. The issue is root caused that there are huge SOF gaps seen between the two

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: On Wed, Mar 27, 2013 at 10:24:04PM +0200, Alexander Shishkin wrote: Michael Grzeschik m...@pengutronix.de writes: On Wed, Mar 27, 2013 at 06:35:30PM +0200, Alexander Shishkin wrote: Michael Grzeschik m.grzesc...@pengutronix.de writes:

Re: [PATCH v8 1/8] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The compiler currently does not know about the alignment of the

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Laurent Pinchart
Hi Ravi, On Thursday 28 March 2013 06:48:09 B, Ravi wrote: On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: Hi I am observing issue while streaming video from usb camera connected to host controller based on mentor graphics. The issue is root caused that there are huge SOF gaps

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent On Thursday 28 March 2013 06:48:09 B, Ravi wrote: On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: Hi I am observing issue while streaming video from usb camera connected to host controller based on mentor graphics. The issue is root caused that there are huge SOF

Re: [PATCH v5 06/12] usb: chipidea: udc: configure iso endpoints

2013-03-28 Thread Peter Chen
On Tue, Mar 26, 2013 at 07:49:07PM +0200, Felipe Balbi wrote: Hi, On Tue, Mar 26, 2013 at 05:58:42PM +0100, Michael Grzeschik wrote: The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik

Re: [PATCH V5 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
Hi Bhupesh, Thanks for the patch. We're almost there :-) On Thursday 28 March 2013 10:39:13 Bhupesh Sharma wrote: This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer management. To

RE: [PATCH V5 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Bhupesh SHARMA
Hi Laurent, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Thursday, March 28, 2013 2:35 PM To: Bhupesh SHARMA Cc: linux-usb@vger.kernel.org; ba...@ti.com; bhupesh.li...@gmail.com; m...@pengutronix.de; gang.c...@asianux.com;

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-28 Thread Felipe Balbi
On Thu, Mar 28, 2013 at 08:55:07AM +0200, Alexander Shishkin wrote: Agreed. What about the multi-td patch and the rest? Are you going to resend them still? I will clean up this series first and add the following patch to it: usb: chipidea: udc: prepare qhead with dma_alloc_coherent

Re: Renesas sparse errors

2013-03-28 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 11:18:11AM +0200, Felipe Balbi wrote: Hi, On Wed, Mar 27, 2013 at 06:21:19PM -0700, Kuninori Morimoto wrote: linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types)

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Alexander Shishkin
Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. Fix cases where the little-endian memory layout is taken for granted. The patch doesn't have any effect on

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Matthijs Kooijman
Hi Paul, Overall this seems to be an improvement, so I have no objections. There is a pretty high likelihood of something getting broken in the translation, however. For example, this: + hw-host_nperio_tx_fifo_size = (readl(hsotg-regs + GNPTXFSIZ) GNPTXFSIZ_NP_TXF_DEP_MASK)

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-28 Thread Michael Grzeschik
On Thu, Mar 28, 2013 at 11:12:51AM +0200, Felipe Balbi wrote: On Thu, Mar 28, 2013 at 08:55:07AM +0200, Alexander Shishkin wrote: Agreed. What about the multi-td patch and the rest? Are you going to resend them still? I will clean up this series first and add the following patch to

[PATCH V6 0/2] UVC webcam gadget related changes

2013-03-28 Thread Bhupesh Sharma
This patchset tries to enhance the UVC webcam gadget driver and is based on Laurent's git tree available here (head uvc-gadget): git://linuxtv.org/pinchartl/uvcvideo.git Note that to ease review and integration of these patches, I have rebased them on Laurent's repo and all the relevant patches

[PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Bhupesh Sharma
This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer management. To support routing video data captured from a real V4L2 video capture device with a zero copy operation on videobuffers (as they

[PATCH V6 2/2] usb: gadget/uvc: Add support for 'get_unmapped_area' for MMUless architectures

2013-03-28 Thread Bhupesh Sharma
This patch adds the support for 'get_unmapped_area' in UVC gadget which is called when the 'mmap' system call is executed on MMUless architectures. Signed-off-by: Bhupesh Sharma bhupesh.sha...@st.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/usb/gadget/uvc_queue.c

Re: [PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
Hi Bhupesh, Thanks for the patch. On Thursday 28 March 2013 15:11:52 Bhupesh Sharma wrote: This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer management. To support routing video data

Re: [PATCH v8 7/8] usb: chipidea: udc: fix possible memory leak in _ep_nuke

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: In hardware_enqueue code adds one extra td with dma_pool_alloc if mReq-req.zero is true. When _ep_nuke will be called for that endpoint, dma_pool_free will not be called to free that memory again. That patch fixes this. Okay, drop the

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: On Thu, Mar 28, 2013 at 11:12:51AM +0200, Felipe Balbi wrote: On Thu, Mar 28, 2013 at 08:55:07AM +0200, Alexander Shishkin wrote: Agreed. What about the multi-td patch and the rest? Are you going to resend them still? I will clean up

[PATCH 0/9] Equivalent of g_serial.ko with configfs

2013-03-28 Thread Andrzej Pietrasiewicz
Dear All, I have changed the way of aiming at a configurable configfs-based gadget. After Sebastian has laid the foundation for the conversion I thought of doing the conversion to configfs like this: 1) convert the functions to the new function interface from Sebastian, 2) add configfs support.

[PATCH 6/9] usb/gadget: f_serial: add configfs support

2013-03-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_serial.c | 55 + 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/f_serial.c

[PATCH 5/9] usb/gadget: f_serial: remove compatibility layer

2013-03-28 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_serial.c | 46 - 1 files

[PATCH 4/9] usb/gadget: serial: convert to new interface of f_serial

2013-03-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/serial.c | 25 +++-- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git

[PATCH 8/9] usb/gadget: serial: convert to new interface of f_obex

2013-03-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/serial.c | 42 +++--- 2 files changed, 4 insertions(+), 39 deletions(-) diff --git

[PATCH 3/9] usb/gadget: f_serial: convert to new function interface with backward compatibility

2013-03-28 Thread Andrzej Pietrasiewicz
Converting f_serial to the new function interface requires converting the f_serial's function code and its users. This patch converts the f_serial.c to the new function interface. The file is now compiled into a separate usb_f_serial.ko module. The old function interface is provided by means of

[PATCH 9/9] usb/gadget: f_obex: add configfs support

2013-03-28 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_obex.c | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/f_obex.c

RE: [PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Bhupesh SHARMA
Hi Laurent, Hi Bhupesh, Thanks for the patch. On Thursday 28 March 2013 15:11:52 Bhupesh Sharma wrote: This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer management. To support

[PATCH v9 2/2] usb: chipidea: udc: fix memory leak in _ep_nuke

2013-03-28 Thread Michael Grzeschik
In hardware_enqueue code adds one extra td with dma_pool_alloc if mReq-req.zero is true. When _ep_nuke will be called for that endpoint, dma_pool_free will not be called to free that memory again. That patch fixes this. Cc: stable sta...@vger.kernel.org # v3.5 Signed-off-by: Michael Grzeschik

[PATCH v9 0/2] usb: chipidea: udc: bugfixes

2013-03-28 Thread Michael Grzeschik
Hi, this series solves some memroy issues with the chipidea udc The series is based on v3.9-rc4. Thanks, Michael Michael Grzeschik (2): usb: chipidea: udc: fix memory access of shared memory on armv5 machines usb: chipidea: udc: fix memory leak in _ep_nuke drivers/usb/chipidea/udc.c | 8

[PATCH v9 1/2] usb: chipidea: udc: fix memory access of shared memory on armv5 machines

2013-03-28 Thread Michael Grzeschik
The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The compiler currently does not know about the alignment of the memory layout, and will create strb and ldrb operations.

Re: [PATCH V6 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-28 Thread Laurent Pinchart
Hi Bhupesh, On Thursday 28 March 2013 18:39:54 Bhupesh SHARMA wrote: On Thursday 28 March 2013 15:11:52 Bhupesh Sharma wrote: This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the more apt videobuf2 framework for video buffer

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Alexander Shishkin
Felipe Balbi ba...@ti.com writes: Hi, On Fri, Mar 08, 2013 at 10:55:46PM +0200, Alexander Shishkin wrote: + dr_mode = ci-platdata-dr_mode; + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == USB_DR_MODE_DUAL_ROLE) + dr_mode = USB_DR_MODE_OTG; + /*

Re: [PATCH 2/5] USB chipidea: add PTW and PTS handling

2013-03-28 Thread Alexander Shishkin
Marc Kleine-Budde m...@pengutronix.de writes: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to configure the PTW and PTS bits inside the portsc register for host and device mode before the driver starts and the phy can be addressed as hardware implementation

Re: [PATCH v9 0/2] usb: chipidea: udc: bugfixes

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m.grzesc...@pengutronix.de writes: Hi, this series solves some memroy issues with the chipidea udc The series is based on v3.9-rc4. Looks good. Thanks, -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 01:13:00PM +0200, Alexander Shishkin wrote: + dr_mode = ci-platdata-dr_mode; + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == USB_DR_MODE_DUAL_ROLE) + dr_mode = USB_DR_MODE_OTG; + /* initialize role(s) before the interrupt

[PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-03-28 Thread Laurent Pinchart
The camera fails to start video streaming after having been autosuspend. Add a new quirk to selectively disable autosuspend for devices that don't support it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/usb/uvc/uvc_driver.c | 14 +-

Re: [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver

2013-03-28 Thread Alexander Shishkin
Svetoslav Neykov svetos...@neykov.name writes: Support host and device usb modes for the chipidea controller in AR933x. Changes since last version of the patch: * conditionally include ci13xxx_ar933x.c for compilation * removed __devinit/__devexit/__devexit_p() * use a

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent Some more debugging, Most of the time spend in stream-decode() function That points to uvc_video_decode_isoc(). You are correct, that points to uvc_video_decode_isoc() in uvc_video_complete() callback handler. It's not very surprising, but doesn't tell where the

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Ming Lei
On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi ravib...@ti.com wrote: For example, in one iteration I have observed, the time taken by uvc_video_decode_isoc() was 2175 usec. In this maximum amount of time was consumed by uvc_video_decode_data() around 1792 usec. uvc_video_decode_data() is

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Alexander Shishkin
Felipe Balbi ba...@ti.com writes: Hi, Hi, On Thu, Mar 28, 2013 at 01:13:00PM +0200, Alexander Shishkin wrote: + dr_mode = ci-platdata-dr_mode; + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == USB_DR_MODE_DUAL_ROLE) + dr_mode = USB_DR_MODE_OTG; +

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi ravib...@ti.com wrote: For example, in one iteration I have observed, the time taken by uvc_video_decode_isoc() was 2175 usec. In this maximum amount of time was consumed by

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread Felipe Balbi
On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote: Hi, On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi ravib...@ti.com wrote: For example, in one iteration I have observed, the time taken by uvc_video_decode_isoc() was

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/28 2:45, Alan Stern wrote: +int usb_hub_port_power_reset(struct usb_device *hdev, int port1) +{ + struct usb_hub *hub = usb_hub_to_struct_hub(hdev); + struct usb_interface *intf = to_usb_interface(hub-intfdev); + int ret; + + usb_autopm_get_interface(intf);

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-28 Thread Ruslan Bilovol
Hi Felipe, On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: MUSB controller cannot work in DMA mode with misaligned buffers, switching in PIO mode. HCD core has hooks that allow to override the default DMA

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-28 Thread Felipe Balbi
On Thu, Mar 28, 2013 at 03:44:50PM +0200, Ruslan Bilovol wrote: Hi Felipe, On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: MUSB controller cannot work in DMA mode with misaligned buffers, switching

Re: xhci page fault panic on Ubuntu kernel with HP desktop hardware

2013-03-28 Thread Yann Sionneau
Le 27/03/2013 23:40, Sarah Sharp a écrit : On Wed, Mar 27, 2013 at 02:24:24PM +0100, Yann Sionneau wrote: Le 26/03/2013 17:30, Sarah Sharp a écrit : On Tue, Mar 26, 2013 at 12:11:13PM +0100, Yann Sionneau wrote: Le 25/03/2013 19:13, Sarah Sharp a écrit : On Mon, Mar 25, 2013 at 05:43:40PM

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Michael Grzeschik
On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. Fix cases where the little-endian

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Marc Kleine-Budde
On 03/28/2013 10:28 AM, Alexander Shishkin wrote: Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. Fix cases where the little-endian memory layout is

Re: 3.8.4: ohci question

2013-03-28 Thread Alan Stern
On Wed, 27 Mar 2013, Bjorn Helgaas wrote: [+cc linux-usb] On Wed, Mar 27, 2013 at 11:37 AM, Udo van den Heuvel udo...@xs4all.nl wrote: Hello, When my dmesg gives me a growing number of lines like the one below, what is going on? ohci_hcd :00:12.0: urb 88023025c500 path 2

Re: [PATCH V2 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Chao Xie wrote: hi, Alan This is the patch for EHCI clock fix. Can you help to review and ack it? Thanks. On Mon, Mar 25, 2013 at 3:06 PM, Chao Xie chao@marvell.com wrote: The origianl understanding of clock is wrong. The EHCI controller only have one clock

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Wed, 2013-03-27 at 16:13 -0700, Greg KH wrote: On Wed, Mar 27, 2013 at 09:28:11PM +0100, Wesley W. Terpstra wrote: On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: Our current prototypes borrow the Sierra VID And the USB-IF might revoke your vendor id, if they find you shipping a

Re: Linux USB file storage gadget with new UDC

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, victor yeo wrote: There is a problem with SCSI_READ_10 command if looking at usbmon. I pasted the usbmon log that starts from SCSI_READ_10. Basically, the SCSI_READ_10 was received by gadget, processed, sent CSW, followed by control packets. Then another SCSI_READ_10,

Re: [PATCH/RFC] uvcvideo: Disable USB autosuspend for Creative Live! Cam Optia AF

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Laurent Pinchart wrote: The camera fails to start video streaming after having been autosuspend. Add a new quirk to selectively disable autosuspend for devices that don't support it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: How long do you think the power should remain turned off? This code will leave it off for only a few milliseconds at most. That may not even be long enough for the voltage to drop all the way to 0. The delay probably should be at least 100 ms.

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Wesley W. Terpstra
On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: Greg's right, there's no reason not to use cdc-acm if you want to do that, since not all cdc-acm devices are modems. If you get a USBIF vendor ID, then I'll happily add your device to the ModemManager probing blacklist too. Yes, the

[PATCH] usb: ftdi_sio: Add support for Mitsubishi FX-USB-AW/-BD

2013-03-28 Thread Konstantin Holoborodko
It enhances the driver for FTDI-based USB serial adapters to recognize Mitsubishi Electric Corp. USB/RS422 Converters as FT232BM chips and support them. https://search.meau.com/?q=FX-USB-AW Signed-off-by: Konstantin Holoborodko klh.ker...@gmail.com Tested-by: Konstantin Holoborodko

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Thu, 2013-03-28 at 15:58 +0100, Wesley W. Terpstra wrote: On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: Greg's right, there's no reason not to use cdc-acm if you want to do that, since not all cdc-acm devices are modems. If you get a USBIF vendor ID, then I'll happily add your

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-03-28 Thread Stephen Warren
On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the diff --git a/Documentation/devicetree/bindings/phy/phy-bindings.txt

Re: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/28 22:46, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote: How long do you think the power should remain turned off? This code will leave it off for only a few milliseconds at most. That may not even be long enough for the voltage to drop all the way to 0. The delay

[PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-03-28 Thread Dan Williams
Some drivers (sierra_net) need the status interrupt URB active even when the device is closed, because they receive custom indications from firmware. Add functions to refcount the status interrupt URB submit/kill operation so that sub-drivers and the generic driver don't fight over whether the

[PATCH 2/2 v3] sierra_net: keep status interrupt URB active

2013-03-28 Thread Dan Williams
The driver and firmware sync up through SYNC messages, and the firmware's affirmative reply to these SYNC messages appears to be the Reset indication received via the status interrupt endpoint. Thus the driver needs the status interrupt endpoint always active so that the Reset indication can be

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Matthijs Kooijman
Hi Paul, while continuing this patch, I stumbled upon a bit of code which doesn't make sense to me. In dwc2_dump_global_registers is the following bit: if (hsotg-core_params-en_multiple_tx_fifo = 0) { ep_num = hsotg-hwcfg4 GHWCFG4_NUM_DEV_PERIO_IN_EP_SHIFT

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path usb: Add usb port system pm support, do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check for any PM_QOS constraints? Either on the port itself or on the child device. Alan Stern -- To unsubscribe from this

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 0:50, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path usb: Add usb port system pm support, do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check for any PM_QOS constraints? Either on the port itself or on the child device.

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-28 Thread David Linares
On 27 March 2013 20:00, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 27 Mar 2013, David Linares wrote: Please correct me if I am wrong. On my iMX25 board, I have got a 1-port root_hub which will provide 500mA max to its unique child. You should check that against the iMX25's specs.

[GIT PATCH] USB fixes for 3.9-rc4

2013-03-28 Thread Greg KH
The following changes since commit 8bb9660418e05bb1845ac1a2428444d78e322cc7: Linux 3.9-rc4 (2013-03-23 16:52:44 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.9-rc4 for you to fetch changes up to

Re: 3.8.4: ohci question

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Udo van den Heuvel wrote: On 2013-03-28 15:35, Alan Stern wrote: When my dmesg gives me a growing number of lines like the one below, what is going on? ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 -- status -71 Please let me know!

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: On 2013/3/29 0:50, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path usb: Add usb port system pm support, do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check for any PM_QOS constraints?

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 1:49, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: On 2013/3/29 0:50, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: About the path usb: Add usb port system pm support, do you think it's ok? Generally yes. But why doesn't usb_port_system_suspend check

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2 This patch is to register usb port to usb_bus_type. The usb port's original name is portX.

Re: [PATCH] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Greg KH
On Wed, Mar 27, 2013 at 04:13:36PM -0400, Alan Stern wrote: It seems to be getting more common recently for EHCI host controllers to be probed after their companion UHCI or OHCI controllers. This may be caused partly by splitting the ehci-pci driver out from ehci-hcd, or it may be caused by

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 02:17:02AM +0800, Lan Tianyu wrote: On 2013/3/29 1:59, Greg KH wrote: On Thu, Mar 28, 2013 at 01:11:04AM +0800, Lan Tianyu wrote: Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usbm=136200364929942w=2

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:21, Greg KH wrote: What does it look like if you reverse the naming scheme (hub dev name + port)? Doesn't that show the devices in a bit more logical way? Hi Greg: Do you mean e.g port1.2-1, originally it's port2-1.1. 2-1 is hub dev name? No, I mean 2-1.port1 as these

Re: [PATCH v4 0/6] Generic PHY Framework

2013-03-28 Thread David Miller
You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, David Linares wrote: Ok so here is what I did: - compiled all USB stuff as modules - boot up the device with nothing plugged in - Checked that lsmod | grep usb didn't return anything - modprobe usbmon (this will also load usbcore) - start the capture : cat

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4 port3-2 usb1 1-1:1.0

[PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h. Signed-off-by: David Howells dhowe...@redhat.com cc: Sarah Sharp sarah.a.sh...@linux.intel.com cc: Greg Kroah-Hartman gre...@linuxfoundation.org cc: linux-usb@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 16

[PATCH 1/2] xhci: Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT

2013-03-28 Thread David Howells
Use ilog2() rather than __ffs() for calculating SEGMENT_SHIFT as ilog2() can be worked out at compile time, whereas __ffs() must be calculated at runtime. Signed-off-by: David Howells dhowe...@redhat.com cc: Sarah Sharp sarah.a.sh...@linux.intel.com cc: Greg Kroah-Hartman

Re: [PATCH] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: On Wed, Mar 27, 2013 at 04:13:36PM -0400, Alan Stern wrote: It seems to be getting more common recently for EHCI host controllers to be probed after their companion UHCI or OHCI controllers. This may be caused partly by splitting the ehci-pci driver out

Re: [PATCH 2/2] USB: remove CONFIG_USB_SUSPEND option

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: On Wed, Mar 27, 2013 at 04:14:46PM -0400, Alan Stern wrote: This patch (as1675) removes the CONFIG_USB_SUSPEND option, essentially replacing it everywhere with CONFIG_PM_RUNTIME (except for one place in hub.c, where it is replaced with CONFIG_PM because

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:44, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1 port4-4 1-1.1 2-1:1.0 port1-1.2port1-1.5 port2-1.4

[PATCH refreshed] USB: improve port transitions when EHCI starts up

2013-03-28 Thread Alan Stern
It seems to be getting more common recently for EHCI host controllers to be probed after their companion UHCI or OHCI controllers. This may be caused partly by splitting the ehci-pci driver out from ehci-hcd, or it may be caused by changes in the way the kernel does driver probing. Regardless,

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Lan Tianyu
On 2013/3/29 2:53, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4 port2-1.3 port3-1

RE: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Paul Zimmerman
Whoops, resending as text instead of html. From: Matthijs Kooijman [mailto:matth...@stdin.nl] Sent: Thursday, March 28, 2013 9:32 AM Hi Paul, while continuing this patch, I stumbled upon a bit of code which doesn't make sense to me. In dwc2_dump_global_registers is the following bit:

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-12-1 port1-1.1port1-1.4

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-28 Thread Matthijs Kooijman
Hi Paul, If you look closely at the databook, you will see that DPTXFSIZn and DIEPTXFn are both aliases for the same register address. Ah, right. Remebmer I don't have the databook, only the register descriptions from the RT3052 datasheet, which are riddled with typos, so I had assumed the

[PATCH] USB: remove CONFIG_USB_SUSPEND from Documentation

2013-03-28 Thread Alan Stern
An earlier patch removed the CONFIG_USB_SUSPEND symbol but forgot to update the Documentation files. This patch (as1676) rectifies that omission. Signed-off-by: Alan Stern st...@rowland.harvard.edu --- Documentation/ABI/testing/sysfs-bus-usb |6 +++---

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Fri, 29 Mar 2013, Lan Tianyu wrote: Ok. I just refresh patch usb: introduce usb force power off mechanism Please have a look. From 16f5c7c6dd00830530a9ac758af25b575e0b8731 Mon Sep 17 00:00:00 2001 From: Lan Tianyu tianyu@intel.com Date: Tue, 26 Feb 2013 11:12:09 +0800 Subject:

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Lan Tianyu
On 2013/3/29 3:38, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: Ok. I just refresh patch usb: introduce usb force power off mechanism Please have a look. From 16f5c7c6dd00830530a9ac758af25b575e0b8731 Mon Sep 17 00:00:00 2001 From: Lan Tianyu tianyu@intel.com Date: Tue, 26

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
Hi Dave, I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI driver is built in? Or is there some other point I'm missing? Are these feature patches for 3.10, or bug fixes for

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: Some devices' firmware will be broken at some points. Power down and power on device can help device to rework in this case. This patch is to add ioctl cmd USBDEVFS_POWER_RESET for usbfs node to repower usb device. First, call

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Fri, Mar 29, 2013 at 03:51:50AM +0800, Lan Tianyu wrote: On 2013/3/29 3:38, Alan Stern wrote: On Fri, 29 Mar 2013, Lan Tianyu wrote: It looks okay. When you test it, does the attached device get detected and initialized properly? I test usb2.0 key on my machine. It works. Did you test

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 07:58:47AM +0800, Lan Tianyu wrote: On 2013/3/28 2:47, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote What happens if there's no device plugged in to the port, but the hub is enabled for remote wakeup? How will the hub be able to detect a plug-in event if the

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Alan Stern
On Thu, 28 Mar 2013, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: Some devices' firmware will be broken at some points. Power down and power on device can help device to rework in this case. This patch is to add ioctl cmd USBDEVFS_POWER_RESET for usbfs

[PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
Patch 4d053fdac3 usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Unfortunately that had the effect of introducing a new warning:

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Arnd Bergmann wrote: Patch 4d053fdac3 usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Hi Greg, Apparently the warning is now

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Tony Prisk
On 29/03/13 10:16, Arnd Bergmann wrote: On Thursday 28 March 2013, Arnd Bergmann wrote: Patch 4d053fdac3 usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Hi

  1   2   >