Re: [PATCH] Fix stack corruption on some architectures

2013-08-21 Thread David Miller
Please submit this with a more appropriate subject line. After '[PATCH] ' there should be a subsystem or driver name prefix, followed up a semicolon. Here it could be hso: , so something like: [PATCH] hso: Fix stack corruption on some architectures. -- To unsubscribe from this list: send the

Re: [PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-21 Thread Roger Quadros
On 08/20/2013 08:57 PM, Sergei Shtylyov wrote: Hello. On 08/20/2013 06:56 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the

Re: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-21 Thread Roger Quadros
Hi Thomas, On 08/20/2013 06:04 PM, thomas.lan...@lantiq.com wrote: Hello Roger, this will not work! Roger Quadros wrote on 2013-08-20: -struct omap_control_usb_platform_data *pdata = -dev_get_platdata(pdev-dev); + +if (np) { +

Re: [PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-21 Thread Oliver Neukum
On Fri, 2013-08-16 at 22:25 +0200, Yann Cantin wrote: +/* IRQ */ +static int ebeam_read_data(struct ebeam_device *ebeam, unsigned char *pkt) +{ + +/* + * Packet description : 8 bytes + * + * nop packet : FF FF FF FF FF FF FF FF + * + * pkt[0] : Sensors + * bit 1 : ultrasound signal

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Bjørn Mork
Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org

[PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-21 Thread Ming Lei
This patch introduces ehci_disable_event(), which is applied on IAA_WATCHDOG and START_UNLINK_INTR timeouts if the two corresponding events(IAA and intr URB submission) happened, so that we may avoid unnecessary CPU wakeup by canceling the timer. One simple test indicates about 7~8 timer

re: usb: musb: ux500: attempt to find channels by name before using pdata

2013-08-21 Thread Dan Carpenter
Hello Lee Jones, This is a semi-automatic email about new static checker warnings. The patch 2968da0b2c72: usb: musb: ux500: attempt to find channels by name before using pdata from May 15, 2013, leads to the following Smatch complaint: drivers/usb/musb/ux500_dma.c:335

[patch] usb: musb: unlock on error in cppi41_dma_callback()

2013-08-21 Thread Dan Carpenter
We need to unlock and enable IRQs before returning on error. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- I cannot compile this code. diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c index e64701d..5c42fc1 100644 --- a/drivers/usb/musb/musb_cppi41.c +++

[patch] usb: phy: signedness bugs in suspend/resume functions

2013-08-21 Thread Dan Carpenter
ret needs to be signed for the error handling to work. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- I can't compile this. diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c index 844ab68..d266861 100644 --- a/drivers/usb/phy/phy-omap-usb2.c +++

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not.

[patch] usb: gadget: double unlocks on error in atmel_usba_start()

2013-08-21 Thread Dan Carpenter
The goto out statements were wrong. We aren't holding any locks at that point so we should return directly. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- I can't compile this. diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index

[PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread Daniel Gimpelevich
There is no need to get an interface specification if we know it's the wrong one. Signed-off-by: Daniel Gimpelevich dan...@gimpelevich.san-francisco.ca.us --- drivers/net/usb/hso.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/hso.c

[PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread Daniel Gimpelevich
As Sergei Shtylyov explained in the #mipslinux IRC channel: [Mon 2013-08-19 12:28:21 PM PDT] headless guys, are you sure it's not DMA off stack case? [Mon 2013-08-19 12:28:35 PM PDT] headless it's a known stack corruptor on non-coherent arches [Mon 2013-08-19 12:31:48 PM PDT] DonkeyHotei

Re: [PATCH] Fix stack corruption on some architectures

2013-08-21 Thread Daniel Gimpelevich
On Tue, 2013-08-20 at 23:29 -0700, David Miller wrote: Please submit this with a more appropriate subject line. After '[PATCH] ' there should be a subsystem or driver name prefix, followed up a semicolon. Here it could be hso: , so something like: [PATCH] hso: Fix stack corruption on

Re: [PATCH] usb: musb dsps: fix pdev cast in suspend/resume

2013-08-21 Thread Daniel Mack
On 13.08.2013 14:40, Daniel Mack wrote: dsps_suspend() and dsps_resume() are called with the device that has the glue assigned as drvdata. Using dev-parent seems wrong and causes a NULL pointer exception on an AM33xx board. The code was introduced by commit c68bb4c6 (usb: musb: dsps: control

[PATCH] usb: ehci-mxc: check for pdata before dereferencing

2013-08-21 Thread Daniel Mack
Commit 7e8d5cd93fac (USB: Add EHCI support for MX27 and MX31 based boards) introduced code that could potentially lead to a NULL pointer dereference on driver removal. Fix this by checking for the value of pdata before dereferencing it. Signed-off-by: Daniel Mack zon...@gmail.com Reported-by:

Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-21 Thread Krzysztof Mazur
On Tue, Aug 20, 2013 at 03:50:37PM -0400, Alan Stern wrote: On Tue, 20 Aug 2013, Krzysztof Mazur wrote: On Tue, Aug 20, 2013 at 02:18:57PM -0400, Alan Stern wrote: On Tue, 20 Aug 2013, Krzysztof Mazur wrote: Ignoring usb_hub_create_port_device() errors cause later NULL pointer

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Jussi Kivilinna
On 21.08.2013 11:41, Brian Norris wrote: On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need

Re: usb: musb: ux500: attempt to find channels by name before using pdata

2013-08-21 Thread Lee Jones
333if (!ux500_channel-dma_chan) 334ux500_channel-dma_chan = 335 dma_request_channel(mask, 336

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
and the attachment file is the result of scripts/checkpatch.pl patch-commit-20130821 I'm sorry that I'm still finding the way to signed-off 3, Thanks again for your correct suggestion and Please check the new device driver patch

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
Dear Francois Romieu : 1, all the format problems have been fixed 2, sr9700.h registers definition is re-written 3, Thanks for your detail checking and I have beed scripts/checkpatch.pl the patch and please check it. [PATCH] : diff --git

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
Dear Joe : Thanks a lot and I have been fixed all the problems mentioned above. please check the following patch and thanks again. [PATCH] : diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 287cc62..a94b196 100644 --- a/drivers/net/usb/Kconfig +++

Re: USB gadget on mx6

2013-08-21 Thread Fabio Estevam
On Wed, Aug 21, 2013 at 12:46 AM, Peter Chen peter.c...@freescale.com wrote: Please compile g_ether as loadable module, not build-in. Thanks, it works if I build g_ether as module on mx6. mx28evk works fine if I build it as built-in though. Any ideas of why g_ether does not work if built-in

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Joe Perches
On Wed, 2013-08-21 at 18:07 +0800, liujunliang_ljl wrote: Thanks a lot and I have been fixed all the problems mentioned above. please check the following patch and thanks again. Just trivial comments below: diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c []

[PATCH] usb: musb: ux500: Add check for NULL board data

2013-08-21 Thread Lee Jones
Dan Carpenter's automatic Smatch checker found an anomaly in the ux500 MUSB driver, whereby board data was checked before use in all but one occasion. It is believed that it needs to be checked every time. Smatch complaint: drivers/usb/musb/ux500_dma.c:335 ux500_dma_controller_start()

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-21 Thread Ivan T. Ivanov
On Tue, 2013-08-20 at 18:01 +0100, Pawel Moll wrote: On Tue, 2013-08-20 at 16:06 +0100, Pawel Moll wrote: On Tue, 2013-08-20 at 16:01 +0100, Kumar Gala wrote: On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: Hi, On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote:

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change. In that case, the PCF8575 node needs to be a GPIO controller and an IRQ

[PATCH v5 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-21 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-21 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

[PATCH v5 0/3] DWC3 USB support for Qualcomm platform

2013-08-21 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Hi, Here is fifth version of MSM USB3 drivers patches. Changes since v4: * Substitute references to wc3 with just dw in USB PHY drivers and file names. This is to indicate that the PHY's are DesignWare, but not necessarily related to DWC3 IP core.

[PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-08-21 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-21 Thread Alan Stern
On Wed, 21 Aug 2013, Ming Lei wrote: This patch introduces ehci_disable_event(), which is applied on IAA_WATCHDOG and START_UNLINK_INTR timeouts if the two corresponding events(IAA and intr URB submission) happened, so that we may avoid unnecessary CPU wakeup by canceling the timer. One

Re: [PATCH 2/2] usb: fail on usb_hub_create_port_device() errors

2013-08-21 Thread Alan Stern
On Wed, 21 Aug 2013, Krzysztof Mazur wrote: We should never have maxchild bNbrPorts (unless maxchild is 0). But just in case we do, changing the code is a good idea. Besides, hub-maxchild is shorter and easier to read than hub-descriptor-bNbrPorts. :-) It's hub-hdev-maxchild,

[PATCH] USB: OHCI: add missing PCI PM callbacks to ohci-pci.c

2013-08-21 Thread Alan Stern
Commit c1117afb8589 (USB: OHCI: make ohci-pci a separate driver) neglected to preserve the entries for the pci_suspend and pci_resume driver callbacks. As a result, OHCI controllers don't work properly during suspend and after hibernation. This patch adds the missing callbacks to the driver.

[PATCH v3 5/5] arm: omap2plus_defconfig: enable dwc3 and dependencies

2013-08-21 Thread Kishon Vijay Abraham I
From: Felipe Balbi ba...@ti.com DWC3 enables USB3 functionality for OMAP5 boards, it's safe to enable those drivers in omap2plus_defconfig. Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com ---

[PATCH v3 1/5] arm: omap5: dts: fix reg property size

2013-08-21 Thread Kishon Vijay Abraham I
From: Felipe Balbi ba...@ti.com USB3 block has a 64KiB space, another 64KiB is used for the wrapper. Without this change, resource_size() will get confused and driver won't probe because size will be negative. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I

[PATCH v3 4/5] arm: omap5: hwmod: add missing ocp2scp hwmod data

2013-08-21 Thread Kishon Vijay Abraham I
From: Benoit Cousson bcous...@baylibre.com without that hwmod data, USB3 will not in OMAP5 boards. Signed-off-by: Benoit Cousson bcous...@baylibre.com Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c |

[PATCH v3 3/5] arm: omap5: dts: add palmas-usb node

2013-08-21 Thread Kishon Vijay Abraham I
From: Felipe Balbi ba...@ti.com Without this node, there will be no palmas driver to notify dwc3 that a cable has been connected and, without that, dwc3 will never initialize. [ kis...@ti.com: added dt properties for enabling vbus/id interrupts and fixed vbus-supply value after SMPS10 is modeled

[PATCH v3 0/5] ARM: OMAP: DTS/HWMOD/defconfig changes for USB3

2013-08-21 Thread Kishon Vijay Abraham I
From: Felipe Balbi ba...@ti.com With these patches (plus a few others on the driver side which will be going upstream soon) I could get functional USB3 with my omap5-uevm platform. Changes since v2: - added dt properties for enabling vbus/id interrupts and fixed vbus-supply value after

[PATCH v3 2/5] arm: omap5: dts: fix ocp2scp DTS data

2013-08-21 Thread Kishon Vijay Abraham I
From: Felipe Balbi ba...@ti.com this patch fixes the DTS data for ocp2scp node by adding the missing reg property. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- arch/arm/boot/dts/omap5.dtsi |3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-21 Thread Ming Lei
On Wed, Aug 21, 2013 at 10:23 PM, Alan Stern st...@rowland.harvard.edu wrote: Okay. You can add Acked-by: Alan Stern st...@rowland.harvard.edu and submit it as a version-2 patch. I think Greg will add the ack, so needn't v2. By the way, even though it's a little late to ask this... Why

Re: [PATCH v3 0/5] ARM: OMAP: DTS/HWMOD/defconfig changes for USB3

2013-08-21 Thread Benoit Cousson
Hi Kishon, On 21/08/2013 16:31, Kishon Vijay Abraham I wrote: From: Felipe Balbi ba...@ti.com With these patches (plus a few others on the driver side which will be going upstream soon) I could get functional USB3 with my omap5-uevm platform. Changes since v2: - added dt properties

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-21 Thread Alan Stern
On Tue, 20 Aug 2013, Kevin Archer wrote: Here are the registers for :00:1a.0 and :00:1d.0 prior to inserting any usb 2.0 device I have not included the after logs as there were no changes that occurred to the file(s) after a device was plugged in. Forget about the 1d.0 stuff; the

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-21 Thread Alan Stern
On Tue, 20 Aug 2013, Kevin Archer wrote: DMESG log from CONFIG_DUMMY_IRQ per your instructions [ 8561.353244] ath9k: ath9k: Driver unloaded [ 8627.529948] ehci-pci :00:1a.0: remove, state 1 [ 8627.529961] ehci-pci :00:1a.0: roothub graceful disconnect [ 8627.529973] usb usb1: USB

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-21 Thread Alan Stern
On Wed, 21 Aug 2013, Ming Lei wrote: By the way, even though it's a little late to ask this... Why did you decide to move only the giveback routine into a tasklet, instead of moving the entire interrupt handler? Looks below reasons in my mind before preparing the tasklet patch: 1,

[PATCH] xhci: fix port BESL LPM capability checking

2013-08-21 Thread Mathias Nyman
Wrong capability bit was checked for best effort service latency. bit 20 indicate port is BESL LPM capable (BLC), bit 19 is hardware LPM capable (HLC) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ext-caps.h |2 +- 1 files changed, 1 insertions(+), 1

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 06:06:02PM +0800, liujunliang_ljl wrote: Dear Francois Romieu : 1, all the format problems have been fixed 2, sr9700.h registers definition is re-written 3, Thanks for your detail checking and I have beed scripts/checkpatch.pl the patch

Re: [PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 01:43:19AM -0700, Daniel Gimpelevich wrote: As Sergei Shtylyov explained in the #mipslinux IRC channel: [Mon 2013-08-19 12:28:21 PM PDT] headless guys, are you sure it's not DMA off stack case? [Mon 2013-08-19 12:28:35 PM PDT] headless it's a known stack corruptor on

Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote: There is no need to get an interface specification if we know it's the wrong one. Signed-off-by: Daniel Gimpelevich dan...@gimpelevich.san-francisco.ca.us Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To

Re: [RFC PATCH v2 3/4] usb: xhci: add USB2 Link power management BESL support

2013-08-21 Thread Sarah Sharp
On Wed, Aug 21, 2013 at 03:44:35PM +0100, Steve Cotton wrote: Hi Mathias, Sorry for a very late respose, replying to a 3-month old patch. Something looks odd in a558ccdcc71c - AFAICS these two calls to xhci_check_usb2_port_capability will always return the same value, so

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread Stephen Warren
On 08/21/2013 07:06 AM, George Cherian wrote: Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin change. In that case, the

FT232H bandwidth

2013-08-21 Thread Simon Gornall
Hi there, I'm in the process of designing a VME=USB interface, and I wanted to use the FT232H, but according to FTDI, the throughput on Linux is only ~9MBytes/sec using current kernels. In the past, it was ~40MBytes/sec. Sadly my Arm board is delivered running Linux 3.4.29 I don't really want

Re: FT232H bandwidth

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 10:36:18AM -0700, Simon Gornall wrote: Hi there, I'm in the process of designing a VME=USB interface, and I wanted to use the FT232H, but according to FTDI, the throughput on Linux is only ~9MBytes/sec using current kernels. In the past, it was ~40MBytes/sec. Sadly

Re: FT232H bandwidth

2013-08-21 Thread Simon Gornall
On Aug 21, 2013, at 10:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Aug 21, 2013 at 10:36:18AM -0700, Simon Gornall wrote: Hi there, I'm in the process of designing a VME=USB interface, and I wanted to use the FT232H, but according to FTDI, the throughput on Linux is only

Re: FT232H bandwidth

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 10:53:32AM -0700, Simon Gornall wrote: On Aug 21, 2013, at 10:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Aug 21, 2013 at 10:36:18AM -0700, Simon Gornall wrote: Hi there, I'm in the process of designing a VME=USB interface, and I wanted to use

Re: FT232H bandwidth

2013-08-21 Thread Simon Gornall
On Aug 21, 2013, at 11:01 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Aug 21, 2013 at 10:53:32AM -0700, Simon Gornall wrote: On Aug 21, 2013, at 10:39 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Aug 21, 2013 at 10:36:18AM -0700, Simon Gornall wrote: Hi there, I'm

Re: FT232H bandwidth

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 11:07:49AM -0700, Simon Gornall wrote: I was hoping there was a we changed it because... reason. If you were unaware of the problem, I guess there's little you can do to fix it :) I'm not sure if this helps, but the driver they're talking about is the D2XX

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Sarah Sharp
Hi Julius, Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Sarah Sharp On Tue, Aug 20, 2013 at 04:21:49PM -0700, Julius Werner wrote:

[PATCH] USB: gadget: pch_udc: Fix bad dma

2013-08-21 Thread Mark Ferrell
During modprobe -r pch_udc we receive a warning about freeing a bad dma request. * Properly free the requests from the PCI pool they where allocated in. Signed-off-by: Mark Ferrell mferr...@uplogix.com --- drivers/usb/gadget/pch_udc.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH] USB: g-serial gadget hangs

2013-08-21 Thread Mark Ferrell
Well timed removal of USB cable leaves g_serial unusable. * It is possible that the g_serial driver can recieve a request to handle SET_LINE_CODING in acm_setup() when the end-point is invalid. Further more, acm_setup() will setup a completition handler for the request which results in the

[PATCH] HID: New hid-cp2112 driver.

2013-08-21 Thread David Barksdale
I sent this to Jiri Kosina and linux-kernel a week ago and haven't gotten any attention. Maybe linux-usb can tell me if this driver is any good. From: David Barksdale dbarksd...@uplogix.com This patch adds support for the Silicon Labs CP2112 Single-Chip HID USB to SMBus Master Bridge. I wrote

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 2:59 AM, Jussi Kivilinna jussi.kivili...@iki.fi wrote: On 21.08.2013 11:41, Brian Norris wrote: On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote:

Re: [PATCH] HID: New hid-cp2112 driver.

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 02:52:31PM -0500, David Barksdale wrote: I sent this to Jiri Kosina and linux-kernel a week ago and haven't gotten any attention. Maybe linux-usb can tell me if this driver is any good. Did you run it through the scripts/checkpatch.pl tool? It looks like your spaces

[PATCH] HID: New hid-cp2112 driver.

2013-08-21 Thread David Barksdale
From: David Barksdale dbarksd...@uplogix.com This patch adds support for the Silicon Labs CP2112 Single-Chip HID USB to SMBus Master Bridge. I wrote this to support a USB temperature and humidity sensor I've been working on. It's been tested by using SMBus byte-read, byte-data-read/write, and

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Jörn Engel
On Wed, 21 August 2013 13:00:15 -0700, Brian Norris wrote: Yes, that's a good point. Quoting Documentation/stable_kernel_rules.txt: It must be obviously correct and tested. Seeing as it was not tested, I am dropping the patch entirely (it is not stable material, and there is no point

Re: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

2013-08-21 Thread Matthijs Kooijman
Hi Paul, @@ -365,6 +366,7 @@ struct dwc2_hsotg { u8 otg_port; u32 *frame_list; dma_addr_t frame_list_dma; + int next_sched_frame; This variable is still not really used, I think. Most of the mentions in the patch are assignments, except for these two: +

Re: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

2013-08-21 Thread Gordon Hollingworth
Yes, I added the next_sched_frame to track the next uframe that there is anything to do in the periodic schedule. The SOF interrupt is then disabled until that uframe (although the FIQ still runs each uframe to decide whether to trigger the USB interrupt) Gordon On 21/08/2013 22:24, Matthijs

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-21 Thread Alan Stern
On Wed, 14 Aug 2013, Clemens Ladisch wrote: In other words, there should be enough URBs so that an entire ALSA buffer can be queued at any time, subject only to the limit on the maximum number of URBs and packets. The URB queue adds latency, so it should never be made too big, even for

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Julius Werner
Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Yes, I did. The LPM transfers on the analyzer look good and the device works as

Re: [RFC 0/5] usbfs: Add support for bulk streams

2013-08-21 Thread Sarah Sharp
On Thu, Aug 15, 2013 at 10:33:42PM +0200, Hans de Goede wrote: Hi, On 08/15/2013 12:42 PM, Hans de Goede wrote: snip What device did you find? I have yet to see a shipping device with streams... I don't know about streams, I'm hoping that having a uasp device means it will also

Re: [PATCH] HID: New hid-cp2112 driver.

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 03:11:12PM -0500, David Barksdale wrote: From: David Barksdale dbarksd...@uplogix.com This patch adds support for the Silicon Labs CP2112 Single-Chip HID USB to SMBus Master Bridge. I wrote this to support a USB temperature and humidity sensor I've been working on.

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Sarah Sharp
On Wed, Aug 21, 2013 at 02:43:55PM -0700, Julius Werner wrote: Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Yes, I did. The LPM

Re: [PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-21 Thread Yann Cantin
Hi, All issues addressed. Just a point : + +/* input final setup */ +ebeam_setup_input(ebeam, input_dev); + +err = input_register_device(ebeam-input); +if (err) { +dev_dbg(intf-dev, +%s - input_register_device failed, err: %d\n, +

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Greg Kroah-Hartman
On Wed, Aug 21, 2013 at 05:45:14PM -0700, Sarah Sharp wrote: On Wed, Aug 21, 2013 at 02:43:55PM -0700, Julius Werner wrote: Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking

[PATCH RESEND net-next V2 3/3] net: cdc_ncm: remove non-standard NCM device IDs

2013-08-21 Thread Enrico Mioso
Remove device IDs of NCM-like (but not NCM-conformant) devices, that are handled by the huawwei_cdc_ncm driver now. Signed-off-by: Enrico Mioso mrkiko...@gmail.com --- drivers/net/usb/cdc_ncm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c

[PATCH RESEND net-next V2 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-21 Thread Enrico Mioso
This driver supports devices using the NCM protocol as an encapsulation layer for other protocols, like the E3131 Huawei 3G modem. This driver was heavily inspired by the qmi_wwan approach code model. Suggested-by: Bjorn Mork bj...@mork.no Signed-off-by: Enrico Mioso mrkiko...@gmail.com ---

[PATCH RESEND net-next V2 0/3] huawei_cdc_ncm introduction

2013-08-21 Thread Enrico Mioso
These patches are all related to the new huawei_cdc_ncm driver, supporting devices that use the NCM protocol as a transport layer for other protocols. this is the case of the Huawei E3131 3G modem. Thanks should go to bjorn and others who helped me with patience. Enrico Mioso (3): net:

[PATCH RESEND net-next V2 1/3] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-21 Thread Enrico Mioso
Some drivers implementing NCM-like protocols, may re-use those functions, as is the case in the huawei_cdc_ncm driver. Export them via EXPORT_SYMBOL_GPL, in accordance with how other functions have been exported. Signed-off-by: Enrico Mioso mrkiko...@gmail.com --- drivers/net/usb/cdc_ncm.c |

Re: [PATCH RESEND net-next V2 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver

2013-08-21 Thread Greg KH
On Thu, Aug 22, 2013 at 04:30:40AM +0200, Enrico Mioso wrote: This driver supports devices using the NCM protocol as an encapsulation layer for other protocols, like the E3131 Huawei 3G modem. This driver was heavily inspired by the qmi_wwan approach code model. Line-wrap your changelog

Re: [PATCH 1/2] hso: Earlier catch of error condition

2013-08-21 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Wed, 21 Aug 2013 09:25:07 -0700 On Wed, Aug 21, 2013 at 01:43:07AM -0700, Daniel Gimpelevich wrote: There is no need to get an interface specification if we know it's the wrong one. Signed-off-by: Daniel Gimpelevich

Re: [PATCH 2/2] hso: Fix stack corruption on some architectures

2013-08-21 Thread David Miller
From: Greg KH gre...@linuxfoundation.org Date: Wed, 21 Aug 2013 09:24:47 -0700 On Wed, Aug 21, 2013 at 01:43:19AM -0700, Daniel Gimpelevich wrote: As Sergei Shtylyov explained in the #mipslinux IRC channel: [Mon 2013-08-19 12:28:21 PM PDT] headless guys, are you sure it's not DMA off stack

USB Card reader constantly resets with xhci

2013-08-21 Thread Joseph Yasi
Hi, I just recently moved an internal USB card reader from an ehci machine to an xhci machine, and dmesg is filled with this message over and over again: [ 1596.047684] usb 1-8: reset high-speed USB device number 4 using xhci_hcd [ 1596.090902] xhci_hcd :00:14.0: xHCI xhci_drop_endpoint

Dear Friend.

2013-08-21 Thread Zakan M
Dear Friend,   I am contacting you to assist me in a transfer of $6,200,000.00 US dollars into your personal bank account for the benefit of both of us, this transaction is confidential and we MUST remain fiducially in all our dealings since I cannot execute this opportunity alone without the

[RFT RFC] USB: Fix USB device disconnects on resume.

2013-08-21 Thread Sarah Sharp
The TLDR; version: We've assumed that when a device disconnects after a resume from device suspend, it was just a cheap, buggy device. It turns out that the USB core simply wasn't waiting long enough for the devices to transition from resume to U0, and it's actually been the USB core's fault all

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-21 Thread Paul Zimmerman
From: Julius Werner Sent: Wednesday, August 21, 2013 9:22 PM You need the USB 2.0 spec errata from 2011-11 that describes the changes made for BESL as well. It's in the USB2-LPM-Errata-final.pdf and USB2_LinkPowerMangement_ECN[final].pdf files in this zip file:

Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-21 Thread George Cherian
On 8/21/2013 11:05 PM, Stephen Warren wrote: On 08/21/2013 07:06 AM, George Cherian wrote: Hi Stephen, On 8/20/2013 10:23 PM, Stephen Warren wrote: ID pins are connected to pcf8575, and the pcf8575's interrupt line is inturn connected to gpio bank6 pin 11, we use this gpio interrupt to detect